From 452b57563b72326a35aa5e1f72d5d92369110b63 Mon Sep 17 00:00:00 2001 From: Jason Song Date: Tue, 11 Apr 2023 18:49:12 +0800 Subject: [PATCH 1/7] feat: share icons --- templates/repo/actions/runs_list.tmpl | 2 +- templates/repo/actions/status.tmpl | 12 ------------ web_src/js/components/ActionRunStatus.vue | 18 +++++++++++++++++- web_src/js/index.js | 2 ++ 4 files changed, 20 insertions(+), 14 deletions(-) delete mode 100644 templates/repo/actions/status.tmpl diff --git a/templates/repo/actions/runs_list.tmpl b/templates/repo/actions/runs_list.tmpl index a28b9d71378b5..5d4f66c4f0299 100644 --- a/templates/repo/actions/runs_list.tmpl +++ b/templates/repo/actions/runs_list.tmpl @@ -2,7 +2,7 @@ {{range .Runs}}
  • - {{template "repo/actions/status" .Status}} +
    diff --git a/templates/repo/actions/status.tmpl b/templates/repo/actions/status.tmpl deleted file mode 100644 index fd8a683bda0f4..0000000000000 --- a/templates/repo/actions/status.tmpl +++ /dev/null @@ -1,12 +0,0 @@ -{{if .IsWaiting}} - -{{end}} -{{if .IsRunning}} - -{{end}} -{{if .IsSuccess}} - -{{end}} -{{if .IsFailure}} - -{{end}} diff --git a/web_src/js/components/ActionRunStatus.vue b/web_src/js/components/ActionRunStatus.vue index b72dfb1aa699e..3a41911c3413f 100644 --- a/web_src/js/components/ActionRunStatus.vue +++ b/web_src/js/components/ActionRunStatus.vue @@ -9,8 +9,9 @@ diff --git a/web_src/js/index.js b/web_src/js/index.js index f7cbb24e8562e..5b76b23c59fd5 100644 --- a/web_src/js/index.js +++ b/web_src/js/index.js @@ -77,6 +77,7 @@ import {initRepoCommentForm, initRepository} from './features/repo-legacy.js'; import {initCopyContent} from './features/copycontent.js'; import {initCaptcha} from './features/captcha.js'; import {initRepositoryActionView} from './components/RepoActionView.vue'; +import {initActionRunStatus} from './components/ActionRunStatus.vue'; import {initGlobalTooltips} from './modules/tippy.js'; import {initGiteaFomantic} from './modules/fomantic.js'; import {onDomReady} from './utils/dom.js'; @@ -165,6 +166,7 @@ onDomReady(() => { initRepoWikiForm(); initRepository(); initRepositoryActionView(); + initActionRunStatus(); initCommitStatuses(); initCaptcha(); From 8eb63c869eee53dd9280999a147221383d667bdf Mon Sep 17 00:00:00 2001 From: HesterG Date: Tue, 18 Apr 2023 11:49:40 +0800 Subject: [PATCH 2/7] use template --- templates/repo/actions/runs_list.tmpl | 4 ++-- templates/repo/actions/status.tmpl | 13 +++++++++++++ web_src/css/shared/issuelist.css | 5 +++++ web_src/js/components/ActionRunStatus.vue | 18 +----------------- web_src/js/index.js | 2 -- 5 files changed, 21 insertions(+), 21 deletions(-) create mode 100644 templates/repo/actions/status.tmpl diff --git a/templates/repo/actions/runs_list.tmpl b/templates/repo/actions/runs_list.tmpl index 5d4f66c4f0299..709bfaaced2c4 100644 --- a/templates/repo/actions/runs_list.tmpl +++ b/templates/repo/actions/runs_list.tmpl @@ -1,8 +1,8 @@
    {{range .Runs}}
  • -
    -
    +
    + {{template "repo/actions/status" (dict "status" .Status.String)}}
    diff --git a/templates/repo/actions/status.tmpl b/templates/repo/actions/status.tmpl new file mode 100644 index 0000000000000..9a24ef1b052a3 --- /dev/null +++ b/templates/repo/actions/status.tmpl @@ -0,0 +1,13 @@ +{{if eq .status "success"}} + {{svg "octicon-check-circle-fill" 16 "ui text green"}} +{{else if eq .status "skipped"}} + {{svg "octicon-skip" 16 "ui text grey"}} +{{else if eq .status "waiting"}} + {{svg "octicon-clock" 16 "ui text yellow"}} +{{else if eq .status "blocked"}} + {{svg "octicon-blocked" 16 "ui text yellow"}} +{{else if eq .status "running"}} + {{svg "octicon-meter" 16 "ui text yellow job-status-rotate"}} +{{else}} + {{svg "octicon-x-circle-fill" 16 "ui text red"}} +{{end}} \ No newline at end of file diff --git a/web_src/css/shared/issuelist.css b/web_src/css/shared/issuelist.css index 26affd98a093d..5681f35d0411d 100644 --- a/web_src/css/shared/issuelist.css +++ b/web_src/css/shared/issuelist.css @@ -161,3 +161,8 @@ .issue.list > .item + .item { border-top: 1px solid var(--color-secondary); } + +.action-run-status { + height: 16px; + width: 16px; +} \ No newline at end of file diff --git a/web_src/js/components/ActionRunStatus.vue b/web_src/js/components/ActionRunStatus.vue index 3a41911c3413f..7808419a4576f 100644 --- a/web_src/js/components/ActionRunStatus.vue +++ b/web_src/js/components/ActionRunStatus.vue @@ -9,9 +9,8 @@ diff --git a/web_src/js/index.js b/web_src/js/index.js index 5b76b23c59fd5..f7cbb24e8562e 100644 --- a/web_src/js/index.js +++ b/web_src/js/index.js @@ -77,7 +77,6 @@ import {initRepoCommentForm, initRepository} from './features/repo-legacy.js'; import {initCopyContent} from './features/copycontent.js'; import {initCaptcha} from './features/captcha.js'; import {initRepositoryActionView} from './components/RepoActionView.vue'; -import {initActionRunStatus} from './components/ActionRunStatus.vue'; import {initGlobalTooltips} from './modules/tippy.js'; import {initGiteaFomantic} from './modules/fomantic.js'; import {onDomReady} from './utils/dom.js'; @@ -166,7 +165,6 @@ onDomReady(() => { initRepoWikiForm(); initRepository(); initRepositoryActionView(); - initActionRunStatus(); initCommitStatuses(); initCaptcha(); From d92d586b819a2fb930b36c07a758a8b8ae00cb12 Mon Sep 17 00:00:00 2001 From: HesterG Date: Tue, 18 Apr 2023 11:52:00 +0800 Subject: [PATCH 3/7] remove unnecessary change --- web_src/js/components/ActionRunStatus.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web_src/js/components/ActionRunStatus.vue b/web_src/js/components/ActionRunStatus.vue index 7808419a4576f..b72dfb1aa699e 100644 --- a/web_src/js/components/ActionRunStatus.vue +++ b/web_src/js/components/ActionRunStatus.vue @@ -10,7 +10,7 @@