From 35d0145a332cc958b8176b49f694f9dcb3c29645 Mon Sep 17 00:00:00 2001
From: HesterG
Date: Thu, 13 Apr 2023 10:58:43 +0800
Subject: [PATCH 01/26] fix project column delete
---
templates/base/delete_modal_actions.tmpl | 2 +-
templates/projects/view.tmpl | 8 ++++----
templates/repo/projects/view.tmpl | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/templates/base/delete_modal_actions.tmpl b/templates/base/delete_modal_actions.tmpl
index 29bf5f92fd53f..8348cfad7917f 100644
--- a/templates/base/delete_modal_actions.tmpl
+++ b/templates/base/delete_modal_actions.tmpl
@@ -3,7 +3,7 @@
{{svg "octicon-x"}}
{{.locale.Tr "modal.no"}}
-
{{end}}
@@ -139,6 +139,6 @@
{{.locale.Tr "settings.remove_account_link_desc"}}
- {{template "base/delete_modal_actions" .}}
+ {{template "base/page_dimmer_buttons" .}}
{{template "base/footer" .}}
diff --git a/templates/user/settings/security/accountlinks.tmpl b/templates/user/settings/security/accountlinks.tmpl
index e8eed632946c1..aa8332f6d8054 100644
--- a/templates/user/settings/security/accountlinks.tmpl
+++ b/templates/user/settings/security/accountlinks.tmpl
@@ -49,5 +49,5 @@
{{.locale.Tr "settings.remove_account_link_desc"}}
- {{template "base/delete_modal_actions" .}}
+ {{template "base/page_dimmer_buttons" .}}
diff --git a/templates/user/settings/security/openid.tmpl b/templates/user/settings/security/openid.tmpl
index 5d6c9cf8cd425..3fd49300fc7cd 100644
--- a/templates/user/settings/security/openid.tmpl
+++ b/templates/user/settings/security/openid.tmpl
@@ -59,5 +59,5 @@
{{.locale.Tr "settings.openid_deletion_desc"}}
- {{template "base/delete_modal_actions" .}}
+ {{template "base/page_dimmer_buttons" .}}
diff --git a/templates/user/settings/security/twofa.tmpl b/templates/user/settings/security/twofa.tmpl
index 1a0a8a6432c09..c4a4e8fbed417 100644
--- a/templates/user/settings/security/twofa.tmpl
+++ b/templates/user/settings/security/twofa.tmpl
@@ -31,5 +31,5 @@
{{.locale.Tr "settings.twofa_disable_desc"}}
- {{template "base/delete_modal_actions" .}}
+ {{template "base/page_dimmer_buttons" .}}
diff --git a/templates/user/settings/security/webauthn.tmpl b/templates/user/settings/security/webauthn.tmpl
index 2fea2843f6e05..3c5677aca0e01 100644
--- a/templates/user/settings/security/webauthn.tmpl
+++ b/templates/user/settings/security/webauthn.tmpl
@@ -38,5 +38,5 @@
{{.locale.Tr "settings.webauthn_delete_key_desc"}}
- {{template "base/delete_modal_actions" .}}
+ {{template "base/page_dimmer_buttons" .}}
From 1df04eef57e9b9d8020cd460dea87cdd0338b2dd Mon Sep 17 00:00:00 2001
From: HesterG
Date: Thu, 20 Apr 2023 09:00:57 +0800
Subject: [PATCH 08/26] modify css and change button on
default-project-board-modal
---
templates/base/page_dimmer_buttons.tmpl | 4 ++--
templates/projects/view.tmpl | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/templates/base/page_dimmer_buttons.tmpl b/templates/base/page_dimmer_buttons.tmpl
index 60bb27122c21e..330c1d7542958 100644
--- a/templates/base/page_dimmer_buttons.tmpl
+++ b/templates/base/page_dimmer_buttons.tmpl
@@ -1,9 +1,9 @@
-
+
{{svg "octicon-x"}}
{{if .ModalNoText}}{{.ModalNoText}}{{else}}{{.locale.Tr "modal.no"}}{{end}}
-
+
{{svg "octicon-check"}}
{{if .ModalYesText}}{{.ModalYesText}}{{else}}{{.locale.Tr "modal.yes"}}{{end}}
diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl
index cde653a0609b3..a79f7e363773f 100644
--- a/templates/projects/view.tmpl
+++ b/templates/projects/view.tmpl
@@ -157,8 +157,8 @@
- {{$.locale.Tr "settings.cancel"}}
-
+ {{$.locale.Tr "settings.cancel"}}
+
From 6651064d61fdc3e83b38efbf65e2d6ceb425f0f3 Mon Sep 17 00:00:00 2001
From: HesterG
Date: Thu, 20 Apr 2023 09:21:48 +0800
Subject: [PATCH 09/26] modify css for repo unset
---
templates/repo/projects/view.tmpl | 4 ++--
web_src/js/features/repo-projects.js | 5 -----
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl
index f6adec259c42a..663eb3ab4996d 100644
--- a/templates/repo/projects/view.tmpl
+++ b/templates/repo/projects/view.tmpl
@@ -163,8 +163,8 @@
- {{$.locale.Tr "settings.cancel"}}
-
+ {{$.locale.Tr "settings.cancel"}}
+
diff --git a/web_src/js/features/repo-projects.js b/web_src/js/features/repo-projects.js
index a2679130d70f3..63ef541c7451f 100644
--- a/web_src/js/features/repo-projects.js
+++ b/web_src/js/features/repo-projects.js
@@ -131,11 +131,6 @@ export function initRepoProject() {
const showButton = $(boardColumn).find('.default-project-board-show');
const commitButton = $(this).find('.default-project-board-button');
- if ($(showButton).data('type') === 'unset_default') {
- $(commitButton).removeClass('primary');
- $(commitButton).addClass('red');
- }
-
$(commitButton).on('click', (e) => {
e.preventDefault();
From f9430f7b13b5169bec9eedde9c89fa5891a0b2da Mon Sep 17 00:00:00 2001
From: HesterG
Date: Thu, 20 Apr 2023 13:33:26 +0800
Subject: [PATCH 10/26] use data- attributes to pass data
---
templates/base/page_dimmer_buttons.tmpl | 4 ++--
templates/projects/view.tmpl | 14 +++++++-------
templates/repo/projects/view.tmpl | 14 +++++++-------
web_src/js/features/repo-projects.js | 12 ++++++++----
4 files changed, 24 insertions(+), 20 deletions(-)
diff --git a/templates/base/page_dimmer_buttons.tmpl b/templates/base/page_dimmer_buttons.tmpl
index 330c1d7542958..1c3e78f456cde 100644
--- a/templates/base/page_dimmer_buttons.tmpl
+++ b/templates/base/page_dimmer_buttons.tmpl
@@ -1,9 +1,9 @@
-
+
{{svg "octicon-x"}}
{{if .ModalNoText}}{{.ModalNoText}}{{else}}{{.locale.Tr "modal.no"}}{{end}}
-
+
{{svg "octicon-check"}}
{{if .ModalYesText}}{{.ModalYesText}}{{else}}{{.locale.Tr "modal.yes"}}{{end}}
diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl
index a79f7e363773f..9a6d6951e2554 100644
--- a/templates/projects/view.tmpl
+++ b/templates/projects/view.tmpl
@@ -115,7 +115,10 @@
{{$.locale.Tr "repo.projects.column.unset_default"}}
{{end}}
-
+
{{svg "octicon-trash"}}
{{$.locale.Tr "repo.projects.column.delete"}}
@@ -171,12 +174,9 @@
{{$.locale.Tr "repo.projects.column.deletion_desc"}}
-
- {{$DataUrl := printf "%s/%d" $.Link .ID}}
- {{$ModalNoText := $.locale.Tr "settings.cancel"}}
- {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
- {{template "base/page_dimmer_buttons" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
-
+ {{$ModalNoText := $.locale.Tr "settings.cancel"}}
+ {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
+ {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl
index 663eb3ab4996d..29d7eebcd02c1 100644
--- a/templates/repo/projects/view.tmpl
+++ b/templates/repo/projects/view.tmpl
@@ -121,7 +121,10 @@
{{$.locale.Tr "repo.projects.column.unset_default"}}
{{end}}
-
+
{{svg "octicon-trash"}}
{{$.locale.Tr "repo.projects.column.delete"}}
@@ -177,12 +180,9 @@
{{$.locale.Tr "repo.projects.column.deletion_desc"}}
-
- {{$DataUrl := printf "%s/projects/%d/%d" $.RepoLink $.Project.ID .ID}}
- {{$ModalNoText := $.locale.Tr "settings.cancel"}}
- {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
- {{template "base/page_dimmer_buttons" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
-
+ {{$ModalNoText := $.locale.Tr "settings.cancel"}}
+ {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
+ {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
diff --git a/web_src/js/features/repo-projects.js b/web_src/js/features/repo-projects.js
index 63ef541c7451f..a2a6ff148594b 100644
--- a/web_src/js/features/repo-projects.js
+++ b/web_src/js/features/repo-projects.js
@@ -147,12 +147,16 @@ export function initRepoProject() {
});
});
- $('.delete-project-board').each(function () {
- $(this).click(function (e) {
+ $('.show-delete-column-modal').each(function () {
+ const deleteColumnModal = $(`${$(this).attr('data-modal')}`);
+ const deleteColumnButton = deleteColumnModal.find('.confirm-button');
+ const deleteUrl = $(this).attr('data-url');
+
+ deleteColumnButton.on('click', function (e) {
e.preventDefault();
$.ajax({
- url: $(this).data('url'),
+ url: deleteUrl,
headers: {
'X-Csrf-Token': csrfToken,
},
@@ -162,7 +166,7 @@ export function initRepoProject() {
window.location.reload();
});
});
- });
+ })
$('#new_board_submit').click(function (e) {
e.preventDefault();
From 68824ff7fa21d95e39250388c9e4a6be2727948c Mon Sep 17 00:00:00 2001
From: HesterG
Date: Thu, 20 Apr 2023 14:36:04 +0800
Subject: [PATCH 11/26] try use template for set/unset columns and fix lint
---
templates/base/page_dimmer_buttons.tmpl | 4 ++--
templates/projects/view.tmpl | 13 ++++++-------
templates/repo/projects/view.tmpl | 13 ++++++-------
web_src/js/features/repo-projects.js | 8 ++++----
4 files changed, 18 insertions(+), 20 deletions(-)
diff --git a/templates/base/page_dimmer_buttons.tmpl b/templates/base/page_dimmer_buttons.tmpl
index 1c3e78f456cde..79229b62688ab 100644
--- a/templates/base/page_dimmer_buttons.tmpl
+++ b/templates/base/page_dimmer_buttons.tmpl
@@ -1,9 +1,9 @@
-
+
{{svg "octicon-x"}}
{{if .ModalNoText}}{{.ModalNoText}}{{else}}{{.locale.Tr "modal.no"}}{{end}}
-
+
{{svg "octicon-check"}}
{{if .ModalYesText}}{{.ModalYesText}}{{else}}{{.locale.Tr "modal.yes"}}{{end}}
diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl
index 9a6d6951e2554..c4d72e0cf3365 100644
--- a/templates/projects/view.tmpl
+++ b/templates/projects/view.tmpl
@@ -99,7 +99,6 @@
data-modal="#default-project-board-modal-{{.ID}}"
data-modal-default-project-board-header="{{$.locale.Tr "repo.projects.column.set_default"}}"
data-modal-default-project-board-content="{{$.locale.Tr "repo.projects.column.set_default_desc"}}"
- data-modal-default-project-board-submit="{{$.locale.Tr "repo.projects.column.set_default"}}"
data-url="{{$.Link}}/{{.ID}}/default">
{{svg "octicon-pin"}}
{{$.locale.Tr "repo.projects.column.set_default"}}
@@ -109,7 +108,6 @@
data-modal="#default-project-board-modal-{{.ID}}"
data-modal-default-project-board-header="{{$.locale.Tr "repo.projects.column.unset_default"}}"
data-modal-default-project-board-content="{{$.locale.Tr "repo.projects.column.unset_default_desc"}}"
- data-modal-default-project-board-submit="{{$.locale.Tr "repo.projects.column.unset_default"}}"
data-url="{{$.Link}}/{{.ID}}/unsetdefault">
{{svg "octicon-pin"}}
{{$.locale.Tr "repo.projects.column.unset_default"}}
@@ -159,10 +157,12 @@
-
- {{$.locale.Tr "settings.cancel"}}
-
-
+ {{$ModalNoText := $.locale.Tr "settings.cancel"}}
+ {{- $ModalYesText := $.locale.Tr "repo.projects.column.set_default" -}}
+ {{- if .Default -}}
+ {{- $ModalYesText = $.locale.Tr "repo.projects.column.unset_default" -}}
+ {{- end -}}
+ {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
@@ -174,7 +174,6 @@
{{$.locale.Tr "repo.projects.column.deletion_desc"}}
- {{$ModalNoText := $.locale.Tr "settings.cancel"}}
{{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
{{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl
index 29d7eebcd02c1..a597b5d6c0776 100644
--- a/templates/repo/projects/view.tmpl
+++ b/templates/repo/projects/view.tmpl
@@ -103,7 +103,6 @@
data-modal="#default-project-board-modal-{{.ID}}"
data-modal-default-project-board-header="{{$.locale.Tr "repo.projects.column.set_default"}}"
data-modal-default-project-board-content="{{$.locale.Tr "repo.projects.column.set_default_desc"}}"
- data-modal-default-project-board-submit="{{$.locale.Tr "repo.projects.column.set_default"}}"
data-type="set_default"
data-url="{{$.Link}}/{{.ID}}/default">
{{svg "octicon-pin"}}
@@ -114,7 +113,6 @@
data-modal="#default-project-board-modal-{{.ID}}"
data-modal-default-project-board-header="{{$.locale.Tr "repo.projects.column.unset_default"}}"
data-modal-default-project-board-content="{{$.locale.Tr "repo.projects.column.unset_default_desc"}}"
- data-modal-default-project-board-submit="{{$.locale.Tr "repo.projects.column.unset_default"}}"
data-type="unset_default"
data-url="{{$.Link}}/{{.ID}}/unsetdefault">
{{svg "octicon-pin"}}
@@ -165,10 +163,12 @@
-
- {{$.locale.Tr "settings.cancel"}}
-
-
+ {{$ModalNoText := $.locale.Tr "settings.cancel"}}
+ {{- $ModalYesText := $.locale.Tr "repo.projects.column.set_default" -}}
+ {{- if .Default -}}
+ {{- $ModalYesText = $.locale.Tr "repo.projects.column.unset_default" -}}
+ {{- end -}}
+ {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
@@ -180,7 +180,6 @@
{{$.locale.Tr "repo.projects.column.deletion_desc"}}
- {{$ModalNoText := $.locale.Tr "settings.cancel"}}
{{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
{{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
diff --git a/web_src/js/features/repo-projects.js b/web_src/js/features/repo-projects.js
index a2a6ff148594b..32a5b9a8ddedf 100644
--- a/web_src/js/features/repo-projects.js
+++ b/web_src/js/features/repo-projects.js
@@ -129,7 +129,7 @@ export function initRepoProject() {
$('.default-project-board-modal').each(function () {
const boardColumn = $(this).closest('.board-column');
const showButton = $(boardColumn).find('.default-project-board-show');
- const commitButton = $(this).find('.default-project-board-button');
+ const commitButton = $(this).find('.modal-confirm-button');
$(commitButton).on('click', (e) => {
e.preventDefault();
@@ -149,10 +149,10 @@ export function initRepoProject() {
$('.show-delete-column-modal').each(function () {
const deleteColumnModal = $(`${$(this).attr('data-modal')}`);
- const deleteColumnButton = deleteColumnModal.find('.confirm-button');
+ const deleteColumnButton = deleteColumnModal.find('.modal-confirm-button');
const deleteUrl = $(this).attr('data-url');
- deleteColumnButton.on('click', function (e) {
+ deleteColumnButton.on('click', (e) => {
e.preventDefault();
$.ajax({
@@ -166,7 +166,7 @@ export function initRepoProject() {
window.location.reload();
});
});
- })
+ });
$('#new_board_submit').click(function (e) {
e.preventDefault();
From c2e81e26a1fce1a273c7fe281f14b0519b6bc4af Mon Sep 17 00:00:00 2001
From: HesterG
Date: Thu, 20 Apr 2023 15:03:58 +0800
Subject: [PATCH 12/26] fix lint and change name to basic_modal_actions for now
---
templates/admin/auth/edit.tmpl | 2 +-
templates/admin/emails/list.tmpl | 2 +-
templates/admin/monitor.tmpl | 2 +-
templates/admin/packages/list.tmpl | 2 +-
templates/admin/queue.tmpl | 2 +-
templates/admin/repo/list.tmpl | 2 +-
templates/admin/stacktrace.tmpl | 2 +-
templates/admin/user/edit.tmpl | 2 +-
...{page_dimmer_buttons.tmpl => basic_modal_actions.tmpl} | 0
templates/org/member/members.tmpl | 4 ++--
templates/org/settings/delete.tmpl | 2 +-
templates/org/team/members.tmpl | 2 +-
templates/org/team/new.tmpl | 2 +-
templates/org/team/repositories.tmpl | 4 ++--
templates/org/team/sidebar.tmpl | 2 +-
templates/org/team/teams.tmpl | 2 +-
templates/package/settings.tmpl | 2 +-
templates/projects/list.tmpl | 2 +-
templates/projects/view.tmpl | 8 ++++----
templates/repo/branch/list.tmpl | 2 +-
templates/repo/issue/labels/edit_delete_label.tmpl | 2 +-
templates/repo/issue/milestones.tmpl | 2 +-
templates/repo/issue/view_content.tmpl | 2 +-
.../repo/issue/view_content/comments_delete_time.tmpl | 2 +-
templates/repo/projects/list.tmpl | 2 +-
templates/repo/projects/view.tmpl | 8 ++++----
templates/repo/release/list.tmpl | 2 +-
templates/repo/release/new.tmpl | 2 +-
templates/repo/settings/branches.tmpl | 2 +-
templates/repo/settings/collaboration.tmpl | 2 +-
templates/repo/settings/deploy_keys.tmpl | 2 +-
templates/repo/settings/lfs.tmpl | 2 +-
templates/repo/settings/options.tmpl | 2 +-
templates/repo/settings/webhook/delete_modal.tmpl | 2 +-
templates/repo/wiki/view.tmpl | 2 +-
templates/shared/actions/runner_edit.tmpl | 2 +-
templates/shared/secrets/add_list.tmpl | 2 +-
templates/user/settings/account.tmpl | 4 ++--
templates/user/settings/applications.tmpl | 2 +-
templates/user/settings/applications_oauth2_list.tmpl | 2 +-
templates/user/settings/grants_oauth2.tmpl | 2 +-
templates/user/settings/keys_gpg.tmpl | 2 +-
templates/user/settings/keys_principal.tmpl | 2 +-
templates/user/settings/keys_ssh.tmpl | 2 +-
templates/user/settings/organization.tmpl | 2 +-
templates/user/settings/repos.tmpl | 4 ++--
templates/user/settings/security/accountlinks.tmpl | 2 +-
templates/user/settings/security/openid.tmpl | 2 +-
templates/user/settings/security/twofa.tmpl | 2 +-
templates/user/settings/security/webauthn.tmpl | 2 +-
50 files changed, 59 insertions(+), 59 deletions(-)
rename templates/base/{page_dimmer_buttons.tmpl => basic_modal_actions.tmpl} (100%)
diff --git a/templates/admin/auth/edit.tmpl b/templates/admin/auth/edit.tmpl
index 5cb5aaae69fa0..e46afe4ad686b 100644
--- a/templates/admin/auth/edit.tmpl
+++ b/templates/admin/auth/edit.tmpl
@@ -448,6 +448,6 @@
{{.locale.Tr "admin.auths.delete_auth_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/emails/list.tmpl b/templates/admin/emails/list.tmpl
index ca6ebed226c12..37da00d5e8d42 100644
--- a/templates/admin/emails/list.tmpl
+++ b/templates/admin/emails/list.tmpl
@@ -94,7 +94,7 @@
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
diff --git a/templates/admin/monitor.tmpl b/templates/admin/monitor.tmpl
index 0c1d2193d63d1..c4257a8527c06 100644
--- a/templates/admin/monitor.tmpl
+++ b/templates/admin/monitor.tmpl
@@ -46,6 +46,6 @@
{{$.locale.Tr "admin.monitor.process.cancel_notices" `` | Safe}}
{{$.locale.Tr "admin.monitor.process.cancel_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/packages/list.tmpl b/templates/admin/packages/list.tmpl
index 356cd4d638924..d97b41ffa5727 100644
--- a/templates/admin/packages/list.tmpl
+++ b/templates/admin/packages/list.tmpl
@@ -88,6 +88,6 @@
{{.locale.Tr "packages.settings.delete.notice" `` `` | Safe}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/queue.tmpl b/templates/admin/queue.tmpl
index 949564dcc2fb5..2ace03810cb04 100644
--- a/templates/admin/queue.tmpl
+++ b/templates/admin/queue.tmpl
@@ -190,7 +190,7 @@
{{$.locale.Tr "admin.monitor.queue.pool.cancel_notices" `` | Safe}}
{{$.locale.Tr "admin.monitor.queue.pool.cancel_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/repo/list.tmpl b/templates/admin/repo/list.tmpl
index aa65e48f9161e..7c907e5cfcf16 100644
--- a/templates/admin/repo/list.tmpl
+++ b/templates/admin/repo/list.tmpl
@@ -105,6 +105,6 @@
{{.locale.Tr "repo.settings.delete_notices_2" `` | Safe}}
{{.locale.Tr "repo.settings.delete_notices_fork_1"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/stacktrace.tmpl b/templates/admin/stacktrace.tmpl
index aa84e02e06abf..8dfe78422a858 100644
--- a/templates/admin/stacktrace.tmpl
+++ b/templates/admin/stacktrace.tmpl
@@ -27,7 +27,7 @@
{{$.locale.Tr "admin.monitor.process.cancel_notices" `` | Safe}}
{{$.locale.Tr "admin.monitor.process.cancel_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/user/edit.tmpl b/templates/admin/user/edit.tmpl
index 4606be39625df..17a64359d9c02 100644
--- a/templates/admin/user/edit.tmpl
+++ b/templates/admin/user/edit.tmpl
@@ -213,7 +213,7 @@
{{.locale.Tr "admin.users.purge_help"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/base/page_dimmer_buttons.tmpl b/templates/base/basic_modal_actions.tmpl
similarity index 100%
rename from templates/base/page_dimmer_buttons.tmpl
rename to templates/base/basic_modal_actions.tmpl
diff --git a/templates/org/member/members.tmpl b/templates/org/member/members.tmpl
index 505cffd32a802..d83b742f9f4bf 100644
--- a/templates/org/member/members.tmpl
+++ b/templates/org/member/members.tmpl
@@ -89,7 +89,7 @@
{{$.locale.Tr "org.members.leave.detail" `` | Safe}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/org/settings/delete.tmpl b/templates/org/settings/delete.tmpl
index 56fa3606a9d6e..6352396d867c5 100644
--- a/templates/org/settings/delete.tmpl
+++ b/templates/org/settings/delete.tmpl
@@ -37,6 +37,6 @@
{{.locale.Tr "org.settings.delete_org_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/org/team/members.tmpl b/templates/org/team/members.tmpl
index 81562c39edb08..c59cce11be4fd 100644
--- a/templates/org/team/members.tmpl
+++ b/templates/org/team/members.tmpl
@@ -72,6 +72,6 @@
{{$.locale.Tr "org.members.remove.detail" `` `` | Safe}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/org/team/new.tmpl b/templates/org/team/new.tmpl
index 8746bccce2bbd..48ec1f4586e05 100644
--- a/templates/org/team/new.tmpl
+++ b/templates/org/team/new.tmpl
@@ -156,6 +156,6 @@
{{.locale.Tr "org.teams.delete_team_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/org/team/repositories.tmpl b/templates/org/team/repositories.tmpl
index 8d1e129016555..0d7da480ddae2 100644
--- a/templates/org/team/repositories.tmpl
+++ b/templates/org/team/repositories.tmpl
@@ -72,7 +72,7 @@
{{.locale.Tr "org.teams.remove_all_repos_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
@@ -83,7 +83,7 @@
{{.locale.Tr "org.teams.add_all_repos_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/org/team/sidebar.tmpl b/templates/org/team/sidebar.tmpl
index 9e0239fc83a52..1c98315697da5 100644
--- a/templates/org/team/sidebar.tmpl
+++ b/templates/org/team/sidebar.tmpl
@@ -91,5 +91,5 @@
{{$.locale.Tr "org.teams.leave.detail" `` | Safe}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
diff --git a/templates/org/team/teams.tmpl b/templates/org/team/teams.tmpl
index 627b27eb91364..2f9d447b1c43b 100644
--- a/templates/org/team/teams.tmpl
+++ b/templates/org/team/teams.tmpl
@@ -51,6 +51,6 @@
{{$.locale.Tr "org.teams.leave.detail" `` | Safe}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/package/settings.tmpl b/templates/package/settings.tmpl
index a1b2b2172c99f..69d4306978e00 100644
--- a/templates/package/settings.tmpl
+++ b/templates/package/settings.tmpl
@@ -57,7 +57,7 @@
diff --git a/templates/projects/list.tmpl b/templates/projects/list.tmpl
index 2777e3260eaeb..2ddf7477e857e 100644
--- a/templates/projects/list.tmpl
+++ b/templates/projects/list.tmpl
@@ -84,6 +84,6 @@
{{.locale.Tr "repo.projects.deletion_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{end}}
diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl
index c4d72e0cf3365..c1251df29e25e 100644
--- a/templates/projects/view.tmpl
+++ b/templates/projects/view.tmpl
@@ -113,7 +113,7 @@
{{$.locale.Tr "repo.projects.column.unset_default"}}
{{end}}
-
@@ -162,7 +162,7 @@
{{- if .Default -}}
{{- $ModalYesText = $.locale.Tr "repo.projects.column.unset_default" -}}
{{- end -}}
- {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
+ {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
@@ -175,7 +175,7 @@
{{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
- {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
+ {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
@@ -286,6 +286,6 @@
{{.locale.Tr "repo.projects.deletion_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{end}}
diff --git a/templates/repo/branch/list.tmpl b/templates/repo/branch/list.tmpl
index 9a46e2cfe5f5d..5cea38e7b6bd7 100644
--- a/templates/repo/branch/list.tmpl
+++ b/templates/repo/branch/list.tmpl
@@ -155,7 +155,7 @@
{{.locale.Tr "repo.branch.delete_desc" | Str2html}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
diff --git a/templates/repo/issue/labels/edit_delete_label.tmpl b/templates/repo/issue/labels/edit_delete_label.tmpl
index 2c62d1a61c68b..c90fdc13effc3 100644
--- a/templates/repo/issue/labels/edit_delete_label.tmpl
+++ b/templates/repo/issue/labels/edit_delete_label.tmpl
@@ -6,7 +6,7 @@
{{.locale.Tr "repo.issues.label_deletion_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
diff --git a/templates/repo/issue/milestones.tmpl b/templates/repo/issue/milestones.tmpl
index 04267e2d3b807..a8c43815be0c8 100644
--- a/templates/repo/issue/milestones.tmpl
+++ b/templates/repo/issue/milestones.tmpl
@@ -124,7 +124,7 @@
{{.locale.Tr "repo.milestones.deletion_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{end}}
{{template "base/footer" .}}
diff --git a/templates/repo/issue/view_content.tmpl b/templates/repo/issue/view_content.tmpl
index 7c68e68886f20..5df7f50c116a1 100644
--- a/templates/repo/issue/view_content.tmpl
+++ b/templates/repo/issue/view_content.tmpl
@@ -205,5 +205,5 @@
{{.locale.Tr "repo.branch.delete_desc" | Str2html}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
diff --git a/templates/repo/issue/view_content/comments_delete_time.tmpl b/templates/repo/issue/view_content/comments_delete_time.tmpl
index cf3f5c0c8a87f..42f142725b21e 100644
--- a/templates/repo/issue/view_content/comments_delete_time.tmpl
+++ b/templates/repo/issue/view_content/comments_delete_time.tmpl
@@ -7,7 +7,7 @@
{{.ctxData.CsrfTokenHtml}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{svg "octicon-trash"}}
diff --git a/templates/repo/projects/list.tmpl b/templates/repo/projects/list.tmpl
index 14f1d1fa111c7..ebe0657504846 100644
--- a/templates/repo/projects/list.tmpl
+++ b/templates/repo/projects/list.tmpl
@@ -86,7 +86,7 @@
{{.locale.Tr "repo.projects.deletion_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{end}}
{{template "base/footer" .}}
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl
index a597b5d6c0776..a8411b89aabb7 100644
--- a/templates/repo/projects/view.tmpl
+++ b/templates/repo/projects/view.tmpl
@@ -119,7 +119,7 @@
{{$.locale.Tr "repo.projects.column.unset_default"}}
{{end}}
-
@@ -168,7 +168,7 @@
{{- if .Default -}}
{{- $ModalYesText = $.locale.Tr "repo.projects.column.unset_default" -}}
{{- end -}}
- {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
+ {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
@@ -181,7 +181,7 @@
{{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
- {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
+ {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
@@ -292,7 +292,7 @@
{{.locale.Tr "repo.projects.deletion_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{end}}
diff --git a/templates/repo/release/list.tmpl b/templates/repo/release/list.tmpl
index 5771e9f20a7cd..ec270546bebb6 100644
--- a/templates/repo/release/list.tmpl
+++ b/templates/repo/release/list.tmpl
@@ -192,7 +192,7 @@
{{.locale.Tr "repo.release.deletion_tag_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{end}}
diff --git a/templates/repo/release/new.tmpl b/templates/repo/release/new.tmpl
index 40fbc239063da..7f99ca2873289 100644
--- a/templates/repo/release/new.tmpl
+++ b/templates/repo/release/new.tmpl
@@ -146,7 +146,7 @@
{{.locale.Tr "repo.release.deletion_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{end}}
{{template "base/footer" .}}
diff --git a/templates/repo/settings/branches.tmpl b/templates/repo/settings/branches.tmpl
index 11fa3111d008e..1d4e56e9072d9 100644
--- a/templates/repo/settings/branches.tmpl
+++ b/templates/repo/settings/branches.tmpl
@@ -104,7 +104,7 @@
{{.locale.Tr "repo.settings.protected_branch_deletion_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/repo/settings/collaboration.tmpl b/templates/repo/settings/collaboration.tmpl
index 1f213d701c0eb..341c5fc678776 100644
--- a/templates/repo/settings/collaboration.tmpl
+++ b/templates/repo/settings/collaboration.tmpl
@@ -120,6 +120,6 @@
{{.locale.Tr "repo.settings.collaborator_deletion_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/repo/settings/deploy_keys.tmpl b/templates/repo/settings/deploy_keys.tmpl
index 50269969d58b5..9fc2fc27845fd 100644
--- a/templates/repo/settings/deploy_keys.tmpl
+++ b/templates/repo/settings/deploy_keys.tmpl
@@ -85,6 +85,6 @@
{{.locale.Tr "repo.settings.deploy_key_deletion_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/repo/settings/lfs.tmpl b/templates/repo/settings/lfs.tmpl
index 45e237f501e50..8752e1c876537 100644
--- a/templates/repo/settings/lfs.tmpl
+++ b/templates/repo/settings/lfs.tmpl
@@ -50,7 +50,7 @@
{{end}}
@@ -139,6 +139,6 @@
{{.locale.Tr "settings.remove_account_link_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
{{template "base/footer" .}}
diff --git a/templates/user/settings/security/accountlinks.tmpl b/templates/user/settings/security/accountlinks.tmpl
index aa8332f6d8054..5bb1a857969d6 100644
--- a/templates/user/settings/security/accountlinks.tmpl
+++ b/templates/user/settings/security/accountlinks.tmpl
@@ -49,5 +49,5 @@
{{.locale.Tr "settings.remove_account_link_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
diff --git a/templates/user/settings/security/openid.tmpl b/templates/user/settings/security/openid.tmpl
index 3fd49300fc7cd..04356adf9965d 100644
--- a/templates/user/settings/security/openid.tmpl
+++ b/templates/user/settings/security/openid.tmpl
@@ -59,5 +59,5 @@
{{.locale.Tr "settings.openid_deletion_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
diff --git a/templates/user/settings/security/twofa.tmpl b/templates/user/settings/security/twofa.tmpl
index c4a4e8fbed417..d4e1ef91e8647 100644
--- a/templates/user/settings/security/twofa.tmpl
+++ b/templates/user/settings/security/twofa.tmpl
@@ -31,5 +31,5 @@
{{.locale.Tr "settings.twofa_disable_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
diff --git a/templates/user/settings/security/webauthn.tmpl b/templates/user/settings/security/webauthn.tmpl
index 3c5677aca0e01..7d52c2bad67b1 100644
--- a/templates/user/settings/security/webauthn.tmpl
+++ b/templates/user/settings/security/webauthn.tmpl
@@ -38,5 +38,5 @@
{{.locale.Tr "settings.webauthn_delete_key_desc"}}
- {{template "base/page_dimmer_buttons" .}}
+ {{template "base/basic_modal_actions" .}}
From 159e22880c2accd452a3198f3db72159ebece0c4 Mon Sep 17 00:00:00 2001
From: HesterG
Date: Fri, 21 Apr 2023 09:05:44 +0800
Subject: [PATCH 13/26] use template for delete pr
---
templates/repo/issue/view_content/sidebar.tmpl | 5 +----
web_src/css/base.css | 4 ++++
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/templates/repo/issue/view_content/sidebar.tmpl b/templates/repo/issue/view_content/sidebar.tmpl
index 290488d9fbb94..eebdf42542361 100644
--- a/templates/repo/issue/view_content/sidebar.tmpl
+++ b/templates/repo/issue/view_content/sidebar.tmpl
@@ -682,10 +682,7 @@
{{end}}
diff --git a/web_src/css/base.css b/web_src/css/base.css
index 79e1566b64998..e596e3ff41f61 100644
--- a/web_src/css/base.css
+++ b/web_src/css/base.css
@@ -1166,6 +1166,10 @@ a.ui.card:hover {
color: var(--color-text);
}
+.ui.modal > form > .actions {
+ text-align: right;
+}
+
.ui.basic.table > tbody > tr {
border-color: var(--color-secondary);
}
From 6ea509ed7d5aedccf4486c4a301b259f99c62e3f Mon Sep 17 00:00:00 2001
From: HesterG
Date: Fri, 21 Apr 2023 09:39:08 +0800
Subject: [PATCH 14/26] change to template and add TODOs
---
templates/admin/repo/unadopted.tmpl | 4 ++--
templates/repo/issue/view_content/sidebar.tmpl | 13 +++----------
templates/user/settings/repos.tmpl | 2 +-
3 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/templates/admin/repo/unadopted.tmpl b/templates/admin/repo/unadopted.tmpl
index a8e04850d0dd3..357ca9b042e1b 100644
--- a/templates/admin/repo/unadopted.tmpl
+++ b/templates/admin/repo/unadopted.tmpl
@@ -43,7 +43,7 @@
-
+
{{/* TODO: Convert to base/basic_modal_actions */}}
{{svg "octicon-trash" 16 "gt-mr-2"}}
{{$.locale.Tr "modal.no"}}
@@ -70,7 +70,7 @@
-
+
{{/* TODO: Convert to base/basic_modal_actions */}}
{{svg "octicon-trash" 16 "gt-mr-2"}}
{{$.locale.Tr "modal.no"}}
diff --git a/templates/repo/issue/view_content/sidebar.tmpl b/templates/repo/issue/view_content/sidebar.tmpl
index eebdf42542361..d767ce6122785 100644
--- a/templates/repo/issue/view_content/sidebar.tmpl
+++ b/templates/repo/issue/view_content/sidebar.tmpl
@@ -559,16 +559,9 @@
{{.locale.Tr "repo.issues.dependency.issue_remove_text"}}
{{end}}
-
-
- {{svg "octicon-x"}}
- {{.locale.Tr "repo.issues.dependency.cancel"}}
-
-
- {{svg "octicon-check"}}
- {{.locale.Tr "repo.issues.dependency.remove"}}
-
-
+ {{$ModalNoText := .locale.Tr "repo.issues.dependency.cancel"}}
+ {{$ModalYesText := .locale.Tr "repo.issues.dependency.remove"}}
+ {{template "base/basic_modal_actions" (dict "." . "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
{{end}}
{{end}}
diff --git a/templates/user/settings/repos.tmpl b/templates/user/settings/repos.tmpl
index 545671dae5512..9e11786d45c50 100644
--- a/templates/user/settings/repos.tmpl
+++ b/templates/user/settings/repos.tmpl
@@ -50,7 +50,7 @@
{{$.CsrfTokenHtml}}
-
+
{{/* TODO: Convert to base/basic_modal_actions */}}
{{svg "octicon-x"}}
{{$.locale.Tr "modal.no"}}
From 7545bca0eec5fb96673779058c98e22fa6410e1c Mon Sep 17 00:00:00 2001
From: HesterG
Date: Fri, 21 Apr 2023 14:48:16 +0800
Subject: [PATCH 15/26] use centerd style for buttons
---
web_src/css/base.css | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/web_src/css/base.css b/web_src/css/base.css
index cf440a1df4d69..32dfc8eff0da8 100644
--- a/web_src/css/base.css
+++ b/web_src/css/base.css
@@ -1160,6 +1160,7 @@ a.ui.card:hover {
.ui.modal > .actions {
background: var(--color-secondary-bg);
border-color: var(--color-secondary);
+ text-align: center;
}
.ui.modal > .close.inside {
@@ -1167,7 +1168,7 @@ a.ui.card:hover {
}
.ui.modal > form > .actions {
- text-align: right;
+ text-align: center;
}
.ui.basic.table > tbody > tr {
From ed7d1912c4bc2433b3268342d599a757ab71a143 Mon Sep 17 00:00:00 2001
From: HesterG
Date: Fri, 21 Apr 2023 14:50:37 +0800
Subject: [PATCH 16/26] move selector
---
web_src/css/base.css | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/web_src/css/base.css b/web_src/css/base.css
index 32dfc8eff0da8..03f75d48d5fff 100644
--- a/web_src/css/base.css
+++ b/web_src/css/base.css
@@ -1157,7 +1157,8 @@ a.ui.card:hover {
text-align: left !important;
}
-.ui.modal > .actions {
+.ui.modal > .actions,
+.ui.modal > form > .actions {
background: var(--color-secondary-bg);
border-color: var(--color-secondary);
text-align: center;
@@ -1167,10 +1168,6 @@ a.ui.card:hover {
color: var(--color-text);
}
-.ui.modal > form > .actions {
- text-align: center;
-}
-
.ui.basic.table > tbody > tr {
border-color: var(--color-secondary);
}
From ebe447992dd3ffaa5002fd8b0b2367c8b3d504fa Mon Sep 17 00:00:00 2001
From: HesterG
Date: Fri, 21 Apr 2023 14:54:16 +0800
Subject: [PATCH 17/26] revert
---
web_src/css/base.css | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/web_src/css/base.css b/web_src/css/base.css
index 03f75d48d5fff..32dfc8eff0da8 100644
--- a/web_src/css/base.css
+++ b/web_src/css/base.css
@@ -1157,8 +1157,7 @@ a.ui.card:hover {
text-align: left !important;
}
-.ui.modal > .actions,
-.ui.modal > form > .actions {
+.ui.modal > .actions {
background: var(--color-secondary-bg);
border-color: var(--color-secondary);
text-align: center;
@@ -1168,6 +1167,10 @@ a.ui.card:hover {
color: var(--color-text);
}
+.ui.modal > form > .actions {
+ text-align: center;
+}
+
.ui.basic.table > tbody > tr {
border-color: var(--color-secondary);
}
From 4ce523669b6f1d881a02579bef982205abf64106 Mon Sep 17 00:00:00 2001
From: wxiaoguang
Date: Sun, 23 Apr 2023 11:52:41 +0800
Subject: [PATCH 18/26] match Fomantic Modal defination
---
templates/admin/auth/edit.tmpl | 2 +-
templates/admin/emails/list.tmpl | 2 +-
templates/admin/monitor.tmpl | 2 +-
templates/admin/packages/list.tmpl | 2 +-
templates/admin/queue.tmpl | 2 +-
templates/admin/repo/list.tmpl | 2 +-
templates/admin/repo/unadopted.tmpl | 4 ++--
templates/admin/stacktrace.tmpl | 2 +-
templates/admin/user/edit.tmpl | 2 +-
templates/base/basic_modal_actions.tmpl | 10 ----------
templates/base/modal_actions_confirm.tmpl | 17 +++++++++++++++++
templates/org/member/members.tmpl | 4 ++--
templates/org/settings/delete.tmpl | 2 +-
templates/org/team/members.tmpl | 2 +-
templates/org/team/new.tmpl | 2 +-
templates/org/team/repositories.tmpl | 4 ++--
templates/org/team/sidebar.tmpl | 2 +-
templates/org/team/teams.tmpl | 2 +-
templates/package/settings.tmpl | 2 +-
templates/projects/list.tmpl | 2 +-
templates/projects/view.tmpl | 14 +++++++-------
templates/repo/branch/list.tmpl | 2 +-
.../repo/issue/labels/edit_delete_label.tmpl | 2 +-
templates/repo/issue/milestones.tmpl | 2 +-
templates/repo/issue/view_content.tmpl | 2 +-
.../view_content/comments_delete_time.tmpl | 2 +-
templates/repo/issue/view_content/sidebar.tmpl | 8 ++++----
templates/repo/projects/list.tmpl | 2 +-
templates/repo/projects/view.tmpl | 14 +++++++-------
templates/repo/release/list.tmpl | 2 +-
templates/repo/release/new.tmpl | 2 +-
templates/repo/settings/branches.tmpl | 2 +-
templates/repo/settings/collaboration.tmpl | 2 +-
templates/repo/settings/deploy_keys.tmpl | 2 +-
templates/repo/settings/lfs.tmpl | 2 +-
templates/repo/settings/options.tmpl | 2 +-
.../repo/settings/webhook/delete_modal.tmpl | 2 +-
templates/repo/wiki/view.tmpl | 2 +-
templates/shared/actions/runner_edit.tmpl | 2 +-
templates/shared/secrets/add_list.tmpl | 2 +-
templates/user/settings/account.tmpl | 4 ++--
templates/user/settings/applications.tmpl | 2 +-
.../user/settings/applications_oauth2_list.tmpl | 2 +-
templates/user/settings/grants_oauth2.tmpl | 2 +-
templates/user/settings/keys_gpg.tmpl | 2 +-
templates/user/settings/keys_principal.tmpl | 2 +-
templates/user/settings/keys_ssh.tmpl | 2 +-
templates/user/settings/organization.tmpl | 2 +-
templates/user/settings/repos.tmpl | 6 +++---
.../user/settings/security/accountlinks.tmpl | 2 +-
templates/user/settings/security/openid.tmpl | 2 +-
templates/user/settings/security/twofa.tmpl | 2 +-
templates/user/settings/security/webauthn.tmpl | 2 +-
web_src/js/features/repo-projects.js | 4 ++--
54 files changed, 91 insertions(+), 84 deletions(-)
delete mode 100644 templates/base/basic_modal_actions.tmpl
create mode 100644 templates/base/modal_actions_confirm.tmpl
diff --git a/templates/admin/auth/edit.tmpl b/templates/admin/auth/edit.tmpl
index e46afe4ad686b..ec0cb10b56214 100644
--- a/templates/admin/auth/edit.tmpl
+++ b/templates/admin/auth/edit.tmpl
@@ -448,6 +448,6 @@
{{.locale.Tr "admin.auths.delete_auth_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/emails/list.tmpl b/templates/admin/emails/list.tmpl
index 37da00d5e8d42..b71acb28d7ad8 100644
--- a/templates/admin/emails/list.tmpl
+++ b/templates/admin/emails/list.tmpl
@@ -94,7 +94,7 @@
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
diff --git a/templates/admin/monitor.tmpl b/templates/admin/monitor.tmpl
index c4257a8527c06..31929764a5899 100644
--- a/templates/admin/monitor.tmpl
+++ b/templates/admin/monitor.tmpl
@@ -46,6 +46,6 @@
{{$.locale.Tr "admin.monitor.process.cancel_notices" `` | Safe}}
{{$.locale.Tr "admin.monitor.process.cancel_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/packages/list.tmpl b/templates/admin/packages/list.tmpl
index d97b41ffa5727..17b4d0afe9e1f 100644
--- a/templates/admin/packages/list.tmpl
+++ b/templates/admin/packages/list.tmpl
@@ -88,6 +88,6 @@
{{.locale.Tr "packages.settings.delete.notice" `` `` | Safe}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/queue.tmpl b/templates/admin/queue.tmpl
index 2ace03810cb04..e6f908aefcbe5 100644
--- a/templates/admin/queue.tmpl
+++ b/templates/admin/queue.tmpl
@@ -190,7 +190,7 @@
{{$.locale.Tr "admin.monitor.queue.pool.cancel_notices" `` | Safe}}
{{$.locale.Tr "admin.monitor.queue.pool.cancel_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/repo/list.tmpl b/templates/admin/repo/list.tmpl
index 7c907e5cfcf16..5daf50fc5edb5 100644
--- a/templates/admin/repo/list.tmpl
+++ b/templates/admin/repo/list.tmpl
@@ -105,6 +105,6 @@
{{.locale.Tr "repo.settings.delete_notices_2" `` | Safe}}
{{.locale.Tr "repo.settings.delete_notices_fork_1"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/repo/unadopted.tmpl b/templates/admin/repo/unadopted.tmpl
index 357ca9b042e1b..fc3a632f02032 100644
--- a/templates/admin/repo/unadopted.tmpl
+++ b/templates/admin/repo/unadopted.tmpl
@@ -43,7 +43,7 @@
- {{/* TODO: Convert to base/basic_modal_actions */}}
+
{{/* TODO: Convert to base/modal_actions_confirm */}}
{{svg "octicon-trash" 16 "gt-mr-2"}}
{{$.locale.Tr "modal.no"}}
@@ -70,7 +70,7 @@
- {{/* TODO: Convert to base/basic_modal_actions */}}
+
{{/* TODO: Convert to base/modal_actions_confirm */}}
{{svg "octicon-trash" 16 "gt-mr-2"}}
{{$.locale.Tr "modal.no"}}
diff --git a/templates/admin/stacktrace.tmpl b/templates/admin/stacktrace.tmpl
index 8dfe78422a858..f5b2fd25f6aaa 100644
--- a/templates/admin/stacktrace.tmpl
+++ b/templates/admin/stacktrace.tmpl
@@ -27,7 +27,7 @@
{{$.locale.Tr "admin.monitor.process.cancel_notices" `` | Safe}}
{{$.locale.Tr "admin.monitor.process.cancel_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/admin/user/edit.tmpl b/templates/admin/user/edit.tmpl
index 17a64359d9c02..63ac2e0b042da 100644
--- a/templates/admin/user/edit.tmpl
+++ b/templates/admin/user/edit.tmpl
@@ -213,7 +213,7 @@
{{.locale.Tr "admin.users.purge_help"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/base/basic_modal_actions.tmpl b/templates/base/basic_modal_actions.tmpl
deleted file mode 100644
index 79229b62688ab..0000000000000
--- a/templates/base/basic_modal_actions.tmpl
+++ /dev/null
@@ -1,10 +0,0 @@
-
-
- {{svg "octicon-x"}}
- {{if .ModalNoText}}{{.ModalNoText}}{{else}}{{.locale.Tr "modal.no"}}{{end}}
-
-
- {{svg "octicon-check"}}
- {{if .ModalYesText}}{{.ModalYesText}}{{else}}{{.locale.Tr "modal.yes"}}{{end}}
-
-
diff --git a/templates/base/modal_actions_confirm.tmpl b/templates/base/modal_actions_confirm.tmpl
new file mode 100644
index 0000000000000..70d3f0af0e65a
--- /dev/null
+++ b/templates/base/modal_actions_confirm.tmpl
@@ -0,0 +1,17 @@
+{{/*
+Template Attributes:
+* ModalButtonCancelText
+* ModalButtonOkText
+
+The ".ok.button" and ".cancel.button" selectors are also used by Fomantic Modal internally
+*/}}
+
+
+ {{svg "octicon-x"}}
+ {{if .ModalButtonCancelText}}{{.ModalButtonCancelText}}{{else}}{{.locale.Tr "modal.no"}}{{end}}
+
+
+ {{svg "octicon-check"}}
+ {{if .ModalButtonOkText}}{{.ModalButtonOkText}}{{else}}{{.locale.Tr "modal.yes"}}{{end}}
+
+
diff --git a/templates/org/member/members.tmpl b/templates/org/member/members.tmpl
index d83b742f9f4bf..e273e0d2b37c8 100644
--- a/templates/org/member/members.tmpl
+++ b/templates/org/member/members.tmpl
@@ -89,7 +89,7 @@
{{$.locale.Tr "org.members.leave.detail" `` | Safe}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/org/settings/delete.tmpl b/templates/org/settings/delete.tmpl
index 6352396d867c5..80d0ed212d131 100644
--- a/templates/org/settings/delete.tmpl
+++ b/templates/org/settings/delete.tmpl
@@ -37,6 +37,6 @@
{{.locale.Tr "org.settings.delete_org_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/org/team/members.tmpl b/templates/org/team/members.tmpl
index c59cce11be4fd..efe32d09ad8a9 100644
--- a/templates/org/team/members.tmpl
+++ b/templates/org/team/members.tmpl
@@ -72,6 +72,6 @@
{{$.locale.Tr "org.members.remove.detail" `` `` | Safe}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/org/team/new.tmpl b/templates/org/team/new.tmpl
index 48ec1f4586e05..99530b1be61d1 100644
--- a/templates/org/team/new.tmpl
+++ b/templates/org/team/new.tmpl
@@ -156,6 +156,6 @@
{{.locale.Tr "org.teams.delete_team_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/org/team/repositories.tmpl b/templates/org/team/repositories.tmpl
index 0d7da480ddae2..e8d3ea66cf849 100644
--- a/templates/org/team/repositories.tmpl
+++ b/templates/org/team/repositories.tmpl
@@ -72,7 +72,7 @@
{{.locale.Tr "org.teams.remove_all_repos_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
@@ -83,7 +83,7 @@
{{.locale.Tr "org.teams.add_all_repos_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/org/team/sidebar.tmpl b/templates/org/team/sidebar.tmpl
index 1c98315697da5..311601ac595ea 100644
--- a/templates/org/team/sidebar.tmpl
+++ b/templates/org/team/sidebar.tmpl
@@ -91,5 +91,5 @@
{{$.locale.Tr "org.teams.leave.detail" `` | Safe}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
diff --git a/templates/org/team/teams.tmpl b/templates/org/team/teams.tmpl
index 2f9d447b1c43b..56e5ed315d262 100644
--- a/templates/org/team/teams.tmpl
+++ b/templates/org/team/teams.tmpl
@@ -51,6 +51,6 @@
{{$.locale.Tr "org.teams.leave.detail" `` | Safe}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/package/settings.tmpl b/templates/package/settings.tmpl
index 69d4306978e00..a443a8d27f483 100644
--- a/templates/package/settings.tmpl
+++ b/templates/package/settings.tmpl
@@ -57,7 +57,7 @@
diff --git a/templates/projects/list.tmpl b/templates/projects/list.tmpl
index 2ddf7477e857e..34460ebe574ac 100644
--- a/templates/projects/list.tmpl
+++ b/templates/projects/list.tmpl
@@ -84,6 +84,6 @@
{{.locale.Tr "repo.projects.deletion_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{end}}
diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl
index c1251df29e25e..a9297bf07c10f 100644
--- a/templates/projects/view.tmpl
+++ b/templates/projects/view.tmpl
@@ -157,12 +157,12 @@
- {{$ModalNoText := $.locale.Tr "settings.cancel"}}
- {{- $ModalYesText := $.locale.Tr "repo.projects.column.set_default" -}}
+ {{$ModalButtonCancelText := $.locale.Tr "settings.cancel"}}
+ {{- $ModalButtonOkText := $.locale.Tr "repo.projects.column.set_default" -}}
{{- if .Default -}}
- {{- $ModalYesText = $.locale.Tr "repo.projects.column.unset_default" -}}
+ {{- $ModalButtonOkText = $.locale.Tr "repo.projects.column.unset_default" -}}
{{- end -}}
- {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
+ {{template "base/modal_actions_confirm" (dict "." $ "ModalButtonCancelText" $ModalButtonCancelText "ModalButtonOkText" $ModalButtonOkText)}}
@@ -174,8 +174,8 @@
{{$.locale.Tr "repo.projects.column.deletion_desc"}}
- {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
- {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
+ {{$ModalButtonOkText := $.locale.Tr "repo.projects.column.delete"}}
+ {{template "base/modal_actions_confirm" (dict "." $ "ModalButtonCancelText" $ModalButtonCancelText "ModalButtonOkText" $ModalButtonOkText)}}
@@ -286,6 +286,6 @@
{{.locale.Tr "repo.projects.deletion_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{end}}
diff --git a/templates/repo/branch/list.tmpl b/templates/repo/branch/list.tmpl
index 5cea38e7b6bd7..6b8d87d3b2739 100644
--- a/templates/repo/branch/list.tmpl
+++ b/templates/repo/branch/list.tmpl
@@ -155,7 +155,7 @@
{{.locale.Tr "repo.branch.delete_desc" | Str2html}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
diff --git a/templates/repo/issue/labels/edit_delete_label.tmpl b/templates/repo/issue/labels/edit_delete_label.tmpl
index c90fdc13effc3..e5ef6a3e4163e 100644
--- a/templates/repo/issue/labels/edit_delete_label.tmpl
+++ b/templates/repo/issue/labels/edit_delete_label.tmpl
@@ -6,7 +6,7 @@
{{.locale.Tr "repo.issues.label_deletion_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
diff --git a/templates/repo/issue/milestones.tmpl b/templates/repo/issue/milestones.tmpl
index a8c43815be0c8..2b11be6d5dd40 100644
--- a/templates/repo/issue/milestones.tmpl
+++ b/templates/repo/issue/milestones.tmpl
@@ -124,7 +124,7 @@
{{.locale.Tr "repo.milestones.deletion_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{end}}
{{template "base/footer" .}}
diff --git a/templates/repo/issue/view_content.tmpl b/templates/repo/issue/view_content.tmpl
index 5df7f50c116a1..4dab4faf2e704 100644
--- a/templates/repo/issue/view_content.tmpl
+++ b/templates/repo/issue/view_content.tmpl
@@ -205,5 +205,5 @@
{{.locale.Tr "repo.branch.delete_desc" | Str2html}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
diff --git a/templates/repo/issue/view_content/comments_delete_time.tmpl b/templates/repo/issue/view_content/comments_delete_time.tmpl
index 42f142725b21e..d86cc52d3a183 100644
--- a/templates/repo/issue/view_content/comments_delete_time.tmpl
+++ b/templates/repo/issue/view_content/comments_delete_time.tmpl
@@ -7,7 +7,7 @@
{{.ctxData.CsrfTokenHtml}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{svg "octicon-trash"}}
diff --git a/templates/repo/issue/view_content/sidebar.tmpl b/templates/repo/issue/view_content/sidebar.tmpl
index d767ce6122785..098d642d0f1e7 100644
--- a/templates/repo/issue/view_content/sidebar.tmpl
+++ b/templates/repo/issue/view_content/sidebar.tmpl
@@ -559,9 +559,9 @@
{{.locale.Tr "repo.issues.dependency.issue_remove_text"}}
{{end}}
- {{$ModalNoText := .locale.Tr "repo.issues.dependency.cancel"}}
- {{$ModalYesText := .locale.Tr "repo.issues.dependency.remove"}}
- {{template "base/basic_modal_actions" (dict "." . "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
+ {{$ModalButtonCancelText := .locale.Tr "repo.issues.dependency.cancel"}}
+ {{$ModalButtonOkText := .locale.Tr "repo.issues.dependency.remove"}}
+ {{template "base/modal_actions_confirm" (dict "." . "ModalButtonCancelText" $ModalButtonCancelText "ModalButtonOkText" $ModalButtonOkText)}}
{{end}}
{{end}}
@@ -675,7 +675,7 @@
{{end}}
diff --git a/templates/repo/projects/list.tmpl b/templates/repo/projects/list.tmpl
index ebe0657504846..b093d948d26f7 100644
--- a/templates/repo/projects/list.tmpl
+++ b/templates/repo/projects/list.tmpl
@@ -86,7 +86,7 @@
{{.locale.Tr "repo.projects.deletion_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{end}}
{{template "base/footer" .}}
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl
index a8411b89aabb7..c9b657c862d16 100644
--- a/templates/repo/projects/view.tmpl
+++ b/templates/repo/projects/view.tmpl
@@ -163,12 +163,12 @@
- {{$ModalNoText := $.locale.Tr "settings.cancel"}}
- {{- $ModalYesText := $.locale.Tr "repo.projects.column.set_default" -}}
+ {{$ModalButtonCancelText := $.locale.Tr "settings.cancel"}}
+ {{- $ModalButtonOkText := $.locale.Tr "repo.projects.column.set_default" -}}
{{- if .Default -}}
- {{- $ModalYesText = $.locale.Tr "repo.projects.column.unset_default" -}}
+ {{- $ModalButtonOkText = $.locale.Tr "repo.projects.column.unset_default" -}}
{{- end -}}
- {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
+ {{template "base/modal_actions_confirm" (dict "." $ "ModalButtonCancelText" $ModalButtonCancelText "ModalButtonOkText" $ModalButtonOkText)}}
@@ -180,8 +180,8 @@
{{$.locale.Tr "repo.projects.column.deletion_desc"}}
- {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}}
- {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
+ {{$ModalButtonOkText := $.locale.Tr "repo.projects.column.delete"}}
+ {{template "base/modal_actions_confirm" (dict "." $ "ModalButtonCancelText" $ModalButtonCancelText "ModalButtonOkText" $ModalButtonOkText)}}
@@ -292,7 +292,7 @@
{{.locale.Tr "repo.projects.deletion_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{end}}
diff --git a/templates/repo/release/list.tmpl b/templates/repo/release/list.tmpl
index ec270546bebb6..aae351324a7eb 100644
--- a/templates/repo/release/list.tmpl
+++ b/templates/repo/release/list.tmpl
@@ -192,7 +192,7 @@
{{.locale.Tr "repo.release.deletion_tag_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{end}}
diff --git a/templates/repo/release/new.tmpl b/templates/repo/release/new.tmpl
index 7f99ca2873289..4f162f924e5a3 100644
--- a/templates/repo/release/new.tmpl
+++ b/templates/repo/release/new.tmpl
@@ -146,7 +146,7 @@
{{.locale.Tr "repo.release.deletion_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{end}}
{{template "base/footer" .}}
diff --git a/templates/repo/settings/branches.tmpl b/templates/repo/settings/branches.tmpl
index 1d4e56e9072d9..3258a056a4b5c 100644
--- a/templates/repo/settings/branches.tmpl
+++ b/templates/repo/settings/branches.tmpl
@@ -104,7 +104,7 @@
{{.locale.Tr "repo.settings.protected_branch_deletion_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/repo/settings/collaboration.tmpl b/templates/repo/settings/collaboration.tmpl
index 341c5fc678776..f378805a4af18 100644
--- a/templates/repo/settings/collaboration.tmpl
+++ b/templates/repo/settings/collaboration.tmpl
@@ -120,6 +120,6 @@
{{.locale.Tr "repo.settings.collaborator_deletion_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/repo/settings/deploy_keys.tmpl b/templates/repo/settings/deploy_keys.tmpl
index 9fc2fc27845fd..bf39bd24a2a01 100644
--- a/templates/repo/settings/deploy_keys.tmpl
+++ b/templates/repo/settings/deploy_keys.tmpl
@@ -85,6 +85,6 @@
{{.locale.Tr "repo.settings.deploy_key_deletion_desc"}}
- {{template "base/basic_modal_actions" .}}
+ {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}}
diff --git a/templates/repo/settings/lfs.tmpl b/templates/repo/settings/lfs.tmpl
index 8752e1c876537..a2dd6224a7765 100644
--- a/templates/repo/settings/lfs.tmpl
+++ b/templates/repo/settings/lfs.tmpl
@@ -50,7 +50,7 @@