From 35d0145a332cc958b8176b49f694f9dcb3c29645 Mon Sep 17 00:00:00 2001 From: HesterG Date: Thu, 13 Apr 2023 10:58:43 +0800 Subject: [PATCH 01/26] fix project column delete --- templates/base/delete_modal_actions.tmpl | 2 +- templates/projects/view.tmpl | 8 ++++---- templates/repo/projects/view.tmpl | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/templates/base/delete_modal_actions.tmpl b/templates/base/delete_modal_actions.tmpl index 29bf5f92fd53f..8348cfad7917f 100644 --- a/templates/base/delete_modal_actions.tmpl +++ b/templates/base/delete_modal_actions.tmpl @@ -3,7 +3,7 @@ {{svg "octicon-x"}} {{.locale.Tr "modal.no"}} - diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index 41bbb83f7b1de..cb0ef42208948 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -144,8 +144,8 @@
- - + +
@@ -159,8 +159,8 @@
{{/* TODO: convert to base/delete_modal_actions.tmpl */}} - - + {{$DataUrl := printf "%s/%d" $.Link .ID}} + {{template "base/delete_modal_actions" (dict "." $ "ExtClass" "delete-project-board" "DataUrl" $DataUrl)}}
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index acbd0241d4a58..2b1e0c018b7ca 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -163,8 +163,8 @@
{{/* TODO: Convert to base/delete_modal_actions.tmpl? */}} - - + {{$DataUrl := printf "%s/projects/%d/%d" $.RepoLink $.Project.ID .ID}} + {{template "base/delete_modal_actions" (dict "." $ "ExtClass" "delete-project-board" "DataUrl" $DataUrl)}}
From 11e133f2ada3702a75a3a9047a4f52b29baa74a4 Mon Sep 17 00:00:00 2001 From: HesterG Date: Thu, 13 Apr 2023 11:13:43 +0800 Subject: [PATCH 02/26] set default template --- templates/projects/view.tmpl | 4 ++-- templates/repo/projects/view.tmpl | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index cb0ef42208948..657d9015ab645 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -144,8 +144,8 @@
- - + {{$DataUrl := printf "%s/%d/default" $.Link .ID}} + {{template "base/delete_modal_actions" (dict "." $ "ExtClass" "set-default-project-board" "DataUrl" $DataUrl)}}
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index 2b1e0c018b7ca..918b8df1bc5a4 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -148,8 +148,8 @@
- - + {{$DataUrl := printf "%s/projects/%d/%d/default" $.RepoLink $.Project.ID .ID}} + {{template "base/delete_modal_actions" (dict "." $ "ExtClass" "set-default-project-board" "DataUrl" $DataUrl)}}
From 31162d8d8cfca5b282c14b4088c4b95ebfcc722a Mon Sep 17 00:00:00 2001 From: HesterG Date: Thu, 13 Apr 2023 11:41:00 +0800 Subject: [PATCH 03/26] remove todo --- templates/projects/view.tmpl | 2 +- templates/repo/projects/view.tmpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index 657d9015ab645..128988d08467c 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -158,7 +158,7 @@ {{$.locale.Tr "repo.projects.column.deletion_desc"}} -
{{/* TODO: convert to base/delete_modal_actions.tmpl */}} +
{{$DataUrl := printf "%s/%d" $.Link .ID}} {{template "base/delete_modal_actions" (dict "." $ "ExtClass" "delete-project-board" "DataUrl" $DataUrl)}}
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index 918b8df1bc5a4..4f38c18418a57 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -162,7 +162,7 @@ {{$.locale.Tr "repo.projects.column.deletion_desc"}}
-
{{/* TODO: Convert to base/delete_modal_actions.tmpl? */}} +
{{$DataUrl := printf "%s/projects/%d/%d" $.RepoLink $.Project.ID .ID}} {{template "base/delete_modal_actions" (dict "." $ "ExtClass" "delete-project-board" "DataUrl" $DataUrl)}}
From 66700ffaeb12a6c6247c2fc1a4f7fa2862eeb273 Mon Sep 17 00:00:00 2001 From: HesterG Date: Thu, 13 Apr 2023 11:51:43 +0800 Subject: [PATCH 04/26] rename variable --- templates/base/delete_modal_actions.tmpl | 2 +- templates/projects/view.tmpl | 4 ++-- templates/repo/projects/view.tmpl | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/templates/base/delete_modal_actions.tmpl b/templates/base/delete_modal_actions.tmpl index 8348cfad7917f..8ad4cf65e4834 100644 --- a/templates/base/delete_modal_actions.tmpl +++ b/templates/base/delete_modal_actions.tmpl @@ -3,7 +3,7 @@ {{svg "octicon-x"}} {{.locale.Tr "modal.no"}} - diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index 128988d08467c..11e3312d9bcf4 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -145,7 +145,7 @@
{{$DataUrl := printf "%s/%d/default" $.Link .ID}} - {{template "base/delete_modal_actions" (dict "." $ "ExtClass" "set-default-project-board" "DataUrl" $DataUrl)}} + {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "set-default-project-board" "DataUrl" $DataUrl)}}
@@ -160,7 +160,7 @@
{{$DataUrl := printf "%s/%d" $.Link .ID}} - {{template "base/delete_modal_actions" (dict "." $ "ExtClass" "delete-project-board" "DataUrl" $DataUrl)}} + {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl)}}
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index 4f38c18418a57..9dbf2d49c04c2 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -149,7 +149,7 @@
{{$DataUrl := printf "%s/projects/%d/%d/default" $.RepoLink $.Project.ID .ID}} - {{template "base/delete_modal_actions" (dict "." $ "ExtClass" "set-default-project-board" "DataUrl" $DataUrl)}} + {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "set-default-project-board" "DataUrl" $DataUrl)}}
@@ -164,7 +164,7 @@
{{$DataUrl := printf "%s/projects/%d/%d" $.RepoLink $.Project.ID .ID}} - {{template "base/delete_modal_actions" (dict "." $ "ExtClass" "delete-project-board" "DataUrl" $DataUrl)}} + {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl)}}
From 9037ed079f1239a4a7774aaf5c1842511453bca7 Mon Sep 17 00:00:00 2001 From: HesterG Date: Thu, 13 Apr 2023 13:22:36 +0800 Subject: [PATCH 05/26] add variable --- templates/base/delete_modal_actions.tmpl | 4 ++-- templates/projects/view.tmpl | 2 +- templates/repo/projects/view.tmpl | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/templates/base/delete_modal_actions.tmpl b/templates/base/delete_modal_actions.tmpl index 8ad4cf65e4834..c45d3a98040a2 100644 --- a/templates/base/delete_modal_actions.tmpl +++ b/templates/base/delete_modal_actions.tmpl @@ -1,10 +1,10 @@
diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index 11e3312d9bcf4..ffe5f6164b2c7 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -145,7 +145,7 @@
{{$DataUrl := printf "%s/%d/default" $.Link .ID}} - {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "set-default-project-board" "DataUrl" $DataUrl)}} + {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "set-default-project-board" "DataUrl" $DataUrl "ModalNoTranslationKey" "settings.cancel" "ModalYesTranslationKey" "repo.projects.column.set_default")}}
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index 9dbf2d49c04c2..40206ea7449fb 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -149,7 +149,7 @@
{{$DataUrl := printf "%s/projects/%d/%d/default" $.RepoLink $.Project.ID .ID}} - {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "set-default-project-board" "DataUrl" $DataUrl)}} + {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "set-default-project-board" "DataUrl" $DataUrl "ModalNoTranslationKey" "settings.cancel" "ModalYesTranslationKey" "repo.projects.column.set_default")}}
From 50d6b5a6083ce6da17b7709752bad3098957dabb Mon Sep 17 00:00:00 2001 From: HesterG Date: Thu, 13 Apr 2023 15:20:33 +0800 Subject: [PATCH 06/26] revert set/unset col for now and test texts --- templates/base/delete_modal_actions.tmpl | 4 ++-- templates/projects/view.tmpl | 8 +++++--- templates/repo/projects/view.tmpl | 4 ++-- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/templates/base/delete_modal_actions.tmpl b/templates/base/delete_modal_actions.tmpl index c45d3a98040a2..60bb27122c21e 100644 --- a/templates/base/delete_modal_actions.tmpl +++ b/templates/base/delete_modal_actions.tmpl @@ -1,10 +1,10 @@
diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index ffe5f6164b2c7..02b7c9258c6e5 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -144,8 +144,8 @@
- {{$DataUrl := printf "%s/%d/default" $.Link .ID}} - {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "set-default-project-board" "DataUrl" $DataUrl "ModalNoTranslationKey" "settings.cancel" "ModalYesTranslationKey" "repo.projects.column.set_default")}} + +
@@ -160,7 +160,9 @@
{{$DataUrl := printf "%s/%d" $.Link .ID}} - {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl)}} + {{$ModalNoText := $.locale.Tr "settings.cancel"}} + {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}} + {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index 40206ea7449fb..aee714dea7b9a 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -148,8 +148,8 @@
- {{$DataUrl := printf "%s/projects/%d/%d/default" $.RepoLink $.Project.ID .ID}} - {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "set-default-project-board" "DataUrl" $DataUrl "ModalNoTranslationKey" "settings.cancel" "ModalYesTranslationKey" "repo.projects.column.set_default")}} + +
From 6ac0e0063025cddff439a34496fc84596205afb0 Mon Sep 17 00:00:00 2001 From: HesterG Date: Fri, 14 Apr 2023 14:51:20 +0800 Subject: [PATCH 07/26] refactor and respect original button texts for project deletion --- templates/admin/auth/edit.tmpl | 2 +- templates/admin/emails/list.tmpl | 2 +- templates/admin/monitor.tmpl | 2 +- templates/admin/packages/list.tmpl | 2 +- templates/admin/queue.tmpl | 2 +- templates/admin/repo/list.tmpl | 2 +- templates/admin/stacktrace.tmpl | 2 +- templates/admin/user/edit.tmpl | 2 +- .../{delete_modal_actions.tmpl => page_dimmer_buttons.tmpl} | 0 templates/org/member/members.tmpl | 4 ++-- templates/org/settings/delete.tmpl | 2 +- templates/org/team/members.tmpl | 2 +- templates/org/team/new.tmpl | 2 +- templates/org/team/repositories.tmpl | 4 ++-- templates/org/team/sidebar.tmpl | 2 +- templates/org/team/teams.tmpl | 2 +- templates/package/settings.tmpl | 2 +- templates/projects/list.tmpl | 2 +- templates/projects/view.tmpl | 4 ++-- templates/repo/branch/list.tmpl | 2 +- templates/repo/issue/labels/edit_delete_label.tmpl | 2 +- templates/repo/issue/milestones.tmpl | 2 +- templates/repo/issue/view_content.tmpl | 2 +- templates/repo/issue/view_content/comments_delete_time.tmpl | 2 +- templates/repo/projects/list.tmpl | 2 +- templates/repo/projects/view.tmpl | 6 ++++-- templates/repo/release/list.tmpl | 2 +- templates/repo/release/new.tmpl | 2 +- templates/repo/settings/branches.tmpl | 2 +- templates/repo/settings/collaboration.tmpl | 2 +- templates/repo/settings/deploy_keys.tmpl | 2 +- templates/repo/settings/lfs.tmpl | 2 +- templates/repo/settings/options.tmpl | 2 +- templates/repo/settings/webhook/delete_modal.tmpl | 2 +- templates/repo/wiki/view.tmpl | 2 +- templates/shared/actions/runner_edit.tmpl | 2 +- templates/shared/secrets/add_list.tmpl | 2 +- templates/user/settings/account.tmpl | 4 ++-- templates/user/settings/applications.tmpl | 2 +- templates/user/settings/applications_oauth2_list.tmpl | 2 +- templates/user/settings/grants_oauth2.tmpl | 2 +- templates/user/settings/keys_gpg.tmpl | 2 +- templates/user/settings/keys_principal.tmpl | 2 +- templates/user/settings/keys_ssh.tmpl | 2 +- templates/user/settings/organization.tmpl | 2 +- templates/user/settings/repos.tmpl | 4 ++-- templates/user/settings/security/accountlinks.tmpl | 2 +- templates/user/settings/security/openid.tmpl | 2 +- templates/user/settings/security/twofa.tmpl | 2 +- templates/user/settings/security/webauthn.tmpl | 2 +- 50 files changed, 57 insertions(+), 55 deletions(-) rename templates/base/{delete_modal_actions.tmpl => page_dimmer_buttons.tmpl} (100%) diff --git a/templates/admin/auth/edit.tmpl b/templates/admin/auth/edit.tmpl index 49007e572da96..5cb5aaae69fa0 100644 --- a/templates/admin/auth/edit.tmpl +++ b/templates/admin/auth/edit.tmpl @@ -448,6 +448,6 @@

{{.locale.Tr "admin.auths.delete_auth_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/admin/emails/list.tmpl b/templates/admin/emails/list.tmpl index d8fa986cff3e3..ca6ebed226c12 100644 --- a/templates/admin/emails/list.tmpl +++ b/templates/admin/emails/list.tmpl @@ -94,7 +94,7 @@
- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}}
diff --git a/templates/admin/monitor.tmpl b/templates/admin/monitor.tmpl index d53e9e18dcc8c..0c1d2193d63d1 100644 --- a/templates/admin/monitor.tmpl +++ b/templates/admin/monitor.tmpl @@ -46,6 +46,6 @@

{{$.locale.Tr "admin.monitor.process.cancel_notices" `` | Safe}}

{{$.locale.Tr "admin.monitor.process.cancel_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/admin/packages/list.tmpl b/templates/admin/packages/list.tmpl index 121f575861d99..356cd4d638924 100644 --- a/templates/admin/packages/list.tmpl +++ b/templates/admin/packages/list.tmpl @@ -88,6 +88,6 @@
{{.locale.Tr "packages.settings.delete.notice" `` `` | Safe}}
- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/admin/queue.tmpl b/templates/admin/queue.tmpl index 767c235a385e1..949564dcc2fb5 100644 --- a/templates/admin/queue.tmpl +++ b/templates/admin/queue.tmpl @@ -190,7 +190,7 @@

{{$.locale.Tr "admin.monitor.queue.pool.cancel_notices" `` | Safe}}

{{$.locale.Tr "admin.monitor.queue.pool.cancel_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/admin/repo/list.tmpl b/templates/admin/repo/list.tmpl index f8e2bbc8444ef..aa65e48f9161e 100644 --- a/templates/admin/repo/list.tmpl +++ b/templates/admin/repo/list.tmpl @@ -105,6 +105,6 @@ {{.locale.Tr "repo.settings.delete_notices_2" `` | Safe}}
{{.locale.Tr "repo.settings.delete_notices_fork_1"}}
- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/admin/stacktrace.tmpl b/templates/admin/stacktrace.tmpl index 4e16036ae3a3c..aa84e02e06abf 100644 --- a/templates/admin/stacktrace.tmpl +++ b/templates/admin/stacktrace.tmpl @@ -27,7 +27,7 @@

{{$.locale.Tr "admin.monitor.process.cancel_notices" `` | Safe}}

{{$.locale.Tr "admin.monitor.process.cancel_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/admin/user/edit.tmpl b/templates/admin/user/edit.tmpl index 4fd0d892f258d..4606be39625df 100644 --- a/templates/admin/user/edit.tmpl +++ b/templates/admin/user/edit.tmpl @@ -213,7 +213,7 @@

{{.locale.Tr "admin.users.purge_help"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/base/delete_modal_actions.tmpl b/templates/base/page_dimmer_buttons.tmpl similarity index 100% rename from templates/base/delete_modal_actions.tmpl rename to templates/base/page_dimmer_buttons.tmpl diff --git a/templates/org/member/members.tmpl b/templates/org/member/members.tmpl index 511d333c29c27..505cffd32a802 100644 --- a/templates/org/member/members.tmpl +++ b/templates/org/member/members.tmpl @@ -89,7 +89,7 @@

{{$.locale.Tr "org.members.leave.detail" `` | Safe}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/org/team/members.tmpl b/templates/org/team/members.tmpl index bb975c0c4df7a..81562c39edb08 100644 --- a/templates/org/team/members.tmpl +++ b/templates/org/team/members.tmpl @@ -72,6 +72,6 @@

{{$.locale.Tr "org.members.remove.detail" `` `` | Safe}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/org/team/new.tmpl b/templates/org/team/new.tmpl index 2e65d63580319..8746bccce2bbd 100644 --- a/templates/org/team/new.tmpl +++ b/templates/org/team/new.tmpl @@ -156,6 +156,6 @@

{{.locale.Tr "org.teams.delete_team_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/org/team/repositories.tmpl b/templates/org/team/repositories.tmpl index ac863f3a7ba37..b55b39da1f225 100644 --- a/templates/org/team/repositories.tmpl +++ b/templates/org/team/repositories.tmpl @@ -72,7 +72,7 @@

{{.locale.Tr "org.teams.remove_all_repos_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/org/team/sidebar.tmpl b/templates/org/team/sidebar.tmpl index cecd8ddee6c1a..9e0239fc83a52 100644 --- a/templates/org/team/sidebar.tmpl +++ b/templates/org/team/sidebar.tmpl @@ -91,5 +91,5 @@

{{$.locale.Tr "org.teams.leave.detail" `` | Safe}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} diff --git a/templates/org/team/teams.tmpl b/templates/org/team/teams.tmpl index 27bbe80a3c535..627b27eb91364 100644 --- a/templates/org/team/teams.tmpl +++ b/templates/org/team/teams.tmpl @@ -51,6 +51,6 @@

{{$.locale.Tr "org.teams.leave.detail" `` | Safe}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/package/settings.tmpl b/templates/package/settings.tmpl index 875bf852bb98a..a1b2b2172c99f 100644 --- a/templates/package/settings.tmpl +++ b/templates/package/settings.tmpl @@ -57,7 +57,7 @@
{{.CsrfTokenHtml}} - {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}}
diff --git a/templates/projects/list.tmpl b/templates/projects/list.tmpl index 213bab70b66e2..cd15882c03a13 100644 --- a/templates/projects/list.tmpl +++ b/templates/projects/list.tmpl @@ -84,6 +84,6 @@

{{.locale.Tr "repo.projects.deletion_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{end}} diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index 02b7c9258c6e5..0df3fa1f48672 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -162,7 +162,7 @@ {{$DataUrl := printf "%s/%d" $.Link .ID}} {{$ModalNoText := $.locale.Tr "settings.cancel"}} {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}} - {{template "base/delete_modal_actions" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} + {{template "base/page_dimmer_buttons" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} @@ -274,6 +274,6 @@

{{.locale.Tr "repo.projects.deletion_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{end}} diff --git a/templates/repo/branch/list.tmpl b/templates/repo/branch/list.tmpl index 6dd6aecb37f6f..9a46e2cfe5f5d 100644 --- a/templates/repo/branch/list.tmpl +++ b/templates/repo/branch/list.tmpl @@ -155,7 +155,7 @@

{{.locale.Tr "repo.branch.delete_desc" | Str2html}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{end}} {{template "base/footer" .}} diff --git a/templates/repo/issue/view_content.tmpl b/templates/repo/issue/view_content.tmpl index a5d9b0bde0acf..b7bb72fd65ca1 100644 --- a/templates/repo/issue/view_content.tmpl +++ b/templates/repo/issue/view_content.tmpl @@ -203,5 +203,5 @@

{{.locale.Tr "repo.branch.delete_desc" | Str2html}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} diff --git a/templates/repo/issue/view_content/comments_delete_time.tmpl b/templates/repo/issue/view_content/comments_delete_time.tmpl index a0d6b0ea05747..cf3f5c0c8a87f 100644 --- a/templates/repo/issue/view_content/comments_delete_time.tmpl +++ b/templates/repo/issue/view_content/comments_delete_time.tmpl @@ -7,7 +7,7 @@ {{.ctxData.CsrfTokenHtml}}
{{.ctxData.locale.Tr "repo.issues.del_time"}}
- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} diff --git a/templates/repo/settings/options.tmpl b/templates/repo/settings/options.tmpl index 1aaf58ee91ca5..908ef2be361fe 100644 --- a/templates/repo/settings/options.tmpl +++ b/templates/repo/settings/options.tmpl @@ -988,7 +988,7 @@ {{.CsrfTokenHtml}} - {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{end}} diff --git a/templates/repo/settings/webhook/delete_modal.tmpl b/templates/repo/settings/webhook/delete_modal.tmpl index f455899663e8f..c5d05ced478d2 100644 --- a/templates/repo/settings/webhook/delete_modal.tmpl +++ b/templates/repo/settings/webhook/delete_modal.tmpl @@ -6,5 +6,5 @@

{{.locale.Tr "repo.settings.webhook_deletion_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} diff --git a/templates/repo/wiki/view.tmpl b/templates/repo/wiki/view.tmpl index a1d1c047515be..4b36bfb5e0099 100644 --- a/templates/repo/wiki/view.tmpl +++ b/templates/repo/wiki/view.tmpl @@ -121,7 +121,7 @@

{{.locale.Tr "repo.wiki.delete_page_notice_1" ($title|Escape) | Safe}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/shared/actions/runner_edit.tmpl b/templates/shared/actions/runner_edit.tmpl index 40b4924743226..9b66402438085 100644 --- a/templates/shared/actions/runner_edit.tmpl +++ b/templates/shared/actions/runner_edit.tmpl @@ -97,6 +97,6 @@

{{.locale.Tr "actions.runners.delete_runner_notice" | Safe}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} diff --git a/templates/shared/secrets/add_list.tmpl b/templates/shared/secrets/add_list.tmpl index 4aa5f0ccd578a..da4a0774a98a8 100644 --- a/templates/shared/secrets/add_list.tmpl +++ b/templates/shared/secrets/add_list.tmpl @@ -64,5 +64,5 @@

{{.locale.Tr "secrets.deletion.description"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} diff --git a/templates/user/settings/account.tmpl b/templates/user/settings/account.tmpl index 53f7d021e0b6a..a16c6afbffacb 100644 --- a/templates/user/settings/account.tmpl +++ b/templates/user/settings/account.tmpl @@ -169,7 +169,7 @@

{{.locale.Tr "settings.email_deletion_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/user/settings/applications.tmpl b/templates/user/settings/applications.tmpl index 2694f5cad0d40..21182d09635bd 100644 --- a/templates/user/settings/applications.tmpl +++ b/templates/user/settings/applications.tmpl @@ -277,7 +277,7 @@

{{.locale.Tr "settings.access_token_deletion_desc"}}

-
{{/* TODO: Convert to base/delete_modal_actions.tmpl */}} +
{{/* TODO: Convert to base/page_dimmer_buttons.tmpl */}}
diff --git a/templates/user/settings/grants_oauth2.tmpl b/templates/user/settings/grants_oauth2.tmpl index 3b92f35f37afe..83cfa75883001 100644 --- a/templates/user/settings/grants_oauth2.tmpl +++ b/templates/user/settings/grants_oauth2.tmpl @@ -36,5 +36,5 @@

{{.locale.Tr "settings.revoke_oauth2_grant_description"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}}
diff --git a/templates/user/settings/keys_gpg.tmpl b/templates/user/settings/keys_gpg.tmpl index 9ba9199db70d8..bd201149a41b5 100644 --- a/templates/user/settings/keys_gpg.tmpl +++ b/templates/user/settings/keys_gpg.tmpl @@ -119,5 +119,5 @@

{{.locale.Tr "settings.gpg_key_deletion_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} diff --git a/templates/user/settings/keys_principal.tmpl b/templates/user/settings/keys_principal.tmpl index 6194db13ab7ca..cc354afba499d 100644 --- a/templates/user/settings/keys_principal.tmpl +++ b/templates/user/settings/keys_principal.tmpl @@ -62,6 +62,6 @@

{{.locale.Tr "settings.ssh_principal_deletion_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{end}} diff --git a/templates/user/settings/keys_ssh.tmpl b/templates/user/settings/keys_ssh.tmpl index b60434cae4685..69bde0ca65da2 100644 --- a/templates/user/settings/keys_ssh.tmpl +++ b/templates/user/settings/keys_ssh.tmpl @@ -108,5 +108,5 @@

{{.locale.Tr "settings.ssh_key_deletion_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} diff --git a/templates/user/settings/organization.tmpl b/templates/user/settings/organization.tmpl index cd513db2490a5..5db6f632a753e 100644 --- a/templates/user/settings/organization.tmpl +++ b/templates/user/settings/organization.tmpl @@ -48,6 +48,6 @@

{{$.locale.Tr "org.members.leave.detail" `` | Safe}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/user/settings/repos.tmpl b/templates/user/settings/repos.tmpl index 6742cb1671826..e1c537c320091 100644 --- a/templates/user/settings/repos.tmpl +++ b/templates/user/settings/repos.tmpl @@ -77,7 +77,7 @@ {{$.CsrfTokenHtml}} - {{template "base/delete_modal_actions" $}} + {{template "base/page_dimmer_buttons" $}} {{end}} @@ -139,6 +139,6 @@

{{.locale.Tr "settings.remove_account_link_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} {{template "base/footer" .}} diff --git a/templates/user/settings/security/accountlinks.tmpl b/templates/user/settings/security/accountlinks.tmpl index e8eed632946c1..aa8332f6d8054 100644 --- a/templates/user/settings/security/accountlinks.tmpl +++ b/templates/user/settings/security/accountlinks.tmpl @@ -49,5 +49,5 @@

{{.locale.Tr "settings.remove_account_link_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} diff --git a/templates/user/settings/security/openid.tmpl b/templates/user/settings/security/openid.tmpl index 5d6c9cf8cd425..3fd49300fc7cd 100644 --- a/templates/user/settings/security/openid.tmpl +++ b/templates/user/settings/security/openid.tmpl @@ -59,5 +59,5 @@

{{.locale.Tr "settings.openid_deletion_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} diff --git a/templates/user/settings/security/twofa.tmpl b/templates/user/settings/security/twofa.tmpl index 1a0a8a6432c09..c4a4e8fbed417 100644 --- a/templates/user/settings/security/twofa.tmpl +++ b/templates/user/settings/security/twofa.tmpl @@ -31,5 +31,5 @@

{{.locale.Tr "settings.twofa_disable_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} diff --git a/templates/user/settings/security/webauthn.tmpl b/templates/user/settings/security/webauthn.tmpl index 2fea2843f6e05..3c5677aca0e01 100644 --- a/templates/user/settings/security/webauthn.tmpl +++ b/templates/user/settings/security/webauthn.tmpl @@ -38,5 +38,5 @@

{{.locale.Tr "settings.webauthn_delete_key_desc"}}

- {{template "base/delete_modal_actions" .}} + {{template "base/page_dimmer_buttons" .}} From 1df04eef57e9b9d8020cd460dea87cdd0338b2dd Mon Sep 17 00:00:00 2001 From: HesterG Date: Thu, 20 Apr 2023 09:00:57 +0800 Subject: [PATCH 08/26] modify css and change button on default-project-board-modal --- templates/base/page_dimmer_buttons.tmpl | 4 ++-- templates/projects/view.tmpl | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/templates/base/page_dimmer_buttons.tmpl b/templates/base/page_dimmer_buttons.tmpl index 60bb27122c21e..330c1d7542958 100644 --- a/templates/base/page_dimmer_buttons.tmpl +++ b/templates/base/page_dimmer_buttons.tmpl @@ -1,9 +1,9 @@
- - diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index cde653a0609b3..a79f7e363773f 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -157,8 +157,8 @@
- - + +
From 6651064d61fdc3e83b38efbf65e2d6ceb425f0f3 Mon Sep 17 00:00:00 2001 From: HesterG Date: Thu, 20 Apr 2023 09:21:48 +0800 Subject: [PATCH 09/26] modify css for repo unset --- templates/repo/projects/view.tmpl | 4 ++-- web_src/js/features/repo-projects.js | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index f6adec259c42a..663eb3ab4996d 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -163,8 +163,8 @@
- - + +
diff --git a/web_src/js/features/repo-projects.js b/web_src/js/features/repo-projects.js index a2679130d70f3..63ef541c7451f 100644 --- a/web_src/js/features/repo-projects.js +++ b/web_src/js/features/repo-projects.js @@ -131,11 +131,6 @@ export function initRepoProject() { const showButton = $(boardColumn).find('.default-project-board-show'); const commitButton = $(this).find('.default-project-board-button'); - if ($(showButton).data('type') === 'unset_default') { - $(commitButton).removeClass('primary'); - $(commitButton).addClass('red'); - } - $(commitButton).on('click', (e) => { e.preventDefault(); From f9430f7b13b5169bec9eedde9c89fa5891a0b2da Mon Sep 17 00:00:00 2001 From: HesterG Date: Thu, 20 Apr 2023 13:33:26 +0800 Subject: [PATCH 10/26] use data- attributes to pass data --- templates/base/page_dimmer_buttons.tmpl | 4 ++-- templates/projects/view.tmpl | 14 +++++++------- templates/repo/projects/view.tmpl | 14 +++++++------- web_src/js/features/repo-projects.js | 12 ++++++++---- 4 files changed, 24 insertions(+), 20 deletions(-) diff --git a/templates/base/page_dimmer_buttons.tmpl b/templates/base/page_dimmer_buttons.tmpl index 330c1d7542958..1c3e78f456cde 100644 --- a/templates/base/page_dimmer_buttons.tmpl +++ b/templates/base/page_dimmer_buttons.tmpl @@ -1,9 +1,9 @@
- - diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index a79f7e363773f..9a6d6951e2554 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -115,7 +115,10 @@ {{$.locale.Tr "repo.projects.column.unset_default"}} {{end}} - + {{svg "octicon-trash"}} {{$.locale.Tr "repo.projects.column.delete"}} @@ -171,12 +174,9 @@ {{$.locale.Tr "repo.projects.column.deletion_desc"}}
-
- {{$DataUrl := printf "%s/%d" $.Link .ID}} - {{$ModalNoText := $.locale.Tr "settings.cancel"}} - {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}} - {{template "base/page_dimmer_buttons" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} -
+ {{$ModalNoText := $.locale.Tr "settings.cancel"}} + {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}} + {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index 663eb3ab4996d..29d7eebcd02c1 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -121,7 +121,10 @@ {{$.locale.Tr "repo.projects.column.unset_default"}} {{end}} - + {{svg "octicon-trash"}} {{$.locale.Tr "repo.projects.column.delete"}} @@ -177,12 +180,9 @@ {{$.locale.Tr "repo.projects.column.deletion_desc"}} -
- {{$DataUrl := printf "%s/projects/%d/%d" $.RepoLink $.Project.ID .ID}} - {{$ModalNoText := $.locale.Tr "settings.cancel"}} - {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}} - {{template "base/page_dimmer_buttons" (dict "." $ "ExtendedClasses" "delete-project-board" "DataUrl" $DataUrl "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} -
+ {{$ModalNoText := $.locale.Tr "settings.cancel"}} + {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}} + {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} diff --git a/web_src/js/features/repo-projects.js b/web_src/js/features/repo-projects.js index 63ef541c7451f..a2a6ff148594b 100644 --- a/web_src/js/features/repo-projects.js +++ b/web_src/js/features/repo-projects.js @@ -147,12 +147,16 @@ export function initRepoProject() { }); }); - $('.delete-project-board').each(function () { - $(this).click(function (e) { + $('.show-delete-column-modal').each(function () { + const deleteColumnModal = $(`${$(this).attr('data-modal')}`); + const deleteColumnButton = deleteColumnModal.find('.confirm-button'); + const deleteUrl = $(this).attr('data-url'); + + deleteColumnButton.on('click', function (e) { e.preventDefault(); $.ajax({ - url: $(this).data('url'), + url: deleteUrl, headers: { 'X-Csrf-Token': csrfToken, }, @@ -162,7 +166,7 @@ export function initRepoProject() { window.location.reload(); }); }); - }); + }) $('#new_board_submit').click(function (e) { e.preventDefault(); From 68824ff7fa21d95e39250388c9e4a6be2727948c Mon Sep 17 00:00:00 2001 From: HesterG Date: Thu, 20 Apr 2023 14:36:04 +0800 Subject: [PATCH 11/26] try use template for set/unset columns and fix lint --- templates/base/page_dimmer_buttons.tmpl | 4 ++-- templates/projects/view.tmpl | 13 ++++++------- templates/repo/projects/view.tmpl | 13 ++++++------- web_src/js/features/repo-projects.js | 8 ++++---- 4 files changed, 18 insertions(+), 20 deletions(-) diff --git a/templates/base/page_dimmer_buttons.tmpl b/templates/base/page_dimmer_buttons.tmpl index 1c3e78f456cde..79229b62688ab 100644 --- a/templates/base/page_dimmer_buttons.tmpl +++ b/templates/base/page_dimmer_buttons.tmpl @@ -1,9 +1,9 @@
- - diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index 9a6d6951e2554..c4d72e0cf3365 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -99,7 +99,6 @@ data-modal="#default-project-board-modal-{{.ID}}" data-modal-default-project-board-header="{{$.locale.Tr "repo.projects.column.set_default"}}" data-modal-default-project-board-content="{{$.locale.Tr "repo.projects.column.set_default_desc"}}" - data-modal-default-project-board-submit="{{$.locale.Tr "repo.projects.column.set_default"}}" data-url="{{$.Link}}/{{.ID}}/default"> {{svg "octicon-pin"}} {{$.locale.Tr "repo.projects.column.set_default"}} @@ -109,7 +108,6 @@ data-modal="#default-project-board-modal-{{.ID}}" data-modal-default-project-board-header="{{$.locale.Tr "repo.projects.column.unset_default"}}" data-modal-default-project-board-content="{{$.locale.Tr "repo.projects.column.unset_default_desc"}}" - data-modal-default-project-board-submit="{{$.locale.Tr "repo.projects.column.unset_default"}}" data-url="{{$.Link}}/{{.ID}}/unsetdefault"> {{svg "octicon-pin"}} {{$.locale.Tr "repo.projects.column.unset_default"}} @@ -159,10 +157,12 @@
-
- - -
+ {{$ModalNoText := $.locale.Tr "settings.cancel"}} + {{- $ModalYesText := $.locale.Tr "repo.projects.column.set_default" -}} + {{- if .Default -}} + {{- $ModalYesText = $.locale.Tr "repo.projects.column.unset_default" -}} + {{- end -}} + {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
- {{$ModalNoText := $.locale.Tr "settings.cancel"}} {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}} {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index 29d7eebcd02c1..a597b5d6c0776 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -103,7 +103,6 @@ data-modal="#default-project-board-modal-{{.ID}}" data-modal-default-project-board-header="{{$.locale.Tr "repo.projects.column.set_default"}}" data-modal-default-project-board-content="{{$.locale.Tr "repo.projects.column.set_default_desc"}}" - data-modal-default-project-board-submit="{{$.locale.Tr "repo.projects.column.set_default"}}" data-type="set_default" data-url="{{$.Link}}/{{.ID}}/default"> {{svg "octicon-pin"}} @@ -114,7 +113,6 @@ data-modal="#default-project-board-modal-{{.ID}}" data-modal-default-project-board-header="{{$.locale.Tr "repo.projects.column.unset_default"}}" data-modal-default-project-board-content="{{$.locale.Tr "repo.projects.column.unset_default_desc"}}" - data-modal-default-project-board-submit="{{$.locale.Tr "repo.projects.column.unset_default"}}" data-type="unset_default" data-url="{{$.Link}}/{{.ID}}/unsetdefault"> {{svg "octicon-pin"}} @@ -165,10 +163,12 @@
-
- - -
+ {{$ModalNoText := $.locale.Tr "settings.cancel"}} + {{- $ModalYesText := $.locale.Tr "repo.projects.column.set_default" -}} + {{- if .Default -}} + {{- $ModalYesText = $.locale.Tr "repo.projects.column.unset_default" -}} + {{- end -}} + {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} - {{$ModalNoText := $.locale.Tr "settings.cancel"}} {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}} {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} diff --git a/web_src/js/features/repo-projects.js b/web_src/js/features/repo-projects.js index a2a6ff148594b..32a5b9a8ddedf 100644 --- a/web_src/js/features/repo-projects.js +++ b/web_src/js/features/repo-projects.js @@ -129,7 +129,7 @@ export function initRepoProject() { $('.default-project-board-modal').each(function () { const boardColumn = $(this).closest('.board-column'); const showButton = $(boardColumn).find('.default-project-board-show'); - const commitButton = $(this).find('.default-project-board-button'); + const commitButton = $(this).find('.modal-confirm-button'); $(commitButton).on('click', (e) => { e.preventDefault(); @@ -149,10 +149,10 @@ export function initRepoProject() { $('.show-delete-column-modal').each(function () { const deleteColumnModal = $(`${$(this).attr('data-modal')}`); - const deleteColumnButton = deleteColumnModal.find('.confirm-button'); + const deleteColumnButton = deleteColumnModal.find('.modal-confirm-button'); const deleteUrl = $(this).attr('data-url'); - deleteColumnButton.on('click', function (e) { + deleteColumnButton.on('click', (e) => { e.preventDefault(); $.ajax({ @@ -166,7 +166,7 @@ export function initRepoProject() { window.location.reload(); }); }); - }) + }); $('#new_board_submit').click(function (e) { e.preventDefault(); From c2e81e26a1fce1a273c7fe281f14b0519b6bc4af Mon Sep 17 00:00:00 2001 From: HesterG Date: Thu, 20 Apr 2023 15:03:58 +0800 Subject: [PATCH 12/26] fix lint and change name to basic_modal_actions for now --- templates/admin/auth/edit.tmpl | 2 +- templates/admin/emails/list.tmpl | 2 +- templates/admin/monitor.tmpl | 2 +- templates/admin/packages/list.tmpl | 2 +- templates/admin/queue.tmpl | 2 +- templates/admin/repo/list.tmpl | 2 +- templates/admin/stacktrace.tmpl | 2 +- templates/admin/user/edit.tmpl | 2 +- ...{page_dimmer_buttons.tmpl => basic_modal_actions.tmpl} | 0 templates/org/member/members.tmpl | 4 ++-- templates/org/settings/delete.tmpl | 2 +- templates/org/team/members.tmpl | 2 +- templates/org/team/new.tmpl | 2 +- templates/org/team/repositories.tmpl | 4 ++-- templates/org/team/sidebar.tmpl | 2 +- templates/org/team/teams.tmpl | 2 +- templates/package/settings.tmpl | 2 +- templates/projects/list.tmpl | 2 +- templates/projects/view.tmpl | 8 ++++---- templates/repo/branch/list.tmpl | 2 +- templates/repo/issue/labels/edit_delete_label.tmpl | 2 +- templates/repo/issue/milestones.tmpl | 2 +- templates/repo/issue/view_content.tmpl | 2 +- .../repo/issue/view_content/comments_delete_time.tmpl | 2 +- templates/repo/projects/list.tmpl | 2 +- templates/repo/projects/view.tmpl | 8 ++++---- templates/repo/release/list.tmpl | 2 +- templates/repo/release/new.tmpl | 2 +- templates/repo/settings/branches.tmpl | 2 +- templates/repo/settings/collaboration.tmpl | 2 +- templates/repo/settings/deploy_keys.tmpl | 2 +- templates/repo/settings/lfs.tmpl | 2 +- templates/repo/settings/options.tmpl | 2 +- templates/repo/settings/webhook/delete_modal.tmpl | 2 +- templates/repo/wiki/view.tmpl | 2 +- templates/shared/actions/runner_edit.tmpl | 2 +- templates/shared/secrets/add_list.tmpl | 2 +- templates/user/settings/account.tmpl | 4 ++-- templates/user/settings/applications.tmpl | 2 +- templates/user/settings/applications_oauth2_list.tmpl | 2 +- templates/user/settings/grants_oauth2.tmpl | 2 +- templates/user/settings/keys_gpg.tmpl | 2 +- templates/user/settings/keys_principal.tmpl | 2 +- templates/user/settings/keys_ssh.tmpl | 2 +- templates/user/settings/organization.tmpl | 2 +- templates/user/settings/repos.tmpl | 4 ++-- templates/user/settings/security/accountlinks.tmpl | 2 +- templates/user/settings/security/openid.tmpl | 2 +- templates/user/settings/security/twofa.tmpl | 2 +- templates/user/settings/security/webauthn.tmpl | 2 +- 50 files changed, 59 insertions(+), 59 deletions(-) rename templates/base/{page_dimmer_buttons.tmpl => basic_modal_actions.tmpl} (100%) diff --git a/templates/admin/auth/edit.tmpl b/templates/admin/auth/edit.tmpl index 5cb5aaae69fa0..e46afe4ad686b 100644 --- a/templates/admin/auth/edit.tmpl +++ b/templates/admin/auth/edit.tmpl @@ -448,6 +448,6 @@

{{.locale.Tr "admin.auths.delete_auth_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/admin/emails/list.tmpl b/templates/admin/emails/list.tmpl index ca6ebed226c12..37da00d5e8d42 100644 --- a/templates/admin/emails/list.tmpl +++ b/templates/admin/emails/list.tmpl @@ -94,7 +94,7 @@
- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}}
diff --git a/templates/admin/monitor.tmpl b/templates/admin/monitor.tmpl index 0c1d2193d63d1..c4257a8527c06 100644 --- a/templates/admin/monitor.tmpl +++ b/templates/admin/monitor.tmpl @@ -46,6 +46,6 @@

{{$.locale.Tr "admin.monitor.process.cancel_notices" `` | Safe}}

{{$.locale.Tr "admin.monitor.process.cancel_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/admin/packages/list.tmpl b/templates/admin/packages/list.tmpl index 356cd4d638924..d97b41ffa5727 100644 --- a/templates/admin/packages/list.tmpl +++ b/templates/admin/packages/list.tmpl @@ -88,6 +88,6 @@
{{.locale.Tr "packages.settings.delete.notice" `` `` | Safe}}
- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/admin/queue.tmpl b/templates/admin/queue.tmpl index 949564dcc2fb5..2ace03810cb04 100644 --- a/templates/admin/queue.tmpl +++ b/templates/admin/queue.tmpl @@ -190,7 +190,7 @@

{{$.locale.Tr "admin.monitor.queue.pool.cancel_notices" `` | Safe}}

{{$.locale.Tr "admin.monitor.queue.pool.cancel_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/admin/repo/list.tmpl b/templates/admin/repo/list.tmpl index aa65e48f9161e..7c907e5cfcf16 100644 --- a/templates/admin/repo/list.tmpl +++ b/templates/admin/repo/list.tmpl @@ -105,6 +105,6 @@ {{.locale.Tr "repo.settings.delete_notices_2" `` | Safe}}
{{.locale.Tr "repo.settings.delete_notices_fork_1"}}
- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/admin/stacktrace.tmpl b/templates/admin/stacktrace.tmpl index aa84e02e06abf..8dfe78422a858 100644 --- a/templates/admin/stacktrace.tmpl +++ b/templates/admin/stacktrace.tmpl @@ -27,7 +27,7 @@

{{$.locale.Tr "admin.monitor.process.cancel_notices" `` | Safe}}

{{$.locale.Tr "admin.monitor.process.cancel_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/admin/user/edit.tmpl b/templates/admin/user/edit.tmpl index 4606be39625df..17a64359d9c02 100644 --- a/templates/admin/user/edit.tmpl +++ b/templates/admin/user/edit.tmpl @@ -213,7 +213,7 @@

{{.locale.Tr "admin.users.purge_help"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/base/page_dimmer_buttons.tmpl b/templates/base/basic_modal_actions.tmpl similarity index 100% rename from templates/base/page_dimmer_buttons.tmpl rename to templates/base/basic_modal_actions.tmpl diff --git a/templates/org/member/members.tmpl b/templates/org/member/members.tmpl index 505cffd32a802..d83b742f9f4bf 100644 --- a/templates/org/member/members.tmpl +++ b/templates/org/member/members.tmpl @@ -89,7 +89,7 @@

{{$.locale.Tr "org.members.leave.detail" `` | Safe}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/org/team/members.tmpl b/templates/org/team/members.tmpl index 81562c39edb08..c59cce11be4fd 100644 --- a/templates/org/team/members.tmpl +++ b/templates/org/team/members.tmpl @@ -72,6 +72,6 @@

{{$.locale.Tr "org.members.remove.detail" `` `` | Safe}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/org/team/new.tmpl b/templates/org/team/new.tmpl index 8746bccce2bbd..48ec1f4586e05 100644 --- a/templates/org/team/new.tmpl +++ b/templates/org/team/new.tmpl @@ -156,6 +156,6 @@

{{.locale.Tr "org.teams.delete_team_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/org/team/repositories.tmpl b/templates/org/team/repositories.tmpl index 8d1e129016555..0d7da480ddae2 100644 --- a/templates/org/team/repositories.tmpl +++ b/templates/org/team/repositories.tmpl @@ -72,7 +72,7 @@

{{.locale.Tr "org.teams.remove_all_repos_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/org/team/sidebar.tmpl b/templates/org/team/sidebar.tmpl index 9e0239fc83a52..1c98315697da5 100644 --- a/templates/org/team/sidebar.tmpl +++ b/templates/org/team/sidebar.tmpl @@ -91,5 +91,5 @@

{{$.locale.Tr "org.teams.leave.detail" `` | Safe}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} diff --git a/templates/org/team/teams.tmpl b/templates/org/team/teams.tmpl index 627b27eb91364..2f9d447b1c43b 100644 --- a/templates/org/team/teams.tmpl +++ b/templates/org/team/teams.tmpl @@ -51,6 +51,6 @@

{{$.locale.Tr "org.teams.leave.detail" `` | Safe}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/package/settings.tmpl b/templates/package/settings.tmpl index a1b2b2172c99f..69d4306978e00 100644 --- a/templates/package/settings.tmpl +++ b/templates/package/settings.tmpl @@ -57,7 +57,7 @@
{{.CsrfTokenHtml}} - {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}}
diff --git a/templates/projects/list.tmpl b/templates/projects/list.tmpl index 2777e3260eaeb..2ddf7477e857e 100644 --- a/templates/projects/list.tmpl +++ b/templates/projects/list.tmpl @@ -84,6 +84,6 @@

{{.locale.Tr "repo.projects.deletion_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{end}} diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index c4d72e0cf3365..c1251df29e25e 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -113,7 +113,7 @@ {{$.locale.Tr "repo.projects.column.unset_default"}} {{end}} - @@ -162,7 +162,7 @@ {{- if .Default -}} {{- $ModalYesText = $.locale.Tr "repo.projects.column.unset_default" -}} {{- end -}} - {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} + {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}} - {{template "base/page_dimmer_buttons" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} + {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} @@ -286,6 +286,6 @@

{{.locale.Tr "repo.projects.deletion_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{end}} diff --git a/templates/repo/branch/list.tmpl b/templates/repo/branch/list.tmpl index 9a46e2cfe5f5d..5cea38e7b6bd7 100644 --- a/templates/repo/branch/list.tmpl +++ b/templates/repo/branch/list.tmpl @@ -155,7 +155,7 @@

{{.locale.Tr "repo.branch.delete_desc" | Str2html}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{end}} {{template "base/footer" .}} diff --git a/templates/repo/issue/view_content.tmpl b/templates/repo/issue/view_content.tmpl index 7c68e68886f20..5df7f50c116a1 100644 --- a/templates/repo/issue/view_content.tmpl +++ b/templates/repo/issue/view_content.tmpl @@ -205,5 +205,5 @@

{{.locale.Tr "repo.branch.delete_desc" | Str2html}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} diff --git a/templates/repo/issue/view_content/comments_delete_time.tmpl b/templates/repo/issue/view_content/comments_delete_time.tmpl index cf3f5c0c8a87f..42f142725b21e 100644 --- a/templates/repo/issue/view_content/comments_delete_time.tmpl +++ b/templates/repo/issue/view_content/comments_delete_time.tmpl @@ -7,7 +7,7 @@ {{.ctxData.CsrfTokenHtml}}
{{.ctxData.locale.Tr "repo.issues.del_time"}}
- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}}
diff --git a/templates/repo/settings/options.tmpl b/templates/repo/settings/options.tmpl index 908ef2be361fe..32d5fe17f9375 100644 --- a/templates/repo/settings/options.tmpl +++ b/templates/repo/settings/options.tmpl @@ -988,7 +988,7 @@ {{.CsrfTokenHtml}} - {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{end}} diff --git a/templates/repo/settings/webhook/delete_modal.tmpl b/templates/repo/settings/webhook/delete_modal.tmpl index c5d05ced478d2..622d24a46ca90 100644 --- a/templates/repo/settings/webhook/delete_modal.tmpl +++ b/templates/repo/settings/webhook/delete_modal.tmpl @@ -6,5 +6,5 @@

{{.locale.Tr "repo.settings.webhook_deletion_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} diff --git a/templates/repo/wiki/view.tmpl b/templates/repo/wiki/view.tmpl index 4ba6b74445a0c..0e770ee28e6af 100644 --- a/templates/repo/wiki/view.tmpl +++ b/templates/repo/wiki/view.tmpl @@ -107,7 +107,7 @@

{{.locale.Tr "repo.wiki.delete_page_notice_1" ($title|Escape) | Safe}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/shared/actions/runner_edit.tmpl b/templates/shared/actions/runner_edit.tmpl index 9b66402438085..4733d2d7b2f5d 100644 --- a/templates/shared/actions/runner_edit.tmpl +++ b/templates/shared/actions/runner_edit.tmpl @@ -97,6 +97,6 @@

{{.locale.Tr "actions.runners.delete_runner_notice" | Safe}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} diff --git a/templates/shared/secrets/add_list.tmpl b/templates/shared/secrets/add_list.tmpl index da4a0774a98a8..8820686aa93a2 100644 --- a/templates/shared/secrets/add_list.tmpl +++ b/templates/shared/secrets/add_list.tmpl @@ -64,5 +64,5 @@

{{.locale.Tr "secrets.deletion.description"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} diff --git a/templates/user/settings/account.tmpl b/templates/user/settings/account.tmpl index a16c6afbffacb..5c6e35c7140b3 100644 --- a/templates/user/settings/account.tmpl +++ b/templates/user/settings/account.tmpl @@ -169,7 +169,7 @@

{{.locale.Tr "settings.email_deletion_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/user/settings/applications.tmpl b/templates/user/settings/applications.tmpl index 21182d09635bd..5724bb1fd8473 100644 --- a/templates/user/settings/applications.tmpl +++ b/templates/user/settings/applications.tmpl @@ -277,7 +277,7 @@

{{.locale.Tr "settings.access_token_deletion_desc"}}

-
{{/* TODO: Convert to base/page_dimmer_buttons.tmpl */}} +
{{/* TODO: Convert to base/basic_modal_actions.tmpl */}}
diff --git a/templates/user/settings/grants_oauth2.tmpl b/templates/user/settings/grants_oauth2.tmpl index 83cfa75883001..a9635543c1542 100644 --- a/templates/user/settings/grants_oauth2.tmpl +++ b/templates/user/settings/grants_oauth2.tmpl @@ -36,5 +36,5 @@

{{.locale.Tr "settings.revoke_oauth2_grant_description"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}}
diff --git a/templates/user/settings/keys_gpg.tmpl b/templates/user/settings/keys_gpg.tmpl index bd201149a41b5..86113c4e9085f 100644 --- a/templates/user/settings/keys_gpg.tmpl +++ b/templates/user/settings/keys_gpg.tmpl @@ -119,5 +119,5 @@

{{.locale.Tr "settings.gpg_key_deletion_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} diff --git a/templates/user/settings/keys_principal.tmpl b/templates/user/settings/keys_principal.tmpl index cc354afba499d..71c51037adc53 100644 --- a/templates/user/settings/keys_principal.tmpl +++ b/templates/user/settings/keys_principal.tmpl @@ -62,6 +62,6 @@

{{.locale.Tr "settings.ssh_principal_deletion_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{end}} diff --git a/templates/user/settings/keys_ssh.tmpl b/templates/user/settings/keys_ssh.tmpl index 69bde0ca65da2..e1412e01e96d3 100644 --- a/templates/user/settings/keys_ssh.tmpl +++ b/templates/user/settings/keys_ssh.tmpl @@ -108,5 +108,5 @@

{{.locale.Tr "settings.ssh_key_deletion_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} diff --git a/templates/user/settings/organization.tmpl b/templates/user/settings/organization.tmpl index 5db6f632a753e..44d20995af64f 100644 --- a/templates/user/settings/organization.tmpl +++ b/templates/user/settings/organization.tmpl @@ -48,6 +48,6 @@

{{$.locale.Tr "org.members.leave.detail" `` | Safe}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/user/settings/repos.tmpl b/templates/user/settings/repos.tmpl index e1c537c320091..5e1bbcb5c7141 100644 --- a/templates/user/settings/repos.tmpl +++ b/templates/user/settings/repos.tmpl @@ -77,7 +77,7 @@ {{$.CsrfTokenHtml}} - {{template "base/page_dimmer_buttons" $}} + {{template "base/basic_modal_actions" $}} {{end}} @@ -139,6 +139,6 @@

{{.locale.Tr "settings.remove_account_link_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} {{template "base/footer" .}} diff --git a/templates/user/settings/security/accountlinks.tmpl b/templates/user/settings/security/accountlinks.tmpl index aa8332f6d8054..5bb1a857969d6 100644 --- a/templates/user/settings/security/accountlinks.tmpl +++ b/templates/user/settings/security/accountlinks.tmpl @@ -49,5 +49,5 @@

{{.locale.Tr "settings.remove_account_link_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} diff --git a/templates/user/settings/security/openid.tmpl b/templates/user/settings/security/openid.tmpl index 3fd49300fc7cd..04356adf9965d 100644 --- a/templates/user/settings/security/openid.tmpl +++ b/templates/user/settings/security/openid.tmpl @@ -59,5 +59,5 @@

{{.locale.Tr "settings.openid_deletion_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} diff --git a/templates/user/settings/security/twofa.tmpl b/templates/user/settings/security/twofa.tmpl index c4a4e8fbed417..d4e1ef91e8647 100644 --- a/templates/user/settings/security/twofa.tmpl +++ b/templates/user/settings/security/twofa.tmpl @@ -31,5 +31,5 @@

{{.locale.Tr "settings.twofa_disable_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} diff --git a/templates/user/settings/security/webauthn.tmpl b/templates/user/settings/security/webauthn.tmpl index 3c5677aca0e01..7d52c2bad67b1 100644 --- a/templates/user/settings/security/webauthn.tmpl +++ b/templates/user/settings/security/webauthn.tmpl @@ -38,5 +38,5 @@

{{.locale.Tr "settings.webauthn_delete_key_desc"}}

- {{template "base/page_dimmer_buttons" .}} + {{template "base/basic_modal_actions" .}} From 159e22880c2accd452a3198f3db72159ebece0c4 Mon Sep 17 00:00:00 2001 From: HesterG Date: Fri, 21 Apr 2023 09:05:44 +0800 Subject: [PATCH 13/26] use template for delete pr --- templates/repo/issue/view_content/sidebar.tmpl | 5 +---- web_src/css/base.css | 4 ++++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/templates/repo/issue/view_content/sidebar.tmpl b/templates/repo/issue/view_content/sidebar.tmpl index 290488d9fbb94..eebdf42542361 100644 --- a/templates/repo/issue/view_content/sidebar.tmpl +++ b/templates/repo/issue/view_content/sidebar.tmpl @@ -682,10 +682,7 @@
{{.CsrfTokenHtml}} -
- - -
+ {{template "base/basic_modal_actions" .}}
{{end}} diff --git a/web_src/css/base.css b/web_src/css/base.css index 79e1566b64998..e596e3ff41f61 100644 --- a/web_src/css/base.css +++ b/web_src/css/base.css @@ -1166,6 +1166,10 @@ a.ui.card:hover { color: var(--color-text); } +.ui.modal > form > .actions { + text-align: right; +} + .ui.basic.table > tbody > tr { border-color: var(--color-secondary); } From 6ea509ed7d5aedccf4486c4a301b259f99c62e3f Mon Sep 17 00:00:00 2001 From: HesterG Date: Fri, 21 Apr 2023 09:39:08 +0800 Subject: [PATCH 14/26] change to template and add TODOs --- templates/admin/repo/unadopted.tmpl | 4 ++-- templates/repo/issue/view_content/sidebar.tmpl | 13 +++---------- templates/user/settings/repos.tmpl | 2 +- 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/templates/admin/repo/unadopted.tmpl b/templates/admin/repo/unadopted.tmpl index a8e04850d0dd3..357ca9b042e1b 100644 --- a/templates/admin/repo/unadopted.tmpl +++ b/templates/admin/repo/unadopted.tmpl @@ -43,7 +43,7 @@ -
+
{{/* TODO: Convert to base/basic_modal_actions */}}
-
- - -
+ {{$ModalNoText := .locale.Tr "repo.issues.dependency.cancel"}} + {{$ModalYesText := .locale.Tr "repo.issues.dependency.remove"}} + {{template "base/basic_modal_actions" (dict "." . "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}}
{{end}} {{end}} diff --git a/templates/user/settings/repos.tmpl b/templates/user/settings/repos.tmpl index 545671dae5512..9e11786d45c50 100644 --- a/templates/user/settings/repos.tmpl +++ b/templates/user/settings/repos.tmpl @@ -50,7 +50,7 @@ {{$.CsrfTokenHtml}} -
+
{{/* TODO: Convert to base/basic_modal_actions */}}
{{template "base/footer" .}} diff --git a/templates/admin/emails/list.tmpl b/templates/admin/emails/list.tmpl index 37da00d5e8d42..b71acb28d7ad8 100644 --- a/templates/admin/emails/list.tmpl +++ b/templates/admin/emails/list.tmpl @@ -94,7 +94,7 @@
- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}}
diff --git a/templates/admin/monitor.tmpl b/templates/admin/monitor.tmpl index c4257a8527c06..31929764a5899 100644 --- a/templates/admin/monitor.tmpl +++ b/templates/admin/monitor.tmpl @@ -46,6 +46,6 @@

{{$.locale.Tr "admin.monitor.process.cancel_notices" `` | Safe}}

{{$.locale.Tr "admin.monitor.process.cancel_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/admin/packages/list.tmpl b/templates/admin/packages/list.tmpl index d97b41ffa5727..17b4d0afe9e1f 100644 --- a/templates/admin/packages/list.tmpl +++ b/templates/admin/packages/list.tmpl @@ -88,6 +88,6 @@
{{.locale.Tr "packages.settings.delete.notice" `` `` | Safe}}
- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/admin/queue.tmpl b/templates/admin/queue.tmpl index 2ace03810cb04..e6f908aefcbe5 100644 --- a/templates/admin/queue.tmpl +++ b/templates/admin/queue.tmpl @@ -190,7 +190,7 @@

{{$.locale.Tr "admin.monitor.queue.pool.cancel_notices" `` | Safe}}

{{$.locale.Tr "admin.monitor.queue.pool.cancel_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/admin/repo/list.tmpl b/templates/admin/repo/list.tmpl index 7c907e5cfcf16..5daf50fc5edb5 100644 --- a/templates/admin/repo/list.tmpl +++ b/templates/admin/repo/list.tmpl @@ -105,6 +105,6 @@ {{.locale.Tr "repo.settings.delete_notices_2" `` | Safe}}
{{.locale.Tr "repo.settings.delete_notices_fork_1"}}
- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/admin/repo/unadopted.tmpl b/templates/admin/repo/unadopted.tmpl index 357ca9b042e1b..fc3a632f02032 100644 --- a/templates/admin/repo/unadopted.tmpl +++ b/templates/admin/repo/unadopted.tmpl @@ -43,7 +43,7 @@ -
{{/* TODO: Convert to base/basic_modal_actions */}} +
{{/* TODO: Convert to base/modal_actions_confirm */}}
- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}} diff --git a/templates/admin/user/edit.tmpl b/templates/admin/user/edit.tmpl index 17a64359d9c02..63ac2e0b042da 100644 --- a/templates/admin/user/edit.tmpl +++ b/templates/admin/user/edit.tmpl @@ -213,7 +213,7 @@

{{.locale.Tr "admin.users.purge_help"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/base/basic_modal_actions.tmpl b/templates/base/basic_modal_actions.tmpl deleted file mode 100644 index 79229b62688ab..0000000000000 --- a/templates/base/basic_modal_actions.tmpl +++ /dev/null @@ -1,10 +0,0 @@ -
- - -
diff --git a/templates/base/modal_actions_confirm.tmpl b/templates/base/modal_actions_confirm.tmpl new file mode 100644 index 0000000000000..70d3f0af0e65a --- /dev/null +++ b/templates/base/modal_actions_confirm.tmpl @@ -0,0 +1,17 @@ +{{/* +Template Attributes: +* ModalButtonCancelText +* ModalButtonOkText + +The ".ok.button" and ".cancel.button" selectors are also used by Fomantic Modal internally +*/}} +
+ + +
diff --git a/templates/org/member/members.tmpl b/templates/org/member/members.tmpl index d83b742f9f4bf..e273e0d2b37c8 100644 --- a/templates/org/member/members.tmpl +++ b/templates/org/member/members.tmpl @@ -89,7 +89,7 @@

{{$.locale.Tr "org.members.leave.detail" `` | Safe}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/org/team/members.tmpl b/templates/org/team/members.tmpl index c59cce11be4fd..efe32d09ad8a9 100644 --- a/templates/org/team/members.tmpl +++ b/templates/org/team/members.tmpl @@ -72,6 +72,6 @@

{{$.locale.Tr "org.members.remove.detail" `` `` | Safe}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/org/team/new.tmpl b/templates/org/team/new.tmpl index 48ec1f4586e05..99530b1be61d1 100644 --- a/templates/org/team/new.tmpl +++ b/templates/org/team/new.tmpl @@ -156,6 +156,6 @@

{{.locale.Tr "org.teams.delete_team_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/org/team/repositories.tmpl b/templates/org/team/repositories.tmpl index 0d7da480ddae2..e8d3ea66cf849 100644 --- a/templates/org/team/repositories.tmpl +++ b/templates/org/team/repositories.tmpl @@ -72,7 +72,7 @@

{{.locale.Tr "org.teams.remove_all_repos_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/org/team/sidebar.tmpl b/templates/org/team/sidebar.tmpl index 1c98315697da5..311601ac595ea 100644 --- a/templates/org/team/sidebar.tmpl +++ b/templates/org/team/sidebar.tmpl @@ -91,5 +91,5 @@

{{$.locale.Tr "org.teams.leave.detail" `` | Safe}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/templates/org/team/teams.tmpl b/templates/org/team/teams.tmpl index 2f9d447b1c43b..56e5ed315d262 100644 --- a/templates/org/team/teams.tmpl +++ b/templates/org/team/teams.tmpl @@ -51,6 +51,6 @@

{{$.locale.Tr "org.teams.leave.detail" `` | Safe}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/package/settings.tmpl b/templates/package/settings.tmpl index 69d4306978e00..a443a8d27f483 100644 --- a/templates/package/settings.tmpl +++ b/templates/package/settings.tmpl @@ -57,7 +57,7 @@
{{.CsrfTokenHtml}} - {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}}
diff --git a/templates/projects/list.tmpl b/templates/projects/list.tmpl index 2ddf7477e857e..34460ebe574ac 100644 --- a/templates/projects/list.tmpl +++ b/templates/projects/list.tmpl @@ -84,6 +84,6 @@

{{.locale.Tr "repo.projects.deletion_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{end}} diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index c1251df29e25e..a9297bf07c10f 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -157,12 +157,12 @@
- {{$ModalNoText := $.locale.Tr "settings.cancel"}} - {{- $ModalYesText := $.locale.Tr "repo.projects.column.set_default" -}} + {{$ModalButtonCancelText := $.locale.Tr "settings.cancel"}} + {{- $ModalButtonOkText := $.locale.Tr "repo.projects.column.set_default" -}} {{- if .Default -}} - {{- $ModalYesText = $.locale.Tr "repo.projects.column.unset_default" -}} + {{- $ModalButtonOkText = $.locale.Tr "repo.projects.column.unset_default" -}} {{- end -}} - {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} + {{template "base/modal_actions_confirm" (dict "." $ "ModalButtonCancelText" $ModalButtonCancelText "ModalButtonOkText" $ModalButtonOkText)}} - {{$ModalYesText := $.locale.Tr "repo.projects.column.delete"}} - {{template "base/basic_modal_actions" (dict "." $ "ModalNoText" $ModalNoText "ModalYesText" $ModalYesText)}} + {{$ModalButtonOkText := $.locale.Tr "repo.projects.column.delete"}} + {{template "base/modal_actions_confirm" (dict "." $ "ModalButtonCancelText" $ModalButtonCancelText "ModalButtonOkText" $ModalButtonOkText)}} @@ -286,6 +286,6 @@

{{.locale.Tr "repo.projects.deletion_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{end}} diff --git a/templates/repo/branch/list.tmpl b/templates/repo/branch/list.tmpl index 5cea38e7b6bd7..6b8d87d3b2739 100644 --- a/templates/repo/branch/list.tmpl +++ b/templates/repo/branch/list.tmpl @@ -155,7 +155,7 @@

{{.locale.Tr "repo.branch.delete_desc" | Str2html}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{end}} {{template "base/footer" .}} diff --git a/templates/repo/issue/view_content.tmpl b/templates/repo/issue/view_content.tmpl index 5df7f50c116a1..4dab4faf2e704 100644 --- a/templates/repo/issue/view_content.tmpl +++ b/templates/repo/issue/view_content.tmpl @@ -205,5 +205,5 @@

{{.locale.Tr "repo.branch.delete_desc" | Str2html}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/templates/repo/issue/view_content/comments_delete_time.tmpl b/templates/repo/issue/view_content/comments_delete_time.tmpl index 42f142725b21e..d86cc52d3a183 100644 --- a/templates/repo/issue/view_content/comments_delete_time.tmpl +++ b/templates/repo/issue/view_content/comments_delete_time.tmpl @@ -7,7 +7,7 @@ {{.ctxData.CsrfTokenHtml}}
{{.ctxData.locale.Tr "repo.issues.del_time"}}
- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/templates/repo/settings/options.tmpl b/templates/repo/settings/options.tmpl index 33ccbbb23da0a..41804ce3b7d05 100644 --- a/templates/repo/settings/options.tmpl +++ b/templates/repo/settings/options.tmpl @@ -988,7 +988,7 @@ {{.CsrfTokenHtml}} - {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{end}} diff --git a/templates/repo/settings/webhook/delete_modal.tmpl b/templates/repo/settings/webhook/delete_modal.tmpl index 622d24a46ca90..6dc13c68addaa 100644 --- a/templates/repo/settings/webhook/delete_modal.tmpl +++ b/templates/repo/settings/webhook/delete_modal.tmpl @@ -6,5 +6,5 @@

{{.locale.Tr "repo.settings.webhook_deletion_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/templates/repo/wiki/view.tmpl b/templates/repo/wiki/view.tmpl index 0e770ee28e6af..549be33856325 100644 --- a/templates/repo/wiki/view.tmpl +++ b/templates/repo/wiki/view.tmpl @@ -107,7 +107,7 @@

{{.locale.Tr "repo.wiki.delete_page_notice_1" ($title|Escape) | Safe}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/shared/actions/runner_edit.tmpl b/templates/shared/actions/runner_edit.tmpl index 4733d2d7b2f5d..e68fd1bbc3124 100644 --- a/templates/shared/actions/runner_edit.tmpl +++ b/templates/shared/actions/runner_edit.tmpl @@ -97,6 +97,6 @@

{{.locale.Tr "actions.runners.delete_runner_notice" | Safe}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/templates/shared/secrets/add_list.tmpl b/templates/shared/secrets/add_list.tmpl index 8820686aa93a2..bbac728fa4c8b 100644 --- a/templates/shared/secrets/add_list.tmpl +++ b/templates/shared/secrets/add_list.tmpl @@ -64,5 +64,5 @@

{{.locale.Tr "secrets.deletion.description"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/templates/user/settings/account.tmpl b/templates/user/settings/account.tmpl index 5c6e35c7140b3..b94006b86e4a0 100644 --- a/templates/user/settings/account.tmpl +++ b/templates/user/settings/account.tmpl @@ -169,7 +169,7 @@

{{.locale.Tr "settings.email_deletion_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/user/settings/applications.tmpl b/templates/user/settings/applications.tmpl index 5724bb1fd8473..ce095d2474d4e 100644 --- a/templates/user/settings/applications.tmpl +++ b/templates/user/settings/applications.tmpl @@ -277,7 +277,7 @@

{{.locale.Tr "settings.access_token_deletion_desc"}}

-
{{/* TODO: Convert to base/basic_modal_actions.tmpl */}} +
{{/* TODO: Convert to base/modal_actions_confirm.tmpl */}}
diff --git a/templates/user/settings/grants_oauth2.tmpl b/templates/user/settings/grants_oauth2.tmpl index a9635543c1542..7b37cd6fa835a 100644 --- a/templates/user/settings/grants_oauth2.tmpl +++ b/templates/user/settings/grants_oauth2.tmpl @@ -36,5 +36,5 @@

{{.locale.Tr "settings.revoke_oauth2_grant_description"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}}
diff --git a/templates/user/settings/keys_gpg.tmpl b/templates/user/settings/keys_gpg.tmpl index 86113c4e9085f..a93e193eae541 100644 --- a/templates/user/settings/keys_gpg.tmpl +++ b/templates/user/settings/keys_gpg.tmpl @@ -119,5 +119,5 @@

{{.locale.Tr "settings.gpg_key_deletion_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/templates/user/settings/keys_principal.tmpl b/templates/user/settings/keys_principal.tmpl index 71c51037adc53..7ee56f54d2944 100644 --- a/templates/user/settings/keys_principal.tmpl +++ b/templates/user/settings/keys_principal.tmpl @@ -62,6 +62,6 @@

{{.locale.Tr "settings.ssh_principal_deletion_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{end}} diff --git a/templates/user/settings/keys_ssh.tmpl b/templates/user/settings/keys_ssh.tmpl index e1412e01e96d3..257c7e28178d2 100644 --- a/templates/user/settings/keys_ssh.tmpl +++ b/templates/user/settings/keys_ssh.tmpl @@ -108,5 +108,5 @@

{{.locale.Tr "settings.ssh_key_deletion_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/templates/user/settings/organization.tmpl b/templates/user/settings/organization.tmpl index 44d20995af64f..9f2392aaa7cf8 100644 --- a/templates/user/settings/organization.tmpl +++ b/templates/user/settings/organization.tmpl @@ -48,6 +48,6 @@

{{$.locale.Tr "org.members.leave.detail" `` | Safe}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} {{template "base/footer" .}} diff --git a/templates/user/settings/repos.tmpl b/templates/user/settings/repos.tmpl index 9e11786d45c50..4838b954112b6 100644 --- a/templates/user/settings/repos.tmpl +++ b/templates/user/settings/repos.tmpl @@ -50,7 +50,7 @@ {{$.CsrfTokenHtml}} -
{{/* TODO: Convert to base/basic_modal_actions */}} +
{{/* TODO: Convert to base/modal_actions_confirm */}}
{{end}} @@ -139,6 +139,6 @@

{{.locale.Tr "settings.remove_account_link_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}}
{{template "base/footer" .}} diff --git a/templates/user/settings/security/accountlinks.tmpl b/templates/user/settings/security/accountlinks.tmpl index 5bb1a857969d6..0ccb57ca81742 100644 --- a/templates/user/settings/security/accountlinks.tmpl +++ b/templates/user/settings/security/accountlinks.tmpl @@ -49,5 +49,5 @@

{{.locale.Tr "settings.remove_account_link_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/templates/user/settings/security/openid.tmpl b/templates/user/settings/security/openid.tmpl index 04356adf9965d..18dba417abce5 100644 --- a/templates/user/settings/security/openid.tmpl +++ b/templates/user/settings/security/openid.tmpl @@ -59,5 +59,5 @@

{{.locale.Tr "settings.openid_deletion_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/templates/user/settings/security/twofa.tmpl b/templates/user/settings/security/twofa.tmpl index d4e1ef91e8647..ffc6de452ec1c 100644 --- a/templates/user/settings/security/twofa.tmpl +++ b/templates/user/settings/security/twofa.tmpl @@ -31,5 +31,5 @@

{{.locale.Tr "settings.twofa_disable_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/templates/user/settings/security/webauthn.tmpl b/templates/user/settings/security/webauthn.tmpl index 7d52c2bad67b1..268b2e5cecd55 100644 --- a/templates/user/settings/security/webauthn.tmpl +++ b/templates/user/settings/security/webauthn.tmpl @@ -38,5 +38,5 @@

{{.locale.Tr "settings.webauthn_delete_key_desc"}}

- {{template "base/basic_modal_actions" .}} + {{template "base/modal_actions_confirm" .}} diff --git a/web_src/js/features/repo-projects.js b/web_src/js/features/repo-projects.js index 838183e0f6e57..5d4009622057a 100644 --- a/web_src/js/features/repo-projects.js +++ b/web_src/js/features/repo-projects.js @@ -129,7 +129,7 @@ export function initRepoProject() { $('.default-project-board-modal').each(function () { const boardColumn = $(this).closest('.board-column'); const showButton = $(boardColumn).find('.default-project-board-show'); - const commitButton = $(this).find('.modal-confirm-button'); + const commitButton = $(this).find('.actions > .ok.button'); $(commitButton).on('click', (e) => { e.preventDefault(); @@ -149,7 +149,7 @@ export function initRepoProject() { $('.show-delete-column-modal').each(function () { const deleteColumnModal = $(`${$(this).attr('data-modal')}`); - const deleteColumnButton = deleteColumnModal.find('.modal-confirm-button'); + const deleteColumnButton = deleteColumnModal.find('.actions > .ok.button'); const deleteUrl = $(this).attr('data-url'); deleteColumnButton.on('click', (e) => { From bb7fcf74226b4dc9bbdd74ef7d8bf729948b1f7b Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Sun, 23 Apr 2023 12:25:02 +0800 Subject: [PATCH 19/26] temp --- options/locale/locale_en-US.ini | 2 ++ templates/base/modal_actions_confirm.tmpl | 20 +++++++++------ templates/projects/view.tmpl | 10 ++------ templates/repo/projects/view.tmpl | 10 ++------ web_src/css/base.css | 31 ----------------------- web_src/css/index.css | 1 + web_src/css/modules/modal.css | 28 ++++++++++++++++++++ 7 files changed, 47 insertions(+), 55 deletions(-) create mode 100644 web_src/css/modules/modal.css diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index c0e94d3b87903..b4233d65d1ad8 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -462,6 +462,8 @@ team_invite.text_3 = Note: This invitation was intended for %[1]s. If you were n [modal] yes = Yes no = No +confirm = Confirm +cancel = Cancel modify = Update [form] diff --git a/templates/base/modal_actions_confirm.tmpl b/templates/base/modal_actions_confirm.tmpl index 70d3f0af0e65a..361f214466fd8 100644 --- a/templates/base/modal_actions_confirm.tmpl +++ b/templates/base/modal_actions_confirm.tmpl @@ -1,17 +1,21 @@ {{/* Template Attributes: +* locale +* ModalButtonStyle: "yes" (default) or "confirm" * ModalButtonCancelText * ModalButtonOkText The ".ok.button" and ".cancel.button" selectors are also used by Fomantic Modal internally */}}
- - + {{$textNegitive := .locale.Tr "modal.no"}} + {{$textPositive := .locale.Tr "modal.yes"}} + {{if eq .ModalButtonStyle "confirm"}} + {{$textNegitive = .locale.Tr "modal.cancel"}} + {{$textPositive = .locale.Tr "modal.confirm"}} + {{end}} + {{if .ModalButtonCancelText}}{{$textNegitive = .ModalButtonCancelText}}{{end}} + {{if .ModalButtonOkText}}{{$textPositive = .ModalButtonOkText}}{{end}} + +
diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index a9297bf07c10f..777cc0d043da1 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -157,12 +157,7 @@
- {{$ModalButtonCancelText := $.locale.Tr "settings.cancel"}} - {{- $ModalButtonOkText := $.locale.Tr "repo.projects.column.set_default" -}} - {{- if .Default -}} - {{- $ModalButtonOkText = $.locale.Tr "repo.projects.column.unset_default" -}} - {{- end -}} - {{template "base/modal_actions_confirm" (dict "." $ "ModalButtonCancelText" $ModalButtonCancelText "ModalButtonOkText" $ModalButtonOkText)}} + {{template "base/modal_actions_confirm" (dict "locale" $.locale "ModalButtonStyle" "confirm")}} - {{$ModalButtonOkText := $.locale.Tr "repo.projects.column.delete"}} - {{template "base/modal_actions_confirm" (dict "." $ "ModalButtonCancelText" $ModalButtonCancelText "ModalButtonOkText" $ModalButtonOkText)}} + {{template "base/modal_actions_confirm" (dict "locale" $.locale "ModalButtonStyle" "confirm")}} diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index c9b657c862d16..e4f8a52971e41 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -163,12 +163,7 @@
- {{$ModalButtonCancelText := $.locale.Tr "settings.cancel"}} - {{- $ModalButtonOkText := $.locale.Tr "repo.projects.column.set_default" -}} - {{- if .Default -}} - {{- $ModalButtonOkText = $.locale.Tr "repo.projects.column.unset_default" -}} - {{- end -}} - {{template "base/modal_actions_confirm" (dict "." $ "ModalButtonCancelText" $ModalButtonCancelText "ModalButtonOkText" $ModalButtonOkText)}} + {{template "base/modal_actions_confirm" (dict "locale" $.locale "ModalButtonStyle" "confirm")}} - {{$ModalButtonOkText := $.locale.Tr "repo.projects.column.delete"}} - {{template "base/modal_actions_confirm" (dict "." $ "ModalButtonCancelText" $ModalButtonCancelText "ModalButtonOkText" $ModalButtonOkText)}} + {{template "base/modal_actions_confirm" (dict "locale" $.locale "ModalButtonStyle" "confirm")}} diff --git a/web_src/css/base.css b/web_src/css/base.css index a55a8f244a7e0..42263a974ff5a 100644 --- a/web_src/css/base.css +++ b/web_src/css/base.css @@ -1140,37 +1140,6 @@ a.ui.card:hover { color: var(--color-text); } -.ui.modal { - background: var(--color-body); -} - -.ui.modal > .header { - color: var(--color-text-dark); - background: var(--color-secondary-bg); - border-color: var(--color-secondary); - border-top-left-radius: var(--border-radius); - border-top-right-radius: var(--border-radius); -} - -.ui.modal > .content { - background: var(--color-body); - text-align: left !important; -} - -.ui.modal > .actions { - background: var(--color-secondary-bg); - border-color: var(--color-secondary); - text-align: center; -} - -.ui.modal > .close.inside { - color: var(--color-text); -} - -.ui.modal > form > .actions { - text-align: center; -} - .ui.basic.table > tbody > tr { border-color: var(--color-secondary); } diff --git a/web_src/css/index.css b/web_src/css/index.css index 253083033862c..828251180446c 100644 --- a/web_src/css/index.css +++ b/web_src/css/index.css @@ -10,6 +10,7 @@ @import "./features/codeeditor.css"; @import "./features/projects.css"; @import "./modules/tippy.css"; +@import "./modules/modal.css"; @import "./code/linebutton.css"; @import "./markup/content.css"; @import "./markup/codecopy.css"; diff --git a/web_src/css/modules/modal.css b/web_src/css/modules/modal.css new file mode 100644 index 0000000000000..db2c949362415 --- /dev/null +++ b/web_src/css/modules/modal.css @@ -0,0 +1,28 @@ +.ui.modal { + background: var(--color-body); +} + +.ui.modal > .header { + color: var(--color-text-dark); + background: var(--color-secondary-bg); + border-color: var(--color-secondary); + border-top-left-radius: var(--border-radius); + border-top-right-radius: var(--border-radius); +} + +.ui.modal > .content { + background: var(--color-body); +} + +.ui.modal > .actions { + background: var(--color-secondary-bg); + border-color: var(--color-secondary); +} + +.ui.modal > .close.inside { + color: var(--color-text); +} + +.ui.modal > form > .actions { + text-align: center; +} From 246879b5a5d17eee96b958888cf52ea7d926f8f0 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Sun, 23 Apr 2023 12:31:16 +0800 Subject: [PATCH 20/26] replace basic modal => gitea-custom modal --- templates/admin/auth/edit.tmpl | 2 +- templates/admin/emails/list.tmpl | 2 +- templates/admin/monitor.tmpl | 2 +- templates/admin/packages/list.tmpl | 2 +- templates/admin/queue.tmpl | 2 +- templates/admin/repo/list.tmpl | 2 +- templates/admin/repo/unadopted.tmpl | 4 ++-- templates/admin/stacktrace.tmpl | 2 +- templates/admin/user/edit.tmpl | 2 +- templates/org/member/members.tmpl | 4 ++-- templates/org/settings/delete.tmpl | 2 +- templates/org/team/members.tmpl | 2 +- templates/org/team/new.tmpl | 2 +- templates/org/team/repositories.tmpl | 4 ++-- templates/org/team/sidebar.tmpl | 2 +- templates/org/team/teams.tmpl | 2 +- templates/package/settings.tmpl | 2 +- templates/projects/list.tmpl | 2 +- templates/projects/view.tmpl | 6 +++--- templates/repo/branch/list.tmpl | 6 +++--- templates/repo/commit_page.tmpl | 2 +- templates/repo/editor/edit.tmpl | 2 +- templates/repo/editor/patch.tmpl | 2 +- templates/repo/issue/labels/edit_delete_label.tmpl | 2 +- templates/repo/issue/milestones.tmpl | 2 +- templates/repo/issue/view_content.tmpl | 2 +- templates/repo/issue/view_content/sidebar.tmpl | 4 ++-- templates/repo/migrate/migrating.tmpl | 2 +- templates/repo/projects/list.tmpl | 2 +- templates/repo/projects/view.tmpl | 6 +++--- templates/repo/release/list.tmpl | 2 +- templates/repo/release/new.tmpl | 2 +- templates/repo/settings/branches.tmpl | 2 +- templates/repo/settings/collaboration.tmpl | 2 +- templates/repo/settings/deploy_keys.tmpl | 2 +- templates/repo/settings/lfs.tmpl | 4 ++-- templates/repo/settings/options.tmpl | 14 +++++++------- templates/repo/settings/webhook/delete_modal.tmpl | 2 +- templates/repo/wiki/view.tmpl | 2 +- templates/shared/actions/runner_edit.tmpl | 2 +- templates/shared/secrets/add_list.tmpl | 2 +- templates/user/settings/account.tmpl | 4 ++-- templates/user/settings/applications.tmpl | 2 +- .../user/settings/applications_oauth2_list.tmpl | 2 +- templates/user/settings/grants_oauth2.tmpl | 2 +- templates/user/settings/keys_gpg.tmpl | 2 +- templates/user/settings/keys_principal.tmpl | 2 +- templates/user/settings/keys_ssh.tmpl | 2 +- templates/user/settings/organization.tmpl | 2 +- templates/user/settings/repos.tmpl | 6 +++--- templates/user/settings/security/accountlinks.tmpl | 2 +- templates/user/settings/security/openid.tmpl | 2 +- templates/user/settings/security/twofa.tmpl | 2 +- templates/user/settings/security/webauthn.tmpl | 2 +- web_src/css/modules/modal.css | 4 ---- 55 files changed, 74 insertions(+), 78 deletions(-) diff --git a/templates/admin/auth/edit.tmpl b/templates/admin/auth/edit.tmpl index ec0cb10b56214..980dc10f836ff 100644 --- a/templates/admin/auth/edit.tmpl +++ b/templates/admin/auth/edit.tmpl @@ -440,7 +440,7 @@ -