From 1ae54e687562f771557dcd0b17af5dab5244d2d0 Mon Sep 17 00:00:00 2001 From: Tyrone Yeh Date: Wed, 27 Jul 2022 09:18:14 +0800 Subject: [PATCH 1/2] Modify milestone search keywords to be case insensitive (#20266) Milestone search keywords are now sensitive, this modification is changed to insensitive --- models/issues/milestone.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/issues/milestone.go b/models/issues/milestone.go index fba599e6ece48..c49799f391dc3 100644 --- a/models/issues/milestone.go +++ b/models/issues/milestone.go @@ -361,7 +361,7 @@ func (opts GetMilestonesOption) toCond() builder.Cond { } if len(opts.Name) != 0 { - cond = cond.And(builder.Like{"name", opts.Name}) + cond = cond.And(builder.Like{"UPPER(name)", strings.ToUpper(opts.Name)}) } return cond From 7e5ad0507fd4f95b1f279c58ad612df4958f1b4b Mon Sep 17 00:00:00 2001 From: Tyrone Yeh Date: Wed, 27 Jul 2022 17:23:27 +0800 Subject: [PATCH 2/2] Modify for #18437 --- models/issues/milestone.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/models/issues/milestone.go b/models/issues/milestone.go index c49799f391dc3..4197fb9120baa 100644 --- a/models/issues/milestone.go +++ b/models/issues/milestone.go @@ -15,6 +15,7 @@ import ( "code.gitea.io/gitea/modules/setting" api "code.gitea.io/gitea/modules/structs" "code.gitea.io/gitea/modules/timeutil" + "code.gitea.io/gitea/modules/util" "xorm.io/builder" ) @@ -361,7 +362,11 @@ func (opts GetMilestonesOption) toCond() builder.Cond { } if len(opts.Name) != 0 { - cond = cond.And(builder.Like{"UPPER(name)", strings.ToUpper(opts.Name)}) + if setting.Database.UseSQLite3 { + cond = cond.And(builder.Like{"UPPER(name)", util.ToUpperASCII(opts.Name)}) + } else { + cond = cond.And(builder.Like{"UPPER(name)", strings.ToUpper(opts.Name)}) + } } return cond