From 9e9699bec36cf8bf81128782346681998cbca53d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Jaenisch?= Date: Wed, 8 Jun 2022 22:51:22 +0200 Subject: [PATCH 1/2] Band-aid solution to make edit buttons focusable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These will need more work to get done properly. However, this will require more communication, which might mean that a fix may or may not make it into the next release. To improve the situation at least a little bit, allow for keyboard usage. Signed-off-by: André Jaenisch --- templates/repo/issue/view_title.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/repo/issue/view_title.tmpl b/templates/repo/issue/view_title.tmpl index 22ad58876f434..e2f85de7b521a 100644 --- a/templates/repo/issue/view_title.tmpl +++ b/templates/repo/issue/view_title.tmpl @@ -14,8 +14,8 @@ {{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .Repository.IsArchived)}}
- - + +
{{end}} From 5f999d8d60d52736e204593f222c2c57ccd17bb6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Jaenisch?= Date: Sat, 11 Jun 2022 17:45:33 +0200 Subject: [PATCH 2/2] Properly markup buttons as buttons MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The only downside I observed is that cancel button accepts only space keys. Using return will execute the logic twice for whatever reason and thus yields in no visible change. Signed-off-by: André Jaenisch --- templates/repo/issue/view_title.tmpl | 4 ++-- web_src/less/_base.less | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/templates/repo/issue/view_title.tmpl b/templates/repo/issue/view_title.tmpl index e2f85de7b521a..a5ef81432d482 100644 --- a/templates/repo/issue/view_title.tmpl +++ b/templates/repo/issue/view_title.tmpl @@ -14,8 +14,8 @@ {{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .Repository.IsArchived)}}
- - + +
{{end}} diff --git a/web_src/less/_base.less b/web_src/less/_base.less index 62119fbb99187..2274ede59b5c4 100644 --- a/web_src/less/_base.less +++ b/web_src/less/_base.less @@ -1816,6 +1816,13 @@ a.ui.label:hover { .ui.basic.secondary.buttons .button:active, .ui.basic.secondary.button:active { color: var(--color-secondary-dark-8) !important; + border-color: var(--color-secondary-dark-4) !important; +} + +.ui.basic.secondary.button:focus, +.ui.basic.secondary.buttons .button:focus { + color: var(--color-secondary-dark-8) !important; + border-color: var(--color-secondary-dark-6) !important; } .ui.primary.label,