Skip to content

Replace ARCCache with TwoQueueCache to avoid patent issue #16240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2021
Merged

Replace ARCCache with TwoQueueCache to avoid patent issue #16240

merged 2 commits into from
Jun 24, 2021

Conversation

typeless
Copy link
Contributor

As per @zeripath's suggestion.

@codecov-commenter
Copy link

Codecov Report

Merging #16240 (8bb6362) into main (0393a57) will increase coverage by 1.23%.
The diff coverage is 48.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16240      +/-   ##
==========================================
+ Coverage   44.24%   45.47%   +1.23%     
==========================================
  Files         695      705      +10     
  Lines       82341    83154     +813     
==========================================
+ Hits        36429    37817    +1388     
+ Misses      40014    39271     -743     
- Partials     5898     6066     +168
Impacted Files Coverage Δ
cmd/generate.go 0.00% <0.00%> (ø)
cmd/hook.go 0.00% <0.00%> (ø)
models/action.go 47.12% <ø> (ø)
models/oauth2.go 28.00% <0.00%> (-1.17%) ⬇️
models/repo_archiver.go 0.00% <0.00%> (ø)
models/user.go 52.32% <ø> (-1.07%) ⬇️
modules/context/repo.go 52.99% <0.00%> (-0.30%) ⬇️
modules/generate/generate.go 0.00% <0.00%> (-16.00%) ⬇️
modules/git/error.go 50.00% <0.00%> (-4.24%) ⬇️
modules/git/last_commit_cache_nogogit.go 35.84% <0.00%> (+0.66%) ⬆️
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c5a8f...8bb6362. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 24, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 24, 2021
@techknowlogick techknowlogick added this to the 1.15.0 milestone Jun 24, 2021
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Jun 24, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 24, 2021
@techknowlogick techknowlogick merged commit fd6b1be into go-gitea:main Jun 24, 2021
@typeless typeless deleted the lrc-2q branch June 24, 2021 23:36
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 27, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@typeless @techknowlogick @AbdulrhmnGhanem
Replace ARCCache with TwoQueueCache to avoid patent issue (go-gitea#1…
2eea8d3 
…6240)

Co-authored-by: Mura Li <typeless@users.noreply.github.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@typeless @codecov-commenter @techknowlogick @zeripath @GiteaBot