False information in "merged by"

[strk]

Gitea version 1.5.2 shows a pull request as "merged by " but the merge was actually done by somebody else (<committer> does not have write access to the repo).

The information about who did the merge was lost.

Can this happen when the merge is a forward-merge ?
It sounds like a bug to me, to loose such information.

[strk]

Where you can see this problem live: https://git.osgeo.org/gitea/geos/geos/pulls/70#issuecomment-3854

[strk]

@lafriks do you have any idea about this ? (pinging you as the author of #3368)

[strk]

For comparison, github seems to always say merged by <authenticated_user_at_time_of_push>, which I guess implies checking each of the commits being pushed to a repository against existing PRs and spotting which ones are being manually merged.

\cc @dbaston

[strk]

Interesting read: https://help.github.com/en/articles/about-pull-request-merges
\cc @mloskot

[0x5c]

1.5.2?

[lafriks]

@strk can you reproduce this on try.gitea.io? There have been changes about this, and I think it should be already fixed in latest version

[0x5c]

Looking at the latest messages on the thread, the PR closed itself as merged when the (locally merged) commit was pushed by someone.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. You can re-open it if needed.