Skip to content

Commit f1ec841

Browse files
committed
adjust tests
1 parent 683b4db commit f1ec841

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

integrations/issue_test.go

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -361,12 +361,13 @@ func TestSearchIssues(t *testing.T) {
361361
resp := session.MakeRequest(t, req, http.StatusOK)
362362
var apiIssues []*api.Issue
363363
DecodeJSON(t, resp, &apiIssues)
364-
assert.Len(t, apiIssues, 10)
364+
// as this API is used in the frontend, it uses UI page size
365+
assert.Len(t, apiIssues, setting.UI.IssuePagingNum)
365366

366367
req = NewRequest(t, "GET", link.String())
367368
resp = session.MakeRequest(t, req, http.StatusOK)
368369
DecodeJSON(t, resp, &apiIssues)
369-
assert.Len(t, apiIssues, 10)
370+
assert.Len(t, apiIssues, setting.UI.IssuePagingNum)
370371

371372
since := "2000-01-01T00%3A50%3A01%2B00%3A00" // 946687801
372373
before := time.Unix(999307200, 0).Format(time.RFC3339)
@@ -394,14 +395,15 @@ func TestSearchIssues(t *testing.T) {
394395
resp = session.MakeRequest(t, req, http.StatusOK)
395396
DecodeJSON(t, resp, &apiIssues)
396397
assert.EqualValues(t, "17", resp.Header().Get("X-Total-Count"))
397-
assert.Len(t, apiIssues, 10) // there are more but 10 is page item limit
398+
assert.Len(t, apiIssues, 17)
398399

399-
query.Add("limit", "20")
400+
query.Add("limit", "5")
400401
link.RawQuery = query.Encode()
401402
req = NewRequest(t, "GET", link.String())
402403
resp = session.MakeRequest(t, req, http.StatusOK)
403404
DecodeJSON(t, resp, &apiIssues)
404-
assert.Len(t, apiIssues, 17)
405+
assert.EqualValues(t, "17", resp.Header().Get("X-Total-Count"))
406+
assert.Len(t, apiIssues, 5)
405407

406408
query = url.Values{"assigned": {"true"}, "state": {"all"}}
407409
link.RawQuery = query.Encode()
@@ -457,7 +459,7 @@ func TestSearchIssuesWithLabels(t *testing.T) {
457459
var apiIssues []*api.Issue
458460
DecodeJSON(t, resp, &apiIssues)
459461

460-
assert.Len(t, apiIssues, 10)
462+
assert.Len(t, apiIssues, setting.UI.IssuePagingNum)
461463

462464
query := url.Values{
463465
"token": []string{token},
@@ -466,7 +468,7 @@ func TestSearchIssuesWithLabels(t *testing.T) {
466468
req = NewRequest(t, "GET", link.String())
467469
resp = MakeRequest(t, req, http.StatusOK)
468470
DecodeJSON(t, resp, &apiIssues)
469-
assert.Len(t, apiIssues, 10)
471+
assert.Len(t, apiIssues, setting.UI.IssuePagingNum)
470472

471473
query.Add("labels", "label1")
472474
link.RawQuery = query.Encode()

0 commit comments

Comments
 (0)