Skip to content

Commit d74c222

Browse files
yp05327GiteaBot
andauthored
Remove nonsense <a> for commit status check icon (#26287)
We are using `<a>` for commit status check icon with no link. So it is clickable but this is no sense. I think we can convert this to `div`. ![image](https://github.com/go-gitea/gitea/assets/18380374/23db1a11-b0c7-4444-bfa6-fe68aeb1c682) Co-authored-by: Giteabot <teabot@gitea.io>
1 parent 0827fbd commit d74c222

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

templates/repo/issue/view_content/pull.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
{{/* Then the merge box will not be displayed because this page already contains enough information */}}
33
{{else}}
44
<div class="timeline-item comment merge box">
5-
<a class="timeline-avatar text {{if .Issue.PullRequest.HasMerged}}purple
5+
<div class="timeline-avatar text {{if .Issue.PullRequest.HasMerged}}purple
66
{{- else if .Issue.IsClosed}}grey
77
{{- else if .IsPullWorkInProgress}}grey
88
{{- else if .IsFilesConflicted}}grey
@@ -18,7 +18,7 @@
1818
{{- else if .Issue.PullRequest.IsChecking}}yellow
1919
{{- else if .Issue.PullRequest.IsEmpty}}grey
2020
{{- else if .Issue.PullRequest.CanAutoMerge}}green
21-
{{- else}}red{{end}}">{{svg "octicon-git-merge" 40}}</a>
21+
{{- else}}red{{end}}">{{svg "octicon-git-merge" 40}}</div>
2222
<div class="content">
2323
{{template "repo/pulls/status" .}}
2424
{{$showGeneralMergeForm := false}}

0 commit comments

Comments
 (0)