Skip to content

Commit 96aae56

Browse files
committed
add some notes
Signed-off-by: Andrew Thornton <art27@cantab.net>
1 parent 544c359 commit 96aae56

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

modules/context/context.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -649,6 +649,7 @@ func Contexter() func(next http.Handler) http.Handler {
649649
log.Debug("Session ID: %s", ctx.Session.ID())
650650
log.Debug("CSRF Token: %v", ctx.Data["CsrfToken"])
651651

652+
// FIXME: do we really always need these setting?
652653
ctx.Data["IsLandingPageHome"] = setting.LandingPageURL == setting.LandingPageHome
653654
ctx.Data["IsLandingPageExplore"] = setting.LandingPageURL == setting.LandingPageExplore
654655
ctx.Data["IsLandingPageOrganizations"] = setting.LandingPageURL == setting.LandingPageOrganizations

services/auth/sspi_windows.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ func (s *SSPI) VerifyAuthData(req *http.Request, w http.ResponseWriter, store Da
9898
// Include the user login page in the 401 response to allow the user
9999
// to login with another authentication method if SSPI authentication
100100
// fails
101+
// FIXME: This doesn't work
101102
store.GetData()["Flash"] = map[string]string{
102103
"ErrorMsg": err.Error(),
103104
}

0 commit comments

Comments
 (0)