check release publisher exists (#14375)

noerw · web-flow · commit 5ee09d3c8161 · 2021-01-18T14:14:27.000+01:00
fixes #14365 was silently fixed in the feature PR #12096 for v1.14
diff --git a/models/release.go b/models/release.go
@@ -54,7 +54,11 @@ func (r *Release) loadAttributes(e Engine) error {
 	if r.Publisher == nil {
 		r.Publisher, err = getUserByID(e, r.PublisherID)
 		if err != nil {
-			return err
+			if IsErrUserNotExist(err) {
+				r.Publisher = NewGhostUser()
+			} else {
+				return err
+			}
 		}
 	}
 	return getReleaseAttachments(e, r)

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,11 @@ func (r *Release) loadAttributes(e Engine) error {`
`54`	`54`	`if r.Publisher == nil {`
`55`	`55`	`r.Publisher, err = getUserByID(e, r.PublisherID)`
`56`	`56`	`if err != nil {`
`57`		`- return err`
	`57`	`+ if IsErrUserNotExist(err) {`
	`58`	`+ r.Publisher = NewGhostUser()`
	`59`	`+ } else {`
	`60`	`+ return err`
	`61`	`+ }`
`58`	`62`	`}`
`59`	`63`	`}`
`60`	`64`	`return getReleaseAttachments(e, r)`