Skip to content

Commit 5bd0533

Browse files
authored
Fix comment triangles and tweak inline comment margins (#13554)
- Fix various miscolored comment bubble triangles - Tweak padding on inline comment boxes
1 parent 586bfb9 commit 5bd0533

File tree

3 files changed

+18
-46
lines changed

3 files changed

+18
-46
lines changed

web_src/less/_repository.less

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -523,12 +523,12 @@
523523
position: relative;
524524
padding: 15px;
525525
margin-bottom: 10px;
526-
border: 1px solid #dddddd;
526+
border: 1px solid var(--color-secondary);
527527
border-radius: 3px;
528528
#avatar-arrow;
529529

530530
&::after {
531-
border-right-color: #ffffff;
531+
border-right-color: var(--color-box-header);
532532
}
533533

534534
.quick-pull-choice {
@@ -598,7 +598,7 @@
598598
#avatar-arrow;
599599

600600
&::after {
601-
border-right-color: #ffffff;
601+
border-right-color: var(--color-box-body);
602602
}
603603

604604
.markdown {
@@ -1024,6 +1024,10 @@
10241024

10251025
&.no-header {
10261026
#avatar-arrow;
1027+
1028+
&::after {
1029+
border-right-color: var(--color-box-body);
1030+
}
10271031
}
10281032

10291033
@media only screen and (max-width: 767px) {
@@ -1221,7 +1225,7 @@
12211225
#avatar-arrow;
12221226

12231227
&::after {
1224-
border-right-color: #ffffff;
1228+
border-right-color: var(--color-box-body);
12251229
}
12261230
}
12271231

@@ -1361,7 +1365,7 @@
13611365
#avatar-arrow;
13621366

13631367
&::after {
1364-
border-right-color: #ffffff;
1368+
border-right-color: var(--color-box-body);
13651369
}
13661370
}
13671371
}
@@ -2915,7 +2919,6 @@
29152919
}
29162920

29172921
#avatar-arrow {
2918-
29192922
&::before,
29202923
&::after {
29212924
right: 100%;

web_src/less/_review.less

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,15 @@
4242
}
4343

4444
.comment-code-cloud {
45-
padding: 4px;
45+
padding: .5rem;
4646
padding-left: 0;
4747
position: relative;
4848
margin: 0 auto;
4949

50+
.comments .comment {
51+
margin: 0;
52+
}
53+
5054
.attached {
5155
&.tab {
5256
border: 0;

web_src/less/themes/theme-arc-green.less

Lines changed: 4 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1036,28 +1036,10 @@ a.ui.basic.green.label:hover {
10361036
color: #dbdbdb !important;
10371037
}
10381038

1039-
.repository.view.issue .comment-list .comment .content {
1040-
.header {
1041-
color: #dbdbdb;
1042-
background-color: var(--color-secondary);
1043-
border-color: var(--color-secondary);
1044-
}
1045-
1046-
.header::after {
1047-
border-right-color: var(--color-secondary);
1048-
}
1049-
1050-
.merge-section.no-header::after {
1051-
border-right-color: var(--color-secondary);
1052-
}
1053-
1054-
.header::before {
1055-
border-right-color: var(--color-secondary);
1056-
}
1057-
1058-
.merge-section.no-header::before {
1059-
border-right-color: #505667;
1060-
}
1039+
.repository.view.issue .comment-list .comment .content .header {
1040+
color: #dbdbdb;
1041+
background-color: var(--color-secondary);
1042+
border-color: var(--color-secondary);
10611043
}
10621044

10631045
.repository.view.issue .comment-list .timeline-item .badge {
@@ -1072,23 +1054,6 @@ a.ui.basic.green.label:hover {
10721054
color: #dedede;
10731055
}
10741056

1075-
.repository.file.editor .commit-form-wrapper .commit-form {
1076-
border-color: #505667;
1077-
}
1078-
1079-
.repository.file.editor .commit-form-wrapper .commit-form::before,
1080-
.repository.file.editor .commit-form-wrapper .commit-form::after {
1081-
border-right-color: #505667;
1082-
}
1083-
1084-
.repository .comment.form .content .form::after {
1085-
border-right-color: #353945;
1086-
}
1087-
1088-
.repository .comment.form .content .form::before {
1089-
border-right-color: var(--color-secondary);
1090-
}
1091-
10921057
.repository .comment.form .ui.tabular.menu .item.active {
10931058
background: #353945;
10941059
}

0 commit comments

Comments
 (0)