Skip to content

Commit 5b095fb

Browse files
committed
as per review
Signed-off-by: Andrew Thornton <art27@cantab.net>
1 parent c2842fb commit 5b095fb

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

services/migrations/gitea_downloader.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -670,18 +670,18 @@ func (g *GiteaDownloader) GetReviews(reviewable base.Reviewable) ([]*base.Review
670670
}
671671

672672
review := &base.Review{
673-
ID: pr.ID,
674-
IssueIndex: reviewable.GetLocalIndex(),
675-
Official: pr.Official,
676-
CommitID: pr.CommitID,
677-
Content: pr.Body,
678-
CreatedAt: pr.Submitted,
679-
State: string(pr.State),
680-
Comments: reviewComments,
673+
ID: pr.ID,
674+
IssueIndex: reviewable.GetLocalIndex(),
675+
ReviewerID: pr.Reviewer.ID,
676+
ReviewerName: pr.Reviewer.UserName,
677+
Official: pr.Official,
678+
CommitID: pr.CommitID,
679+
Content: pr.Body,
680+
CreatedAt: pr.Submitted,
681+
State: string(pr.State),
682+
Comments: reviewComments,
681683
}
682684

683-
review.ReviewerID = pr.Reviewer.ID
684-
review.ReviewerName = pr.Reviewer.UserName
685685
allReviews = append(allReviews, review)
686686
}
687687

services/migrations/github.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -778,6 +778,7 @@ func (g *GithubDownloaderV3) GetReviews(reviewable base.Reviewable) ([]*base.Rev
778778
opt := &github.ListOptions{
779779
PerPage: g.maxPerPage,
780780
}
781+
// Get approve/request change reviews
781782
for {
782783
g.waitAndPickClient()
783784
reviews, resp, err := g.getClient().PullRequests.ListReviews(g.ctx, g.repoOwner, g.repoName, int(reviewable.GetForeignIndex()), opt)
@@ -817,6 +818,7 @@ func (g *GithubDownloaderV3) GetReviews(reviewable base.Reviewable) ([]*base.Rev
817818
}
818819
opt.Page = resp.NextPage
819820
}
821+
// Get requested reviews
820822
for {
821823
g.waitAndPickClient()
822824
reviewers, resp, err := g.getClient().PullRequests.ListReviewers(g.ctx, g.repoOwner, g.repoName, int(reviewable.GetForeignIndex()), opt)

0 commit comments

Comments
 (0)