API should follow RequireSignInView (#8654)

lunny · web-flow · commit 3c63c3ace4bf · 2019-10-24T13:32:40.000+08:00
diff --git a/routers/api/v1/api.go b/routers/api/v1/api.go
@@ -862,7 +862,7 @@ func RegisterRoutes(m *macaron.Macaron) {
 		m.Group("/topics", func() {
 			m.Get("/search", repo.TopicSearch)
 		})
-	}, securityHeaders(), context.APIContexter(), sudo())
+	}, securityHeaders(), reqTokenBySetting(), context.APIContexter(), sudo())
 }
 
 func securityHeaders() macaron.Handler {
@@ -874,3 +874,10 @@ func securityHeaders() macaron.Handler {
 		})
 	}
 }
+
+func reqTokenBySetting() macaron.Handler {
+	if setting.Service.RequireSignInView {
+		return reqToken()
+	}
+	return func(ctx *macaron.Context) {}
+}

Original file line number	Diff line number	Diff line change
`@@ -862,7 +862,7 @@ func RegisterRoutes(m *macaron.Macaron) {`
`862`	`862`	`m.Group("/topics", func() {`
`863`	`863`	`m.Get("/search", repo.TopicSearch)`
`864`	`864`	`})`
`865`		`- }, securityHeaders(), context.APIContexter(), sudo())`
	`865`	`+ }, securityHeaders(), reqTokenBySetting(), context.APIContexter(), sudo())`
`866`	`866`	`}`
`867`	`867`
`868`	`868`	`func securityHeaders() macaron.Handler {`
`@@ -874,3 +874,10 @@ func securityHeaders() macaron.Handler {`
`874`	`874`	`})`
`875`	`875`	`}`
`876`	`876`	`}`
	`877`	`+`
	`878`	`+func reqTokenBySetting() macaron.Handler {`
	`879`	`+ if setting.Service.RequireSignInView {`
	`880`	`+ return reqToken()`
	`881`	`+ }`
	`882`	`+ return func(ctx *macaron.Context) {}`
	`883`	`+}`