fix lint

Author: philip-peterson

modules/git/git.go

@@ -201,6 +201,29 @@ func InitFull(ctx context.Context) (err error) {
 	return syncGitConfig()
 }
 
+func enableReflogs() error {
+	if err := configSet("core.logAllRefUpdates", "true"); err != nil {
+		return err
+	}
+	if setting.Git.Reflog.Expiration != 90 {
+		if err := configSet("gc.reflogExpire", fmt.Sprintf("%d", setting.Git.Reflog.Expiration)); err != nil {
+			return err
+		}
+	} else if err := configUnsetAll("gc.reflogExpire", ""); err != nil {
+		return err
+	}
+	return nil
+}
+
+func disableReflogs() error {
+	if err := configUnsetAll("core.logAllRefUpdates", "true"); err != nil {
+		return err
+	} else if err := configUnsetAll("gc.reflogExpire", ""); err != nil {
+		return err
+	}
+	return nil
+}
+
 // syncGitConfig only modifies gitconfig, won't change global variables (otherwise there will be data-race problem)
 func syncGitConfig() (err error) {
 	if err = os.MkdirAll(HomeDir(), os.ModePerm); err != nil {
@@ -225,25 +248,12 @@ func syncGitConfig() (err error) {
 	}
 
 	if setting.Git.Reflog.Enabled {
-		if err := configSet("core.logAllRefUpdates", "true"); err != nil {
+		if err := enableReflogs(); err != nil {
 			return err
 		}
-		if setting.Git.Reflog.Expiration != 90 {
-			if err := configSet("gc.reflogExpire", fmt.Sprintf("%d", setting.Git.Reflog.Expiration)); err != nil {
-				return err
-			}
-		} else {
-			if err := configUnsetAll("gc.reflogExpire", ""); err != nil {
-				return err
-			}
-		}
 	} else {
-		if err := configUnsetAll("core.logAllRefUpdates", "true"); err != nil {
+		if err := disableReflogs(); err != nil {
 			return err
-		} else {
-			if err := configUnsetAll("gc.reflogExpire", ""); err != nil {
-				return err
-			}
 		}
 	}