In File Create/Update API return 404 if Branch does not exist (#11791) (#11795)

6543 · web-flow · commit 20951c5c215b · 2020-06-07T22:50:19.000+03:00
* In File Create/Update API return 404 if Branch does not exist (#11791) * v1.12 version ;)
diff --git a/routers/api/v1/repo/file.go b/routers/api/v1/repo/file.go
@@ -350,6 +350,10 @@ func handleCreateOrUpdateFileError(ctx *context.APIContext, err error) {
 		ctx.Error(http.StatusUnprocessableEntity, "Invalid", err)
 		return
 	}
+	if git.IsErrBranchNotExist(err) {
+		ctx.Error(http.StatusNotFound, "BranchDoesNotExist", err)
+		return
+	}
 
 	ctx.Error(http.StatusInternalServerError, "UpdateFile", err)
 }

Original file line number	Diff line number	Diff line change
`@@ -350,6 +350,10 @@ func handleCreateOrUpdateFileError(ctx *context.APIContext, err error) {`
`350`	`350`	`ctx.Error(http.StatusUnprocessableEntity, "Invalid", err)`
`351`	`351`	`return`
`352`	`352`	`}`
	`353`	`+ if git.IsErrBranchNotExist(err) {`
	`354`	`+ ctx.Error(http.StatusNotFound, "BranchDoesNotExist", err)`
	`355`	`+ return`
	`356`	`+ }`
`353`	`357`
`354`	`358`	`ctx.Error(http.StatusInternalServerError, "UpdateFile", err)`
`355`	`359`	`}`