fix: adjust the order of judgment

wolfogre · wolfogre · commit 1d6aea1f8c48 · 2022-09-06T21:06:58.000+08:00
diff --git a/services/issue/assignee.go b/services/issue/assignee.go
@@ -131,9 +131,9 @@ func IsValidReviewRequest(ctx context.Context, reviewer, doer *user_model.User,
 			return nil
 		}
 
-		pemResult = permDoer.CanAccessAny(perm.AccessModeWrite, unit.TypePullRequests)
+		pemResult = doer.ID == issue.PosterID
 		if !pemResult {
-			pemResult = doer.ID == issue.PosterID
+			pemResult = permDoer.CanAccessAny(perm.AccessModeWrite, unit.TypePullRequests)
 		}
 		if !pemResult {
 			pemResult, err = issues_model.IsOfficialReviewer(ctx, issue, doer)

Original file line number	Diff line number	Diff line change
`@@ -131,9 +131,9 @@ func IsValidReviewRequest(ctx context.Context, reviewer, doer *user_model.User,`
`131`	`131`	`return nil`
`132`	`132`	`}`
`133`	`133`
`134`		`- pemResult = permDoer.CanAccessAny(perm.AccessModeWrite, unit.TypePullRequests)`
	`134`	`+ pemResult = doer.ID == issue.PosterID`
`135`	`135`	`if !pemResult {`
`136`		`- pemResult = doer.ID == issue.PosterID`
	`136`	`+ pemResult = permDoer.CanAccessAny(perm.AccessModeWrite, unit.TypePullRequests)`
`137`	`137`	`}`
`138`	`138`	`if !pemResult {`
`139`	`139`	`pemResult, err = issues_model.IsOfficialReviewer(ctx, issue, doer)`