Skip to content

Commit 0292519

Browse files
committed
extend & ajust tests
1 parent d14705e commit 0292519

File tree

4 files changed

+26
-26
lines changed

4 files changed

+26
-26
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
423313fbd38093bb10d0c8387db9105409c6f196
1+
0dca5bd9b5d7ef937710e056f575e86c0184ba85

services/wiki/wiki_test.go

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -218,42 +218,42 @@ func TestPrepareWikiFileName(t *testing.T) {
218218
assert.NoError(t, err)
219219

220220
tests := []struct {
221-
name string
222-
arg string
223-
hasWiki bool
224-
wikiPath string
225-
wantErr bool
221+
name string
222+
arg string
223+
existence bool
224+
wikiPath string
225+
wantErr bool
226226
}{{
227-
name: "add suffix",
228-
arg: "home",
229-
hasWiki: true,
230-
wikiPath: "home.md",
231-
wantErr: false,
227+
name: "add suffix",
228+
arg: "Home",
229+
existence: true,
230+
wikiPath: "Home.md",
231+
wantErr: false,
232232
}, {
233-
name: "test special chars",
234-
arg: "home of and & or wiki page!",
235-
hasWiki: true,
236-
wikiPath: "home-of-and-%26-or-wiki-page%21.md",
237-
wantErr: false,
233+
name: "test special chars",
234+
arg: "home of and & or wiki page!",
235+
existence: false,
236+
wikiPath: "home-of-and-%26-or-wiki-page%21.md",
237+
wantErr: false,
238238
}, {
239-
name: "strange cases",
240-
arg: "...",
241-
hasWiki: true,
242-
wikiPath: "....md",
243-
wantErr: false,
239+
name: "fount unescaped cases",
240+
arg: "Unescaped File",
241+
existence: true,
242+
wikiPath: "Unescaped File.md",
243+
wantErr: false,
244244
}}
245245
for _, tt := range tests {
246246
t.Run(tt.name, func(t *testing.T) {
247-
isWikiExist, newWikiPath, err := prepareWikiFileName(gitRepo, tt.arg)
247+
existence, newWikiPath, err := prepareWikiFileName(gitRepo, tt.arg)
248248
if (err != nil) != tt.wantErr {
249249
assert.NoError(t, err)
250250
return
251251
}
252-
if isWikiExist != tt.hasWiki {
253-
if isWikiExist {
254-
t.Errorf("expect to have no wiki but we detect one")
252+
if existence != tt.existence {
253+
if existence {
254+
t.Errorf("expect to find no escaped file but we detect one")
255255
} else {
256-
t.Errorf("expect to have wiki but we could not detect one")
256+
t.Errorf("expect to find an escaped file but we could not detect one")
257257
}
258258
}
259259
assert.Equal(t, tt.wikiPath, newWikiPath)

0 commit comments

Comments
 (0)