Indicate to the user that a stash save is in progress #1702
Conversation
| @@ -419,7 +432,7 @@ impl Component for TextInputComponent { | |||
| } | |||
|
|
|||
| fn event(&mut self, ev: &Event) -> Result<EventState> { | |||
| if self.visible { | |||
| if self.visible && !self.disabled { | |||
There was a problem hiding this comment.
this is pretty invasive. why do we need that? the text input for the stashing can just close IMO and does not need to learn a new state of disabled. what is the rational?
There was a problem hiding this comment.
Without disabled, it's possible to type in the field while the operation is pending.
I suppose we could close the model and continue the operation in the background. In this case, is there a pattern for handling stashing errors if they occur?
There was a problem hiding this comment.
yeah that's what I think we should do, what we do in other cases already. just close the text input popup regularly and then the new popup will block any other input and visualise that the stashing is in progress
There was a problem hiding this comment.
for error handling use try_or_popup and find other examples for it
There was a problem hiding this comment.
Thanks, I'll make that change soon 👍🏻
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@nrempel are you willing to finish this up? |
|
Sorry, it's been a very busy year. I may have time to finish this over the holiday break. But I'll close this for now and revive it if needed. |
This Pull Request fixes #1495.
It changes the following:
StashMsgComponentto use AsyncStash instead of sync::StashTextInputComponentStashMsgComponenttitle to "Stashing..." while stash is pending and disable inputI followed the checklist:
make checkwithout errors