Skip to content

Commit b1c0c8d

Browse files
authored
Merge pull request microsoft#186030 from microsoft/merogge/new-cue
use new audio cues, set in progress one to `auto` by default
2 parents 7309642 + f250898 commit b1c0c8d

File tree

10 files changed

+2
-8
lines changed

10 files changed

+2
-8
lines changed

src/vs/platform/audioCues/browser/audioCueService.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,6 @@ export class Sound {
224224
public static readonly chatResponseReceived2 = Sound.register({ fileName: 'chatResponseReceived2.mp3' });
225225
public static readonly chatResponseReceived3 = Sound.register({ fileName: 'chatResponseReceived3.mp3' });
226226
public static readonly chatResponseReceived4 = Sound.register({ fileName: 'chatResponseReceived4.mp3' });
227-
public static readonly chatResponseReceived5 = Sound.register({ fileName: 'chatResponseReceived5.mp3' });
228227

229228
private constructor(public readonly fileName: string) { }
230229
}
@@ -380,11 +379,6 @@ export class AudioCue {
380379
...this.chatResponseReceived
381380
});
382381

383-
public static readonly chatResponseReceived5 = AudioCue.register({
384-
sound: Sound.chatResponseReceived5,
385-
...this.chatResponseReceived
386-
});
387-
388382
public static readonly chatResponsePending = AudioCue.register({
389383
name: localize('audioCues.chatResponsePending', 'Chat Response Pending'),
390384
sound: Sound.chatResponsePending,
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

src/vs/workbench/contrib/audioCues/browser/audioCues.contribution.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration).regis
125125
'audioCues.chatResponsePending': {
126126
'description': localize('audioCues.chatResponsePending', "Plays a sound on loop while the response is pending."),
127127
...audioCueFeatureBase,
128-
default: 'off'
128+
default: 'auto'
129129
},
130130
'audioCues.chatResponseReceived': {
131131
'description': localize('audioCues.chatResponseReceived', "Plays a sound on loop while the response has been received."),

src/vs/workbench/contrib/chat/browser/actions/chatAccessibilityHelp.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export function getAccessibilityHelpText(accessor: ServicesAccessor, type: 'pane
3939
content.push(localize('inlineChat.explain', "When a request is prefixed with /explain, a response will explain the code in the current selection and the chat view will be focused."));
4040
content.push(localize('inlineChat.toolbar', "Use tab to reach conditional parts like commands, status, message responses and more."));
4141
}
42-
content.push(localize('chat.audioCues', "Audio cues can be changed via settings with a prefix of audioCues.chat."));
42+
content.push(localize('chat.audioCues', "Audio cues can be changed via settings with a prefix of audioCues.chat. By default, if a request takes more than 5 seconds, you will hear an audio cue indicating that progress is still occurring."));
4343
return content.join('\n');
4444
}
4545

0 commit comments

Comments
 (0)