Skip to content

Commit 9e8b013

Browse files
committed
Address Feedback
1 parent b75d4b2 commit 9e8b013

File tree

4 files changed

+4
-15
lines changed

4 files changed

+4
-15
lines changed

src/vs/server/browser/workbench/workbench.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { CancellationToken } from 'vs/base/common/cancellation';
77
import { Event } from 'vs/base/common/event';
88
import { Schemas } from 'vs/base/common/network';
99
import { isEqual } from 'vs/base/common/resources';
10-
import { URI, UriComponents } from 'vs/base/common/uri';
10+
import { URI } from 'vs/base/common/uri';
1111
import { request } from 'vs/base/parts/request/browser/request';
1212
import { localize } from 'vs/nls';
1313
import { parseLogLevel } from 'vs/platform/log/common/log';
@@ -299,11 +299,7 @@ class WindowIndicator implements IWindowIndicator {
299299
// Find config by checking for DOM
300300
const configElement = document.getElementById('vscode-workbench-web-configuration');
301301
const configElementAttribute = configElement ? configElement.getAttribute('data-settings') : undefined;
302-
if (!configElement || !configElementAttribute) {
303-
throw new Error('Missing web configuration element');
304-
}
305-
306-
const config: IWorkbenchConstructionOptions & { folderUri?: UriComponents, workspaceUri?: UriComponents } = JSON.parse(configElementAttribute);
302+
const config: IWorkbenchConstructionOptions = configElementAttribute ? JSON.parse(configElementAttribute) : {};
307303

308304
// Find workspace to open and payload
309305
let workspace: IWorkspace;

src/vs/server/node/server.main.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -209,10 +209,7 @@ async function handleRoot(req: http.IncomingMessage, resp: http.ServerResponse,
209209
return serveError(req, resp, 400, 'Bad request.');
210210
}
211211

212-
const host = req.headers.host;
213-
214212
const workbenchConfig = {
215-
remoteAuthority: host,
216213
developmentOptions: {
217214
enableSmokeTestDriver: environmentService.driverHandle === 'web' ? true : undefined
218215
}
@@ -583,8 +580,6 @@ export async function main(options: IServerOptions): Promise<void> {
583580
const requestService = accessor.get(IRequestService);
584581
channelServer.registerChannel('request', new RequestChannel(requestService));
585582

586-
const environmentService = accessor.get(INativeEnvironmentService);
587-
588583
// Delay creation of spdlog for perf reasons (https://github.com/microsoft/vscode/issues/72906)
589584
bufferLogService.logger = new SpdLogLogger('main', join(environmentService.logsPath, `${RemoteExtensionLogFileName}.log`), true, bufferLogService.getLevel());
590585

test/smoke/src/areas/explorer/explorer.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
/*---------------------------------------------------------------------------------------------
2-
* Copyright (c) Microsoft Corporation. All rights reserved.
3-
* Licensed under the MIT License. See License.txt in the project root for license information.
2+
* Copyright (c) Gitpod. All rights reserved.
43
*--------------------------------------------------------------------------------------------*/
54

65
import minimist = require('minimist');

test/smoke/src/areas/terminal/terminal.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
/*---------------------------------------------------------------------------------------------
2-
* Copyright (c) Microsoft Corporation. All rights reserved.
3-
* Licensed under the MIT License. See License.txt in the project root for license information.
2+
* Copyright (c) Gitpod. All rights reserved.
43
*--------------------------------------------------------------------------------------------*/
54

65
import minimist = require('minimist');

0 commit comments

Comments
 (0)