From 1ed0104b48b334e6eb37d1bc04322fa72010df8d Mon Sep 17 00:00:00 2001
From: Ruizhe Pang <pawn051028@gmail.com>
Date: Tue, 22 Apr 2025 22:02:40 +0800
Subject: [PATCH 01/10] Make the notification volume adjustable

---
 src/renderer/__mocks__/state-mocks.ts         |  1 +
 .../settings/NotificationSettings.tsx         | 20 +++++++++++++
 src/renderer/context/App.tsx                  |  1 +
 src/renderer/types.ts                         |  1 +
 .../utils/notifications/native.test.ts        | 29 +++++++++++++++++++
 src/renderer/utils/notifications/native.ts    |  6 ++--
 6 files changed, 55 insertions(+), 3 deletions(-)

diff --git a/src/renderer/__mocks__/state-mocks.ts b/src/renderer/__mocks__/state-mocks.ts
index a12d6ce96..ee6cb1c93 100644
--- a/src/renderer/__mocks__/state-mocks.ts
+++ b/src/renderer/__mocks__/state-mocks.ts
@@ -93,6 +93,7 @@ const mockNotificationSettings: NotificationSettingsState = {
   markAsDoneOnOpen: false,
   markAsDoneOnUnsubscribe: false,
   delayNotificationState: false,
+  notificationVolume: 20,
 };
 
 const mockSystemSettings: SystemSettingsState = {
diff --git a/src/renderer/components/settings/NotificationSettings.tsx b/src/renderer/components/settings/NotificationSettings.tsx
index 78aaae595..a81c2cb84 100644
--- a/src/renderer/components/settings/NotificationSettings.tsx
+++ b/src/renderer/components/settings/NotificationSettings.tsx
@@ -246,6 +246,26 @@ export const NotificationSettings: FC = () => {
             </Text>
           }
         />
+
+        <Box>
+          <Text as="label" htmlFor="notificationVolume">
+            Notification Volume: {settings.notificationVolume}%
+          </Text>
+          <input
+            id="notificationVolume"
+            type="range"
+            min={0}
+            max={100}
+            step={1}
+            value={settings.notificationVolume}
+            onChange={(evt) =>
+              updateSetting(
+                'notificationVolume',
+                Number.parseInt(evt.target.value, 10),
+              )
+            }
+          />
+        </Box>
       </Stack>
     </fieldset>
   );
diff --git a/src/renderer/context/App.tsx b/src/renderer/context/App.tsx
index d3421e6c2..e41d55ac7 100644
--- a/src/renderer/context/App.tsx
+++ b/src/renderer/context/App.tsx
@@ -85,6 +85,7 @@ const defaultNotificationSettings: NotificationSettingsState = {
   markAsDoneOnOpen: false,
   markAsDoneOnUnsubscribe: false,
   delayNotificationState: false,
+  notificationVolume: 20,
 };
 
 const defaultSystemSettings: SystemSettingsState = {
diff --git a/src/renderer/types.ts b/src/renderer/types.ts
index 3c631bc53..c7ae479fe 100644
--- a/src/renderer/types.ts
+++ b/src/renderer/types.ts
@@ -81,6 +81,7 @@ export interface NotificationSettingsState {
   markAsDoneOnOpen: boolean;
   markAsDoneOnUnsubscribe: boolean;
   delayNotificationState: boolean;
+  notificationVolume: number;
 }
 
 export interface SystemSettingsState {
diff --git a/src/renderer/utils/notifications/native.test.ts b/src/renderer/utils/notifications/native.test.ts
index f30cc9c8f..6e33703aa 100644
--- a/src/renderer/utils/notifications/native.test.ts
+++ b/src/renderer/utils/notifications/native.test.ts
@@ -134,4 +134,33 @@ describe('renderer/utils/notifications/native.ts', () => {
       expect(window.Audio.prototype.play).toHaveBeenCalledTimes(1);
     });
   });
+
+  describe('triggerNativeNotifications', () => {
+    afterEach(() => {
+      jest.clearAllMocks();
+    });
+
+    it('should raise only sound notification with correct volume', () => {
+      const settings: SettingsState = {
+        ...defaultSettings,
+        playSound: true,
+        showNotifications: false,
+        notificationVolume: 80,
+      };
+
+      const raiseSoundNotificationMock = jest.spyOn(
+        native,
+        'raiseSoundNotification',
+      );
+      jest.spyOn(native, 'raiseNativeNotification');
+
+      native.triggerNativeNotifications([], mockAccountNotifications, {
+        auth: mockAuth,
+        settings,
+      });
+
+      expect(raiseSoundNotificationMock).toHaveBeenCalledWith(0.8);
+      expect(native.raiseNativeNotification).not.toHaveBeenCalled();
+    });
+  });
 });
diff --git a/src/renderer/utils/notifications/native.ts b/src/renderer/utils/notifications/native.ts
index cda7f6367..1f4b56bdc 100644
--- a/src/renderer/utils/notifications/native.ts
+++ b/src/renderer/utils/notifications/native.ts
@@ -48,7 +48,7 @@ export const triggerNativeNotifications = (
   }
 
   if (state.settings.playSound) {
-    raiseSoundNotification();
+    raiseSoundNotification(state.settings.notificationVolume / 100);
   }
 
   if (state.settings.showNotifications) {
@@ -86,7 +86,7 @@ export const raiseNativeNotification = (notifications: Notification[]) => {
   return nativeNotification;
 };
 
-export const raiseSoundNotification = () => {
+export const raiseSoundNotification = (volume = 0.2) => {
   const audio = new Audio(
     path.join(
       __dirname,
@@ -96,6 +96,6 @@ export const raiseSoundNotification = () => {
       Constants.NOTIFICATION_SOUND,
     ),
   );
-  audio.volume = 0.2;
+  audio.volume = volume;
   audio.play();
 };

From 933538be0451e529a58b1eab840df193e1455c0e Mon Sep 17 00:00:00 2001
From: Ruizhe Pang <pawn051028@gmail.com>
Date: Tue, 22 Apr 2025 22:45:37 +0800
Subject: [PATCH 02/10] Modify isNaN(val) to Number.isNaN(val)

---
 .../AccountNotifications.test.tsx.snap        |  8 +++---
 .../NotificationFooter.test.tsx.snap          | 20 +++++++-------
 .../NotificationRow.test.tsx.snap             | 12 ++++-----
 .../settings/NotificationSettings.tsx         | 27 ++++++++++++-------
 .../__snapshots__/Settings.test.tsx.snap      | 26 ++++++++++++++++++
 5 files changed, 63 insertions(+), 30 deletions(-)

diff --git a/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap b/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap
index aaa3b4f20..a3f78bc6c 100644
--- a/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap
+++ b/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap
@@ -901,7 +901,7 @@ exports[`renderer/components/notifications/AccountNotifications.tsx should rende
                   class="sc-Qotzb"
                   datetime="2017-05-20T17:51:57.000Z"
                 >
-                  May 20, 2017
+                  May 21, 2017
                 </relative-time>
               </div>
               <div
@@ -1260,7 +1260,7 @@ exports[`renderer/components/notifications/AccountNotifications.tsx should rende
                   class="sc-Qotzb"
                   datetime="2017-05-20T17:06:34.000Z"
                 >
-                  May 20, 2017
+                  May 21, 2017
                 </relative-time>
               </div>
               <div
@@ -1734,7 +1734,7 @@ exports[`renderer/components/notifications/AccountNotifications.tsx should rende
                 class="sc-Qotzb"
                 datetime="2017-05-20T17:51:57.000Z"
               >
-                May 20, 2017
+                May 21, 2017
               </relative-time>
             </div>
             <div
@@ -2093,7 +2093,7 @@ exports[`renderer/components/notifications/AccountNotifications.tsx should rende
                 class="sc-Qotzb"
                 datetime="2017-05-20T17:06:34.000Z"
               >
-                May 20, 2017
+                May 21, 2017
               </relative-time>
             </div>
             <div
diff --git a/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap b/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap
index 24de34692..52ac23678 100644
--- a/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap
+++ b/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap
@@ -60,7 +60,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx security alert
             class="sc-Qotzb"
             datetime="2017-05-20T17:51:57.000Z"
           >
-            May 20, 2017
+            May 21, 2017
           </relative-time>
         </div>
         <div
@@ -200,7 +200,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx security alert
           class="sc-Qotzb"
           datetime="2017-05-20T17:51:57.000Z"
         >
-          May 20, 2017
+          May 21, 2017
         </relative-time>
       </div>
       <div
@@ -397,7 +397,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx security alert
             class="sc-Qotzb"
             datetime="2017-05-20T17:51:57.000Z"
           >
-            May 20, 2017
+            May 21, 2017
           </relative-time>
         </div>
         <div
@@ -537,7 +537,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx security alert
           class="sc-Qotzb"
           datetime="2017-05-20T17:51:57.000Z"
         >
-          May 20, 2017
+          May 21, 2017
         </relative-time>
       </div>
       <div
@@ -734,7 +734,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should default
             class="sc-Qotzb"
             datetime="2017-05-20T17:51:57.000Z"
           >
-            May 20, 2017
+            May 21, 2017
           </relative-time>
         </div>
         <div
@@ -874,7 +874,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should default
           class="sc-Qotzb"
           datetime="2017-05-20T17:51:57.000Z"
         >
-          May 20, 2017
+          May 21, 2017
         </relative-time>
       </div>
       <div
@@ -1071,7 +1071,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
             class="sc-Qotzb"
             datetime="2017-05-20T17:51:57.000Z"
           >
-            May 20, 2017
+            May 21, 2017
           </relative-time>
         </div>
         <div
@@ -1211,7 +1211,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
           class="sc-Qotzb"
           datetime="2017-05-20T17:51:57.000Z"
         >
-          May 20, 2017
+          May 21, 2017
         </relative-time>
       </div>
       <div
@@ -1408,7 +1408,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
             class="sc-Qotzb"
             datetime="2017-05-20T17:51:57.000Z"
           >
-            May 20, 2017
+            May 21, 2017
           </relative-time>
         </div>
         <div
@@ -1548,7 +1548,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
           class="sc-Qotzb"
           datetime="2017-05-20T17:51:57.000Z"
         >
-          May 20, 2017
+          May 21, 2017
         </relative-time>
       </div>
       <div
diff --git a/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap b/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap
index da457bbcb..3fab8c74a 100644
--- a/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap
+++ b/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap
@@ -179,7 +179,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                   class="sc-Qotzb"
                   datetime="2017-05-20T17:51:57.000Z"
                 >
-                  May 20, 2017
+                  May 21, 2017
                 </relative-time>
               </div>
               <div
@@ -541,7 +541,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                 class="sc-Qotzb"
                 datetime="2017-05-20T17:51:57.000Z"
               >
-                May 20, 2017
+                May 21, 2017
               </relative-time>
             </div>
             <div
@@ -909,7 +909,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                   class="sc-Qotzb"
                   datetime="2017-05-20T17:51:57.000Z"
                 >
-                  May 20, 2017
+                  May 21, 2017
                 </relative-time>
               </div>
               <div
@@ -1220,7 +1220,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                 class="sc-Qotzb"
                 datetime="2017-05-20T17:51:57.000Z"
               >
-                May 20, 2017
+                May 21, 2017
               </relative-time>
             </div>
             <div
@@ -1588,7 +1588,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                   class="sc-Qotzb"
                   datetime="2017-05-20T17:51:57.000Z"
                 >
-                  May 20, 2017
+                  May 21, 2017
                 </relative-time>
               </div>
               <div
@@ -1899,7 +1899,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                 class="sc-Qotzb"
                 datetime="2017-05-20T17:51:57.000Z"
               >
-                May 20, 2017
+                May 21, 2017
               </relative-time>
             </div>
             <div
diff --git a/src/renderer/components/settings/NotificationSettings.tsx b/src/renderer/components/settings/NotificationSettings.tsx
index a81c2cb84..2ea5157a7 100644
--- a/src/renderer/components/settings/NotificationSettings.tsx
+++ b/src/renderer/components/settings/NotificationSettings.tsx
@@ -247,25 +247,32 @@ export const NotificationSettings: FC = () => {
           }
         />
 
-        <Box>
+        <Stack direction="horizontal" gap="condensed" alignItems="center">
           <Text as="label" htmlFor="notificationVolume">
-            Notification Volume: {settings.notificationVolume}%
+            Notification Volume:
           </Text>
           <input
             id="notificationVolume"
-            type="range"
+            type="number"
             min={0}
             max={100}
             step={1}
             value={settings.notificationVolume}
-            onChange={(evt) =>
-              updateSetting(
-                'notificationVolume',
-                Number.parseInt(evt.target.value, 10),
-              )
-            }
+            onChange={(evt) => {
+              let val = Number(evt.target.value);
+              if (Number.isNaN(val)) val = 0;
+              if (val > 100) val = 100;
+              if (val < 0) val = 0;
+              updateSetting('notificationVolume', val);
+            }}
+            style={{
+              width: '3rem',
+              textAlign: 'center',
+              border: '1px solid #ccc',
+              borderRadius: '4px',
+            }}
           />
-        </Box>
+        </Stack>
       </Stack>
     </fieldset>
   );
diff --git a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
index 1ad989a05..8041209d2 100644
--- a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
+++ b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
@@ -919,6 +919,32 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
               </svg>
             </div>
           </div>
+          <div
+            alignitems="center"
+            class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv"
+            data-align="stretch"
+            data-direction="horizontal"
+            data-gap="condensed"
+            data-justify="start"
+            data-padding="none"
+            data-wrap="nowrap"
+          >
+            <label
+              class="Text-sc-17v1xeu-0 gfWGMy"
+              for="notificationVolume"
+            >
+              Notification Volume:
+            </label>
+            <input
+              id="notificationVolume"
+              max="100"
+              min="0"
+              step="1"
+              style="width: 3rem; text-align: center; border: 1px solid #ccc; border-radius: 4px;"
+              type="number"
+              value="20"
+            />
+          </div>
         </div>
       </fieldset>
       <fieldset>

From 04e79d16f8eaabd9766fc63f0f839b41ccdb90bb Mon Sep 17 00:00:00 2001
From: Ruizhe Pang <pawn051028@gmail.com>
Date: Wed, 23 Apr 2025 00:32:20 +0800
Subject: [PATCH 03/10] Update the UI

---
 .../settings/NotificationSettings.tsx         | 27 -------
 .../components/settings/SystemSettings.tsx    | 80 ++++++++++++++++++-
 2 files changed, 78 insertions(+), 29 deletions(-)

diff --git a/src/renderer/components/settings/NotificationSettings.tsx b/src/renderer/components/settings/NotificationSettings.tsx
index 2ea5157a7..78aaae595 100644
--- a/src/renderer/components/settings/NotificationSettings.tsx
+++ b/src/renderer/components/settings/NotificationSettings.tsx
@@ -246,33 +246,6 @@ export const NotificationSettings: FC = () => {
             </Text>
           }
         />
-
-        <Stack direction="horizontal" gap="condensed" alignItems="center">
-          <Text as="label" htmlFor="notificationVolume">
-            Notification Volume:
-          </Text>
-          <input
-            id="notificationVolume"
-            type="number"
-            min={0}
-            max={100}
-            step={1}
-            value={settings.notificationVolume}
-            onChange={(evt) => {
-              let val = Number(evt.target.value);
-              if (Number.isNaN(val)) val = 0;
-              if (val > 100) val = 100;
-              if (val < 0) val = 0;
-              updateSetting('notificationVolume', val);
-            }}
-            style={{
-              width: '3rem',
-              textAlign: 'center',
-              border: '1px solid #ccc',
-              borderRadius: '4px',
-            }}
-          />
-        </Stack>
       </Stack>
     </fieldset>
   );
diff --git a/src/renderer/components/settings/SystemSettings.tsx b/src/renderer/components/settings/SystemSettings.tsx
index 58745f203..a0a823088 100644
--- a/src/renderer/components/settings/SystemSettings.tsx
+++ b/src/renderer/components/settings/SystemSettings.tsx
@@ -1,7 +1,20 @@
 import { type FC, useContext } from 'react';
 
-import { DeviceDesktopIcon } from '@primer/octicons-react';
-import { Box, Stack, Text } from '@primer/react';
+import {
+  DashIcon,
+  DeviceDesktopIcon,
+  PlusIcon,
+  XCircleIcon,
+} from '@primer/octicons-react';
+
+import {
+  Box,
+  Button,
+  ButtonGroup,
+  IconButton,
+  Stack,
+  Text,
+} from '@primer/react';
 
 import { APPLICATION } from '../../../shared/constants';
 import { isLinux, isMacOS } from '../../../shared/platform';
@@ -9,6 +22,7 @@ import { AppContext } from '../../context/App';
 import { OpenPreference } from '../../types';
 import { Constants } from '../../utils/constants';
 import { Checkbox } from '../fields/Checkbox';
+import { FieldLabel } from '../fields/FieldLabel';
 import { RadioGroup } from '../fields/RadioGroup';
 import { Title } from '../primitives/Title';
 
@@ -77,6 +91,68 @@ export const SystemSettings: FC = () => {
           onChange={(evt) => updateSetting('playSound', evt.target.checked)}
         />
 
+        {settings.playSound && (
+          <Stack
+            direction="horizontal"
+            gap="condensed"
+            align="center"
+            className="text-sm"
+          >
+            <FieldLabel
+              name="notificationVolume"
+              label="Notification volume:"
+            />
+
+            <ButtonGroup className="ml-2">
+              <IconButton
+                aria-label="Volume down"
+                size="small"
+                icon={DashIcon}
+                unsafeDisableTooltip={true}
+                onClick={() => {
+                  const newVolume = Math.max(
+                    settings.notificationVolume - 10,
+                    0,
+                  );
+                  updateSetting('notificationVolume', newVolume);
+                }}
+                data-testid="settings-volume-down"
+              />
+
+              <Button aria-label="Volume percentage" size="small" disabled>
+                {settings.notificationVolume.toFixed(0)}%
+              </Button>
+
+              <IconButton
+                aria-label="Volume up"
+                size="small"
+                icon={PlusIcon}
+                unsafeDisableTooltip={true}
+                onClick={() => {
+                  const newVolume = Math.min(
+                    settings.notificationVolume + 10,
+                    100,
+                  );
+                  updateSetting('notificationVolume', newVolume);
+                }}
+                data-testid="settings-volume-up"
+              />
+
+              <IconButton
+                aria-label="Reset volume"
+                size="small"
+                variant="danger"
+                icon={XCircleIcon}
+                unsafeDisableTooltip={true}
+                onClick={() => {
+                  updateSetting('notificationVolume', 20);
+                }}
+                data-testid="settings-volume-reset"
+              />
+            </ButtonGroup>
+          </Stack>
+        )}
+
         <Checkbox
           name="useAlternateIdleIcon"
           label="Use alternate idle icon"

From 99a10e7052e3e200f09b764baaf4fcf77124471a Mon Sep 17 00:00:00 2001
From: Ruizhe Pang <pawn051028@gmail.com>
Date: Wed, 23 Apr 2025 00:46:18 +0800
Subject: [PATCH 04/10] move variable(notificationVolume) to
 SystemSettingsState

---
 src/renderer/__mocks__/state-mocks.ts         |   2 +-
 src/renderer/context/App.tsx                  |   2 +-
 .../__snapshots__/Settings.test.tsx.snap      | 171 ++++++++++++++----
 src/renderer/types.ts                         |   2 +-
 4 files changed, 141 insertions(+), 36 deletions(-)

diff --git a/src/renderer/__mocks__/state-mocks.ts b/src/renderer/__mocks__/state-mocks.ts
index ee6cb1c93..a56037a8d 100644
--- a/src/renderer/__mocks__/state-mocks.ts
+++ b/src/renderer/__mocks__/state-mocks.ts
@@ -93,7 +93,6 @@ const mockNotificationSettings: NotificationSettingsState = {
   markAsDoneOnOpen: false,
   markAsDoneOnUnsubscribe: false,
   delayNotificationState: false,
-  notificationVolume: 20,
 };
 
 const mockSystemSettings: SystemSettingsState = {
@@ -104,6 +103,7 @@ const mockSystemSettings: SystemSettingsState = {
   playSound: true,
   useAlternateIdleIcon: false,
   openAtStartup: false,
+  notificationVolume: 20,
 };
 
 const mockFilters: FilterSettingsState = {
diff --git a/src/renderer/context/App.tsx b/src/renderer/context/App.tsx
index e41d55ac7..1cbbce415 100644
--- a/src/renderer/context/App.tsx
+++ b/src/renderer/context/App.tsx
@@ -85,7 +85,6 @@ const defaultNotificationSettings: NotificationSettingsState = {
   markAsDoneOnOpen: false,
   markAsDoneOnUnsubscribe: false,
   delayNotificationState: false,
-  notificationVolume: 20,
 };
 
 const defaultSystemSettings: SystemSettingsState = {
@@ -96,6 +95,7 @@ const defaultSystemSettings: SystemSettingsState = {
   playSound: true,
   useAlternateIdleIcon: false,
   openAtStartup: false,
+  notificationVolume: 20,
 };
 
 export const defaultFilters: FilterSettingsState = {
diff --git a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
index 8041209d2..8b9823b78 100644
--- a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
+++ b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
@@ -919,32 +919,6 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
               </svg>
             </div>
           </div>
-          <div
-            alignitems="center"
-            class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv"
-            data-align="stretch"
-            data-direction="horizontal"
-            data-gap="condensed"
-            data-justify="start"
-            data-padding="none"
-            data-wrap="nowrap"
-          >
-            <label
-              class="Text-sc-17v1xeu-0 gfWGMy"
-              for="notificationVolume"
-            >
-              Notification Volume:
-            </label>
-            <input
-              id="notificationVolume"
-              max="100"
-              min="0"
-              step="1"
-              style="width: 3rem; text-align: center; border: 1px solid #ccc; border-radius: 4px;"
-              type="number"
-              value="20"
-            />
-          </div>
         </div>
       </fieldset>
       <fieldset>
@@ -1176,6 +1150,137 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
               Play sound
             </label>
           </div>
+          <div
+            class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv text-sm"
+            data-align="center"
+            data-direction="horizontal"
+            data-gap="condensed"
+            data-justify="start"
+            data-padding="none"
+            data-wrap="nowrap"
+          >
+            <label
+              class="mr-3 font-medium cursor-pointer"
+              for="notificationVolume"
+            >
+              Notification volume:
+            </label>
+            <div
+              class="ButtonGroup-sc-1gxhls1-0 ePLgSl ml-2"
+            >
+              <button
+                aria-describedby="«r5»-loading-announcement"
+                aria-label="Volume down"
+                class="types__StyledButton-sc-ws60qy-0 QOGvM"
+                data-component="IconButton"
+                data-loading="false"
+                data-no-visuals="true"
+                data-size="small"
+                data-testid="settings-volume-down"
+                sx="[object Object]"
+                type="button"
+              >
+                <svg
+                  aria-hidden="true"
+                  class="octicon octicon-dash"
+                  display="inline-block"
+                  fill="currentColor"
+                  focusable="false"
+                  height="16"
+                  overflow="visible"
+                  style="vertical-align: text-bottom;"
+                  viewBox="0 0 16 16"
+                  width="16"
+                >
+                  <path
+                    d="M2 7.75A.75.75 0 0 1 2.75 7h10a.75.75 0 0 1 0 1.5h-10A.75.75 0 0 1 2 7.75Z"
+                  />
+                </svg>
+              </button>
+              <button
+                aria-describedby="«r6»-loading-announcement"
+                aria-label="Volume percentage"
+                class="types__StyledButton-sc-ws60qy-0 QOGvM"
+                data-loading="false"
+                data-no-visuals="true"
+                data-size="small"
+                disabled=""
+                sx="[object Object]"
+                type="button"
+              >
+                <span
+                  class="Box-sc-g0xbh4-0 cNXQpH"
+                  data-component="buttonContent"
+                  sx="[object Object]"
+                >
+                  <span
+                    data-component="text"
+                  >
+                    20
+                    %
+                  </span>
+                </span>
+              </button>
+              <button
+                aria-describedby="«r7»-loading-announcement"
+                aria-label="Volume up"
+                class="types__StyledButton-sc-ws60qy-0 QOGvM"
+                data-component="IconButton"
+                data-loading="false"
+                data-no-visuals="true"
+                data-size="small"
+                data-testid="settings-volume-up"
+                sx="[object Object]"
+                type="button"
+              >
+                <svg
+                  aria-hidden="true"
+                  class="octicon octicon-plus"
+                  display="inline-block"
+                  fill="currentColor"
+                  focusable="false"
+                  height="16"
+                  overflow="visible"
+                  style="vertical-align: text-bottom;"
+                  viewBox="0 0 16 16"
+                  width="16"
+                >
+                  <path
+                    d="M7.75 2a.75.75 0 0 1 .75.75V7h4.25a.75.75 0 0 1 0 1.5H8.5v4.25a.75.75 0 0 1-1.5 0V8.5H2.75a.75.75 0 0 1 0-1.5H7V2.75A.75.75 0 0 1 7.75 2Z"
+                  />
+                </svg>
+              </button>
+              <button
+                aria-describedby="«r8»-loading-announcement"
+                aria-label="Reset volume"
+                class="types__StyledButton-sc-ws60qy-0 gjscLt"
+                data-component="IconButton"
+                data-loading="false"
+                data-no-visuals="true"
+                data-size="small"
+                data-testid="settings-volume-reset"
+                sx="[object Object]"
+                type="button"
+              >
+                <svg
+                  aria-hidden="true"
+                  class="octicon octicon-x-circle"
+                  display="inline-block"
+                  fill="currentColor"
+                  focusable="false"
+                  height="16"
+                  overflow="visible"
+                  style="vertical-align: text-bottom;"
+                  viewBox="0 0 16 16"
+                  width="16"
+                >
+                  <path
+                    d="M2.344 2.343h-.001a8 8 0 0 1 11.314 11.314A8.002 8.002 0 0 1 .234 10.089a8 8 0 0 1 2.11-7.746Zm1.06 10.253a6.5 6.5 0 1 0 9.108-9.275 6.5 6.5 0 0 0-9.108 9.275ZM6.03 4.97 8 6.94l1.97-1.97a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l1.97 1.97a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-1.97 1.97a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L6.94 8 4.97 6.03a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018Z"
+                  />
+                </svg>
+              </button>
+            </div>
+          </div>
           <div
             class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv text-sm"
             data-align="center"
@@ -1254,7 +1359,7 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
         data-wrap="nowrap"
       >
         <button
-          aria-describedby="«r5»-loading-announcement"
+          aria-describedby="«r9»-loading-announcement"
           class="types__StyledButton-sc-ws60qy-0 fZJSho"
           data-loading="false"
           data-no-visuals="true"
@@ -1299,11 +1404,11 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
         <span
           aria-label="View release notes"
           class="Tooltip__TooltipBase-sc-17tf59c-0 iTeBSL tooltipped-n"
-          id="«r6»"
+          id="«ra»"
           role="tooltip"
         >
           <button
-            aria-describedby="«r7»-loading-announcement"
+            aria-describedby="«rb»-loading-announcement"
             class="types__StyledButton-sc-ws60qy-0 QOGvM"
             data-loading="false"
             data-no-visuals="true"
@@ -1339,11 +1444,11 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
         <span
           aria-label="Accounts"
           class="Tooltip__TooltipBase-sc-17tf59c-0 iTeBSL tooltipped-n"
-          id="«r8»"
+          id="«rc»"
           role="tooltip"
         >
           <button
-            aria-describedby="«r9»-loading-announcement"
+            aria-describedby="«rd»-loading-announcement"
             aria-label="Accounts"
             class="types__StyledButton-sc-ws60qy-0 QOGvM"
             data-component="IconButton"
@@ -1374,11 +1479,11 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
         <span
           aria-label="Quit Gitify"
           class="Tooltip__TooltipBase-sc-17tf59c-0 iTeBSL tooltipped-nw"
-          id="«ra»"
+          id="«re»"
           role="tooltip"
         >
           <button
-            aria-describedby="«rb»-loading-announcement"
+            aria-describedby="«rf»-loading-announcement"
             aria-label="Quit Gitify"
             class="types__StyledButton-sc-ws60qy-0 gjscLt"
             data-component="IconButton"
diff --git a/src/renderer/types.ts b/src/renderer/types.ts
index c7ae479fe..78b100f2b 100644
--- a/src/renderer/types.ts
+++ b/src/renderer/types.ts
@@ -81,7 +81,6 @@ export interface NotificationSettingsState {
   markAsDoneOnOpen: boolean;
   markAsDoneOnUnsubscribe: boolean;
   delayNotificationState: boolean;
-  notificationVolume: number;
 }
 
 export interface SystemSettingsState {
@@ -92,6 +91,7 @@ export interface SystemSettingsState {
   useAlternateIdleIcon: boolean;
   playSound: boolean;
   openAtStartup: boolean;
+  notificationVolume: number;
 }
 
 export interface FilterSettingsState {

From 05e2da3a9cd327cf5cc91bf7bfe23922880f71ba Mon Sep 17 00:00:00 2001
From: Adam Setch <adam.setch@outlook.com>
Date: Wed, 23 Apr 2025 02:51:22 +1000
Subject: [PATCH 05/10] adjust styling, use default value

Signed-off-by: Adam Setch <adam.setch@outlook.com>
---
 src/renderer/__mocks__/state-mocks.ts               |  2 +-
 src/renderer/components/settings/SystemSettings.tsx | 11 +++++++----
 src/renderer/context/App.tsx                        |  2 +-
 src/renderer/types.ts                               |  2 +-
 src/renderer/utils/notifications/native.ts          |  5 ++++-
 5 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/src/renderer/__mocks__/state-mocks.ts b/src/renderer/__mocks__/state-mocks.ts
index ee6cb1c93..63ea4921e 100644
--- a/src/renderer/__mocks__/state-mocks.ts
+++ b/src/renderer/__mocks__/state-mocks.ts
@@ -93,7 +93,6 @@ const mockNotificationSettings: NotificationSettingsState = {
   markAsDoneOnOpen: false,
   markAsDoneOnUnsubscribe: false,
   delayNotificationState: false,
-  notificationVolume: 20,
 };
 
 const mockSystemSettings: SystemSettingsState = {
@@ -102,6 +101,7 @@ const mockSystemSettings: SystemSettingsState = {
   showNotificationsCountInTray: true,
   showNotifications: true,
   playSound: true,
+  notificationVolume: 20,
   useAlternateIdleIcon: false,
   openAtStartup: false,
 };
diff --git a/src/renderer/components/settings/SystemSettings.tsx b/src/renderer/components/settings/SystemSettings.tsx
index a0a823088..ab4672013 100644
--- a/src/renderer/components/settings/SystemSettings.tsx
+++ b/src/renderer/components/settings/SystemSettings.tsx
@@ -18,7 +18,7 @@ import {
 
 import { APPLICATION } from '../../../shared/constants';
 import { isLinux, isMacOS } from '../../../shared/platform';
-import { AppContext } from '../../context/App';
+import { AppContext, defaultSettings } from '../../context/App';
 import { OpenPreference } from '../../types';
 import { Constants } from '../../utils/constants';
 import { Checkbox } from '../fields/Checkbox';
@@ -91,7 +91,7 @@ export const SystemSettings: FC = () => {
           onChange={(evt) => updateSetting('playSound', evt.target.checked)}
         />
 
-        {settings.playSound && (
+        <Box className="pl-6" hidden={!settings.playSound}>
           <Stack
             direction="horizontal"
             gap="condensed"
@@ -145,13 +145,16 @@ export const SystemSettings: FC = () => {
                 icon={XCircleIcon}
                 unsafeDisableTooltip={true}
                 onClick={() => {
-                  updateSetting('notificationVolume', 20);
+                  updateSetting(
+                    'notificationVolume',
+                    defaultSettings.notificationVolume,
+                  );
                 }}
                 data-testid="settings-volume-reset"
               />
             </ButtonGroup>
           </Stack>
-        )}
+        </Box>
 
         <Checkbox
           name="useAlternateIdleIcon"
diff --git a/src/renderer/context/App.tsx b/src/renderer/context/App.tsx
index e41d55ac7..ae9e3dc9e 100644
--- a/src/renderer/context/App.tsx
+++ b/src/renderer/context/App.tsx
@@ -85,7 +85,6 @@ const defaultNotificationSettings: NotificationSettingsState = {
   markAsDoneOnOpen: false,
   markAsDoneOnUnsubscribe: false,
   delayNotificationState: false,
-  notificationVolume: 20,
 };
 
 const defaultSystemSettings: SystemSettingsState = {
@@ -94,6 +93,7 @@ const defaultSystemSettings: SystemSettingsState = {
   showNotificationsCountInTray: true,
   showNotifications: true,
   playSound: true,
+  notificationVolume: 20,
   useAlternateIdleIcon: false,
   openAtStartup: false,
 };
diff --git a/src/renderer/types.ts b/src/renderer/types.ts
index c7ae479fe..e3edef714 100644
--- a/src/renderer/types.ts
+++ b/src/renderer/types.ts
@@ -81,7 +81,6 @@ export interface NotificationSettingsState {
   markAsDoneOnOpen: boolean;
   markAsDoneOnUnsubscribe: boolean;
   delayNotificationState: boolean;
-  notificationVolume: number;
 }
 
 export interface SystemSettingsState {
@@ -91,6 +90,7 @@ export interface SystemSettingsState {
   showNotifications: boolean;
   useAlternateIdleIcon: boolean;
   playSound: boolean;
+  notificationVolume: number;
   openAtStartup: boolean;
 }
 
diff --git a/src/renderer/utils/notifications/native.ts b/src/renderer/utils/notifications/native.ts
index 1f4b56bdc..cce0f4614 100644
--- a/src/renderer/utils/notifications/native.ts
+++ b/src/renderer/utils/notifications/native.ts
@@ -2,6 +2,7 @@ import path from 'node:path';
 
 import { APPLICATION } from '../../../shared/constants';
 import { isWindows } from '../../../shared/platform';
+import { defaultSettings } from '../../context/App';
 import type { AccountNotifications, GitifyState } from '../../types';
 import { Notification } from '../../typesGitHub';
 import { getAccountUUID } from '../auth/utils';
@@ -86,7 +87,9 @@ export const raiseNativeNotification = (notifications: Notification[]) => {
   return nativeNotification;
 };
 
-export const raiseSoundNotification = (volume = 0.2) => {
+export const raiseSoundNotification = (
+  volume = defaultSettings.notificationVolume / 100,
+) => {
   const audio = new Audio(
     path.join(
       __dirname,

From fc64e79a181f74bf01d3039bbcc3746af1eaafdd Mon Sep 17 00:00:00 2001
From: Adam Setch <adam.setch@outlook.com>
Date: Wed, 23 Apr 2025 02:53:02 +1000
Subject: [PATCH 06/10] update snapshots

Signed-off-by: Adam Setch <adam.setch@outlook.com>
---
 .../__snapshots__/Settings.test.tsx.snap      | 175 ++++++++++++++----
 1 file changed, 142 insertions(+), 33 deletions(-)

diff --git a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
index 8041209d2..1998b66de 100644
--- a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
+++ b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
@@ -919,32 +919,6 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
               </svg>
             </div>
           </div>
-          <div
-            alignitems="center"
-            class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv"
-            data-align="stretch"
-            data-direction="horizontal"
-            data-gap="condensed"
-            data-justify="start"
-            data-padding="none"
-            data-wrap="nowrap"
-          >
-            <label
-              class="Text-sc-17v1xeu-0 gfWGMy"
-              for="notificationVolume"
-            >
-              Notification Volume:
-            </label>
-            <input
-              id="notificationVolume"
-              max="100"
-              min="0"
-              step="1"
-              style="width: 3rem; text-align: center; border: 1px solid #ccc; border-radius: 4px;"
-              type="number"
-              value="20"
-            />
-          </div>
         </div>
       </fieldset>
       <fieldset>
@@ -1176,6 +1150,141 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
               Play sound
             </label>
           </div>
+          <div
+            class="Box-sc-g0xbh4-0 pl-6"
+          >
+            <div
+              class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv text-sm"
+              data-align="center"
+              data-direction="horizontal"
+              data-gap="condensed"
+              data-justify="start"
+              data-padding="none"
+              data-wrap="nowrap"
+            >
+              <label
+                class="mr-3 font-medium cursor-pointer"
+                for="notificationVolume"
+              >
+                Notification volume:
+              </label>
+              <div
+                class="ButtonGroup-sc-1gxhls1-0 ePLgSl ml-2"
+              >
+                <button
+                  aria-describedby="«r5»-loading-announcement"
+                  aria-label="Volume down"
+                  class="types__StyledButton-sc-ws60qy-0 QOGvM"
+                  data-component="IconButton"
+                  data-loading="false"
+                  data-no-visuals="true"
+                  data-size="small"
+                  data-testid="settings-volume-down"
+                  sx="[object Object]"
+                  type="button"
+                >
+                  <svg
+                    aria-hidden="true"
+                    class="octicon octicon-dash"
+                    display="inline-block"
+                    fill="currentColor"
+                    focusable="false"
+                    height="16"
+                    overflow="visible"
+                    style="vertical-align: text-bottom;"
+                    viewBox="0 0 16 16"
+                    width="16"
+                  >
+                    <path
+                      d="M2 7.75A.75.75 0 0 1 2.75 7h10a.75.75 0 0 1 0 1.5h-10A.75.75 0 0 1 2 7.75Z"
+                    />
+                  </svg>
+                </button>
+                <button
+                  aria-describedby="«r6»-loading-announcement"
+                  aria-label="Volume percentage"
+                  class="types__StyledButton-sc-ws60qy-0 QOGvM"
+                  data-loading="false"
+                  data-no-visuals="true"
+                  data-size="small"
+                  disabled=""
+                  sx="[object Object]"
+                  type="button"
+                >
+                  <span
+                    class="Box-sc-g0xbh4-0 cNXQpH"
+                    data-component="buttonContent"
+                    sx="[object Object]"
+                  >
+                    <span
+                      data-component="text"
+                    >
+                      20
+                      %
+                    </span>
+                  </span>
+                </button>
+                <button
+                  aria-describedby="«r7»-loading-announcement"
+                  aria-label="Volume up"
+                  class="types__StyledButton-sc-ws60qy-0 QOGvM"
+                  data-component="IconButton"
+                  data-loading="false"
+                  data-no-visuals="true"
+                  data-size="small"
+                  data-testid="settings-volume-up"
+                  sx="[object Object]"
+                  type="button"
+                >
+                  <svg
+                    aria-hidden="true"
+                    class="octicon octicon-plus"
+                    display="inline-block"
+                    fill="currentColor"
+                    focusable="false"
+                    height="16"
+                    overflow="visible"
+                    style="vertical-align: text-bottom;"
+                    viewBox="0 0 16 16"
+                    width="16"
+                  >
+                    <path
+                      d="M7.75 2a.75.75 0 0 1 .75.75V7h4.25a.75.75 0 0 1 0 1.5H8.5v4.25a.75.75 0 0 1-1.5 0V8.5H2.75a.75.75 0 0 1 0-1.5H7V2.75A.75.75 0 0 1 7.75 2Z"
+                    />
+                  </svg>
+                </button>
+                <button
+                  aria-describedby="«r8»-loading-announcement"
+                  aria-label="Reset volume"
+                  class="types__StyledButton-sc-ws60qy-0 gjscLt"
+                  data-component="IconButton"
+                  data-loading="false"
+                  data-no-visuals="true"
+                  data-size="small"
+                  data-testid="settings-volume-reset"
+                  sx="[object Object]"
+                  type="button"
+                >
+                  <svg
+                    aria-hidden="true"
+                    class="octicon octicon-x-circle"
+                    display="inline-block"
+                    fill="currentColor"
+                    focusable="false"
+                    height="16"
+                    overflow="visible"
+                    style="vertical-align: text-bottom;"
+                    viewBox="0 0 16 16"
+                    width="16"
+                  >
+                    <path
+                      d="M2.344 2.343h-.001a8 8 0 0 1 11.314 11.314A8.002 8.002 0 0 1 .234 10.089a8 8 0 0 1 2.11-7.746Zm1.06 10.253a6.5 6.5 0 1 0 9.108-9.275 6.5 6.5 0 0 0-9.108 9.275ZM6.03 4.97 8 6.94l1.97-1.97a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l1.97 1.97a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-1.97 1.97a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L6.94 8 4.97 6.03a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018Z"
+                    />
+                  </svg>
+                </button>
+              </div>
+            </div>
+          </div>
           <div
             class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv text-sm"
             data-align="center"
@@ -1254,7 +1363,7 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
         data-wrap="nowrap"
       >
         <button
-          aria-describedby="«r5»-loading-announcement"
+          aria-describedby="«r9»-loading-announcement"
           class="types__StyledButton-sc-ws60qy-0 fZJSho"
           data-loading="false"
           data-no-visuals="true"
@@ -1299,11 +1408,11 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
         <span
           aria-label="View release notes"
           class="Tooltip__TooltipBase-sc-17tf59c-0 iTeBSL tooltipped-n"
-          id="«r6»"
+          id="«ra»"
           role="tooltip"
         >
           <button
-            aria-describedby="«r7»-loading-announcement"
+            aria-describedby="«rb»-loading-announcement"
             class="types__StyledButton-sc-ws60qy-0 QOGvM"
             data-loading="false"
             data-no-visuals="true"
@@ -1339,11 +1448,11 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
         <span
           aria-label="Accounts"
           class="Tooltip__TooltipBase-sc-17tf59c-0 iTeBSL tooltipped-n"
-          id="«r8»"
+          id="«rc»"
           role="tooltip"
         >
           <button
-            aria-describedby="«r9»-loading-announcement"
+            aria-describedby="«rd»-loading-announcement"
             aria-label="Accounts"
             class="types__StyledButton-sc-ws60qy-0 QOGvM"
             data-component="IconButton"
@@ -1374,11 +1483,11 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
         <span
           aria-label="Quit Gitify"
           class="Tooltip__TooltipBase-sc-17tf59c-0 iTeBSL tooltipped-nw"
-          id="«ra»"
+          id="«re»"
           role="tooltip"
         >
           <button
-            aria-describedby="«rb»-loading-announcement"
+            aria-describedby="«rf»-loading-announcement"
             aria-label="Quit Gitify"
             class="types__StyledButton-sc-ws60qy-0 gjscLt"
             data-component="IconButton"

From cf6b045b82bff06be7088bb6b9fa0e090f258e53 Mon Sep 17 00:00:00 2001
From: Adam Setch <adam.setch@outlook.com>
Date: Wed, 23 Apr 2025 02:57:54 +1000
Subject: [PATCH 07/10] adjust styling, use default value

Signed-off-by: Adam Setch <adam.setch@outlook.com>
---
 src/renderer/__mocks__/state-mocks.ts | 1 -
 src/renderer/context/App.tsx          | 1 -
 src/renderer/types.ts                 | 1 -
 3 files changed, 3 deletions(-)

diff --git a/src/renderer/__mocks__/state-mocks.ts b/src/renderer/__mocks__/state-mocks.ts
index deba08169..63ea4921e 100644
--- a/src/renderer/__mocks__/state-mocks.ts
+++ b/src/renderer/__mocks__/state-mocks.ts
@@ -104,7 +104,6 @@ const mockSystemSettings: SystemSettingsState = {
   notificationVolume: 20,
   useAlternateIdleIcon: false,
   openAtStartup: false,
-  notificationVolume: 20,
 };
 
 const mockFilters: FilterSettingsState = {
diff --git a/src/renderer/context/App.tsx b/src/renderer/context/App.tsx
index b8a381878..ae9e3dc9e 100644
--- a/src/renderer/context/App.tsx
+++ b/src/renderer/context/App.tsx
@@ -96,7 +96,6 @@ const defaultSystemSettings: SystemSettingsState = {
   notificationVolume: 20,
   useAlternateIdleIcon: false,
   openAtStartup: false,
-  notificationVolume: 20,
 };
 
 export const defaultFilters: FilterSettingsState = {
diff --git a/src/renderer/types.ts b/src/renderer/types.ts
index a8c78e332..e3edef714 100644
--- a/src/renderer/types.ts
+++ b/src/renderer/types.ts
@@ -92,7 +92,6 @@ export interface SystemSettingsState {
   playSound: boolean;
   notificationVolume: number;
   openAtStartup: boolean;
-  notificationVolume: number;
 }
 
 export interface FilterSettingsState {

From 555c103d905efe15ed5159d3705175d5987ea918 Mon Sep 17 00:00:00 2001
From: Adam Setch <adam.setch@outlook.com>
Date: Wed, 23 Apr 2025 03:00:56 +1000
Subject: [PATCH 08/10] adjust styling, use default value

Signed-off-by: Adam Setch <adam.setch@outlook.com>
---
 .../__snapshots__/Settings.test.tsx.snap      | 131 ------------------
 1 file changed, 131 deletions(-)

diff --git a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
index 4840e47f2..1998b66de 100644
--- a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
+++ b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
@@ -1285,137 +1285,6 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
               </div>
             </div>
           </div>
-          <div
-            class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv text-sm"
-            data-align="center"
-            data-direction="horizontal"
-            data-gap="condensed"
-            data-justify="start"
-            data-padding="none"
-            data-wrap="nowrap"
-          >
-            <label
-              class="mr-3 font-medium cursor-pointer"
-              for="notificationVolume"
-            >
-              Notification volume:
-            </label>
-            <div
-              class="ButtonGroup-sc-1gxhls1-0 ePLgSl ml-2"
-            >
-              <button
-                aria-describedby="«r5»-loading-announcement"
-                aria-label="Volume down"
-                class="types__StyledButton-sc-ws60qy-0 QOGvM"
-                data-component="IconButton"
-                data-loading="false"
-                data-no-visuals="true"
-                data-size="small"
-                data-testid="settings-volume-down"
-                sx="[object Object]"
-                type="button"
-              >
-                <svg
-                  aria-hidden="true"
-                  class="octicon octicon-dash"
-                  display="inline-block"
-                  fill="currentColor"
-                  focusable="false"
-                  height="16"
-                  overflow="visible"
-                  style="vertical-align: text-bottom;"
-                  viewBox="0 0 16 16"
-                  width="16"
-                >
-                  <path
-                    d="M2 7.75A.75.75 0 0 1 2.75 7h10a.75.75 0 0 1 0 1.5h-10A.75.75 0 0 1 2 7.75Z"
-                  />
-                </svg>
-              </button>
-              <button
-                aria-describedby="«r6»-loading-announcement"
-                aria-label="Volume percentage"
-                class="types__StyledButton-sc-ws60qy-0 QOGvM"
-                data-loading="false"
-                data-no-visuals="true"
-                data-size="small"
-                disabled=""
-                sx="[object Object]"
-                type="button"
-              >
-                <span
-                  class="Box-sc-g0xbh4-0 cNXQpH"
-                  data-component="buttonContent"
-                  sx="[object Object]"
-                >
-                  <span
-                    data-component="text"
-                  >
-                    20
-                    %
-                  </span>
-                </span>
-              </button>
-              <button
-                aria-describedby="«r7»-loading-announcement"
-                aria-label="Volume up"
-                class="types__StyledButton-sc-ws60qy-0 QOGvM"
-                data-component="IconButton"
-                data-loading="false"
-                data-no-visuals="true"
-                data-size="small"
-                data-testid="settings-volume-up"
-                sx="[object Object]"
-                type="button"
-              >
-                <svg
-                  aria-hidden="true"
-                  class="octicon octicon-plus"
-                  display="inline-block"
-                  fill="currentColor"
-                  focusable="false"
-                  height="16"
-                  overflow="visible"
-                  style="vertical-align: text-bottom;"
-                  viewBox="0 0 16 16"
-                  width="16"
-                >
-                  <path
-                    d="M7.75 2a.75.75 0 0 1 .75.75V7h4.25a.75.75 0 0 1 0 1.5H8.5v4.25a.75.75 0 0 1-1.5 0V8.5H2.75a.75.75 0 0 1 0-1.5H7V2.75A.75.75 0 0 1 7.75 2Z"
-                  />
-                </svg>
-              </button>
-              <button
-                aria-describedby="«r8»-loading-announcement"
-                aria-label="Reset volume"
-                class="types__StyledButton-sc-ws60qy-0 gjscLt"
-                data-component="IconButton"
-                data-loading="false"
-                data-no-visuals="true"
-                data-size="small"
-                data-testid="settings-volume-reset"
-                sx="[object Object]"
-                type="button"
-              >
-                <svg
-                  aria-hidden="true"
-                  class="octicon octicon-x-circle"
-                  display="inline-block"
-                  fill="currentColor"
-                  focusable="false"
-                  height="16"
-                  overflow="visible"
-                  style="vertical-align: text-bottom;"
-                  viewBox="0 0 16 16"
-                  width="16"
-                >
-                  <path
-                    d="M2.344 2.343h-.001a8 8 0 0 1 11.314 11.314A8.002 8.002 0 0 1 .234 10.089a8 8 0 0 1 2.11-7.746Zm1.06 10.253a6.5 6.5 0 1 0 9.108-9.275 6.5 6.5 0 0 0-9.108 9.275ZM6.03 4.97 8 6.94l1.97-1.97a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l1.97 1.97a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-1.97 1.97a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L6.94 8 4.97 6.03a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018Z"
-                  />
-                </svg>
-              </button>
-            </div>
-          </div>
           <div
             class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv text-sm"
             data-align="center"

From 8d5e5c9823e56d9412a3fcb2876f8e59df9c2ee7 Mon Sep 17 00:00:00 2001
From: Adam Setch <adam.setch@outlook.com>
Date: Wed, 23 Apr 2025 03:50:23 +1000
Subject: [PATCH 09/10] update snapshots

Signed-off-by: Adam Setch <adam.setch@outlook.com>
---
 .../AccountNotifications.test.tsx.snap        |  8 ++++----
 .../NotificationFooter.test.tsx.snap          | 20 +++++++++----------
 .../NotificationRow.test.tsx.snap             | 12 +++++------
 3 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap b/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap
index a3f78bc6c..aaa3b4f20 100644
--- a/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap
+++ b/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap
@@ -901,7 +901,7 @@ exports[`renderer/components/notifications/AccountNotifications.tsx should rende
                   class="sc-Qotzb"
                   datetime="2017-05-20T17:51:57.000Z"
                 >
-                  May 21, 2017
+                  May 20, 2017
                 </relative-time>
               </div>
               <div
@@ -1260,7 +1260,7 @@ exports[`renderer/components/notifications/AccountNotifications.tsx should rende
                   class="sc-Qotzb"
                   datetime="2017-05-20T17:06:34.000Z"
                 >
-                  May 21, 2017
+                  May 20, 2017
                 </relative-time>
               </div>
               <div
@@ -1734,7 +1734,7 @@ exports[`renderer/components/notifications/AccountNotifications.tsx should rende
                 class="sc-Qotzb"
                 datetime="2017-05-20T17:51:57.000Z"
               >
-                May 21, 2017
+                May 20, 2017
               </relative-time>
             </div>
             <div
@@ -2093,7 +2093,7 @@ exports[`renderer/components/notifications/AccountNotifications.tsx should rende
                 class="sc-Qotzb"
                 datetime="2017-05-20T17:06:34.000Z"
               >
-                May 21, 2017
+                May 20, 2017
               </relative-time>
             </div>
             <div
diff --git a/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap b/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap
index 52ac23678..24de34692 100644
--- a/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap
+++ b/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap
@@ -60,7 +60,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx security alert
             class="sc-Qotzb"
             datetime="2017-05-20T17:51:57.000Z"
           >
-            May 21, 2017
+            May 20, 2017
           </relative-time>
         </div>
         <div
@@ -200,7 +200,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx security alert
           class="sc-Qotzb"
           datetime="2017-05-20T17:51:57.000Z"
         >
-          May 21, 2017
+          May 20, 2017
         </relative-time>
       </div>
       <div
@@ -397,7 +397,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx security alert
             class="sc-Qotzb"
             datetime="2017-05-20T17:51:57.000Z"
           >
-            May 21, 2017
+            May 20, 2017
           </relative-time>
         </div>
         <div
@@ -537,7 +537,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx security alert
           class="sc-Qotzb"
           datetime="2017-05-20T17:51:57.000Z"
         >
-          May 21, 2017
+          May 20, 2017
         </relative-time>
       </div>
       <div
@@ -734,7 +734,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should default
             class="sc-Qotzb"
             datetime="2017-05-20T17:51:57.000Z"
           >
-            May 21, 2017
+            May 20, 2017
           </relative-time>
         </div>
         <div
@@ -874,7 +874,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should default
           class="sc-Qotzb"
           datetime="2017-05-20T17:51:57.000Z"
         >
-          May 21, 2017
+          May 20, 2017
         </relative-time>
       </div>
       <div
@@ -1071,7 +1071,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
             class="sc-Qotzb"
             datetime="2017-05-20T17:51:57.000Z"
           >
-            May 21, 2017
+            May 20, 2017
           </relative-time>
         </div>
         <div
@@ -1211,7 +1211,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
           class="sc-Qotzb"
           datetime="2017-05-20T17:51:57.000Z"
         >
-          May 21, 2017
+          May 20, 2017
         </relative-time>
       </div>
       <div
@@ -1408,7 +1408,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
             class="sc-Qotzb"
             datetime="2017-05-20T17:51:57.000Z"
           >
-            May 21, 2017
+            May 20, 2017
           </relative-time>
         </div>
         <div
@@ -1548,7 +1548,7 @@ exports[`renderer/components/notifications/NotificationFooter.tsx should render
           class="sc-Qotzb"
           datetime="2017-05-20T17:51:57.000Z"
         >
-          May 21, 2017
+          May 20, 2017
         </relative-time>
       </div>
       <div
diff --git a/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap b/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap
index 3fab8c74a..da457bbcb 100644
--- a/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap
+++ b/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap
@@ -179,7 +179,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                   class="sc-Qotzb"
                   datetime="2017-05-20T17:51:57.000Z"
                 >
-                  May 21, 2017
+                  May 20, 2017
                 </relative-time>
               </div>
               <div
@@ -541,7 +541,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                 class="sc-Qotzb"
                 datetime="2017-05-20T17:51:57.000Z"
               >
-                May 21, 2017
+                May 20, 2017
               </relative-time>
             </div>
             <div
@@ -909,7 +909,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                   class="sc-Qotzb"
                   datetime="2017-05-20T17:51:57.000Z"
                 >
-                  May 21, 2017
+                  May 20, 2017
                 </relative-time>
               </div>
               <div
@@ -1220,7 +1220,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                 class="sc-Qotzb"
                 datetime="2017-05-20T17:51:57.000Z"
               >
-                May 21, 2017
+                May 20, 2017
               </relative-time>
             </div>
             <div
@@ -1588,7 +1588,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                   class="sc-Qotzb"
                   datetime="2017-05-20T17:51:57.000Z"
                 >
-                  May 21, 2017
+                  May 20, 2017
                 </relative-time>
               </div>
               <div
@@ -1899,7 +1899,7 @@ exports[`renderer/components/notifications/NotificationRow.tsx should render its
                 class="sc-Qotzb"
                 datetime="2017-05-20T17:51:57.000Z"
               >
-                May 21, 2017
+                May 20, 2017
               </relative-time>
             </div>
             <div

From 2d387351183f7f4bf84f83f4994e2ecea4abe462 Mon Sep 17 00:00:00 2001
From: Adam Setch <adam.setch@outlook.com>
Date: Thu, 24 Apr 2025 01:46:53 +1000
Subject: [PATCH 10/10] update volume icons

Signed-off-by: Adam Setch <adam.setch@outlook.com>
---
 .../components/icons/VolumeDownIcon.tsx       |  18 +++
 .../components/icons/VolumeUpIcon.tsx         |  16 +++
 .../components/settings/SystemSettings.tsx    |  36 +++---
 .../__snapshots__/Settings.test.tsx.snap      | 108 +++++++++---------
 4 files changed, 100 insertions(+), 78 deletions(-)
 create mode 100644 src/renderer/components/icons/VolumeDownIcon.tsx
 create mode 100644 src/renderer/components/icons/VolumeUpIcon.tsx

diff --git a/src/renderer/components/icons/VolumeDownIcon.tsx b/src/renderer/components/icons/VolumeDownIcon.tsx
new file mode 100644
index 000000000..93b2910a4
--- /dev/null
+++ b/src/renderer/components/icons/VolumeDownIcon.tsx
@@ -0,0 +1,18 @@
+import type { FC } from 'react';
+
+export const VolumeDownIcon: FC = () => (
+  <svg
+    className="size-4"
+    xmlns="http://www.w3.org/2000/svg"
+    viewBox="0 0 24 24"
+    width="24"
+    height="24"
+    role="img"
+    aria-label="Volume Down Icon"
+  >
+    <g transform="translate(2, 0)">
+      <path d="M11.553 3.064A.75.75 0 0 1 12 3.75v16.5a.75.75 0 0 1-1.255.555L5.46 16H2.75A1.75 1.75 0 0 1 1 14.25v-4.5C1 8.784 1.784 8 2.75 8h2.71l5.285-4.805a.752.752 0 0 1 .808-.13ZM10.5 5.445l-4.245 3.86a.748.748 0 0 1-.505.195h-3a.25.25 0 0 0-.25.25v4.5c0 .138.112.25.25.25h3c.187 0 .367.069.505.195l4.245 3.86z" />
+      <path d="M16.243 7.757a.75.75 0 1 0-1.061 1.061 4.5 4.5 0 0 1 0 6.364.75.75 0 0 0 1.06 1.06 6 6 0 0 0 0-8.485Z" />
+    </g>
+  </svg>
+);
diff --git a/src/renderer/components/icons/VolumeUpIcon.tsx b/src/renderer/components/icons/VolumeUpIcon.tsx
new file mode 100644
index 000000000..84aac91a4
--- /dev/null
+++ b/src/renderer/components/icons/VolumeUpIcon.tsx
@@ -0,0 +1,16 @@
+import type { FC } from 'react';
+
+export const VolumeUpIcon: FC = () => (
+  <svg
+    className="size-4"
+    xmlns="http://www.w3.org/2000/svg"
+    viewBox="0 0 24 24"
+    width="24"
+    height="24"
+    role="img"
+    aria-label="Volume Up Icon"
+  >
+    <path d="M11.553 3.064A.75.75 0 0 1 12 3.75v16.5a.75.75 0 0 1-1.255.555L5.46 16H2.75A1.75 1.75 0 0 1 1 14.25v-4.5C1 8.784 1.784 8 2.75 8h2.71l5.285-4.805a.752.752 0 0 1 .808-.13ZM10.5 5.445l-4.245 3.86a.748.748 0 0 1-.505.195h-3a.25.25 0 0 0-.25.25v4.5c0 .138.112.25.25.25h3c.187 0 .367.069.505.195l4.245 3.86Zm8.218-1.223a.75.75 0 0 1 1.06 0c4.296 4.296 4.296 11.26 0 15.556a.75.75 0 0 1-1.06-1.06 9.5 9.5 0 0 0 0-13.436.75.75 0 0 1 0-1.06Z" />
+    <path d="M16.243 7.757a.75.75 0 1 0-1.061 1.061 4.5 4.5 0 0 1 0 6.364.75.75 0 0 0 1.06 1.06 6 6 0 0 0 0-8.485Z" />
+  </svg>
+);
diff --git a/src/renderer/components/settings/SystemSettings.tsx b/src/renderer/components/settings/SystemSettings.tsx
index ab4672013..ab224cba4 100644
--- a/src/renderer/components/settings/SystemSettings.tsx
+++ b/src/renderer/components/settings/SystemSettings.tsx
@@ -1,12 +1,6 @@
 import { type FC, useContext } from 'react';
 
-import {
-  DashIcon,
-  DeviceDesktopIcon,
-  PlusIcon,
-  XCircleIcon,
-} from '@primer/octicons-react';
-
+import { DeviceDesktopIcon, SyncIcon } from '@primer/octicons-react';
 import {
   Box,
   Button,
@@ -22,8 +16,9 @@ import { AppContext, defaultSettings } from '../../context/App';
 import { OpenPreference } from '../../types';
 import { Constants } from '../../utils/constants';
 import { Checkbox } from '../fields/Checkbox';
-import { FieldLabel } from '../fields/FieldLabel';
 import { RadioGroup } from '../fields/RadioGroup';
+import { VolumeDownIcon } from '../icons/VolumeDownIcon';
+import { VolumeUpIcon } from '../icons/VolumeUpIcon';
 import { Title } from '../primitives/Title';
 
 export const SystemSettings: FC = () => {
@@ -84,30 +79,25 @@ export const SystemSettings: FC = () => {
           }
         />
 
-        <Checkbox
-          name="playSound"
-          label="Play sound"
-          checked={settings.playSound}
-          onChange={(evt) => updateSetting('playSound', evt.target.checked)}
-        />
-
-        <Box className="pl-6" hidden={!settings.playSound}>
+        <Box>
           <Stack
             direction="horizontal"
             gap="condensed"
             align="center"
             className="text-sm"
           >
-            <FieldLabel
-              name="notificationVolume"
-              label="Notification volume:"
+            <Checkbox
+              name="playSound"
+              label="Play sound"
+              checked={settings.playSound}
+              onChange={(evt) => updateSetting('playSound', evt.target.checked)}
             />
 
-            <ButtonGroup className="ml-2">
+            <ButtonGroup className="ml-2" hidden={!settings.playSound}>
               <IconButton
                 aria-label="Volume down"
                 size="small"
-                icon={DashIcon}
+                icon={VolumeDownIcon}
                 unsafeDisableTooltip={true}
                 onClick={() => {
                   const newVolume = Math.max(
@@ -126,7 +116,7 @@ export const SystemSettings: FC = () => {
               <IconButton
                 aria-label="Volume up"
                 size="small"
-                icon={PlusIcon}
+                icon={VolumeUpIcon}
                 unsafeDisableTooltip={true}
                 onClick={() => {
                   const newVolume = Math.min(
@@ -142,7 +132,7 @@ export const SystemSettings: FC = () => {
                 aria-label="Reset volume"
                 size="small"
                 variant="danger"
-                icon={XCircleIcon}
+                icon={SyncIcon}
                 unsafeDisableTooltip={true}
                 onClick={() => {
                   updateSetting(
diff --git a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
index 1998b66de..84662142f 100644
--- a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
+++ b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
@@ -1128,30 +1128,7 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
             </label>
           </div>
           <div
-            class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv text-sm"
-            data-align="center"
-            data-direction="horizontal"
-            data-gap="condensed"
-            data-justify="start"
-            data-padding="none"
-            data-wrap="nowrap"
-          >
-            <input
-              checked=""
-              class="size-4 rounded-sm cursor-pointer"
-              data-testid="checkbox-playSound"
-              id="playSound"
-              type="checkbox"
-            />
-            <label
-              class="font-medium text-gitify-font cursor-pointer"
-              for="playSound"
-            >
-              Play sound
-            </label>
-          </div>
-          <div
-            class="Box-sc-g0xbh4-0 pl-6"
+            class="Box-sc-g0xbh4-0"
           >
             <div
               class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv text-sm"
@@ -1162,12 +1139,29 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
               data-padding="none"
               data-wrap="nowrap"
             >
-              <label
-                class="mr-3 font-medium cursor-pointer"
-                for="notificationVolume"
+              <div
+                class="Stack__StyledStack-sc-x3xa2i-0 cRiRbv text-sm"
+                data-align="center"
+                data-direction="horizontal"
+                data-gap="condensed"
+                data-justify="start"
+                data-padding="none"
+                data-wrap="nowrap"
               >
-                Notification volume:
-              </label>
+                <input
+                  checked=""
+                  class="size-4 rounded-sm cursor-pointer"
+                  data-testid="checkbox-playSound"
+                  id="playSound"
+                  type="checkbox"
+                />
+                <label
+                  class="font-medium text-gitify-font cursor-pointer"
+                  for="playSound"
+                >
+                  Play sound
+                </label>
+              </div>
               <div
                 class="ButtonGroup-sc-1gxhls1-0 ePLgSl ml-2"
               >
@@ -1184,20 +1178,24 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
                   type="button"
                 >
                   <svg
-                    aria-hidden="true"
-                    class="octicon octicon-dash"
-                    display="inline-block"
-                    fill="currentColor"
-                    focusable="false"
-                    height="16"
-                    overflow="visible"
-                    style="vertical-align: text-bottom;"
-                    viewBox="0 0 16 16"
-                    width="16"
+                    aria-label="Volume Down Icon"
+                    class="size-4"
+                    height="24"
+                    role="img"
+                    viewBox="0 0 24 24"
+                    width="24"
+                    xmlns="http://www.w3.org/2000/svg"
                   >
-                    <path
-                      d="M2 7.75A.75.75 0 0 1 2.75 7h10a.75.75 0 0 1 0 1.5h-10A.75.75 0 0 1 2 7.75Z"
-                    />
+                    <g
+                      transform="translate(2, 0)"
+                    >
+                      <path
+                        d="M11.553 3.064A.75.75 0 0 1 12 3.75v16.5a.75.75 0 0 1-1.255.555L5.46 16H2.75A1.75 1.75 0 0 1 1 14.25v-4.5C1 8.784 1.784 8 2.75 8h2.71l5.285-4.805a.752.752 0 0 1 .808-.13ZM10.5 5.445l-4.245 3.86a.748.748 0 0 1-.505.195h-3a.25.25 0 0 0-.25.25v4.5c0 .138.112.25.25.25h3c.187 0 .367.069.505.195l4.245 3.86z"
+                      />
+                      <path
+                        d="M16.243 7.757a.75.75 0 1 0-1.061 1.061 4.5 4.5 0 0 1 0 6.364.75.75 0 0 0 1.06 1.06 6 6 0 0 0 0-8.485Z"
+                      />
+                    </g>
                   </svg>
                 </button>
                 <button
@@ -1237,19 +1235,19 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
                   type="button"
                 >
                   <svg
-                    aria-hidden="true"
-                    class="octicon octicon-plus"
-                    display="inline-block"
-                    fill="currentColor"
-                    focusable="false"
-                    height="16"
-                    overflow="visible"
-                    style="vertical-align: text-bottom;"
-                    viewBox="0 0 16 16"
-                    width="16"
+                    aria-label="Volume Up Icon"
+                    class="size-4"
+                    height="24"
+                    role="img"
+                    viewBox="0 0 24 24"
+                    width="24"
+                    xmlns="http://www.w3.org/2000/svg"
                   >
                     <path
-                      d="M7.75 2a.75.75 0 0 1 .75.75V7h4.25a.75.75 0 0 1 0 1.5H8.5v4.25a.75.75 0 0 1-1.5 0V8.5H2.75a.75.75 0 0 1 0-1.5H7V2.75A.75.75 0 0 1 7.75 2Z"
+                      d="M11.553 3.064A.75.75 0 0 1 12 3.75v16.5a.75.75 0 0 1-1.255.555L5.46 16H2.75A1.75 1.75 0 0 1 1 14.25v-4.5C1 8.784 1.784 8 2.75 8h2.71l5.285-4.805a.752.752 0 0 1 .808-.13ZM10.5 5.445l-4.245 3.86a.748.748 0 0 1-.505.195h-3a.25.25 0 0 0-.25.25v4.5c0 .138.112.25.25.25h3c.187 0 .367.069.505.195l4.245 3.86Zm8.218-1.223a.75.75 0 0 1 1.06 0c4.296 4.296 4.296 11.26 0 15.556a.75.75 0 0 1-1.06-1.06 9.5 9.5 0 0 0 0-13.436.75.75 0 0 1 0-1.06Z"
+                    />
+                    <path
+                      d="M16.243 7.757a.75.75 0 1 0-1.061 1.061 4.5 4.5 0 0 1 0 6.364.75.75 0 0 0 1.06 1.06 6 6 0 0 0 0-8.485Z"
                     />
                   </svg>
                 </button>
@@ -1267,7 +1265,7 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
                 >
                   <svg
                     aria-hidden="true"
-                    class="octicon octicon-x-circle"
+                    class="octicon octicon-sync"
                     display="inline-block"
                     fill="currentColor"
                     focusable="false"
@@ -1278,7 +1276,7 @@ exports[`renderer/routes/Settings.tsx should render itself & its children 1`] =
                     width="16"
                   >
                     <path
-                      d="M2.344 2.343h-.001a8 8 0 0 1 11.314 11.314A8.002 8.002 0 0 1 .234 10.089a8 8 0 0 1 2.11-7.746Zm1.06 10.253a6.5 6.5 0 1 0 9.108-9.275 6.5 6.5 0 0 0-9.108 9.275ZM6.03 4.97 8 6.94l1.97-1.97a.749.749 0 0 1 1.275.326.749.749 0 0 1-.215.734L9.06 8l1.97 1.97a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L8 9.06l-1.97 1.97a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L6.94 8 4.97 6.03a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018Z"
+                      d="M1.705 8.005a.75.75 0 0 1 .834.656 5.5 5.5 0 0 0 9.592 2.97l-1.204-1.204a.25.25 0 0 1 .177-.427h3.646a.25.25 0 0 1 .25.25v3.646a.25.25 0 0 1-.427.177l-1.38-1.38A7.002 7.002 0 0 1 1.05 8.84a.75.75 0 0 1 .656-.834ZM8 2.5a5.487 5.487 0 0 0-4.131 1.869l1.204 1.204A.25.25 0 0 1 4.896 6H1.25A.25.25 0 0 1 1 5.75V2.104a.25.25 0 0 1 .427-.177l1.38 1.38A7.002 7.002 0 0 1 14.95 7.16a.75.75 0 0 1-1.49.178A5.5 5.5 0 0 0 8 2.5Z"
                     />
                   </svg>
                 </button>