From 8b3aea4fb97e730b20d370ad71762d92884a20b2 Mon Sep 17 00:00:00 2001 From: Adam Setch Date: Sun, 6 Oct 2024 07:37:56 -0400 Subject: [PATCH 1/4] 5.15.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 3993be1aa..7ceed00bd 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "gitify", - "version": "5.14.0", + "version": "5.15.0", "description": "GitHub notifications on your menu bar.", "main": "build/main.js", "scripts": { From ebb7ba87ab770af3ecac7a85d466ab46c816142b Mon Sep 17 00:00:00 2001 From: Adam Setch Date: Sun, 6 Oct 2024 07:46:39 -0400 Subject: [PATCH 2/4] build: simplify bug template Signed-off-by: Adam Setch --- .github/ISSUE_TEMPLATE/bug_report.yml | 25 +++---------------------- CONTRIBUTING.md | 1 - 2 files changed, 3 insertions(+), 23 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 143e5bd98..f3c789352 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -32,31 +32,12 @@ body: validations: required: true - - type: dropdown - id: environment-version + - type: input + id: app-version attributes: label: Gitify Version description: What version of Gitify are you using? - options: - - 5.14.0 - - 5.13.1 - - 5.13.0 - - 5.12.1 - - 5.12.0 - - 5.11.0 - - 5.10.0 - - 5.9.0 - - 5.8.1 - - 5.8.0 - - 5.7.0 - - 5.6.0 - - 5.5.0 - - 5.4.0 - - 5.3.0 - - 5.2.0 - - 5.1.0 - - 5.0.0 - - Other + placeholder: 5.x.x validations: required: true diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 875ed29b7..6e29b0dc0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -59,7 +59,6 @@ The release process is automated. Follow the steps below. 3. Create a [new **draft** release][github-new-release]. Set the tag version to something with the format of `v1.2.3`. Save as a **draft** before moving to the next step 4. Create a branch that starts with `release/vX.X.X` (ie. `release/v1.2.3`). In this branch you need to: * Run `pnpm version Date: Sun, 6 Oct 2024 08:09:49 -0400 Subject: [PATCH 3/4] build: fix jest coverage Signed-off-by: Adam Setch --- jest.config.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/jest.config.ts b/jest.config.ts index d15905628..fe8cbe6a4 100644 --- a/jest.config.ts +++ b/jest.config.ts @@ -5,6 +5,7 @@ const config: Config = { setupFiles: ['/src/renderer/__helpers__/setupEnvVars.js'], testEnvironment: 'jsdom', collectCoverage: true, + collectCoverageFrom: ['src/**/*', '!**/__snapshots__/**'], moduleNameMapper: { // Force CommonJS build for http adapter to be available. // via https://github.com/axios/axios/issues/5101#issuecomment-1276572468 From 12d8ac324d50743485e79c72e947860400867477 Mon Sep 17 00:00:00 2001 From: Adam Setch Date: Sun, 6 Oct 2024 08:10:01 -0400 Subject: [PATCH 4/4] refactor: add types Signed-off-by: Adam Setch --- scripts/notarize.js | 4 ++++ scripts/remove-unused-locales.js | 8 +++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/scripts/notarize.js b/scripts/notarize.js index 58d40d62e..f8635385d 100644 --- a/scripts/notarize.js +++ b/scripts/notarize.js @@ -1,4 +1,5 @@ const { notarize } = require('@electron/notarize'); +const { AfterPackContext } = require('electron-builder'); const packageJson = require('../package.json'); const appBundleId = packageJson.build.appId; @@ -8,6 +9,9 @@ function logNotarizingProgress(msg) { console.log(` • notarizing ${msg}`); } +/** + * @param {AfterPackContext} context + */ const notarizeApp = async (context) => { const { electronPlatformName, appOutDir } = context; const appName = context.packager.appInfo.productFilename; diff --git a/scripts/remove-unused-locales.js b/scripts/remove-unused-locales.js index c5494d58a..fadaa9bbc 100644 --- a/scripts/remove-unused-locales.js +++ b/scripts/remove-unused-locales.js @@ -1,10 +1,14 @@ const path = require('node:path'); const fs = require('node:fs'); +const { AfterPackContext } = require('electron-builder'); const packageJson = require('../package.json'); const electronLanguages = packageJson.build.electronLanguages; -exports.default = async (context) => { +/** + * @param {AfterPackContext} context + */ +const removeLocales = async (context) => { const appName = context.packager.appInfo.productFilename; const appOutDir = context.appOutDir; const platform = context.electronPlatformName; @@ -39,3 +43,5 @@ exports.default = async (context) => { } } }; + +exports.default = removeLocales;