Merge pull request #241 from github/lcartey/20-12-improve-perf

Rule 20.12: Improve performance

Author: lcartey

c/misra/src/rules/RULE-20-12/MacroParameterUsedAsHashOperand.ql

@@ -19,7 +19,7 @@ import codingstandards.cpp.Macro
 
 from FunctionLikeMacro m, MacroInvocation mi, int i, string expanded, string param
 where
-  not isExcluded(m, Preprocessor2Package::macroParameterUsedAsHashOperandQuery()) and
+  not isExcluded(mi, Preprocessor2Package::macroParameterUsedAsHashOperandQuery()) and
   mi = m.getAnInvocation() and
   param = m.getParameter(i) and
   (
@@ -31,9 +31,6 @@ where
   // This check ensure there is an expansion that is used.
   expanded = mi.getExpandedArgument(i) and
   not expanded = "" and
-  exists(Macro furtherExpandedMacro |
-    mi.getUnexpandedArgument(i).matches(furtherExpandedMacro.getName() + "%")
-  )
+  not mi.getUnexpandedArgument(i) = mi.getExpandedArgument(i)
 select m,
-  "Macro " + m.getName() + " contains use of parameter " + m.getParameter(i) +
-    " used in multiple contexts."
+  "Macro " + m.getName() + " contains use of parameter " + param + " used in multiple contexts."

change_notes/2023-03-07-20-12-perf.md

@@ -0,0 +1 @@
+ * `Rule 20.12` - the performance of this rule has been improved.