Exclude conditions in uninitialized templates

The type of conditions in uninitialized templates is unknown
which leads to false positives.

Author: rvermeulen

cpp/common/src/codingstandards/cpp/rules/nonbooleaniterationstmt/NonBooleanIterationStmt.qll

@@ -18,6 +18,8 @@ query predicate problems(Loop loopStmt, string message) {
     not explicitConversionType instanceof BoolType and
     //exclude any generated conditions
     not condition.isCompilerGenerated() and
+    // exclude any conditions in uninstantiated templates, because their type will be unknown.
+    not condition.isFromUninstantiatedTemplate(_) and
     message = "Iteration condition has non boolean type " + explicitConversionType + "."
   )
 }

cpp/common/test/rules/nonbooleaniterationstmt/test.cpp

@@ -41,4 +41,17 @@ class ClassC {
     if (!d.empty()) { // COMPLIANT
     }
   }
-};
+};
+
+#include <vector>
+template <typename T> void test_fp_reported_in_10a(std::vector<T> &p1) {
+  for (typename std::vector<T>::iterator it = p1.begin(); it != p1.end();
+       ++it) { // COMPLIANT
+    (*it)++;
+  }
+}
+
+void test_fp_reported_in_10b() {
+  std::vector<int> vl1;
+  test_fp_reported_in_10a(vl1);
+}