Merge branch 'main' into jsinglet/bump-workflows

Author: jsinglet

.vscode/tasks.json

@@ -185,13 +185,11 @@
             "type": "pickString",
             "options": [
                 "Allocations",
-                "Banned",
                 "BannedFunctions",
+                "BannedLibraries",
                 "BannedSyntax",
                 "BannedTypes",
                 "Classes",
-                "Classes",
-                "Classes",
                 "Comments",
                 "Contracts1",
                 "Concurrency",

c/cert/src/rules/ENV33-C/DoNotCallSystem.ql

@@ -7,7 +7,7 @@
  * @problem.severity error
  * @tags external/cert/id/env33-c
  *       security
- *       external/cert/obligtion/rule
+ *       external/cert/obligation/rule
  */
 
 import cpp

c/cert/src/rules/EXP37-C/CallPOSIXOpenWithCorrectArgumentCount.md

@@ -1,6 +1,6 @@
 /**
  * @id c/cert/call-posix-open-with-correct-argument-count
- * @name EXP37-C: Pass the correct number of arguments to the POSIX open function.
+ * @name EXP37-C: Pass the correct number of arguments to the POSIX open function
  * @description A third argument should be passed to the POSIX function open() when and only when
  *              creating a new file.
  * @kind problem

c/cert/src/rules/EXP37-C/CallPOSIXOpenWithCorrectArgumentCount.ql

@@ -1,6 +1,6 @@
 /**
  * @id c/cert/do-not-call-functions-with-incompatible-arguments
- * @name EXP37-C: Do not pass arguments with an incompatible count or type to a function.
+ * @name EXP37-C: Do not pass arguments with an incompatible count or type to a function
  * @description The arguments passed to a function must be compatible with the function's
  *              parameters.
  * @kind problem

c/cert/src/rules/EXP37-C/DoNotCallFunctionsWithIncompatibleArguments.md

@@ -1,7 +1,8 @@
 /**
  * @id c/cert/do-not-alternately-io-from-a-stream-without-positioning
  * @name FIO39-C: Do not alternately input and output from a stream without an intervening flush or positioning call
- * @description 
+ * @description Do not alternately input and output from a stream without an intervening flush or
+ *              positioning call. This may result in undefined behavior.
  * @kind problem
  * @precision very-high
  * @problem.severity error

c/cert/src/rules/EXP37-C/DoNotCallFunctionsWithIncompatibleArguments.ql

@@ -1,7 +1,8 @@
 /**
  * @id c/cert/close-files-when-they-are-no-longer-needed
  * @name FIO42-C: Close files when they are no longer needed
- * @description 
+ * @description Open files must be closed before the lifetime of the last pointer to the file-object
+ *              has ended to prevent resource exhaustion and data loss issues.
  * @kind problem
  * @precision very-high
  * @problem.severity error

c/cert/src/rules/FIO39-C/DoNotAlternatelyIOFromAStreamWithoutPositioning.ql

@@ -1,7 +1,7 @@
 /**
  * @id c/cert/undefined-behavior-accessing-a-closed-file
  * @name FIO46-C: Do not access a closed file
- * @description Do not access a closed file
+ * @description Do not access a closed file.
  * @kind problem
  * @precision high
  * @problem.severity error

c/cert/src/rules/FIO42-C/CloseFilesWhenTheyAreNoLongerNeeded.ql

@@ -3,7 +3,7 @@
  * @name RULE-13-3: A full expression containing an increment (++) or decrement (--) operator should have no other
  * @description A full expression containing an increment (++) or decrement (--) operator should
  *              have no other potential side effects other than that caused by the increment or
- *              decrement operator
+ *              decrement operator.
  * @kind problem
  * @precision very-high
  * @problem.severity warning

c/cert/src/rules/FIO46-C/UndefinedBehaviorAccessingAClosedFile.ql

@@ -1,7 +1,7 @@
 /**
  * @id c/misra/file-used-after-closed
  * @name RULE-22-6: The value of a pointer to a FILE shall not be used after the associated stream has been closed
- * @description A closed FILE is accessed
+ * @description A closed FILE is accessed.
  * @kind problem
  * @precision very-high
  * @problem.severity error

c/misra/src/rules/RULE-13-3/SideEffectAndCrementInFullExpression.ql

@@ -2,7 +2,7 @@
  * @id c/misra/eof-shall-be-compared-with-unmodified-return-values
  * @name RULE-22-7: The macro EOF shall only be compared with the unmodified return value from any Standard Library
  * @description The macro EOF shall only be compared with the unmodified return value from any
- *              Standard Library function capable of returning EOF
+ *              Standard Library function capable of returning EOF.
  * @kind problem
  * @precision high
  * @problem.severity error

c/misra/src/rules/RULE-22-6/FileUsedAfterClosed.ql

@@ -3,7 +3,7 @@
  * @name RULE-4-12: Dynamic memory allocation shall not be used
  * @description Using dynamic memory allocation and deallocation can result to undefined behavior.
  *              This query is for the Standard Library Implementation. Any implementation outside it
- *              will require a separate query under the same directive
+ *              will require a separate query under the same directive.
  * @kind problem
  * @precision very-high
  * @problem.severity error

c/misra/src/rules/RULE-22-7/EofShallBeComparedWithUnmodifiedReturnValues.ql

@@ -10,7 +10,6 @@
  * @tags external/misra/id/rule-4-8
  *       readability
  *       maintainability
- *       readability
  *       external/misra/obligation/advisory
  */
 

c/misra/src/rules/RULE-4-12/StdLibDynamicMemoryAllocationUsed.ql

@@ -1,4 +1,4 @@
-- description: AUTOSAR C++14 Guidelines 19-11 (Advisory)
+- description: AUTOSAR C++14 Guidelines 20-11 (Advisory)
 - qlpack: autosar-cpp-coding-standards
 - include:
     kind:

c/misra/src/rules/RULE-4-8/ObjectWithNoPointerDereferenceShouldBeOpaque.ql

@@ -1,4 +1,4 @@
-- description: AUTOSAR C++14 Guidelines 19-11 (Audit)
+- description: AUTOSAR C++14 Guidelines 20-11 (Audit)
 - qlpack: autosar-cpp-coding-standards
 - include:
     kind:

change_notes/2022-08-17-add-single-translation-unit-suites.md

@@ -1,4 +1,4 @@
-- description: AUTOSAR C++14 Guidelines 19-11 (Default)
+- description: AUTOSAR C++14 Guidelines 20-11 (Default)
 - qlpack: autosar-cpp-coding-standards
 - include:
     kind:

change_notes/2022-08-17-fix-reported-fp-for-a13-2-2.md

@@ -1,4 +1,4 @@
-- description: AUTOSAR C++14 Guidelines 19-11 (Required)
+- description: AUTOSAR C++14 Guidelines 20-11 (Required)
 - qlpack: autosar-cpp-coding-standards
 - include:
     kind:

change_notes/2022-08-17-fix-reported-fp-for-a7-1-1.md

@@ -0,0 +1,12 @@
+- description: AUTOSAR C++14 Guidelines 20-11 (Single Translation Unit)
+- qlpack: autosar-cpp-coding-standards
+- include:
+    kind:
+    - problem
+    - path-problem
+    tags contain:
+    - scope/single-translation-unit
+- exclude:
+    tags contain:
+    - external/autosar/audit
+    - external/autosar/default-disabled

cpp/autosar/src/codeql-suites/autosar-advisory.qls

@@ -9,6 +9,7 @@
  * @tags external/autosar/id/a0-4-2
  *       correctness
  *       readability
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/codeql-suites/autosar-audit.qls

@@ -8,6 +8,7 @@
  * @tags external/autosar/id/a11-3-1
  *       correctness
  *       security
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/codeql-suites/autosar-default.qls

@@ -14,6 +14,7 @@
  * @tags external/autosar/id/a17-0-1
  *       correctness
  *       maintainability
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/codeql-suites/autosar-required.qls

@@ -9,6 +9,7 @@
  * @tags external/autosar/id/a18-0-1
  *       correctness
  *       readability
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/codeql-suites/autosar-single-translation-unit.qls

@@ -14,6 +14,7 @@
  * @problem.severity warning
  * @tags external/autosar/id/a18-0-3
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A0-4-2/TypeLongDoubleUsed.ql

@@ -9,6 +9,7 @@
  * @problem.severity warning
  * @tags external/autosar/id/a18-0-3
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A11-3-1/FriendDeclarationsUsed.ql

@@ -8,6 +8,7 @@
  * @problem.severity warning
  * @tags external/autosar/id/a18-0-3
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A17-0-1/ReservedIdentifiersMacrosAndFunctionsAreDefinedRedefinedOrUndefined.ql

@@ -8,6 +8,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a18-1-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A18-0-1/CLibraryFacilitiesNotAccessedThroughCPPLibraryHeaders.ql

@@ -9,6 +9,7 @@
  * @problem.severity warning
  * @tags external/autosar/id/a18-1-2
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A18-0-3/LocaleFunctionsUsed.ql

@@ -7,6 +7,7 @@
  * @problem.severity warning
  * @tags external/autosar/id/a18-1-3
  *       maintainability
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A18-0-3/LocaleMacrosUsed.ql

@@ -8,6 +8,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a18-5-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A18-0-3/LocaleTypeLConvUsed.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a18-9-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A18-1-1/CStyleArraysUsed.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a2-11-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/design
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated

cpp/autosar/src/rules/A18-1-2/VectorboolSpecializationUsed.ql

@@ -8,6 +8,7 @@
  * @tags external/autosar/id/a2-13-3
  *       correctness
  *       readability
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/architecture
  *       external/autosar/allocated-target/design
  *       external/autosar/allocated-target/implementation

cpp/autosar/src/rules/A18-1-3/AutoPtrTypeUsed.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a26-5-1
  *       security
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A18-5-1/FunctionsMallocCallocReallocAndFreeUsed.ql

@@ -8,6 +8,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a5-16-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A18-9-1/BindUsed.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a5-2-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/advisory

cpp/autosar/src/rules/A2-11-1/VolatileKeywordUsed.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a5-2-2
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A2-13-3/TypeWcharTUsed.ql

@@ -8,6 +8,7 @@
  * @tags external/autosar/id/a5-2-4
  *       correctness
  *       security
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A26-5-1/PseudorandomNumbersGeneratedUsingRand.ql

@@ -8,6 +8,7 @@
  * @tags external/autosar/id/a6-6-1
  *       correctness
  *       security
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A5-16-1/TernaryConditionalOperatorUsedAsSubExpression.ql

@@ -35,5 +35,6 @@ where
       cond = " points to an object"
     else cond = " is used for an object"
   ) and
-  not exists(LambdaExpression lc | lc.getACapture().getField() = v)
+  not exists(LambdaExpression lc | lc.getACapture().getField() = v) and
+  not v.isFromUninstantiatedTemplate(_)
 select v, "Non-constant variable " + v.getName() + cond + " and is not modified."

cpp/autosar/src/rules/A5-2-1/DynamicCastShouldNotBeUsed.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a7-1-4
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A5-2-2/TraditionalCStyleCastsUsed.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a7-1-6
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A5-2-4/ReinterpretCastUsed.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a7-4-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A6-6-1/GotoStatementUsed.ql

@@ -8,6 +8,7 @@
  * @tags external/autosar/id/a8-4-1
  *       correctness
  *       security
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A7-1-1/DeclarationUnmodifiedObjectMissingConstSpecifier.ql

@@ -8,6 +8,7 @@
  * @problem.severity error
  * @tags external/autosar/id/a9-5-1
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A7-1-4/RegisterKeywordUsed.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @tags external/autosar/id/m17-0-5
  *       correctness
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required

cpp/autosar/src/rules/A7-1-6/TypedefSpecifierUsed.ql

@@ -8,6 +8,7 @@
  * @tags external/autosar/id/m18-0-3
  *       correctness
  *       security
+ *       scope/single-translation-unit
  *       external/autosar/allocated-target/implementation
  *       external/autosar/enforcement/automated
  *       external/autosar/obligation/required