Issue 18: exclude uninstantiated templates (#61)

* Fix issue 18: exclude uninstantiated templates

Author: mbaluda

change_notes/2022-08-17-fix-reported-fp-for-a7-1-1.md

@@ -0,0 +1,2 @@
+ - `A7-1-1` - `DeclarationUnmodifiedObjectMissingConstSpecifier.ql`:
+   -  Remove findings in uninstantiated Templates.

cpp/autosar/src/rules/A7-1-1/DeclarationUnmodifiedObjectMissingConstSpecifier.ql

@@ -35,5 +35,6 @@ where
       cond = " points to an object"
     else cond = " is used for an object"
   ) and
-  not exists(LambdaExpression lc | lc.getACapture().getField() = v)
+  not exists(LambdaExpression lc | lc.getACapture().getField() = v) and
+  not v.isFromUninstantiatedTemplate(_)
 select v, "Non-constant variable " + v.getName() + cond + " and is not modified."

cpp/autosar/test/rules/A7-1-1/test.cpp

@@ -39,9 +39,42 @@ class A7_1_1a final {
     m_ = a.m;
   }
   void Call() {
-    [this]() { std::cout << m_ << '\n'; }(); // COMPLIANT ignore lambdas
+    // ignore lambdas
+    [this]() { std::cout << m_ << '\n'; }(); // COMPLIANT
   }
 
 private:
   std::string m_;
 };
+
+template <typename T> class A7_1_1b final {
+public:
+  explicit A7_1_1b(int i) noexcept {
+    t_.Init(i);
+  } // t_ is modified here by Init
+private:
+  // ignore uninstantiated templates
+  T t_; // COMPLIANT
+};
+
+class A7_1_1bHelper {
+public:
+  void Init(int i) {}
+};
+
+class Issue18 {
+public:
+  template <typename T> void F(const T &s) {
+    // ignore uninstantiated templates
+    std::ostream ostr; // COMPLIANT
+    ostr << s;         // <= Modified here
+    return;
+  }
+};
+
+/// main
+int main(int, char **) noexcept {
+  new A7_1_1b<A7_1_1bHelper>(0);
+
+  (new Issue18)->F(0);
+}