EXP43-C: Replace != with not =

Nikita Kraiouchkine · lcartey · web-flow · commit 563e08409243 · 2023-02-15T16:08:23.000+01:00
Co-authored-by: Luke Cartey &lt;5377966+lcartey@users.noreply.github.com&gt;
diff --git a/c/cert/src/rules/EXP43-C/DoNotPassAliasedPointerToRestrictQualifiedParam.ql b/c/cert/src/rules/EXP43-C/DoNotPassAliasedPointerToRestrictQualifiedParam.ql
@@ -113,7 +113,7 @@ where
   not isExcluded(call, Pointers3Package::doNotPassAliasedPointerToRestrictQualifiedParamQuery()) and
   arg1 = call.getARestrictPtrArg() and
   arg2 = call.getAPtrArg() and
-  arg1 != arg2 and
+  not arg1 = arg2 and
   exists(PointerValueToRestrictArgConfig config, Expr source1, Expr source2 |
     config.hasFlow(DataFlow::exprNode(source1), DataFlow::exprNode(arg1.getAChild*())) and
     (

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ where`
`113`	`113`	`not isExcluded(call, Pointers3Package::doNotPassAliasedPointerToRestrictQualifiedParamQuery()) and`
`114`	`114`	`arg1 = call.getARestrictPtrArg() and`
`115`	`115`	`arg2 = call.getAPtrArg() and`
`116`		`- arg1 != arg2 and`
	`116`	`+ not arg1 = arg2 and`
`117`	`117`	`exists(PointerValueToRestrictArgConfig config, Expr source1, Expr source2 \|`
`118`	`118`	`config.hasFlow(DataFlow::exprNode(source1), DataFlow::exprNode(arg1.getAChild*())) and`
`119`	`119`	`(`