Limit operands to integer types

rvermeulen · rvermeulen · commit 446ff6a43e0d · 2024-02-08T15:13:22.000-08:00
diff --git a/cpp/common/src/codingstandards/cpp/Overflow.qll b/cpp/common/src/codingstandards/cpp/Overflow.qll
@@ -14,6 +14,7 @@ import semmle.code.cpp.valuenumbering.GlobalValueNumbering
  */
 class InterestingOverflowingOperation extends Operation {
   InterestingOverflowingOperation() {
+    forex(Expr operand | operand = this.getAnOperand() | operand.getUnderlyingType() instanceof IntegralType) and
     // Might overflow or underflow
     (
       exprMightOverflowNegatively(this)

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ import semmle.code.cpp.valuenumbering.GlobalValueNumbering`
`14`	`14`	`*/`
`15`	`15`	`class InterestingOverflowingOperation extends Operation {`
`16`	`16`	`InterestingOverflowingOperation() {`
	`17`	`+ forex(Expr operand \| operand = this.getAnOperand() \| operand.getUnderlyingType() instanceof IntegralType) and`
`17`	`18`	`// Might overflow or underflow`
`18`	`19`	`(`
`19`	`20`	`exprMightOverflowNegatively(this)`