Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 801d033

Browse files
Making sure to call base methods appropriately
1 parent ac93c49 commit 801d033

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

src/GitHub.Api/Tasks/ActionTask.cs

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,13 @@ public override void RunSynchronously()
3535
{
3636
foreach (var task in queuedTasks)
3737
task.Start();
38-
base.RunSynchronously();
3938
}
4039
else
4140
{
4241
aggregateTask.TrySetResult(true);
4342
}
43+
44+
base.RunSynchronously();
4445
}
4546

4647
protected override void Schedule()
@@ -49,12 +50,13 @@ protected override void Schedule()
4950
{
5051
foreach (var task in queuedTasks)
5152
task.Start();
52-
base.Schedule();
5353
}
5454
else
5555
{
5656
aggregateTask.TrySetResult(true);
5757
}
58+
59+
base.Schedule();
5860
}
5961

6062
private void InvokeFinishOnlyOnSuccess(ITask task, bool success, Exception ex)
@@ -132,26 +134,29 @@ public override List<TResult> RunSynchronously()
132134
if (queuedTasks.Any())
133135
{
134136
foreach (var task in queuedTasks)
135-
task.Start();
136-
return base.RunSynchronously();
137+
task.Start();
138+
}
139+
else
140+
{
141+
aggregateTask.TrySetResult(new List<TResult>());
137142
}
138143

139-
aggregateTask.TrySetResult(new List<TResult>());
140-
return Result;
144+
return base.RunSynchronously();
141145
}
142146

143147
protected override void Schedule()
144148
{
145149
if (queuedTasks.Any())
146150
{
147151
foreach (var task in queuedTasks)
148-
task.Start();
149-
base.Schedule();
152+
task.Start();
150153
}
151154
else
152155
{
153156
aggregateTask.TrySetResult(new List<TResult>());
154157
}
158+
159+
base.Schedule();
155160
}
156161

157162
private void InvokeFinishOnlyOnSuccess(ITask<TTaskResult> task, TTaskResult result, bool success, Exception ex)

0 commit comments

Comments
 (0)