Ignore case when comparing username

StanleyGoldman · iAmWillShepherd · StanleyGoldman · commit 6fc796469037 · 2018-11-06T17:31:27.000-05:00
Co-authored-by: iamwillshepherd &lt;iamwillshepherd@users.noreply.github.com&gt;
diff --git a/src/GitHub.Api/Application/ApiClient.cs b/src/GitHub.Api/Application/ApiClient.cs
@@ -255,7 +255,7 @@ private GitHubUser GetValidatedGitHubUser(Connection keychainConnection, IKeycha
                 {
                     var login = ret.Output[1];
 
-                    if (login != keychainConnection.Username)
+                    if (!string.Equals(login, keychainConnection.Username, StringComparison.InvariantCultureIgnoreCase))
                     {
                         logger.Trace("LoadKeychainInternal: Api username does not match");
                         throw new TokenUsernameMismatchException(keychainConnection.Username, login);

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ private GitHubUser GetValidatedGitHubUser(Connection keychainConnection, IKeycha`
`255`	`255`	`{`
`256`	`256`	`var login = ret.Output[1];`
`257`	`257`
`258`		`- if (login != keychainConnection.Username)`
	`258`	`+ if (!string.Equals(login, keychainConnection.Username, StringComparison.InvariantCultureIgnoreCase))`
`259`	`259`	`{`
`260`	`260`	`logger.Trace("LoadKeychainInternal: Api username does not match");`
`261`	`261`	`throw new TokenUsernameMismatchException(keychainConnection.Username, login);`