Skip to content

Commit 8856e4e

Browse files
committed
Addressed PR comments
1 parent ae13c19 commit 8856e4e

File tree

3 files changed

+24
-14
lines changed

3 files changed

+24
-14
lines changed

src/main/java/pl/project13/core/GitCommitPropertyConstant.java

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -108,14 +108,15 @@ public class GitCommitPropertyConstant {
108108
*
109109
* Currently supported CIs:
110110
* <ul>
111+
* <li>AWS CodeBuild</li>
112+
* <li>Azure DevOps</li>
111113
* <li>Bamboo</li>
114+
* <li>Bitbucket Pipelines</li>
115+
* <li>GitHub Actions</li>
116+
* <li>Gitlab CI (Gitlab &gt;8.10 &amp; Gitlab CI &gt;0.5)</li>
112117
* <li>Hudson/Jenkins</li>
113118
* <li>TeamCity</li>
114119
* <li>Travis</li>
115-
* <li>Gitlab CI (Gitlab &gt;8.10 &amp; Gitlab CI &gt;0.5)</li>
116-
* <li>Azure DevOps</li>
117-
* <li>AWS CodeBuild</li>
118-
* <li>Bitbucket Pipelines</li>
119120
* </ul>
120121
*/
121122
public static final String BUILD_NUMBER = "build.number";
@@ -127,10 +128,11 @@ public class GitCommitPropertyConstant {
127128
*
128129
* Currently supported CIs:
129130
* <ul>
130-
* <li>TeamCity</li>
131-
* <li>Travis</li>
132-
* <li>Gitlab CI (Gitlab &gt;11.0)</li>
133-
* <li>AWS CodeBuild</li>
131+
* <li>AWS CodeBuild</li>
132+
* <li>Gitlab CI (Gitlab &gt;11.0)</li>
133+
* <li>GitHub Actions</li>
134+
* <li>TeamCity</li>
135+
* <li>Travis</li>
134136
* </ul>
135137
*/
136138
public static final String BUILD_NUMBER_UNIQUE = "build.number.unique";

src/main/java/pl/project13/core/cibuild/GitHubBuildServerData.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,12 @@ public static boolean isActiveServer(Map<String, String> env) {
4040

4141
@Override
4242
void loadBuildNumber(@Nonnull Properties properties) {
43-
String buildNumber = env.getOrDefault("GITHUB_RUN_NUMBER", "");
43+
String runId = env.getOrDefault("GITHUB_RUN_ID", "0");
44+
String runNumber = env.getOrDefault("GITHUB_RUN_NUMBER", "0");
45+
String runAttempt = env.getOrDefault("GITHUB_RUN_ATTEMPT", "0");
4446

45-
maybePut(properties, GitCommitPropertyConstant.BUILD_NUMBER, () -> buildNumber);
47+
maybePut(properties, GitCommitPropertyConstant.BUILD_NUMBER, () -> String.join(".", runNumber, runAttempt));
48+
maybePut(properties, GitCommitPropertyConstant.BUILD_NUMBER_UNIQUE, () -> String.join(".", runId, runNumber, runAttempt));
4649
}
4750

4851
@Override

src/test/java/pl/project13/core/cibuild/BuildServerDataProviderTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,23 +49,28 @@ void shouldVerifyOnGithubEnvironment() {
4949
@Test
5050
void shouldLoadBuildNumber() {
5151
Properties properties = new Properties();
52-
Map<String, String> environment = Map.of("GITHUB_RUN_NUMBER", "123");
52+
Map<String, String> environment = Map.of(
53+
"GITHUB_RUN_ID", "1658821493",
54+
"GITHUB_RUN_NUMBER", "123",
55+
"GITHUB_RUN_ATTEMPT", "1");
5356
GitHubBuildServerData provider = new GitHubBuildServerData(new DummyLogInterface(), environment);
5457

5558
provider.loadBuildNumber(properties);
5659

57-
assertThat(properties).containsEntry(GitCommitPropertyConstant.BUILD_NUMBER, "123");
60+
assertThat(properties).containsEntry(GitCommitPropertyConstant.BUILD_NUMBER, "123.1");
61+
assertThat(properties).containsEntry(GitCommitPropertyConstant.BUILD_NUMBER_UNIQUE, "1658821493.123.1");
5862
}
5963

6064
@Test
61-
void shouldLoadBuildNumberAsEmptyIfNotAvailable() {
65+
void shouldLoadBuildNumberAsZerosIfNotAvailable() {
6266
Properties properties = new Properties();
6367
Map<String, String> environment = Map.of();
6468
GitHubBuildServerData provider = new GitHubBuildServerData(new DummyLogInterface(), environment);
6569

6670
provider.loadBuildNumber(properties);
6771

68-
assertThat(properties).containsEntry(GitCommitPropertyConstant.BUILD_NUMBER, "");
72+
assertThat(properties).containsEntry(GitCommitPropertyConstant.BUILD_NUMBER, "0.0");
73+
assertThat(properties).containsEntry(GitCommitPropertyConstant.BUILD_NUMBER_UNIQUE, "0.0.0");
6974
}
7075

7176
@Test

0 commit comments

Comments
 (0)