From 616fd2f11663491ea88ae012a297d268b32bdf0c Mon Sep 17 00:00:00 2001 From: TheSnoozer Date: Wed, 9 Jun 2021 20:18:24 +0200 Subject: [PATCH 1/5] https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/557: Drop support for Java 8, Java 9 and Java 10 --- .github/workflows/default-tests.yml | 16 ++++++++-------- core/pom.xml | 2 +- maven/pom.xml | 2 +- pom.xml | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/default-tests.yml b/.github/workflows/default-tests.yml index 6e773d33..35f2173d 100644 --- a/.github/workflows/default-tests.yml +++ b/.github/workflows/default-tests.yml @@ -8,11 +8,11 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - name: Set up JDK 8 + - name: Set up JDK 11 uses: actions/setup-java@v2 with: distribution: 'zulu' - java-version: 8 + java-version: 11 java-package: jdk - name: Cache local Maven repository uses: actions/cache@v2 @@ -30,7 +30,7 @@ jobs: strategy: matrix: java_allow_illegal_access: [false] - java_version: ['8', '9', '10', '11', '12', '13', '14', '15'] + java_version: ['11', '12', '13', '14', '15'] include: - java_version: '16' java_allow_illegal_access: true @@ -64,7 +64,7 @@ jobs: needs: checkstyle strategy: matrix: - java_version: ['8'] + java_version: ['11'] maven_version: ['3.0', '3.0.5', '3.1.1', '3.2.5', '3.3.9', '3.5.4', '3.6.3', '3.8.1'] steps: @@ -119,11 +119,11 @@ jobs: steps: - uses: actions/checkout@v2 - run: git checkout "${GITHUB_REF:11}" - - name: Set up JDK 8 + - name: Set up JDK 11 uses: actions/setup-java@v2 with: distribution: 'zulu' - java-version: 8 + java-version: 11 java-package: jdk - name: Cache local Maven repository uses: actions/cache@v2 @@ -142,11 +142,11 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Set up JDK 8 + - name: Set up JDK 11 uses: actions/setup-java@v2 with: distribution: 'zulu' - java-version: 8 + java-version: 11 java-package: jdk - name: Cache local Maven repository uses: actions/cache@v2 diff --git a/core/pom.xml b/core/pom.xml index 066be2cb..5a2136ce 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -15,7 +15,7 @@ UTF-8 UTF-8 - 1.8 + 11 5.12.0.202106070339-r 4.13.2 diff --git a/maven/pom.xml b/maven/pom.xml index 77ed1d21..40f32853 100644 --- a/maven/pom.xml +++ b/maven/pom.xml @@ -27,7 +27,7 @@ UTF-8 UTF-8 - 1.8 + 11 3.0 3.6.0 diff --git a/pom.xml b/pom.xml index 2aa86de3..5b9ff3ae 100644 --- a/pom.xml +++ b/pom.xml @@ -42,7 +42,7 @@ UTF-8 UTF-8 - 1.8 + 11 From 54efb28407369ff351924f50c9c8c4240e43864a Mon Sep 17 00:00:00 2001 From: TheSnoozer Date: Wed, 9 Jun 2021 20:24:38 +0200 Subject: [PATCH 2/5] https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/533: Maven 3.0.x has now reached its end of life. New plugin releases will require Maven 3.1 or later --- maven/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/maven/pom.xml b/maven/pom.xml index 40f32853..0d8fe8ce 100644 --- a/maven/pom.xml +++ b/maven/pom.xml @@ -29,7 +29,7 @@ 11 - 3.0 + 3.1.0-alpha-1 3.6.0 4.13.2 From 3081bccb5b002aec4f4fbdfab44148ff41a9a670 Mon Sep 17 00:00:00 2001 From: TheSnoozer Date: Thu, 10 Jun 2021 22:03:17 +0200 Subject: [PATCH 3/5] https://bugs.openjdk.java.net/browse/JDK-8212233 // https://issues.apache.org/jira/browse/MJAVADOC-562: attempt to ignore javadoc errors --- pom.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pom.xml b/pom.xml index 5b9ff3ae..88556e02 100644 --- a/pom.xml +++ b/pom.xml @@ -152,8 +152,17 @@ org.apache.maven.plugins maven-javadoc-plugin + false 8 + + + attach-javadocs + + jar + + + From a4ccf64d7445aea062a41ddfc11798cdc8a26e32 Mon Sep 17 00:00:00 2001 From: TheSnoozer Date: Thu, 10 Jun 2021 22:08:25 +0200 Subject: [PATCH 4/5] https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/533: drop maven 3.0.X from our test-matrix --- .github/workflows/default-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/default-tests.yml b/.github/workflows/default-tests.yml index 35f2173d..11f5d875 100644 --- a/.github/workflows/default-tests.yml +++ b/.github/workflows/default-tests.yml @@ -65,7 +65,7 @@ jobs: strategy: matrix: java_version: ['11'] - maven_version: ['3.0', '3.0.5', '3.1.1', '3.2.5', '3.3.9', '3.5.4', '3.6.3', '3.8.1'] + maven_version: ['3.1.1', '3.2.5', '3.3.9', '3.5.4', '3.6.3', '3.8.1'] steps: - uses: actions/checkout@v2 From 4c5f15f4439ed2685a61f012ec79440d4932d539 Mon Sep 17 00:00:00 2001 From: TheSnoozer Date: Thu, 10 Jun 2021 22:22:12 +0200 Subject: [PATCH 5/5] https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/557 / https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/533: Add a note on the readme that the plugin now requires Java 11 and drops maven 3.0.X (a 3.1.0-alpha-1 is now the minimal supported) --- README.md | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 0d902a2e..5b7da618 100644 --- a/README.md +++ b/README.md @@ -44,6 +44,7 @@ Plugin compatibility with Java | 2.2.X | Java 1.7 | | 3.0.0 | Java 1.8 | | 4.0.0 | Java 1.8 | +| 5.0.0 | Java 11 | Plugin compatibility with Maven @@ -52,19 +53,28 @@ Even though this plugin tries to be compatible with every Maven version there ar | Maven Version | Plugin Version | Notes | | --------------------------- | ---------------:|:---------------------------------------------------------------------------------------------------------------:| -| Maven 2.0.11 | up to 2.2.6 | Maven 2 is EOL, git-commit-id-plugin:1.0 doesn't work -- requires maven version 2.2.1 | -| Maven 2.2.1 | up to 2.2.6 | Maven 2 is EOL | -| Maven 3.0.X | any | git-commit-id-plugin:2.1.14, 2.1.15, 2.2.0, 2.2.1, 2.2.3 doesn't work -- requires maven version 3.1.1 | -| Maven 3.0.X | any | For git-commit-id-plugin 2.2.4 or higher: works, but failed to load class "org.slf4j.impl.StaticLoggerBinder" | | Maven 3.1.0 | any | git-commit-id-plugin:2.1.14, 2.1.15, 2.2.0, 2.2.1, 2.2.3 doesn't work -- requires maven version 3.1.1 | | Maven 3.3.1 | any | git-commit-id-plugin:2.1.14 doesn't work | | Maven 3.3.3 | any | git-commit-id-plugin:2.1.14 doesn't work | -| Maven 3.X.X | any | Any other non listed version here should work with any plugin version | +| Maven 3.X.X (3.0.X is EOL) | any | Any other non listed version here should work with any plugin version | Note: As an example -- this table should be read as: For `Maven 3.1.0` `any` Plugin Version should work, besides the ones listed in the `Notes` have the limitations listed. +Plugin compatibility with EOL Maven version +----------------------------- +End of life (EOL) Maven versions are no longer supported by Maven, nor this plugin. +The following information is made available for reference. + +| Maven Version | Plugin Version | Notes | +| --------------------------- | ---------------:|:---------------------------------------------------------------------------------------------------------------:| +| Maven 2.0.11 | up to 2.2.6 | Maven 2 is EOL, git-commit-id-plugin:1.0 doesn't work -- requires maven version 2.2.1 | +| Maven 2.2.1 | up to 2.2.6 | Maven 2 is EOL | +| Maven 3.0.X | up to 4.0.5 | git-commit-id-plugin:2.1.14, 2.1.15, 2.2.0, 2.2.1, 2.2.3 doesn't work -- requires maven version 3.1.1 | +| Maven 3.0.X | up to 4.0.5 | For git-commit-id-plugin 2.2.4 or higher: works, but failed to load class "org.slf4j.impl.StaticLoggerBinder" | + + Getting SNAPSHOT versions of the plugin --------------------------------------- If you really want to use **snapshots**, here's the repository they are deployed to.