Skip to content

Commit 76696dc

Browse files
author
TheSnoozer
committed
ensure all properties are generated
1 parent ff14fdc commit 76696dc

File tree

2 files changed

+20
-16
lines changed

2 files changed

+20
-16
lines changed

src/test/java/pl/project13/maven/git/GitCommitIdMojoIntegrationTest.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -65,19 +65,7 @@ public void shouldIncludeExpectedProperties(boolean useNativeGit) throws Excepti
6565

6666
// then
6767
Properties properties = targetProject.getProperties();
68-
69-
assertThat(properties).satisfies(new ContainsKeyCondition("git.branch"));
70-
assertThat(properties).satisfies(new ContainsKeyCondition("git.dirty"));
71-
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.id.full"));
72-
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.id.abbrev"));
73-
assertThat(properties).satisfies(new ContainsKeyCondition("git.build.user.name"));
74-
assertThat(properties).satisfies(new ContainsKeyCondition("git.build.user.email"));
75-
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.user.name"));
76-
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.user.email"));
77-
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.message.full"));
78-
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.message.short"));
79-
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.time"));
80-
assertThat(properties).satisfies(new ContainsKeyCondition("git.remote.origin.url"));
68+
assertGitPropertiesPresentInProject(properties);
8169
}
8270

8371
@Test

src/test/java/pl/project13/maven/git/GitIntegrationTest.java

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,24 +169,40 @@ public static void assertPropertyPresentAndEqual(
169169
assertThat(properties.getProperty(key)).isEqualTo(expected);
170170
}
171171

172+
/**
173+
* Ensures that the provided properties contain the properties the plugin can generate.
174+
* See also {@link pl.project13.core.GitCommitPropertyConstant}
175+
*
176+
* @param properties The properties that should be verified
177+
*/
172178
public static void assertGitPropertiesPresentInProject(Properties properties) {
173-
assertThat(properties).satisfies(new ContainsKeyCondition("git.build.time"));
174-
assertThat(properties).satisfies(new ContainsKeyCondition("git.build.host"));
175179
assertThat(properties).satisfies(new ContainsKeyCondition("git.branch"));
180+
assertThat(properties).satisfies(new ContainsKeyCondition("git.local.branch.ahead"));
181+
assertThat(properties).satisfies(new ContainsKeyCondition("git.local.branch.behind"));
182+
assertThat(properties).satisfies(new ContainsKeyCondition("git.dirty"));
176183
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.id.full"));
177184
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.id.abbrev"));
178185
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.id.describe"));
186+
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.id.describe-short"));
179187
assertThat(properties).satisfies(new ContainsKeyCondition("git.build.user.name"));
180188
assertThat(properties).satisfies(new ContainsKeyCondition("git.build.user.email"));
189+
assertThat(properties).satisfies(new ContainsKeyCondition("git.build.time"));
190+
assertThat(properties).satisfies(new ContainsKeyCondition("git.build.version"));
191+
assertThat(properties).satisfies(new ContainsKeyCondition("git.build.host"));
192+
// assertThat(properties).satisfies(new ContainsKeyCondition("git.build.number"));
193+
// assertThat(properties).satisfies(new ContainsKeyCondition("git.build.number.unique"));
181194
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.user.name"));
182195
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.user.email"));
183196
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.message.full"));
184197
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.message.short"));
185198
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.time"));
186-
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.committer.time"));
187199
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.author.time"));
200+
assertThat(properties).satisfies(new ContainsKeyCondition("git.commit.committer.time"));
188201
assertThat(properties).satisfies(new ContainsKeyCondition("git.remote.origin.url"));
202+
assertThat(properties).satisfies(new ContainsKeyCondition("git.tags"));
189203
assertThat(properties).satisfies(new ContainsKeyCondition("git.closest.tag.name"));
204+
// assertThat(properties).satisfies(new ContainsKeyCondition("git.tag"));
190205
assertThat(properties).satisfies(new ContainsKeyCondition("git.closest.tag.commit.count"));
206+
assertThat(properties).satisfies(new ContainsKeyCondition("git.total.commit.count"));
191207
}
192208
}

0 commit comments

Comments
 (0)