fix false positive when assigning an optional value to a field with a pointer type #11

Author: ghostiam

processor.go

@@ -33,12 +33,19 @@ func (c *processor) process(n ast.Node) (*Result, error) {
 	switch x := n.(type) {
 	case *ast.AssignStmt:
 		// Skip any assignment to the field.
-		for _, s := range x.Lhs {
+		for i, s := range x.Lhs {
 			c.filter.AddPos(s.Pos())
 
 			if se, ok := s.(*ast.StarExpr); ok {
 				c.filter.AddPos(se.X.Pos())
 			}
+
+			if len(x.Rhs) > i {
+				value := x.Rhs[i]
+				if hasPointerKeyWithoutPointerGetter(c.info, s, value) {
+					c.filter.AddPos(value.Pos())
+				}
+			}
 		}
 
 	case *ast.IncDecStmt:
@@ -52,6 +59,11 @@ func (c *processor) process(n ast.Node) (*Result, error) {
 			c.filter.AddPos(x.X.Pos())
 		}
 
+	case *ast.KeyValueExpr:
+		if hasPointerKeyWithoutPointerGetter(c.info, x.Key, x.Value) {
+			c.filter.AddPos(x.Value.Pos())
+		}
+
 	case *ast.CallExpr:
 		if !c.cfg.ReplaceFirstArgInAppend && len(x.Args) > 0 {
 			if v, ok := x.Fun.(*ast.Ident); ok && v.Name == "append" {
@@ -349,3 +361,22 @@ func getterResultHasPointer(info *types.Info, x ast.Expr, name string) (hasPoint
 
 	return false, false
 }
+
+func hasPointerKeyWithoutPointerGetter(info *types.Info, key ast.Expr, value ast.Expr) bool {
+	_, isPtr := info.TypeOf(key).(*types.Pointer)
+	if !isPtr {
+		return false
+	}
+
+	se, ok := value.(*ast.SelectorExpr)
+	if !ok {
+		return false
+	}
+
+	getterHasPointer, ok := getterResultHasPointer(info, se.X, se.Sel.Name)
+	if !ok {
+		return false
+	}
+
+	return !getterHasPointer
+}

protogetter.go

@@ -96,6 +96,7 @@ func Run(pass *analysis.Pass, cfg *Config) error {
 		(*ast.StarExpr)(nil),
 		(*ast.IncDecStmt)(nil),
 		(*ast.UnaryExpr)(nil),
+		(*ast.KeyValueExpr)(nil),
 	}
 
 	// Skip filtered files.

testdata/test.go

@@ -191,6 +191,18 @@ func testValid(t *proto.Test) {
 	// issue #12
 	data := make([]byte, 4)
 	_, _ = t.MyMarshal(data[4:])
+
+	// issue #11
+	var optBoolVar *bool
+	optBoolVar = t.OptBool
+	_ = optBoolVar
+
+	type structWithPtrField struct {
+		OptBool *bool
+	}
+	_ = structWithPtrField{
+		OptBool: t.OptBool,
+	}
 }
 
 // stubs

testdata/test.go.golden

@@ -192,6 +192,18 @@ func testValid(t *proto.Test) {
 	// issue #12
 	data := make([]byte, 4)
 	_, _ = t.MyMarshal(data[4:])
+
+	// issue #11
+	var optBoolVar *bool
+	optBoolVar = t.OptBool
+	_ = optBoolVar
+
+	type structWithPtrField struct {
+		OptBool *bool
+	}
+	_ = structWithPtrField{
+		OptBool: t.OptBool,
+	}
 }
 
 // stubs