Skip to content

Commit be0e350

Browse files
Fix HIP flag inconsistency & build docs (#10524)
* Fix inconsistency of HIP flags in cmake & make * Fix docs regarding GGML_HIP
1 parent 249cd93 commit be0e350

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,7 @@ vulkan-shaders-gen: ggml/src/ggml-vulkan/vulkan-shaders/vulkan-shaders-gen.cpp
752752

753753
endif # GGML_VULKAN
754754

755-
ifdef GGML_HIPBLAS
755+
ifdef GGML_HIP
756756
ifeq ($(wildcard /opt/rocm),)
757757
ROCM_PATH ?= /usr
758758
AMDGPU_TARGETS ?= $(shell $(shell which amdgpu-arch))
@@ -807,7 +807,7 @@ ggml/src/ggml-cuda/%.o: \
807807
ggml/src/ggml-common.h \
808808
ggml/src/ggml-cuda/common.cuh
809809
$(HIPCC) $(CXXFLAGS) $(HIPFLAGS) -x hip -c -o $@ $<
810-
endif # GGML_HIPBLAS
810+
endif # GGML_HIP
811811

812812
ifdef GGML_MUSA
813813
ifeq ($(wildcard /opt/musa),)

docs/build.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ You can download it from your Linux distro's package manager or from here: [ROCm
221221
222222
- Using `make`:
223223
```bash
224-
make GGML_HIPBLAS=1
224+
make GGML_HIP=1
225225
```
226226
- Using `CMake` for Linux (assuming a gfx1030-compatible AMD GPU):
227227
```bash
@@ -249,7 +249,7 @@ You can download it from your Linux distro's package manager or from here: [ROCm
249249
250250
- Using `make` (example for target gfx1030, build with 16 CPU threads):
251251
```bash
252-
make -j16 GGML_HIPBLAS=1 GGML_HIP_UMA=1 AMDGPU_TARGETS=gfx1030
252+
make -j16 GGML_HIP=1 GGML_HIP_UMA=1 AMDGPU_TARGETS=gfx1030
253253
```
254254
255255
- Using `CMake` for Windows (using x64 Native Tools Command Prompt for VS, and assuming a gfx1100-compatible AMD GPU):

0 commit comments

Comments
 (0)