Skip to content

Commit a8b9bb4

Browse files
committed
cmake : respect LLAMA_QKK_64 option
1 parent 049a32f commit a8b9bb4

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

CMakeLists.txt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,15 @@ if (LLAMA_METAL)
182182
# note: this is the only way I found to disable fast-math in Metal. it's ugly, but at least it works
183183
# disabling fast math is needed in order to pass tests/test-backend-ops
184184
# note: adding -fno-inline fixes the tests when using MTL_SHADER_VALIDATION=1
185+
set(XC_FLAGS -fno-fast-math -fno-inline -g)
186+
if (LLAMA_QKK_64)
187+
set(XC_FLAGS ${XC_FLAGS} -DQK_K=64)
188+
endif()
189+
185190
add_custom_command(
186191
OUTPUT ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml.metallib
187-
COMMAND xcrun -sdk macosx metal -fno-fast-math -fno-inline -g -c ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml-metal.metal -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml-metal.air
188-
COMMAND xcrun -sdk macosx metallib ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml-metal.air -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml.metallib
192+
COMMAND xcrun -sdk macosx metal ${XC_FLAGS} -c ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml-metal.metal -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml-metal.air
193+
COMMAND xcrun -sdk macosx metallib ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml-metal.air -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/ggml.metallib
189194
DEPENDS ggml-metal.metal
190195
COMMENT "Compiling Metal kernels"
191196
)

tests/test-backend-ops.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,18 @@
1515
#include <thread>
1616
#include <vector>
1717

18-
1918
static void init_tensor_uniform(ggml_tensor * tensor, float min = -1.0f, float max = 1.0f) {
2019
size_t size = ggml_nelements(tensor);
2120
std::vector<float> data(size);
2221

2322
#if 0
24-
std::default_random_engine generator(rd());
23+
static std::default_random_engine generator(1234);
2524
std::uniform_real_distribution<float> distribution(min, max);
2625

2726
for (size_t i = 0; i < size; i++) {
2827
data[i] = distribution(generator);
2928
}
30-
#endif
29+
#else
3130
auto init_thread = [&](size_t start, size_t end) {
3231
std::random_device rd;
3332
std::default_random_engine generator(rd());
@@ -49,6 +48,7 @@ static void init_tensor_uniform(ggml_tensor * tensor, float min = -1.0f, float m
4948
for (auto & t : threads) {
5049
t.join();
5150
}
51+
#endif
5252

5353
if (tensor->type == GGML_TYPE_F32 || tensor->type == GGML_TYPE_I32) {
5454
ggml_backend_tensor_set(tensor, data.data(), 0, size * sizeof(float));
@@ -437,7 +437,7 @@ struct test_case {
437437
double err = nmse(f1.data(), f2.data(), f1.size());
438438
if (err > ud->max_err) {
439439
printf("[%s] NMSE = %f ", ggml_op_desc(t1), err);
440-
//for (int i = 0; i < f1.size(); i++) {
440+
//for (int i = 0; i < (int) f1.size(); i++) {
441441
// printf("%5d %9.6f %9.6f, diff = %9.6f\n", i, f1[i], f2[i], f1[i] - f2[i]);
442442
//}
443443
//printf("\n");

0 commit comments

Comments
 (0)