File tree 2 files changed +2
-6
lines changed
2 files changed +2
-6
lines changed Original file line number Diff line number Diff line change @@ -171,10 +171,6 @@ jobs:
171
171
LLAMA_NO_METAL=1 make tests -j $(sysctl -n hw.logicalcpu)
172
172
LLAMA_NO_METAL=1 make test -j $(sysctl -n hw.logicalcpu)
173
173
174
- # TODO: build with LLAMA_METAL=OFF because test-backend-ops fail on "Apple Paravirtual device" and I don't know
175
- # how to debug it.
176
- # ref: https://github.com/ggerganov/llama.cpp/actions/runs/7132125951/job/19422043567?pr=4359#step:5:6584
177
- # would be great if we fix these
178
174
macOS-latest-cmake :
179
175
runs-on : macos-latest
180
176
@@ -195,7 +191,7 @@ jobs:
195
191
sysctl -a
196
192
mkdir build
197
193
cd build
198
- cmake -DLLAMA_METAL=OFF ..
194
+ cmake -DLLAMA_METAL=ON -DLLAMA_METAL_NO_FAST_MATH=ON ..
199
195
cmake --build . --config Release -j $(sysctl -n hw.logicalcpu)
200
196
201
197
- name : Test
Original file line number Diff line number Diff line change @@ -184,7 +184,7 @@ if (LLAMA_METAL)
184
184
# note: adding -fno-inline fixes the tests when using MTL_SHADER_VALIDATION=1
185
185
add_custom_command (
186
186
OUTPUT ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} /ggml.metallib
187
- COMMAND xcrun -sdk macosx metal -fno-fast-math -fno-inline -c ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} /ggml-metal.metal -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} /ggml-metal.air
187
+ COMMAND xcrun -sdk macosx metal -O1 - fno-fast-math -fno-inline -c ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} /ggml-metal.metal -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} /ggml-metal.air
188
188
COMMAND xcrun -sdk macosx metallib ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} /ggml-metal.air -o ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} /ggml.metallib
189
189
DEPENDS ggml-metal.metal
190
190
COMMENT "Compiling Metal kernels"
You can’t perform that action at this time.
0 commit comments