Skip to content

Commit 2bad20d

Browse files
committed
try to fix clang compilation errors, 8th attempt
1 parent 9b91918 commit 2bad20d

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

ggml/src/ggml-cpu/ggml-cpu-impl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ void ggml_barrier(struct ggml_threadpool * tp);
513513

514514
#define GGML_DO_PRAGMA_(x) _Pragma (#x)
515515
#define GGML_DO_PRAGMA(x) GGML_DO_PRAGMA_(x)
516-
#if defined(__APPLE__) && !defined(TARGET_OS_OSX)
516+
#if (defined(__APPLE__) && !TARGET_OS_OSX) || defined(__HIPCC__)
517517
// weak alias not working
518518
# define GGML_WEAK_ALIAS(name, alias)
519519
#elif defined(__GNUC__)

ggml/src/ggml-cpu/quants.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ void ggml_vec_dot_iq1_m_q8_K_generic(int n, float * GGML_RESTRICT s, size_t bs,
8888
void ggml_vec_dot_iq4_nl_q8_0_generic(int n, float * GGML_RESTRICT s, size_t bs, const void * GGML_RESTRICT vx, size_t bx, const void * GGML_RESTRICT vy, size_t by, int nrc);
8989
void ggml_vec_dot_iq4_xs_q8_K_generic(int n, float * GGML_RESTRICT s, size_t bs, const void * GGML_RESTRICT vx, size_t bx, const void * GGML_RESTRICT vy, size_t by, int nrc);
9090

91-
#if defined(__APPLE__) && !defined(TARGET_OS_OSX)
91+
#if defined(__APPLE__) && !TARGET_OS_OSX
9292
#define quantize_row_q8_0_generic quantize_row_q8_0
9393
#define quantize_row_q8_1_generic quantize_row_q8_1
9494
#define quantize_row_q8_K_generic quantize_row_q8_K

ggml/src/ggml-cpu/repack.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ extern "C" {
7171
// Workaround for clang:
7272
// clang++ complains: ``error: call to 'ggml_gemm_q4_0_4x4_q8_0' is ambiguous''
7373
// repro: https://godbolt.org/z/oKdeWKonM (ICE), https://godbolt.org/z/1szq6P36v (ambiguous call)
74-
#if defined(GGML_CPU_CLANG_WORKAROUND) || !(defined(__GNUC__) && defined(__clang__))
74+
#if defined(GGML_CPU_CLANG_WORKAROUND) || !(defined(__GNUC__) && defined(__clang__)) || defined(__HIPCC__)
7575
void ggml_quantize_mat_q8_0_4x4(const float * GGML_RESTRICT x, void * GGML_RESTRICT vy, int64_t k);
7676
void ggml_quantize_mat_q8_0_4x8(const float * GGML_RESTRICT x, void * GGML_RESTRICT vy, int64_t k);
7777
void ggml_quantize_mat_q8_K_4x8(const float * GGML_RESTRICT x, void * GGML_RESTRICT vy, int64_t k);
@@ -102,7 +102,7 @@ void ggml_gemm_q4_0_8x8_q8_0_generic(int n, float * GGML_RESTRICT s, size_t bs,
102102
void ggml_gemm_q4_K_8x8_q8_K_generic(int n, float * GGML_RESTRICT s, size_t bs, const void * GGML_RESTRICT vx, const void * GGML_RESTRICT vy, int nr, int nc);
103103
void ggml_gemm_iq4_nl_4x4_q8_0_generic(int n, float * GGML_RESTRICT s, size_t bs, const void * GGML_RESTRICT vx, const void * GGML_RESTRICT vy, int nr, int nc);
104104

105-
#if defined(__APPLE__) && !defined(TARGET_OS_OSX)
105+
#if defined(__APPLE__) && !TARGET_OS_OSX
106106
#define ggml_quantize_mat_q8_0_4x4_generic ggml_quantize_mat_q8_0_4x4
107107
#define ggml_quantize_mat_q8_0_4x8_generic ggml_quantize_mat_q8_0_4x8
108108
#define ggml_quantize_mat_q8_K_4x8_generic ggml_quantize_mat_q8_K_4x8

0 commit comments

Comments
 (0)