Skip to content

Commit 220456d

Browse files
committed
fix: Remove unnecessary hparams argument to create_memory
It was already available as a member! 🤦 Branch: HybridCache Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
1 parent cbf6b10 commit 220456d

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

src/llama-context.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ llama_context::llama_context(
180180
/*.type_v =*/ params.type_v,
181181
};
182182

183-
memory.reset(model.create_memory(params_mem, cparams, hparams));
183+
memory.reset(model.create_memory(params_mem, cparams));
184184
}
185185

186186
// init backends

src/llama-model.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13042,8 +13042,7 @@ struct llm_build_bailingmoe : public llm_graph_context {
1304213042

1304313043
llama_memory_i * llama_model::create_memory(
1304413044
const llama_memory_params & params,
13045-
llama_cparams & cparams,
13046-
const llama_hparams & hparams) const {
13045+
llama_cparams & cparams) const {
1304713046
llama_memory_i * res;
1304813047

1304913048
switch (arch) {

src/llama-model.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -402,10 +402,7 @@ struct llama_model {
402402

403403
// note: can mutate `cparams`
404404
// TODO: move this to new llm_arch_model_i interface
405-
llama_memory_i * create_memory(
406-
const llama_memory_params & params,
407-
llama_cparams & cparams,
408-
const llama_hparams & hparams) const;
405+
llama_memory_i * create_memory(const llama_memory_params & params, llama_cparams & cparams) const;
409406

410407
// TODO: move this to new llm_arch_model_i interface
411408
llm_graph_result_ptr build_graph(

0 commit comments

Comments
 (0)