Skip to content

Commit c4e3664

Browse files
committed
fix: review 2 changes
1 parent 3aa5f01 commit c4e3664

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

sentry_sdk/integrations/aiohttp.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
transaction_from_function,
2424
HAS_REAL_CONTEXTVARS,
2525
CONTEXTVARS_ERROR_MESSAGE,
26+
SENSITIVE_DATA_SUBSTITUTE,
2627
AnnotatedValue,
2728
)
2829

@@ -203,14 +204,16 @@ async def on_request_start(session, trace_config_ctx, params):
203204
parsed_url = parse_url(str(params.url), sanitize=False)
204205

205206
span = hub.start_span(
206-
op=OP.HTTP_CLIENT, description="%s %s" % (method, parsed_url)
207+
op=OP.HTTP_CLIENT,
208+
description="%s %s"
209+
% (method, parsed_url.url if parsed_url else SENSITIVE_DATA_SUBSTITUTE),
207210
)
208211
span.set_data(SPANDATA.HTTP_METHOD, method)
209212
span.set_data("url", parsed_url.url)
210213
span.set_data(SPANDATA.HTTP_QUERY, parsed_url.query)
211214
span.set_data(SPANDATA.HTTP_FRAGMENT, parsed_url.fragment)
212215

213-
if should_propagate_trace(hub, parsed_url.url):
216+
if should_propagate_trace(hub, str(params.url)):
214217
for key, value in hub.iter_trace_propagation_headers(span):
215218
logger.debug(
216219
"[Tracing] Adding `{key}` header {value} to outgoing request to {url}.".format(

0 commit comments

Comments
 (0)