From 1f6c2dde3596217269ad94a1cbc820be678d4d48 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Fri, 27 Oct 2023 14:04:54 +0200 Subject: [PATCH 1/2] ref(replay): Streamline rrweb internal error check I think we don't really need this anymore, and this doesn't even work anyhow in any minified scenario, so we can safe these bundle bytes & also the work to check this on each error. --- packages/replay/src/util/isRrwebError.ts | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/packages/replay/src/util/isRrwebError.ts b/packages/replay/src/util/isRrwebError.ts index bab65638c382..0cb50bfb6802 100644 --- a/packages/replay/src/util/isRrwebError.ts +++ b/packages/replay/src/util/isRrwebError.ts @@ -13,12 +13,5 @@ export function isRrwebError(event: Event, hint: EventHint): boolean { return true; } - // Check if any exception originates from rrweb - return event.exception.values.some(exception => { - if (!exception.stacktrace || !exception.stacktrace.frames || !exception.stacktrace.frames.length) { - return false; - } - - return exception.stacktrace.frames.some(frame => frame.filename && frame.filename.includes('/rrweb/src/')); - }); + return false; } From 1c41f3e328df8cdf0aa050912d9cd423dc88b23a Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Mon, 30 Oct 2023 10:14:08 +0100 Subject: [PATCH 2/2] remove test --- .../coreHandlers/handleGlobalEvent.test.ts | 38 ------------------- 1 file changed, 38 deletions(-) diff --git a/packages/replay/test/integration/coreHandlers/handleGlobalEvent.test.ts b/packages/replay/test/integration/coreHandlers/handleGlobalEvent.test.ts index d4357eb4a6ea..7ea8f45755a4 100644 --- a/packages/replay/test/integration/coreHandlers/handleGlobalEvent.test.ts +++ b/packages/replay/test/integration/coreHandlers/handleGlobalEvent.test.ts @@ -267,44 +267,6 @@ describe('Integration | coreHandlers | handleGlobalEvent', () => { expect(handleGlobalEventListener(replay)(errorEvent, {})).toEqual(errorEvent); }); - it('skips rrweb internal errors', () => { - const errorEvent: Event = { - exception: { - values: [ - { - type: 'TypeError', - value: "Cannot read properties of undefined (reading 'contains')", - stacktrace: { - frames: [ - { - filename: - 'http://example.com/..node_modules/packages/replay/build/npm/esm/node_modules/rrweb/es/rrweb/packages/rrweb/src/record/mutation.js?v=90704e8a', - function: 'MutationBuffer.processMutations', - in_app: true, - lineno: 101, - colno: 23, - }, - { - filename: '', - function: 'Array.forEach', - in_app: true, - }, - ], - }, - mechanism: { - type: 'generic', - handled: true, - }, - }, - ], - }, - level: 'error', - event_id: 'ff1616b1e13744c6964281349aecc82a', - }; - - expect(handleGlobalEventListener(replay)(errorEvent, {})).toEqual(null); - }); - it('skips exception with __rrweb__ set', () => { const errorEvent: Event = { exception: {