From 32e299886d15868015bfa4d062c60243b79c3f50 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Wed, 1 Mar 2023 15:01:50 +0100 Subject: [PATCH 1/2] Revert "test(browser): Temporarily skip offline transport tests (#7305)" This reverts commit 3ba8e0b5b14484087ebee94361508a02b7081c60. --- packages/browser/test/unit/transports/offline.test.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/browser/test/unit/transports/offline.test.ts b/packages/browser/test/unit/transports/offline.test.ts index ff995ce43a44..b224df725bc6 100644 --- a/packages/browser/test/unit/transports/offline.test.ts +++ b/packages/browser/test/unit/transports/offline.test.ts @@ -58,8 +58,7 @@ function delay(ms: number): Promise { return new Promise(resolve => setTimeout(resolve, ms)); } -// TODO: Temp. skipping this because it is very flaky - we should revisit this and make this non-flaky -describe.skip('makeOfflineTransport', () => { +describe('makeOfflineTransport', () => { beforeAll(async () => { await deleteDatabase('sentry'); }); From b1fcb641cc587893d8ef415fb2861a01d12dd1e4 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Wed, 1 Mar 2023 15:03:09 +0100 Subject: [PATCH 2/2] test(core): Skip flaky offline transport test --- packages/core/test/lib/transports/offline.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/test/lib/transports/offline.test.ts b/packages/core/test/lib/transports/offline.test.ts index eebe7c8874ed..0779dff6a8d7 100644 --- a/packages/core/test/lib/transports/offline.test.ts +++ b/packages/core/test/lib/transports/offline.test.ts @@ -326,7 +326,7 @@ describe('makeOfflineTransport', () => { expect(getCalls()).toEqual([]); }); - it( + it.skip( 'Follows the Retry-After header', async () => { const { getCalls, store } = createTestStore(ERROR_ENVELOPE);