From 12452caa8e27db3f3863472669fc26096b7573cc Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 10 Jan 2023 09:45:21 +0000 Subject: [PATCH 1/8] ci(remix): Pin remix version in integration tests --- packages/remix/test/integration/package.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/remix/test/integration/package.json b/packages/remix/test/integration/package.json index 724ee95c1d61..102a7844b1f9 100644 --- a/packages/remix/test/integration/package.json +++ b/packages/remix/test/integration/package.json @@ -7,16 +7,16 @@ "start": "remix-serve build" }, "dependencies": { - "@remix-run/express": "^1.6.5", - "@remix-run/node": "^1.6.5", - "@remix-run/react": "^1.6.5", - "@remix-run/serve": "^1.6.5", + "@remix-run/express": "1.9.0", + "@remix-run/node": "1.9.0", + "@remix-run/react": "1.9.0", + "@remix-run/serve": "1.9.0", "@sentry/remix": "file:../..", "react": "^17.0.2", "react-dom": "^17.0.2" }, "devDependencies": { - "@remix-run/dev": "^1.6.5", + "@remix-run/dev": "1.9.0", "@types/react": "^17.0.47", "@types/react-dom": "^17.0.17", "nock": "^13.1.0", From 480cd761b857909344e5827c82d59f74b2ef63ea Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 10 Jan 2023 10:03:38 +0000 Subject: [PATCH 2/8] Unpin ubuntu version for playwright tests --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 20b723d90ca0..fa3f4cca852a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -503,7 +503,7 @@ jobs: name: Playwright (${{ matrix.bundle }})${{ (matrix.tracing_only && ' tracing only') || '' }} Tests needs: [job_get_metadata, job_build] if: needs.job_get_metadata.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request' - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest strategy: matrix: bundle: @@ -698,7 +698,7 @@ jobs: if: (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]' - needs: [job_get_metadata, job_build] + needs: [job_get_metadata, job_bui^ld] runs-on: ubuntu-20.04 timeout-minutes: 10 steps: From bd16e13d266998d4e7276077bf6c8114295f0190 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 10 Jan 2023 10:06:54 +0000 Subject: [PATCH 3/8] Pin to 22 --- .github/workflows/build.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fa3f4cca852a..e4c1e0ef0537 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -503,7 +503,7 @@ jobs: name: Playwright (${{ matrix.bundle }})${{ (matrix.tracing_only && ' tracing only') || '' }} Tests needs: [job_get_metadata, job_build] if: needs.job_get_metadata.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request' - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 strategy: matrix: bundle: @@ -546,7 +546,6 @@ jobs: PW_TRACING_ONLY: ${{ matrix.tracing_only }} run: | cd packages/integration-tests - sudo apt-get update yarn run playwright install-deps webkit yarn test:ci From 910c194c9a54201094bf04733133db3dc3644875 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 10 Jan 2023 10:09:26 +0000 Subject: [PATCH 4/8] Fix typo --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e4c1e0ef0537..7bc7553ba755 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -697,7 +697,7 @@ jobs: if: (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]' - needs: [job_get_metadata, job_bui^ld] + needs: [job_get_metadata, job_build] runs-on: ubuntu-20.04 timeout-minutes: 10 steps: From bd753ac845a596f2ba0305a606c519e429a82935 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 10 Jan 2023 10:29:26 +0000 Subject: [PATCH 5/8] install missing deps --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7bc7553ba755..ceef8471fc3f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -546,6 +546,7 @@ jobs: PW_TRACING_ONLY: ${{ matrix.tracing_only }} run: | cd packages/integration-tests + sudo apt-get install libicu70 libwebp6 yarn run playwright install-deps webkit yarn test:ci From 35dbf9450806258e0d757759cf56dba7cd378990 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 10 Jan 2023 10:39:37 +0000 Subject: [PATCH 6/8] argh --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ceef8471fc3f..a8274b04c15e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -546,6 +546,7 @@ jobs: PW_TRACING_ONLY: ${{ matrix.tracing_only }} run: | cd packages/integration-tests + sudo apt-get update sudo apt-get install libicu70 libwebp6 yarn run playwright install-deps webkit yarn test:ci From c538c588c7a8de83cb2a6c8f7bd39ea6e2aa51ca Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 10 Jan 2023 11:49:29 +0000 Subject: [PATCH 7/8] Update playwright --- .github/workflows/build.yml | 2 -- packages/integration-tests/package.json | 4 ++-- yarn.lock | 22 +++++++++++++++++----- 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a8274b04c15e..7bc7553ba755 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -546,8 +546,6 @@ jobs: PW_TRACING_ONLY: ${{ matrix.tracing_only }} run: | cd packages/integration-tests - sudo apt-get update - sudo apt-get install libicu70 libwebp6 yarn run playwright install-deps webkit yarn test:ci diff --git a/packages/integration-tests/package.json b/packages/integration-tests/package.json index 5c30315831d7..08dfeaf9c610 100644 --- a/packages/integration-tests/package.json +++ b/packages/integration-tests/package.json @@ -26,10 +26,10 @@ }, "dependencies": { "@babel/preset-typescript": "^7.16.7", - "@playwright/test": "^1.27.1", + "@playwright/test": "^1.29.2", "babel-loader": "^8.2.2", "html-webpack-plugin": "^5.5.0", - "playwright": "^1.27.1", + "playwright": "^1.29.2", "typescript": "^4.5.2", "webpack": "^5.52.0" }, diff --git a/yarn.lock b/yarn.lock index d1bfebbebeba..aebbc2871d55 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3225,13 +3225,13 @@ "@opentelemetry/resources" "^0.12.0" "@opentelemetry/semantic-conventions" "^0.12.0" -"@playwright/test@^1.27.1": - version "1.28.1" - resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.28.1.tgz#e5be297e024a3256610cac2baaa9347fd57c7860" - integrity sha512-xN6spdqrNlwSn9KabIhqfZR7IWjPpFK1835tFNgjrlysaSezuX8PYUwaz38V/yI8TJLG9PkAMEXoHRXYXlpTPQ== +"@playwright/test@^1.29.2": + version "1.29.2" + resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.29.2.tgz#c48184721d0f0b7627a886e2ec42f1efb2be339d" + integrity sha512-+3/GPwOgcoF0xLz/opTnahel1/y42PdcgZ4hs+BZGIUjtmEFSXGg+nFoaH3NSmuc7a6GSFwXDJ5L7VXpqzigNg== dependencies: "@types/node" "*" - playwright-core "1.28.1" + playwright-core "1.29.2" "@polka/url@^1.0.0-next.9": version "1.0.0-next.12" @@ -19107,6 +19107,11 @@ playwright-core@1.28.1: resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.28.1.tgz#8400be9f4a8d1c0489abdb9e75a4cc0ffc3c00cb" integrity sha512-3PixLnGPno0E8rSBJjtwqTwJe3Yw72QwBBBxNoukIj3lEeBNXwbNiKrNuB1oyQgTBw5QHUhNO3SteEtHaMK6ag== +playwright-core@1.29.2: + version "1.29.2" + resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.29.2.tgz#2e8347e7e8522409f22b244e600e703b64022406" + integrity sha512-94QXm4PMgFoHAhlCuoWyaBYKb92yOcGVHdQLoxQ7Wjlc7Flg4aC/jbFW7xMR52OfXMVkWicue4WXE7QEegbIRA== + playwright@^1.27.1: version "1.28.1" resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.28.1.tgz#f23247f1de466ff73d7230d94df96271e5da6583" @@ -19114,6 +19119,13 @@ playwright@^1.27.1: dependencies: playwright-core "1.28.1" +playwright@^1.29.2: + version "1.29.2" + resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.29.2.tgz#d6a0a3e8e44f023f7956ed19ffa8af915a042769" + integrity sha512-hKBYJUtdmYzcjdhYDkP9WGtORwwZBBKAW8+Lz7sr0ZMxtJr04ASXVzH5eBWtDkdb0c3LLFsehfPBTRfvlfKJOA== + dependencies: + playwright-core "1.29.2" + plugin-error@^1.0.1: version "1.0.1" resolved "https://registry.yarnpkg.com/plugin-error/-/plugin-error-1.0.1.tgz#77016bd8919d0ac377fdcdd0322328953ca5781c" From 0bed29a309ac393b7835d1526badf2daf96b417f Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 10 Jan 2023 12:07:19 +0000 Subject: [PATCH 8/8] Pin old ubuntu version --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7bc7553ba755..66bf558f473a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -503,7 +503,7 @@ jobs: name: Playwright (${{ matrix.bundle }})${{ (matrix.tracing_only && ' tracing only') || '' }} Tests needs: [job_get_metadata, job_build] if: needs.job_get_metadata.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request' - runs-on: ubuntu-22.04 + runs-on: ubuntu-20.04 strategy: matrix: bundle: