From 2bf9a72b9d8ab89cd722156147d2070e16bb376e Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Fri, 9 Sep 2022 13:39:29 +0200 Subject: [PATCH] ref(node): Add propagations to http integration fix tests rename name_changes -> changes remaining nameChanges ref(node): Add propagations to http integration fix nextjs tests --- .../test/integration/test/server/tracingHttp.js | 2 +- packages/node/src/integrations/http.ts | 5 +++++ packages/node/test/integrations/http.test.ts | 14 ++++++++++++++ 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/packages/nextjs/test/integration/test/server/tracingHttp.js b/packages/nextjs/test/integration/test/server/tracingHttp.js index 29ab66cc46ea..00cc2d1e3129 100644 --- a/packages/nextjs/test/integration/test/server/tracingHttp.js +++ b/packages/nextjs/test/integration/test/server/tracingHttp.js @@ -32,7 +32,7 @@ module.exports = async ({ url: urlBase, argv }) => { transaction_info: { source: 'route', changes: [], - propagations: 0, + propagations: 1, }, type: 'transaction', request: { diff --git a/packages/node/src/integrations/http.ts b/packages/node/src/integrations/http.ts index 9edd5d8c3d34..0bdb91396a52 100644 --- a/packages/node/src/integrations/http.ts +++ b/packages/node/src/integrations/http.ts @@ -172,6 +172,11 @@ function _createWrappedRequestMethodFactory( `[Tracing] Not adding sentry-trace header to outgoing request (${requestUrl}) due to mismatching tracePropagationTargets option.`, ); } + + const transaction = parentSpan.transaction; + if (transaction) { + transaction.metadata.propagations += 1; + } } } diff --git a/packages/node/test/integrations/http.test.ts b/packages/node/test/integrations/http.test.ts index 72164153bedf..94d1e7565f68 100644 --- a/packages/node/test/integrations/http.test.ts +++ b/packages/node/test/integrations/http.test.ts @@ -172,6 +172,20 @@ describe('tracing', () => { expect(baggage).not.toBeDefined(); }); + it('records outgoing propagations on the transaction', () => { + nock('http://dogs.are.great').get('/').reply(200); + + const transaction = createTransactionOnScope(); + + expect(transaction.metadata.propagations).toBe(0); + + http.get('http://dogs.are.great/'); + expect(transaction.metadata.propagations).toBe(1); + + http.get('http://dogs.are.great/'); + expect(transaction.metadata.propagations).toBe(2); + }); + describe('tracePropagationTargets option', () => { beforeEach(() => { // hacky way of restoring monkey patched functions