From 9f681326cfaa13742e5eddeee0dae52398e0e80f Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 15 Mar 2022 15:35:46 -0700 Subject: [PATCH 1/8] add types-specific tsconfig template --- tsconfig-templates/README.md | 6 +++--- tsconfig-templates/tsconfig.types.json | 10 ++++++++++ 2 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 tsconfig-templates/tsconfig.types.json diff --git a/tsconfig-templates/README.md b/tsconfig-templates/README.md index 53eaa2d7d832..4cb4d29d788f 100644 --- a/tsconfig-templates/README.md +++ b/tsconfig-templates/README.md @@ -1,5 +1,5 @@ # `tsconfig` Templates -Every package should get its own copy of these four files. Package-specific options should go in `tsconfig.json` and -test-specific options in `tsconfig.test.json`. The `cjs` and `esm` files shouldn't need to be modified, and only exist -because tsconfigs don't support multiple inheritence. +Every package should get its own copy of these five files. Package-specific options should go in `tsconfig.json` and +test-specific options in `tsconfig.test.json`. The `cjs`, `esm`, and `types` files shouldn't need to be modified, and +only exist because tsconfigs don't support multiple inheritence. diff --git a/tsconfig-templates/tsconfig.types.json b/tsconfig-templates/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/tsconfig-templates/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} From ec4de5b670affa2363beb6a427cc24dd7764f789 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 15 Mar 2022 15:39:23 -0700 Subject: [PATCH 2/8] add types tsconfig to packages --- packages/angular/tsconfig.types.json | 10 ++++++++++ packages/browser/tsconfig.types.json | 10 ++++++++++ packages/core/tsconfig.types.json | 10 ++++++++++ packages/gatsby/tsconfig.types.json | 10 ++++++++++ packages/hub/tsconfig.types.json | 10 ++++++++++ packages/integrations/tsconfig.types.json | 10 ++++++++++ packages/minimal/tsconfig.types.json | 10 ++++++++++ packages/nextjs/tsconfig.types.json | 10 ++++++++++ packages/node/tsconfig.types.json | 10 ++++++++++ packages/react/tsconfig.types.json | 10 ++++++++++ packages/serverless/tsconfig.types.json | 10 ++++++++++ packages/tracing/tsconfig.types.json | 10 ++++++++++ packages/types/tsconfig.types.json | 10 ++++++++++ packages/utils/tsconfig.types.json | 10 ++++++++++ packages/vue/tsconfig.types.json | 10 ++++++++++ packages/wasm/tsconfig.types.json | 10 ++++++++++ 16 files changed, 160 insertions(+) create mode 100644 packages/angular/tsconfig.types.json create mode 100644 packages/browser/tsconfig.types.json create mode 100644 packages/core/tsconfig.types.json create mode 100644 packages/gatsby/tsconfig.types.json create mode 100644 packages/hub/tsconfig.types.json create mode 100644 packages/integrations/tsconfig.types.json create mode 100644 packages/minimal/tsconfig.types.json create mode 100644 packages/nextjs/tsconfig.types.json create mode 100644 packages/node/tsconfig.types.json create mode 100644 packages/react/tsconfig.types.json create mode 100644 packages/serverless/tsconfig.types.json create mode 100644 packages/tracing/tsconfig.types.json create mode 100644 packages/types/tsconfig.types.json create mode 100644 packages/utils/tsconfig.types.json create mode 100644 packages/vue/tsconfig.types.json create mode 100644 packages/wasm/tsconfig.types.json diff --git a/packages/angular/tsconfig.types.json b/packages/angular/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/angular/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/browser/tsconfig.types.json b/packages/browser/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/browser/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/core/tsconfig.types.json b/packages/core/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/core/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/gatsby/tsconfig.types.json b/packages/gatsby/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/gatsby/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/hub/tsconfig.types.json b/packages/hub/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/hub/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/integrations/tsconfig.types.json b/packages/integrations/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/integrations/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/minimal/tsconfig.types.json b/packages/minimal/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/minimal/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/nextjs/tsconfig.types.json b/packages/nextjs/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/nextjs/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/node/tsconfig.types.json b/packages/node/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/node/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/react/tsconfig.types.json b/packages/react/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/react/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/serverless/tsconfig.types.json b/packages/serverless/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/serverless/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/tracing/tsconfig.types.json b/packages/tracing/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/tracing/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/types/tsconfig.types.json b/packages/types/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/types/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/utils/tsconfig.types.json b/packages/utils/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/utils/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/vue/tsconfig.types.json b/packages/vue/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/vue/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} diff --git a/packages/wasm/tsconfig.types.json b/packages/wasm/tsconfig.types.json new file mode 100644 index 000000000000..65455f66bd75 --- /dev/null +++ b/packages/wasm/tsconfig.types.json @@ -0,0 +1,10 @@ +{ + "extends": "./tsconfig.json", + + "compilerOptions": { + "declaration": true, + "declarationMap": true, + "emitDeclarationOnly": true, + "outDir": "build/types" + } +} From 4cdbb00b23435b8bfca344c45414e7aaf4e43f34 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 15 Mar 2022 19:53:53 -0700 Subject: [PATCH 3/8] add `build:types` and `build:types:watch` commands to packages --- packages/angular/package.json | 2 ++ packages/browser/package.json | 2 ++ packages/core/package.json | 2 ++ packages/gatsby/package.json | 2 ++ packages/hub/package.json | 2 ++ packages/integrations/package.json | 2 ++ packages/minimal/package.json | 2 ++ packages/nextjs/package.json | 2 ++ packages/node/package.json | 2 ++ packages/react/package.json | 2 ++ packages/serverless/package.json | 2 ++ packages/tracing/package.json | 2 ++ packages/types/package.json | 2 ++ packages/utils/package.json | 2 ++ packages/vue/package.json | 2 ++ packages/wasm/package.json | 2 ++ 16 files changed, 32 insertions(+) diff --git a/packages/angular/package.json b/packages/angular/package.json index 41788915b056..7e5fa9738683 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -38,11 +38,13 @@ "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build coverage", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/browser/package.json b/packages/browser/package.json index 78750c2697d0..e8383b33f537 100644 --- a/packages/browser/package.json +++ b/packages/browser/package.json @@ -50,12 +50,14 @@ "build:dev": "run-p build:cjs build:esm", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch build:bundle:watch", "build:bundle:watch": "rollup --config --watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:dev:watch": "run-p build:cjs:watch build:esm:watch", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build coverage .rpt2_cache", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/core/package.json b/packages/core/package.json index ad1a96d14907..bf7e5c0aa404 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -28,11 +28,13 @@ "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm coverage", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json index 925588295bca..4261565d20ff 100644 --- a/packages/gatsby/package.json +++ b/packages/gatsby/package.json @@ -45,11 +45,13 @@ "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build coverage", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/hub/package.json b/packages/hub/package.json index 92340d2061a3..7fe3a4de48a9 100644 --- a/packages/hub/package.json +++ b/packages/hub/package.json @@ -26,11 +26,13 @@ "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm coverage", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/integrations/package.json b/packages/integrations/package.json index adc11b1c481f..b0c9e6bf4bda 100644 --- a/packages/integrations/package.json +++ b/packages/integrations/package.json @@ -31,11 +31,13 @@ "build:dev": "run-s build:cjs build:esm", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build coverage .rpt2_cache", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/minimal/package.json b/packages/minimal/package.json index f75331db7c01..181a3ccc2b0f 100644 --- a/packages/minimal/package.json +++ b/packages/minimal/package.json @@ -26,11 +26,13 @@ "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm coverage", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/nextjs/package.json b/packages/nextjs/package.json index 400378f5282c..1f6f59a25ca4 100644 --- a/packages/nextjs/package.json +++ b/packages/nextjs/package.json @@ -48,11 +48,13 @@ "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.client.ts && madge --circular --exclude 'config/types\\.ts' src/index.server.ts # see https://github.com/pahen/madge/issues/306", "clean": "rimraf dist esm coverage *.js *.js.map *.d.ts", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/node/package.json b/packages/node/package.json index fcf6fb632a95..dbcb8c414af1 100644 --- a/packages/node/package.json +++ b/packages/node/package.json @@ -39,11 +39,13 @@ "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm coverage", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/react/package.json b/packages/react/package.json index ab28dde38b51..b8d712682149 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -55,11 +55,13 @@ "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build coverage", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/serverless/package.json b/packages/serverless/package.json index 81e0971027bb..602b00b34f14 100644 --- a/packages/serverless/package.json +++ b/packages/serverless/package.json @@ -45,11 +45,13 @@ "build:dev": "run-s build:cjs build:esm", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build dist-awslambda-layer coverage", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/tracing/package.json b/packages/tracing/package.json index 5305bfebe3cf..f84e54ae3f93 100644 --- a/packages/tracing/package.json +++ b/packages/tracing/package.json @@ -35,12 +35,14 @@ "build:dev": "run-s build:cjs build:esm", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch build:bundle:watch", "build:bundle:watch": "rollup --config --watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "clean": "rimraf dist esm build coverage", "circularDepCheck": "madge --circular src/index.ts", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/types/package.json b/packages/types/package.json index 22431fb478d5..70a8db080dc6 100644 --- a/packages/types/package.json +++ b/packages/types/package.json @@ -21,11 +21,13 @@ "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "link:yarn": "yarn link", "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", diff --git a/packages/utils/package.json b/packages/utils/package.json index f4f750ee98b9..c09adc2f6215 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -29,11 +29,13 @@ "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm coverage *.js *.js.map *.d.ts", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/vue/package.json b/packages/vue/package.json index 21cd1c3b6dd0..202bdbb73faf 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -37,12 +37,14 @@ "build:dev": "run-s build:cjs build:esm", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:bundle:watch": "rollup --config --watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build coverage", "fix": "run-s fix:eslint fix:prettier", diff --git a/packages/wasm/package.json b/packages/wasm/package.json index 8e1f4de9c125..c147031038a8 100644 --- a/packages/wasm/package.json +++ b/packages/wasm/package.json @@ -35,11 +35,13 @@ "build:dev": "run-s build:cjs build:esm", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", + "build:types": "tsc -p tsconfig.types.json", "build:watch": "run-p build:cjs:watch build:esm:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", + "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm coverage *.js.map *.d.ts", "fix": "run-s fix:eslint fix:prettier", From c8ccfea3aadd9bdbd2f9775de085bda4458d2070 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Thu, 17 Mar 2022 14:43:03 -0700 Subject: [PATCH 4/8] add ts-node --- package.json | 2 ++ yarn.lock | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 79 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index a4eea25ad296..5404e4d719b8 100644 --- a/package.json +++ b/package.json @@ -82,6 +82,8 @@ "sinon": "^7.3.2", "size-limit": "^4.5.5", "ts-jest": "^24.3.0", + "ts-node": "^10.7.0", + "tslib": "^2.3.1", "typedoc": "^0.18.0", "typescript": "3.7.5" }, diff --git a/yarn.lock b/yarn.lock index bd7ea7abf2cf..e1cb1984c431 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1544,6 +1544,18 @@ exec-sh "^0.3.2" minimist "^1.2.0" +"@cspotcode/source-map-consumer@0.8.0": + version "0.8.0" + resolved "https://registry.yarnpkg.com/@cspotcode/source-map-consumer/-/source-map-consumer-0.8.0.tgz#33bf4b7b39c178821606f669bbc447a6a629786b" + integrity sha512-41qniHzTU8yAGbCp04ohlmSrZf8bkf/iJsl3V0dRGsQN/5GFfx+LbCSsCpp2gqrqjTVg/K6O8ycoV35JIwAzAg== + +"@cspotcode/source-map-support@0.7.0": + version "0.7.0" + resolved "https://registry.yarnpkg.com/@cspotcode/source-map-support/-/source-map-support-0.7.0.tgz#4789840aa859e46d2f3173727ab707c66bf344f5" + integrity sha512-X4xqRHqN8ACt2aHVe51OxeA2HjbcL4MqFqXkrmQszJ1NOUuUu5u6Vqx/0lZSVNku7velL5FC/s5uEAj1lsBMhA== + dependencies: + "@cspotcode/source-map-consumer" "0.8.0" + "@ember-data/rfc395-data@^0.0.4": version "0.0.4" resolved "https://registry.yarnpkg.com/@ember-data/rfc395-data/-/rfc395-data-0.0.4.tgz#ecb86efdf5d7733a76ff14ea651a1b0ed1f8a843" @@ -3311,6 +3323,26 @@ "@types/semver" "^7.3.9" ts-type "^2.1.4" +"@tsconfig/node10@^1.0.7": + version "1.0.8" + resolved "https://registry.yarnpkg.com/@tsconfig/node10/-/node10-1.0.8.tgz#c1e4e80d6f964fbecb3359c43bd48b40f7cadad9" + integrity sha512-6XFfSQmMgq0CFLY1MslA/CPUfhIL919M1rMsa5lP2P097N2Wd1sSX0tx1u4olM16fLNhtHZpRhedZJphNJqmZg== + +"@tsconfig/node12@^1.0.7": + version "1.0.9" + resolved "https://registry.yarnpkg.com/@tsconfig/node12/-/node12-1.0.9.tgz#62c1f6dee2ebd9aead80dc3afa56810e58e1a04c" + integrity sha512-/yBMcem+fbvhSREH+s14YJi18sp7J9jpuhYByADT2rypfajMZZN4WQ6zBGgBKp53NKmqI36wFYDb3yaMPurITw== + +"@tsconfig/node14@^1.0.0": + version "1.0.1" + resolved "https://registry.yarnpkg.com/@tsconfig/node14/-/node14-1.0.1.tgz#95f2d167ffb9b8d2068b0b235302fafd4df711f2" + integrity sha512-509r2+yARFfHHE7T6Puu2jjkoycftovhXRqW328PDXTVGKihlb1P8Z9mMZH04ebyajfRY7dedfGynlrFHJUQCg== + +"@tsconfig/node16@^1.0.2": + version "1.0.2" + resolved "https://registry.yarnpkg.com/@tsconfig/node16/-/node16-1.0.2.tgz#423c77877d0569db20e1fc80885ac4118314010e" + integrity sha512-eZxlbI8GZscaGS7kkc/trHTT5xgrjH3/1n2JDwusC9iahPKWMRvRjJSAN5mCXviuTGQ/lHnhvv8Q1YTpnfz9gA== + "@types/aria-query@^4.2.0": version "4.2.1" resolved "https://registry.yarnpkg.com/@types/aria-query/-/aria-query-4.2.1.tgz#78b5433344e2f92e8b306c06a5622c50c245bf6b" @@ -4508,6 +4540,11 @@ acorn-walk@^8.0.0: resolved "https://registry.yarnpkg.com/acorn-walk/-/acorn-walk-8.0.2.tgz#d4632bfc63fd93d0f15fd05ea0e984ffd3f5a8c3" integrity sha512-+bpA9MJsHdZ4bgfDcpk0ozQyhhVct7rzOmO0s1IIr0AGGgKBljss8n2zp11rRP2wid5VGeh04CgeKzgat5/25A== +acorn-walk@^8.1.1: + version "8.2.0" + resolved "https://registry.yarnpkg.com/acorn-walk/-/acorn-walk-8.2.0.tgz#741210f2e2426454508853a2f44d0ab83b7f69c1" + integrity sha512-k+iyHEuPgSw6SbuDpGQM+06HQUa04DZ3o+F6CSzXMvvI5KMvnaEqXe+YVe555R9nn6GPt404fos4wcgpw12SDA== + acorn@^5.5.3: version "5.7.4" resolved "https://registry.yarnpkg.com/acorn/-/acorn-5.7.4.tgz#3e8d8a9947d0599a1796d10225d7432f4a4acf5e" @@ -4756,6 +4793,11 @@ are-we-there-yet@~1.1.2: delegates "^1.0.0" readable-stream "^2.0.6" +arg@^4.1.0: + version "4.1.3" + resolved "https://registry.yarnpkg.com/arg/-/arg-4.1.3.tgz#269fc7ad5b8e42cb63c896d5666017261c144089" + integrity sha512-58S9QDqG0Xx27YwPSt9fJxivjYl432YCwfDMfZ+71RAqUrZef7LrKQZ3LHLOwCS4FLNBplP533Zx895SeOCHvA== + argparse@^1.0.7: version "1.0.10" resolved "https://registry.yarnpkg.com/argparse/-/argparse-1.0.10.tgz#bcd6791ea5ae09725e17e5ad988134cd40b3d911" @@ -8018,6 +8060,11 @@ create-react-context@^0.2.2: fbjs "^0.8.0" gud "^1.0.0" +create-require@^1.1.0: + version "1.1.1" + resolved "https://registry.yarnpkg.com/create-require/-/create-require-1.1.1.tgz#c1d7e8f1e5f6cfc9ff65f9cd352d37348756c333" + integrity sha512-dcKFX3jn0MpIaXjisoRvexIJVEKzaq7z2rZKxf+MSr9TkdmHmsU4m2lcLojrj/FHl8mk5VxMmYA+ftRkP/3oKQ== + cross-env@^7.0.3: version "7.0.3" resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-7.0.3.tgz#865264b29677dc015ba8418918965dd232fc54cf" @@ -15024,7 +15071,7 @@ make-dir@^3.0.0, make-dir@^3.0.2, make-dir@^3.1.0: dependencies: semver "^6.0.0" -make-error@1.x: +make-error@1.x, make-error@^1.1.1: version "1.3.6" resolved "https://registry.yarnpkg.com/make-error/-/make-error-1.3.6.tgz#2eb2e37ea9b67c4891f684a1394799af484cf7a2" integrity sha512-s8UhlNe7vPKomQhC1qFelMokr/Sc3AgNbso3n74mVPA5LTZwkB9NlXf4XPamLxJE8h0gh73rM94xvwRT2CVInw== @@ -20956,6 +21003,25 @@ ts-jest@^24.3.0: semver "^5.5" yargs-parser "10.x" +ts-node@^10.7.0: + version "10.7.0" + resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-10.7.0.tgz#35d503d0fab3e2baa672a0e94f4b40653c2463f5" + integrity sha512-TbIGS4xgJoX2i3do417KSaep1uRAW/Lu+WAL2doDHC0D6ummjirVOXU5/7aiZotbQ5p1Zp9tP7U6cYhA0O7M8A== + dependencies: + "@cspotcode/source-map-support" "0.7.0" + "@tsconfig/node10" "^1.0.7" + "@tsconfig/node12" "^1.0.7" + "@tsconfig/node14" "^1.0.0" + "@tsconfig/node16" "^1.0.2" + acorn "^8.4.1" + acorn-walk "^8.1.1" + arg "^4.1.0" + create-require "^1.1.0" + diff "^4.0.1" + make-error "^1.1.1" + v8-compile-cache-lib "^3.0.0" + yn "3.1.1" + ts-pnp@^1.1.6: version "1.2.0" resolved "https://registry.yarnpkg.com/ts-pnp/-/ts-pnp-1.2.0.tgz#a500ad084b0798f1c3071af391e65912c86bca92" @@ -21510,6 +21576,11 @@ uuid@^8.0.0, uuid@^8.3.0, uuid@^8.3.1, uuid@^8.3.2: resolved "https://registry.yarnpkg.com/uuid/-/uuid-8.3.2.tgz#80d5b5ced271bb9af6c445f21a1a04c606cefbe2" integrity sha512-+NYs2QeMWy+GWFOEm9xnn6HCDp0l7QBD7ml8zLUmJ+93Q5NF0NocErnwkTkXVFNiX3/fpC6afS8Dhb/gz7R7eg== +v8-compile-cache-lib@^3.0.0: + version "3.0.0" + resolved "https://registry.yarnpkg.com/v8-compile-cache-lib/-/v8-compile-cache-lib-3.0.0.tgz#0582bcb1c74f3a2ee46487ceecf372e46bce53e8" + integrity sha512-mpSYqfsFvASnSn5qMiwrr4VKfumbPyONLCOPmsR3A6pTY/r0+tSaVbgPWSAIuzbk3lCTa+FForeTiO+wBQGkjA== + v8-compile-cache@^2.0.3: version "2.3.0" resolved "https://registry.yarnpkg.com/v8-compile-cache/-/v8-compile-cache-2.3.0.tgz#2de19618c66dc247dcfb6f99338035d8245a2cee" @@ -22320,6 +22391,11 @@ yeast@0.1.2: resolved "https://registry.yarnpkg.com/yeast/-/yeast-0.1.2.tgz#008e06d8094320c372dbc2f8ed76a0ca6c8ac419" integrity sha1-AI4G2AlDIMNy28L47XagymyKxBk= +yn@3.1.1: + version "3.1.1" + resolved "https://registry.yarnpkg.com/yn/-/yn-3.1.1.tgz#1e87401a09d767c1d5eab26a6e4c185182d2eb50" + integrity sha512-Ux4ygGWsu2c7isFWe8Yu1YluJmqVhxqK2cLXNQA5AcC3QfbGNpM7fu0Y8b/z16pXLnFxZYvWhd3fhBY9DLmC6Q== + yocto-queue@^0.1.0: version "0.1.0" resolved "https://registry.yarnpkg.com/yocto-queue/-/yocto-queue-0.1.0.tgz#0294eb3dee05028d31ee1a5fa2c556a6aaf10a1b" From db907de4d36c6392f35f5cfc65dcafe380fa3476 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 15 Mar 2022 21:23:45 -0700 Subject: [PATCH 5/8] add `build:types` and `build:types:watch` commands to main package.json --- package.json | 2 ++ scripts/build-types-watch.ts | 43 ++++++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+) create mode 100644 scripts/build-types-watch.ts diff --git a/package.json b/package.json index 5404e4d719b8..a333974ca7d0 100644 --- a/package.json +++ b/package.json @@ -8,8 +8,10 @@ "build:dev:filter": "lerna run --stream --concurrency 1 --sort build:dev --include-filtered-dependencies --include-filtered-dependents --scope", "build:es5": "yarn lerna run --stream --concurrency 1 --sort build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "lerna run --stream --concurrency 1 --sort build:esm", + "build:types": "lerna run --stream --concurrency 1 --sort build:types", "build:watch": "lerna run --parallel build:watch", "build:dev:watch": "lerna run --parallel build:dev:watch", + "build:types:watch": "ts-node scripts/build-types-watch.ts", "circularDepCheck": "lerna run --parallel circularDepCheck", "clean": "lerna run --parallel clean && lerna clean --yes", "codecov": "codecov", diff --git a/scripts/build-types-watch.ts b/scripts/build-types-watch.ts new file mode 100644 index 000000000000..d8a4cedb32aa --- /dev/null +++ b/scripts/build-types-watch.ts @@ -0,0 +1,43 @@ +/** + * If `yarn build:types:watch` is run without types files previously having been created, the build will get stuck in an + * errored state. This happens because lerna runs all of the packages' `yarn build:types:watch` statements in parallel, + * and so packages like `@sentry/browser` will at first be missing types they import from packages like `@sentry/utils` + * and `@sentry/types`, causing errors to be thrown. Normally this is fine, because as the dependencies' types get + * built, file changes will be detected and the dependent packages' types will try again to build themselves. There + * might be several rounds of this, but in theory, eventually all packages should end up with an error-free build. For + * whatever reason, though, at a certain point the process hangs, either because changes stop being detected or because + * recompiles stop being triggered by detected changes. + * + * Either way, the process gets stuck. The solution is to run a sequential build first, because as long as there are + * existing files the first time the watch command runs, no subsequent changes ever cause a hang, no matter how many + * rounds of recompilation are needed. (It's not entirely clear why this is the case.) We only want to take the time to + * do that if we have to, though, so we first check all of the relevant packages to see if there are pre-existing types + * files. + */ + +import * as childProcess from 'child_process'; +import * as fs from 'fs'; +import * as path from 'path'; + +const packages = fs.readdirSync(path.join(__dirname, '../packages')); + +for (const pkg of packages) { + const packagePath = path.join(__dirname, '../packages', pkg); + + if (!fs.lstatSync(packagePath).isDirectory() || !fs.readdirSync(packagePath).includes('package.json')) { + continue; + } + + const packageJSON = JSON.parse(fs.readFileSync(path.resolve(packagePath, 'package.json'), 'utf-8')); + + if ('build:types' in packageJSON.scripts && !fs.existsSync(path.resolve(packagePath, 'build/types'))) { + console.warn( + `\nWarning: Found no pre-existing types in package \`${pkg}\`. Performing a sequential types build before starting the watch process.\n`, + ); + childProcess.execSync('yarn build:types', { stdio: 'inherit' }); + break; + } +} + +console.log('\nStarting `yarn build:types:watch`.\n'); +childProcess.execSync('yarn lerna run --parallel build:types:watch', { stdio: 'inherit' }); From f6810e4e614aed918c39b3a8c9a22e37a3b79cdc Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 15 Mar 2022 21:38:33 -0700 Subject: [PATCH 6/8] add `build:types` and `build:types:watch` to `build`, `build:dev`, `build:watch`, and `build:dev:watch` commands --- packages/angular/package.json | 4 ++-- packages/browser/package.json | 8 ++++---- packages/core/package.json | 4 ++-- packages/gatsby/package.json | 4 ++-- packages/hub/package.json | 4 ++-- packages/integrations/package.json | 6 +++--- packages/minimal/package.json | 4 ++-- packages/nextjs/package.json | 4 ++-- packages/node/package.json | 4 ++-- packages/react/package.json | 4 ++-- packages/serverless/package.json | 6 +++--- packages/tracing/package.json | 6 +++--- packages/types/package.json | 4 ++-- packages/utils/package.json | 4 ++-- packages/vue/package.json | 6 +++--- packages/wasm/package.json | 6 +++--- 16 files changed, 39 insertions(+), 39 deletions(-) diff --git a/packages/angular/package.json b/packages/angular/package.json index 7e5fa9738683..2192f7b61f8c 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -33,13 +33,13 @@ "@angular/router": "^10.0.3" }, "scripts": { - "build": "run-p build:cjs build:esm", + "build": "run-p build:cjs build:esm build:types", "build:cjs": "tsc -p tsconfig.cjs.json", "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/browser/package.json b/packages/browser/package.json index e8383b33f537..4628ed94daf8 100644 --- a/packages/browser/package.json +++ b/packages/browser/package.json @@ -44,18 +44,18 @@ "webpack": "^4.30.0" }, "scripts": { - "build": "run-p build:cjs build:esm build:bundle", + "build": "run-p build:cjs build:esm build:bundle build:types", "build:bundle": "rollup --config", "build:cjs": "tsc -p tsconfig.cjs.json", - "build:dev": "run-p build:cjs build:esm", + "build:dev": "run-p build:cjs build:esm build:types", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch build:bundle:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:bundle:watch build:types:watch", "build:bundle:watch": "rollup --config --watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", - "build:dev:watch": "run-p build:cjs:watch build:esm:watch", + "build:dev:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", "build:types:watch": "tsc -p tsconfig.types.json --watch", "circularDepCheck": "madge --circular src/index.ts", diff --git a/packages/core/package.json b/packages/core/package.json index bf7e5c0aa404..8681a6c56126 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -23,13 +23,13 @@ "tslib": "^1.9.3" }, "scripts": { - "build": "run-p build:cjs build:esm", + "build": "run-p build:cjs build:esm build:types", "build:cjs": "tsc -p tsconfig.cjs.json", "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json index 4261565d20ff..4ffa3f12bcc2 100644 --- a/packages/gatsby/package.json +++ b/packages/gatsby/package.json @@ -40,13 +40,13 @@ "react": "^17.0.0" }, "scripts": { - "build": "run-p build:cjs build:esm", + "build": "run-p build:cjs build:esm build:types", "build:cjs": "tsc -p tsconfig.cjs.json", "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/hub/package.json b/packages/hub/package.json index 7fe3a4de48a9..48dcca448271 100644 --- a/packages/hub/package.json +++ b/packages/hub/package.json @@ -21,13 +21,13 @@ "tslib": "^1.9.3" }, "scripts": { - "build": "run-p build:cjs build:esm", + "build": "run-p build:cjs build:esm build:types", "build:cjs": "tsc -p tsconfig.cjs.json", "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/integrations/package.json b/packages/integrations/package.json index b0c9e6bf4bda..6217cef679ff 100644 --- a/packages/integrations/package.json +++ b/packages/integrations/package.json @@ -25,14 +25,14 @@ "chai": "^4.1.2" }, "scripts": { - "build": "run-p build:cjs build:esm build:bundle", + "build": "run-p build:cjs build:esm build:types build:bundle", "build:bundle": "bash scripts/buildBundles.sh", "build:cjs": "tsc -p tsconfig.cjs.json", - "build:dev": "run-s build:cjs build:esm", + "build:dev": "run-s build:cjs build:esm build:types", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/minimal/package.json b/packages/minimal/package.json index 181a3ccc2b0f..caaf28c056c2 100644 --- a/packages/minimal/package.json +++ b/packages/minimal/package.json @@ -21,13 +21,13 @@ "tslib": "^1.9.3" }, "scripts": { - "build": "run-p build:cjs build:esm", + "build": "run-p build:cjs build:esm build:types", "build:cjs": "tsc -p tsconfig.cjs.json", "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/nextjs/package.json b/packages/nextjs/package.json index 1f6f59a25ca4..6b020e33161c 100644 --- a/packages/nextjs/package.json +++ b/packages/nextjs/package.json @@ -43,13 +43,13 @@ } }, "scripts": { - "build": "run-p build:cjs build:esm", + "build": "run-p build:cjs build:esm build:types", "build:cjs": "tsc -p tsconfig.cjs.json", "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/node/package.json b/packages/node/package.json index dbcb8c414af1..c3a98df1a567 100644 --- a/packages/node/package.json +++ b/packages/node/package.json @@ -34,13 +34,13 @@ "nock": "^13.0.5" }, "scripts": { - "build": "run-p build:cjs build:esm", + "build": "run-p build:cjs build:esm build:types", "build:cjs": "tsc -p tsconfig.cjs.json", "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/react/package.json b/packages/react/package.json index b8d712682149..d84495e75c9e 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -50,13 +50,13 @@ "redux": "^4.0.5" }, "scripts": { - "build": "run-p build:cjs build:esm", + "build": "run-p build:cjs build:esm build:types", "build:cjs": "tsc -p tsconfig.cjs.json", "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/serverless/package.json b/packages/serverless/package.json index 602b00b34f14..56d98113a415 100644 --- a/packages/serverless/package.json +++ b/packages/serverless/package.json @@ -39,14 +39,14 @@ "read-pkg": "^5.2.0" }, "scripts": { - "build": "run-p build:cjs build:esm && yarn build:awslambda-layer", + "build": "run-p build:cjs build:esm build:types && yarn build:awslambda-layer", "build:awslambda-layer": "node scripts/build-awslambda-layer.js", "build:cjs": "tsc -p tsconfig.cjs.json", - "build:dev": "run-s build:cjs build:esm", + "build:dev": "run-s build:cjs build:esm build:types", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/tracing/package.json b/packages/tracing/package.json index f84e54ae3f93..750d8a803254 100644 --- a/packages/tracing/package.json +++ b/packages/tracing/package.json @@ -29,14 +29,14 @@ "jsdom": "^16.2.2" }, "scripts": { - "build": "run-p build:cjs build:esm build:bundle", + "build": "run-p build:cjs build:esm build:types build:bundle", "build:bundle": "rollup --config", "build:cjs": "tsc -p tsconfig.cjs.json", - "build:dev": "run-s build:cjs build:esm", + "build:dev": "run-s build:cjs build:esm build:types", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch build:bundle:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:bundle:watch build:types:watch", "build:bundle:watch": "rollup --config --watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", diff --git a/packages/types/package.json b/packages/types/package.json index 70a8db080dc6..b66d82cb0b54 100644 --- a/packages/types/package.json +++ b/packages/types/package.json @@ -16,13 +16,13 @@ "access": "public" }, "scripts": { - "build": "run-p build:cjs build:esm", + "build": "run-p build:cjs build:esm build:types", "build:cjs": "tsc -p tsconfig.cjs.json", "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/utils/package.json b/packages/utils/package.json index c09adc2f6215..0cf244405a81 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -24,13 +24,13 @@ "jsdom": "^16.2.2" }, "scripts": { - "build": "run-p build:cjs build:esm", + "build": "run-p build:cjs build:esm build:types", "build:cjs": "tsc -p tsconfig.cjs.json", "build:dev": "run-s build", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", diff --git a/packages/vue/package.json b/packages/vue/package.json index 202bdbb73faf..c16ae24441de 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -31,14 +31,14 @@ "jsdom": "^16.2.2" }, "scripts": { - "build": "run-p build:cjs build:esm build:bundle", + "build": "run-p build:cjs build:esm build:bundle build:types", "build:bundle": "rollup --config", "build:cjs": "tsc -p tsconfig.cjs.json", - "build:dev": "run-s build:cjs build:esm", + "build:dev": "run-s build:cjs build:esm build:types", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:bundle:watch": "rollup --config --watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", diff --git a/packages/wasm/package.json b/packages/wasm/package.json index c147031038a8..11cd54d22746 100644 --- a/packages/wasm/package.json +++ b/packages/wasm/package.json @@ -29,14 +29,14 @@ "puppeteer": "^5.5.0" }, "scripts": { - "build": "run-p build:cjs build:esm build:bundle", + "build": "run-p build:cjs build:esm build:bundle build:types", "build:bundle": "rollup --config", "build:cjs": "tsc -p tsconfig.cjs.json", - "build:dev": "run-s build:cjs build:esm", + "build:dev": "run-s build:cjs build:esm build:types", "build:es5": "yarn build:cjs # *** backwards compatibility - remove in v7 ***", "build:esm": "tsc -p tsconfig.esm.json", "build:types": "tsc -p tsconfig.types.json", - "build:watch": "run-p build:cjs:watch build:esm:watch", + "build:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:cjs:watch": "tsc -p tsconfig.cjs.json --watch", "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", From 1f2c96ed797c13e826ab4729cdbbd596a36fd689 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 15 Mar 2022 21:40:44 -0700 Subject: [PATCH 7/8] set package.json's `types` property to new output location --- packages/angular/package.json | 2 +- packages/browser/package.json | 2 +- packages/core/package.json | 2 +- packages/gatsby/package.json | 2 +- packages/hub/package.json | 2 +- packages/integrations/package.json | 2 +- packages/minimal/package.json | 2 +- packages/nextjs/package.json | 2 +- packages/node/package.json | 2 +- packages/react/package.json | 2 +- packages/serverless/package.json | 2 +- packages/tracing/package.json | 2 +- packages/types/package.json | 2 +- packages/utils/package.json | 2 +- packages/vue/package.json | 2 +- packages/wasm/package.json | 2 +- 16 files changed, 16 insertions(+), 16 deletions(-) diff --git a/packages/angular/package.json b/packages/angular/package.json index 2192f7b61f8c..e8ca4ee3884a 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/browser/package.json b/packages/browser/package.json index 4628ed94daf8..156f9dbc0071 100644 --- a/packages/browser/package.json +++ b/packages/browser/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/core/package.json b/packages/core/package.json index 8681a6c56126..127dafe394c5 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json index 4ffa3f12bcc2..0b48665f5761 100644 --- a/packages/gatsby/package.json +++ b/packages/gatsby/package.json @@ -15,7 +15,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "files": [ "/dist", "/esm", diff --git a/packages/hub/package.json b/packages/hub/package.json index 48dcca448271..f12f71cd72c8 100644 --- a/packages/hub/package.json +++ b/packages/hub/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/integrations/package.json b/packages/integrations/package.json index 6217cef679ff..b327f5f9043a 100644 --- a/packages/integrations/package.json +++ b/packages/integrations/package.json @@ -14,7 +14,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "dependencies": { "@sentry/types": "6.18.2", "@sentry/utils": "6.18.2", diff --git a/packages/minimal/package.json b/packages/minimal/package.json index caaf28c056c2..9d99416ee7bd 100644 --- a/packages/minimal/package.json +++ b/packages/minimal/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/nextjs/package.json b/packages/nextjs/package.json index 6b020e33161c..7121be3bb050 100644 --- a/packages/nextjs/package.json +++ b/packages/nextjs/package.json @@ -12,7 +12,7 @@ "main": "./dist/index.server.js", "module": "./esm/index.server.js", "browser": "./esm/index.client.js", - "types": "./esm/index.server.d.ts", + "types": "./build/types/index.server.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/node/package.json b/packages/node/package.json index c3a98df1a567..8db2ecd62641 100644 --- a/packages/node/package.json +++ b/packages/node/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/react/package.json b/packages/react/package.json index d84495e75c9e..9820b7a8dabb 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/serverless/package.json b/packages/serverless/package.json index 56d98113a415..874b70925e9f 100644 --- a/packages/serverless/package.json +++ b/packages/serverless/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/tracing/package.json b/packages/tracing/package.json index 750d8a803254..40cb4dfe9247 100644 --- a/packages/tracing/package.json +++ b/packages/tracing/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/types/package.json b/packages/types/package.json index b66d82cb0b54..30f7357907eb 100644 --- a/packages/types/package.json +++ b/packages/types/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/utils/package.json b/packages/utils/package.json index 0cf244405a81..34fc6e05bf1d 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/vue/package.json b/packages/vue/package.json index c16ae24441de..43106a6f1055 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, diff --git a/packages/wasm/package.json b/packages/wasm/package.json index 11cd54d22746..dfcb687f7a92 100644 --- a/packages/wasm/package.json +++ b/packages/wasm/package.json @@ -11,7 +11,7 @@ }, "main": "dist/index.js", "module": "esm/index.js", - "types": "dist/index.d.ts", + "types": "build/types/index.d.ts", "publishConfig": { "access": "public" }, From e84ffa8ab2880b455ec68b03bff8afc01ebf7ad1 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 15 Mar 2022 21:42:58 -0700 Subject: [PATCH 8/8] add todo to main tsconfig.json --- tsconfig.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tsconfig.json b/tsconfig.json index 7dd191ead9ef..f2ffa0c4e07c 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -2,6 +2,10 @@ "extends": "./packages/typescript/tsconfig.json", "compilerOptions": { + // TODO: turn these on once we switch to only generating types once, using `tsconfig.types.json` + // "declaration": false, + // "declarationMap": false, + "allowSyntheticDefaultImports": true, "types": ["node"], "noErrorTruncation": true // move me up to @sentry/typescript