From c1b599b97df898d2d585c01983cc13dc5e650405 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 14 Mar 2022 14:08:17 +0100 Subject: [PATCH 1/6] ref(build): rename `pack` npm scripts to `package` rename `pack` npm scripts in all `package.json`s to `package`. Previously, these `pack` scripts could cause confusion in connection with yarn, as `yarn pack` and `yarn run pack` would do different things: While running the former would trigger the pack command of yarn (as in `npm pack`), the latter would execute whatever is defined in the resp. `package.json` undder `pack`. Up to recently, this difference was not noticable in most SDKs because the `pack` npm script would simply be `npm pack`. However given that we're moving everything build-related into its own `build` directory, the pack script must point to the `package.json` inside `build`. As a consequence, `yarn run pack` and `yarn pack` will behave differently which can cause confusion when creating a tarball. --- .github/workflows/build.yml | 2 +- package.json | 2 +- packages/angular/package.json | 2 +- packages/browser/package.json | 2 +- packages/core/package.json | 2 +- packages/ember/package.json | 1 + packages/eslint-config-sdk/package.json | 2 +- packages/eslint-plugin-sdk/package.json | 2 +- packages/gatsby/package.json | 2 +- packages/hub/package.json | 2 +- packages/integrations/package.json | 2 +- packages/minimal/package.json | 2 +- packages/nextjs/package.json | 2 +- packages/node/package.json | 2 +- packages/react/package.json | 2 +- packages/serverless/package.json | 2 +- packages/tracing/package.json | 2 +- packages/types/package.json | 2 +- packages/typescript/package.json | 2 +- packages/utils/package.json | 2 +- packages/vue/package.json | 2 +- packages/wasm/package.json | 2 +- 22 files changed, 22 insertions(+), 21 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b93b34709ccf..e2e554d59b48 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -298,7 +298,7 @@ jobs: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} - name: Pack - run: yarn pack:changed + run: yarn package:changed - name: Archive artifacts uses: actions/upload-artifact@v2 with: diff --git a/package.json b/package.json index a333974ca7d0..652087f7f6c9 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,7 @@ "link:yarn": "lerna run --stream --concurrency 1 link:yarn", "lint": "lerna run --parallel lint", "lint:eslint": "lerna run --parallel lint:eslint", - "pack:changed": "lerna run pack --since", + "package:changed": "lerna run package --since", "prepublishOnly": "lerna run --stream --concurrency 1 prepublishOnly", "postpublish": "make publish-docs && lerna run --stream --concurrency 1 postpublish", "test": "lerna run --ignore @sentry-internal/browser-integration-tests --stream --concurrency 1 --sort test" diff --git a/packages/angular/package.json b/packages/angular/package.json index 1c9b6a806322..c24a7f60834d 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -54,7 +54,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack" + "package": "npm pack" }, "volta": { "extends": "../../package.json" diff --git a/packages/browser/package.json b/packages/browser/package.json index d8d16b4c87f0..4af06454fa06 100644 --- a/packages/browser/package.json +++ b/packages/browser/package.json @@ -67,7 +67,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack ./build", + "package": "npm pack ./build", "size:check": "run-p size:check:es5 size:check:es6", "size:check:es5": "cat build/bundles/bundle.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print \"ES5: \",$1,\"kB\";}'", "size:check:es6": "cat build/bundles/bundle.es6.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print \"ES6: \",$1,\"kB\";}'", diff --git a/packages/core/package.json b/packages/core/package.json index 1f2bff527a33..14b39142e724 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -44,7 +44,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "jest", "test:watch": "jest --watch", "version": "node ../../scripts/versionbump.js src/version.ts" diff --git a/packages/ember/package.json b/packages/ember/package.json index 170ee1cb3952..577d3bb08139 100644 --- a/packages/ember/package.json +++ b/packages/ember/package.json @@ -22,6 +22,7 @@ "lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*", "lint:hbs": "ember-template-lint .", "lint:js": "eslint . --cache --cache-location '../../eslintcache/'", + "package": "pack", "pack": "npm pack", "prepack": "ember ts:precompile", "postpack": "ember ts:clean", diff --git a/packages/eslint-config-sdk/package.json b/packages/eslint-config-sdk/package.json index f6d079032474..e9036661d69f 100644 --- a/packages/eslint-config-sdk/package.json +++ b/packages/eslint-config-sdk/package.json @@ -39,7 +39,7 @@ "link:yarn": "yarn link", "lint": "prettier --check \"**/*.js\"", "fix": "prettier --write \"**/*.js\"", - "pack": "npm pack", + "package": "npm pack", "circularDepCheck": "madge --circular src/index.js" }, "volta": { diff --git a/packages/eslint-plugin-sdk/package.json b/packages/eslint-plugin-sdk/package.json index a15755fa1ca3..f05ef433a849 100644 --- a/packages/eslint-plugin-sdk/package.json +++ b/packages/eslint-plugin-sdk/package.json @@ -33,7 +33,7 @@ "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.js\"", "test": "mocha test --recursive", - "pack": "npm pack", + "package": "npm pack", "circularDepCheck": "madge --circular src/index.js" }, "volta": { diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json index 08a5f6a9f3d7..a76d6f7e81bd 100644 --- a/packages/gatsby/package.json +++ b/packages/gatsby/package.json @@ -61,7 +61,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/hub/package.json b/packages/hub/package.json index 6fb1bd17482e..c8440cc8611d 100644 --- a/packages/hub/package.json +++ b/packages/hub/package.json @@ -42,7 +42,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/integrations/package.json b/packages/integrations/package.json index 7b7b7dd094b5..58ccfaafb84f 100644 --- a/packages/integrations/package.json +++ b/packages/integrations/package.json @@ -47,7 +47,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/minimal/package.json b/packages/minimal/package.json index 9407c6a811f3..fa8dbd2c85cc 100644 --- a/packages/minimal/package.json +++ b/packages/minimal/package.json @@ -42,7 +42,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/nextjs/package.json b/packages/nextjs/package.json index 2c1b8795ceb0..af1390bdcc27 100644 --- a/packages/nextjs/package.json +++ b/packages/nextjs/package.json @@ -64,7 +64,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "run-s test:unit", "test:all": "run-s test:unit test:integration", "test:unit": "jest", diff --git a/packages/node/package.json b/packages/node/package.json index a929c9d908b9..fbad637ea967 100644 --- a/packages/node/package.json +++ b/packages/node/package.json @@ -55,7 +55,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "run-s test:jest test:express test:webpack test:release-health", "test:express": "node test/manual/express-scope-separation/start.js", "test:jest": "jest", diff --git a/packages/react/package.json b/packages/react/package.json index 2f3158afe4b0..a1b187f6fcf0 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -71,7 +71,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/serverless/package.json b/packages/serverless/package.json index 251473fc78ab..e5527ba9e91e 100644 --- a/packages/serverless/package.json +++ b/packages/serverless/package.json @@ -61,7 +61,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/tracing/package.json b/packages/tracing/package.json index b0074e0932da..b0cde65dafa7 100644 --- a/packages/tracing/package.json +++ b/packages/tracing/package.json @@ -52,7 +52,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/types/package.json b/packages/types/package.json index 4d385952ced4..673d3cdb46f7 100644 --- a/packages/types/package.json +++ b/packages/types/package.json @@ -35,7 +35,7 @@ "fix": "run-s fix:eslint fix:prettier", "fix:eslint": "eslint . --format stylish --fix", "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"", - "pack": "npm pack" + "package": "npm pack" }, "volta": { "extends": "../../package.json" diff --git a/packages/typescript/package.json b/packages/typescript/package.json index 292559df80de..895c1041d7bd 100644 --- a/packages/typescript/package.json +++ b/packages/typescript/package.json @@ -20,7 +20,7 @@ }, "scripts": { "link:yarn": "yarn link", - "pack": "npm pack" + "package": "npm pack" }, "volta": { "extends": "../../package.json" diff --git a/packages/utils/package.json b/packages/utils/package.json index 1c4f370ad52d..a27fc389abe7 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -45,7 +45,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "jest", "test:watch": "jest --watch", "test:package": "node test/types/index.js" diff --git a/packages/vue/package.json b/packages/vue/package.json index a6d407467a17..b7d7ed6238aa 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -54,7 +54,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/wasm/package.json b/packages/wasm/package.json index 5b198ab52fc7..bc3eafa7143d 100644 --- a/packages/wasm/package.json +++ b/packages/wasm/package.json @@ -51,7 +51,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "pack": "npm pack", + "package": "npm pack", "test": "node test/scripts/ensure-browser-bundle.js && cross-env PORT=1337 jest", "test:watch": "jest --watch" }, From 9baaeebaffa7b65874b7b1644d0d462de9fa5f5c Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 14 Mar 2022 15:39:07 +0100 Subject: [PATCH 2/6] fix ember `package` script --- packages/ember/package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/ember/package.json b/packages/ember/package.json index 577d3bb08139..9f037800932b 100644 --- a/packages/ember/package.json +++ b/packages/ember/package.json @@ -22,8 +22,7 @@ "lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*", "lint:hbs": "ember-template-lint .", "lint:js": "eslint . --cache --cache-location '../../eslintcache/'", - "package": "pack", - "pack": "npm pack", + "package": "run-s prepack && npm pack && run-s postpack", "prepack": "ember ts:precompile", "postpack": "ember ts:clean", "start": "ember serve", From 053008709f766f777c73b9df0fcf0ae6844e3f41 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 14 Mar 2022 17:42:39 +0100 Subject: [PATCH 3/6] ref(build): rename package to createTarball --- .github/workflows/build.yml | 2 +- package.json | 2 +- packages/angular/package.json | 2 +- packages/browser/package.json | 2 +- packages/core/package.json | 2 +- packages/ember/package.json | 2 +- packages/eslint-config-sdk/package.json | 2 +- packages/eslint-plugin-sdk/package.json | 2 +- packages/gatsby/package.json | 2 +- packages/hub/package.json | 2 +- packages/integrations/package.json | 2 +- packages/minimal/package.json | 2 +- packages/nextjs/package.json | 2 +- packages/node/package.json | 2 +- packages/react/package.json | 2 +- packages/serverless/package.json | 2 +- packages/tracing/package.json | 2 +- packages/types/package.json | 2 +- packages/typescript/package.json | 2 +- packages/utils/package.json | 2 +- packages/vue/package.json | 2 +- packages/wasm/package.json | 2 +- 22 files changed, 22 insertions(+), 22 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e2e554d59b48..7bb460dad4c7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -298,7 +298,7 @@ jobs: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} - name: Pack - run: yarn package:changed + run: yarn createTarball:changed - name: Archive artifacts uses: actions/upload-artifact@v2 with: diff --git a/package.json b/package.json index 652087f7f6c9..627dbc125122 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,7 @@ "link:yarn": "lerna run --stream --concurrency 1 link:yarn", "lint": "lerna run --parallel lint", "lint:eslint": "lerna run --parallel lint:eslint", - "package:changed": "lerna run package --since", + "createTarball:changed": "lerna run createTarball --since", "prepublishOnly": "lerna run --stream --concurrency 1 prepublishOnly", "postpublish": "make publish-docs && lerna run --stream --concurrency 1 postpublish", "test": "lerna run --ignore @sentry-internal/browser-integration-tests --stream --concurrency 1 --sort test" diff --git a/packages/angular/package.json b/packages/angular/package.json index c24a7f60834d..e9c73cba2d77 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -54,7 +54,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack" + "createTarball": "npm pack" }, "volta": { "extends": "../../package.json" diff --git a/packages/browser/package.json b/packages/browser/package.json index 4af06454fa06..f4dd2ac5a030 100644 --- a/packages/browser/package.json +++ b/packages/browser/package.json @@ -67,7 +67,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack ./build", + "createTarball": "npm pack ./build", "size:check": "run-p size:check:es5 size:check:es6", "size:check:es5": "cat build/bundles/bundle.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print \"ES5: \",$1,\"kB\";}'", "size:check:es6": "cat build/bundles/bundle.es6.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print \"ES6: \",$1,\"kB\";}'", diff --git a/packages/core/package.json b/packages/core/package.json index 14b39142e724..c690b9772934 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -44,7 +44,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch", "version": "node ../../scripts/versionbump.js src/version.ts" diff --git a/packages/ember/package.json b/packages/ember/package.json index 9f037800932b..ddc24dcdd48e 100644 --- a/packages/ember/package.json +++ b/packages/ember/package.json @@ -22,7 +22,7 @@ "lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*", "lint:hbs": "ember-template-lint .", "lint:js": "eslint . --cache --cache-location '../../eslintcache/'", - "package": "run-s prepack && npm pack && run-s postpack", + "createTarball": "run-s prepack && npm pack && run-s postpack", "prepack": "ember ts:precompile", "postpack": "ember ts:clean", "start": "ember serve", diff --git a/packages/eslint-config-sdk/package.json b/packages/eslint-config-sdk/package.json index e9036661d69f..66ad091525d0 100644 --- a/packages/eslint-config-sdk/package.json +++ b/packages/eslint-config-sdk/package.json @@ -39,7 +39,7 @@ "link:yarn": "yarn link", "lint": "prettier --check \"**/*.js\"", "fix": "prettier --write \"**/*.js\"", - "package": "npm pack", + "createTarball": "npm pack", "circularDepCheck": "madge --circular src/index.js" }, "volta": { diff --git a/packages/eslint-plugin-sdk/package.json b/packages/eslint-plugin-sdk/package.json index f05ef433a849..ac42df4b27f3 100644 --- a/packages/eslint-plugin-sdk/package.json +++ b/packages/eslint-plugin-sdk/package.json @@ -33,7 +33,7 @@ "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.js\"", "test": "mocha test --recursive", - "package": "npm pack", + "createTarball": "npm pack", "circularDepCheck": "madge --circular src/index.js" }, "volta": { diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json index a76d6f7e81bd..6eefccdc841a 100644 --- a/packages/gatsby/package.json +++ b/packages/gatsby/package.json @@ -61,7 +61,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/hub/package.json b/packages/hub/package.json index c8440cc8611d..15ffe8793782 100644 --- a/packages/hub/package.json +++ b/packages/hub/package.json @@ -42,7 +42,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/integrations/package.json b/packages/integrations/package.json index 58ccfaafb84f..4d54139a6b80 100644 --- a/packages/integrations/package.json +++ b/packages/integrations/package.json @@ -47,7 +47,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/minimal/package.json b/packages/minimal/package.json index fa8dbd2c85cc..63c0c6d7a53a 100644 --- a/packages/minimal/package.json +++ b/packages/minimal/package.json @@ -42,7 +42,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/nextjs/package.json b/packages/nextjs/package.json index af1390bdcc27..96fa743b19d8 100644 --- a/packages/nextjs/package.json +++ b/packages/nextjs/package.json @@ -64,7 +64,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "run-s test:unit", "test:all": "run-s test:unit test:integration", "test:unit": "jest", diff --git a/packages/node/package.json b/packages/node/package.json index fbad637ea967..950ff9ffb088 100644 --- a/packages/node/package.json +++ b/packages/node/package.json @@ -55,7 +55,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "run-s test:jest test:express test:webpack test:release-health", "test:express": "node test/manual/express-scope-separation/start.js", "test:jest": "jest", diff --git a/packages/react/package.json b/packages/react/package.json index a1b187f6fcf0..f48e6d6edaf7 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -71,7 +71,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/serverless/package.json b/packages/serverless/package.json index e5527ba9e91e..bdbbce3f95e7 100644 --- a/packages/serverless/package.json +++ b/packages/serverless/package.json @@ -61,7 +61,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/tracing/package.json b/packages/tracing/package.json index b0cde65dafa7..e1b050e576cb 100644 --- a/packages/tracing/package.json +++ b/packages/tracing/package.json @@ -52,7 +52,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/types/package.json b/packages/types/package.json index 673d3cdb46f7..e09164a85a68 100644 --- a/packages/types/package.json +++ b/packages/types/package.json @@ -35,7 +35,7 @@ "fix": "run-s fix:eslint fix:prettier", "fix:eslint": "eslint . --format stylish --fix", "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"", - "package": "npm pack" + "createTarball": "npm pack" }, "volta": { "extends": "../../package.json" diff --git a/packages/typescript/package.json b/packages/typescript/package.json index 895c1041d7bd..496ed3192503 100644 --- a/packages/typescript/package.json +++ b/packages/typescript/package.json @@ -20,7 +20,7 @@ }, "scripts": { "link:yarn": "yarn link", - "package": "npm pack" + "createTarball": "npm pack" }, "volta": { "extends": "../../package.json" diff --git a/packages/utils/package.json b/packages/utils/package.json index a27fc389abe7..4ea579e61876 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -45,7 +45,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch", "test:package": "node test/types/index.js" diff --git a/packages/vue/package.json b/packages/vue/package.json index b7d7ed6238aa..f7eedcbc2505 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -54,7 +54,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/wasm/package.json b/packages/wasm/package.json index bc3eafa7143d..c6904ced1a81 100644 --- a/packages/wasm/package.json +++ b/packages/wasm/package.json @@ -51,7 +51,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "package": "npm pack", + "createTarball": "npm pack", "test": "node test/scripts/ensure-browser-bundle.js && cross-env PORT=1337 jest", "test:watch": "jest --watch" }, From f8d295db778413ba45f3e0e42691df24f7083906 Mon Sep 17 00:00:00 2001 From: Lukas Strack Date: Thu, 17 Mar 2022 15:00:38 +0100 Subject: [PATCH 4/6] ref(build): rename `createTarball` to `build:npm` --- .github/workflows/build.yml | 2 +- package.json | 2 +- packages/angular/package.json | 4 ++-- packages/browser/package.json | 2 +- packages/core/package.json | 3 +-- packages/ember/package.json | 2 +- packages/eslint-config-sdk/package.json | 2 +- packages/eslint-plugin-sdk/package.json | 2 +- packages/gatsby/package.json | 2 +- packages/hub/package.json | 2 +- packages/integrations/package.json | 2 +- packages/minimal/package.json | 2 +- packages/nextjs/package.json | 3 +-- packages/node/package.json | 2 +- packages/react/package.json | 3 +-- packages/serverless/package.json | 3 +-- packages/tracing/package.json | 2 +- packages/types/package.json | 4 ++-- packages/typescript/package.json | 2 +- packages/utils/package.json | 2 +- packages/vue/package.json | 2 +- packages/wasm/package.json | 2 +- 22 files changed, 24 insertions(+), 28 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7bb460dad4c7..5cc4017acd3d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -298,7 +298,7 @@ jobs: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} - name: Pack - run: yarn createTarball:changed + run: yarn build:npm:changed - name: Archive artifacts uses: actions/upload-artifact@v2 with: diff --git a/package.json b/package.json index 627dbc125122..a8ed0a425df1 100644 --- a/package.json +++ b/package.json @@ -12,6 +12,7 @@ "build:watch": "lerna run --parallel build:watch", "build:dev:watch": "lerna run --parallel build:dev:watch", "build:types:watch": "ts-node scripts/build-types-watch.ts", + "build:npm:changed": "lerna run build:npm --since", "circularDepCheck": "lerna run --parallel circularDepCheck", "clean": "lerna run --parallel clean && lerna clean --yes", "codecov": "codecov", @@ -19,7 +20,6 @@ "link:yarn": "lerna run --stream --concurrency 1 link:yarn", "lint": "lerna run --parallel lint", "lint:eslint": "lerna run --parallel lint:eslint", - "createTarball:changed": "lerna run createTarball --since", "prepublishOnly": "lerna run --stream --concurrency 1 prepublishOnly", "postpublish": "make publish-docs && lerna run --stream --concurrency 1 postpublish", "test": "lerna run --ignore @sentry-internal/browser-integration-tests --stream --concurrency 1 --sort test" diff --git a/packages/angular/package.json b/packages/angular/package.json index e9c73cba2d77..07337f7b4e89 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -45,6 +45,7 @@ "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build coverage", "fix": "run-s fix:eslint fix:prettier", @@ -53,8 +54,7 @@ "link:yarn": "yarn link", "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", - "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack" + "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"" }, "volta": { "extends": "../../package.json" diff --git a/packages/browser/package.json b/packages/browser/package.json index f4dd2ac5a030..45709509d1a8 100644 --- a/packages/browser/package.json +++ b/packages/browser/package.json @@ -58,6 +58,7 @@ "build:dev:watch": "run-p build:cjs:watch build:esm:watch build:types:watch", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack ./build", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf build coverage .rpt2_cache", "fix": "run-s fix:eslint fix:prettier", @@ -67,7 +68,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack ./build", "size:check": "run-p size:check:es5 size:check:es6", "size:check:es5": "cat build/bundles/bundle.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print \"ES5: \",$1,\"kB\";}'", "size:check:es6": "cat build/bundles/bundle.es6.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print \"ES6: \",$1,\"kB\";}'", diff --git a/packages/core/package.json b/packages/core/package.json index c690b9772934..b5f868906686 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -34,7 +34,7 @@ "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", - "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm coverage", "fix": "run-s fix:eslint fix:prettier", @@ -44,7 +44,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch", "version": "node ../../scripts/versionbump.js src/version.ts" diff --git a/packages/ember/package.json b/packages/ember/package.json index ddc24dcdd48e..45d7ef8ac8c4 100644 --- a/packages/ember/package.json +++ b/packages/ember/package.json @@ -18,11 +18,11 @@ }, "scripts": { "build": "ember build --environment=production", + "build:npm": "run-s prepack && npm pack && run-s postpack", "link:yarn": "yarn link", "lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*", "lint:hbs": "ember-template-lint .", "lint:js": "eslint . --cache --cache-location '../../eslintcache/'", - "createTarball": "run-s prepack && npm pack && run-s postpack", "prepack": "ember ts:precompile", "postpack": "ember ts:clean", "start": "ember serve", diff --git a/packages/eslint-config-sdk/package.json b/packages/eslint-config-sdk/package.json index 66ad091525d0..e40f0eb4cad0 100644 --- a/packages/eslint-config-sdk/package.json +++ b/packages/eslint-config-sdk/package.json @@ -39,7 +39,7 @@ "link:yarn": "yarn link", "lint": "prettier --check \"**/*.js\"", "fix": "prettier --write \"**/*.js\"", - "createTarball": "npm pack", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.js" }, "volta": { diff --git a/packages/eslint-plugin-sdk/package.json b/packages/eslint-plugin-sdk/package.json index ac42df4b27f3..ffd305ddd688 100644 --- a/packages/eslint-plugin-sdk/package.json +++ b/packages/eslint-plugin-sdk/package.json @@ -33,7 +33,7 @@ "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.js\"", "test": "mocha test --recursive", - "createTarball": "npm pack", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.js" }, "volta": { diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json index 6eefccdc841a..9ee76158aa75 100644 --- a/packages/gatsby/package.json +++ b/packages/gatsby/package.json @@ -52,6 +52,7 @@ "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build coverage", "fix": "run-s fix:eslint fix:prettier", @@ -61,7 +62,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/hub/package.json b/packages/hub/package.json index 15ffe8793782..5896357d7bbd 100644 --- a/packages/hub/package.json +++ b/packages/hub/package.json @@ -42,7 +42,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", + "build:npm": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/integrations/package.json b/packages/integrations/package.json index 4d54139a6b80..a04b2d06d567 100644 --- a/packages/integrations/package.json +++ b/packages/integrations/package.json @@ -38,6 +38,7 @@ "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build coverage .rpt2_cache", "fix": "run-s fix:eslint fix:prettier", @@ -47,7 +48,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/minimal/package.json b/packages/minimal/package.json index 63c0c6d7a53a..b6ffddc01590 100644 --- a/packages/minimal/package.json +++ b/packages/minimal/package.json @@ -42,7 +42,7 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", + "build:npm": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/nextjs/package.json b/packages/nextjs/package.json index 96fa743b19d8..d6c60e7e1df7 100644 --- a/packages/nextjs/package.json +++ b/packages/nextjs/package.json @@ -54,7 +54,7 @@ "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", - "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.client.ts && madge --circular --exclude 'config/types\\.ts' src/index.server.ts # see https://github.com/pahen/madge/issues/306", "clean": "rimraf dist esm coverage *.js *.js.map *.d.ts", "fix": "run-s fix:eslint fix:prettier", @@ -64,7 +64,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", "test": "run-s test:unit", "test:all": "run-s test:unit test:integration", "test:unit": "jest", diff --git a/packages/node/package.json b/packages/node/package.json index 950ff9ffb088..b7fc110664bb 100644 --- a/packages/node/package.json +++ b/packages/node/package.json @@ -46,6 +46,7 @@ "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm coverage", "fix": "run-s fix:eslint fix:prettier", @@ -55,7 +56,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", "test": "run-s test:jest test:express test:webpack test:release-health", "test:express": "node test/manual/express-scope-separation/start.js", "test:jest": "jest", diff --git a/packages/react/package.json b/packages/react/package.json index f48e6d6edaf7..cb35fae8949b 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -61,7 +61,7 @@ "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", - "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build coverage", "fix": "run-s fix:eslint fix:prettier", @@ -71,7 +71,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/serverless/package.json b/packages/serverless/package.json index bdbbce3f95e7..885079f63641 100644 --- a/packages/serverless/package.json +++ b/packages/serverless/package.json @@ -51,7 +51,7 @@ "build:dev:watch": "run-s build:watch", "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", - "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build dist-awslambda-layer coverage", "fix": "run-s fix:eslint fix:prettier", @@ -61,7 +61,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/tracing/package.json b/packages/tracing/package.json index e1b050e576cb..7f18bfafbc8e 100644 --- a/packages/tracing/package.json +++ b/packages/tracing/package.json @@ -43,6 +43,7 @@ "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "clean": "rimraf dist esm build coverage", "circularDepCheck": "madge --circular src/index.ts", "fix": "run-s fix:eslint fix:prettier", @@ -52,7 +53,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/types/package.json b/packages/types/package.json index e09164a85a68..913db1701b93 100644 --- a/packages/types/package.json +++ b/packages/types/package.json @@ -28,14 +28,14 @@ "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "link:yarn": "yarn link", "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", "fix": "run-s fix:eslint fix:prettier", "fix:eslint": "eslint . --format stylish --fix", - "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"", - "createTarball": "npm pack" + "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"" }, "volta": { "extends": "../../package.json" diff --git a/packages/typescript/package.json b/packages/typescript/package.json index 496ed3192503..8b0e7a74aa4f 100644 --- a/packages/typescript/package.json +++ b/packages/typescript/package.json @@ -20,7 +20,7 @@ }, "scripts": { "link:yarn": "yarn link", - "createTarball": "npm pack" + "build:npm": "npm pack" }, "volta": { "extends": "../../package.json" diff --git a/packages/utils/package.json b/packages/utils/package.json index 4ea579e61876..d45ed8f3daab 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -36,6 +36,7 @@ "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm coverage *.js *.js.map *.d.ts", "fix": "run-s fix:eslint fix:prettier", @@ -45,7 +46,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch", "test:package": "node test/types/index.js" diff --git a/packages/vue/package.json b/packages/vue/package.json index f7eedcbc2505..6dc5069dc8f2 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -45,6 +45,7 @@ "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm build coverage", "fix": "run-s fix:eslint fix:prettier", @@ -54,7 +55,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", "test": "jest", "test:watch": "jest --watch" }, diff --git a/packages/wasm/package.json b/packages/wasm/package.json index c6904ced1a81..a3c93346a7c9 100644 --- a/packages/wasm/package.json +++ b/packages/wasm/package.json @@ -42,6 +42,7 @@ "build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***", "build:esm:watch": "tsc -p tsconfig.esm.json --watch", "build:types:watch": "tsc -p tsconfig.types.json --watch", + "build:npm": "npm pack", "circularDepCheck": "madge --circular src/index.ts", "clean": "rimraf dist esm coverage *.js.map *.d.ts", "fix": "run-s fix:eslint fix:prettier", @@ -51,7 +52,6 @@ "lint": "run-s lint:prettier lint:eslint", "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish", "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"", - "createTarball": "npm pack", "test": "node test/scripts/ensure-browser-bundle.js && cross-env PORT=1337 jest", "test:watch": "jest --watch" }, From 7796d16d42c220a6d2898e9d823842aed176464c Mon Sep 17 00:00:00 2001 From: Lukas Strack Date: Fri, 18 Mar 2022 09:30:40 +0100 Subject: [PATCH 5/6] remove `--since` flag and add `--parallel` flag to `package.json` --- .github/workflows/build.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5cc4017acd3d..5908a2c65667 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -298,7 +298,7 @@ jobs: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} - name: Pack - run: yarn build:npm:changed + run: yarn build:npm - name: Archive artifacts uses: actions/upload-artifact@v2 with: diff --git a/package.json b/package.json index a8ed0a425df1..0cb310507efa 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "build:watch": "lerna run --parallel build:watch", "build:dev:watch": "lerna run --parallel build:dev:watch", "build:types:watch": "ts-node scripts/build-types-watch.ts", - "build:npm:changed": "lerna run build:npm --since", + "build:npm": "lerna run --parallel build:npm", "circularDepCheck": "lerna run --parallel circularDepCheck", "clean": "lerna run --parallel clean && lerna clean --yes", "codecov": "codecov", From e18a5e661f93d9b5f6fd0f863251610ebb38184d Mon Sep 17 00:00:00 2001 From: Lukas Strack Date: Fri, 18 Mar 2022 09:34:15 +0100 Subject: [PATCH 6/6] inline pre-/postpack with pack in ember package.json --- packages/ember/package.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/ember/package.json b/packages/ember/package.json index 45d7ef8ac8c4..8b53589c693f 100644 --- a/packages/ember/package.json +++ b/packages/ember/package.json @@ -18,13 +18,11 @@ }, "scripts": { "build": "ember build --environment=production", - "build:npm": "run-s prepack && npm pack && run-s postpack", + "build:npm": "ember ts:precompile && npm pack && ember ts:clean", "link:yarn": "yarn link", "lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*", "lint:hbs": "ember-template-lint .", "lint:js": "eslint . --cache --cache-location '../../eslintcache/'", - "prepack": "ember ts:precompile", - "postpack": "ember ts:clean", "start": "ember serve", "test": "ember try:each", "test:all": "node ./scripts/run-CI-tests.js"