From b4fd54aa66724f4dcd62139bf7bbb7e43cf6fa39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20Og=C3=B3rek?= Date: Thu, 5 Nov 2020 15:43:20 +0100 Subject: [PATCH] fix: Remove globalThis usage --- packages/browser/src/transports/base.ts | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/packages/browser/src/transports/base.ts b/packages/browser/src/transports/base.ts index c33a0ae53f3c..bbed12ca641d 100644 --- a/packages/browser/src/transports/base.ts +++ b/packages/browser/src/transports/base.ts @@ -1,5 +1,12 @@ import { API } from '@sentry/core'; -import { Event, Response, SentryRequestType, Status, Transport, TransportOptions } from '@sentry/types'; +import { + Event, + Response as SentryResponse, + SentryRequestType, + Status, + Transport, + TransportOptions, +} from '@sentry/types'; import { logger, parseRetryAfterHeader, PromiseBuffer, SentryError } from '@sentry/utils'; /** Base Transport class implementation */ @@ -13,7 +20,7 @@ export abstract class BaseTransport implements Transport { protected readonly _api: API; /** A simple buffer holding all requests. */ - protected readonly _buffer: PromiseBuffer = new PromiseBuffer(30); + protected readonly _buffer: PromiseBuffer = new PromiseBuffer(30); /** Locks transport after receiving rate limits in a response */ protected readonly _rateLimits: Record = {}; @@ -27,7 +34,7 @@ export abstract class BaseTransport implements Transport { /** * @inheritDoc */ - public sendEvent(_: Event): PromiseLike { + public sendEvent(_: Event): PromiseLike { throw new SentryError('Transport Class has to implement `sendEvent` method'); } @@ -49,9 +56,9 @@ export abstract class BaseTransport implements Transport { reject, }: { requestType: SentryRequestType; - response: globalThis.Response | XMLHttpRequest; + response: Response | XMLHttpRequest; headers: Record; - resolve: (value?: Response | PromiseLike | null | undefined) => void; + resolve: (value?: SentryResponse | PromiseLike | null | undefined) => void; reject: (reason?: unknown) => void; }): void { const status = Status.fromHttpCode(response.status);