From 5d5076448f669119083226036af488d57ffa94fa Mon Sep 17 00:00:00 2001 From: Charly Gomez Date: Mon, 5 May 2025 11:51:26 +0200 Subject: [PATCH 1/3] extend default list --- packages/replay-internal/src/integration.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/replay-internal/src/integration.ts b/packages/replay-internal/src/integration.ts index bc916ba591a8..6db78dced270 100644 --- a/packages/replay-internal/src/integration.ts +++ b/packages/replay-internal/src/integration.ts @@ -95,7 +95,7 @@ export class Replay implements Integration { networkResponseHeaders = [], mask = [], - maskAttributes = ['title', 'placeholder'], + maskAttributes = ['title', 'placeholder', 'aria-label'], unmask = [], block = [], unblock = [], From 63ae059ffd02fa8c483d0e3a3af8ab5df79981ab Mon Sep 17 00:00:00 2001 From: Charly Gomez Date: Wed, 14 May 2025 12:03:09 +0200 Subject: [PATCH 2/3] update privacy snapshot tests --- .../privacyDefault/test.ts-snapshots/privacy-chromium.json | 2 +- .../privacyDefault/test.ts-snapshots/privacy-firefox.json | 2 +- .../replay/privacyDefault/test.ts-snapshots/privacy-webkit.json | 2 +- .../suites/replay/privacyDefault/test.ts-snapshots/privacy.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-chromium.json b/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-chromium.json index e04944384bbd..d27e1dc96634 100644 --- a/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-chromium.json +++ b/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-chromium.json @@ -62,7 +62,7 @@ "type": 2, "tagName": "button", "attributes": { - "aria-label": "Click me", + "aria-label": "***** **", "onclick": "console.log('Test log')" }, "childNodes": [ diff --git a/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-firefox.json b/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-firefox.json index a57a8507fda9..14f3d7989f57 100644 --- a/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-firefox.json +++ b/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-firefox.json @@ -62,7 +62,7 @@ "type": 2, "tagName": "button", "attributes": { - "aria-label": "Click me", + "aria-label": "***** **", "onclick": "console.log('Test log')" }, "childNodes": [ diff --git a/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-webkit.json b/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-webkit.json index e04944384bbd..d27e1dc96634 100644 --- a/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-webkit.json +++ b/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy-webkit.json @@ -62,7 +62,7 @@ "type": 2, "tagName": "button", "attributes": { - "aria-label": "Click me", + "aria-label": "***** **", "onclick": "console.log('Test log')" }, "childNodes": [ diff --git a/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy.json b/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy.json index 16c4caf2ed69..dd5cc92a7723 100644 --- a/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy.json +++ b/dev-packages/browser-integration-tests/suites/replay/privacyDefault/test.ts-snapshots/privacy.json @@ -62,7 +62,7 @@ "type": 2, "tagName": "button", "attributes": { - "aria-label": "Click me", + "aria-label": "***** **", "onclick": "console.log('Test log')" }, "childNodes": [ From b4147e131c700ce4ea48d71e6aac7fa9ad4229d8 Mon Sep 17 00:00:00 2001 From: Charly Gomez Date: Wed, 14 May 2025 13:08:09 +0200 Subject: [PATCH 3/3] update more aria label tests --- .../suites/replay/customEvents/test.ts | 2 +- .../replay/privacyBlock/test.ts-snapshots/privacy-chromium.json | 2 +- .../replay/privacyBlock/test.ts-snapshots/privacy-firefox.json | 2 +- .../replay/privacyBlock/test.ts-snapshots/privacy-webkit.json | 2 +- .../suites/replay/privacyBlock/test.ts-snapshots/privacy.json | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dev-packages/browser-integration-tests/suites/replay/customEvents/test.ts b/dev-packages/browser-integration-tests/suites/replay/customEvents/test.ts index 1d5eda8697f1..336e09a331e1 100644 --- a/dev-packages/browser-integration-tests/suites/replay/customEvents/test.ts +++ b/dev-packages/browser-integration-tests/suites/replay/customEvents/test.ts @@ -104,7 +104,7 @@ sentryTest( nodeId: expect.any(Number), node: { attributes: { - 'aria-label': 'An Error in aria-label', + 'aria-label': '** ***** ** **********', class: 'btn btn-error', id: 'error', role: 'button', diff --git a/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-chromium.json b/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-chromium.json index a3c9c494b0b5..4ac06ffeb444 100644 --- a/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-chromium.json +++ b/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-chromium.json @@ -62,7 +62,7 @@ "type": 2, "tagName": "button", "attributes": { - "aria-label": "Click me", + "aria-label": "***** **", "onclick": "console.log('Test log')" }, "childNodes": [ diff --git a/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-firefox.json b/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-firefox.json index a3c9c494b0b5..4ac06ffeb444 100644 --- a/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-firefox.json +++ b/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-firefox.json @@ -62,7 +62,7 @@ "type": 2, "tagName": "button", "attributes": { - "aria-label": "Click me", + "aria-label": "***** **", "onclick": "console.log('Test log')" }, "childNodes": [ diff --git a/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-webkit.json b/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-webkit.json index a3c9c494b0b5..4ac06ffeb444 100644 --- a/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-webkit.json +++ b/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-webkit.json @@ -62,7 +62,7 @@ "type": 2, "tagName": "button", "attributes": { - "aria-label": "Click me", + "aria-label": "***** **", "onclick": "console.log('Test log')" }, "childNodes": [ diff --git a/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy.json b/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy.json index a3c9c494b0b5..4ac06ffeb444 100644 --- a/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy.json +++ b/dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy.json @@ -62,7 +62,7 @@ "type": 2, "tagName": "button", "attributes": { - "aria-label": "Click me", + "aria-label": "***** **", "onclick": "console.log('Test log')" }, "childNodes": [