From a6dd7c86e470cc57b430130dd018bc9d2b8e5555 Mon Sep 17 00:00:00 2001
From: Charly Gomez <charly.gomez@sentry.io>
Date: Wed, 19 Mar 2025 13:04:51 +0100
Subject: [PATCH] early return on breadcrumbs disabled

---
 .../integrations/http/SentryHttpInstrumentation.ts  | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/packages/node/src/integrations/http/SentryHttpInstrumentation.ts b/packages/node/src/integrations/http/SentryHttpInstrumentation.ts
index 8c7b729b8828..0ac6b77dbce8 100644
--- a/packages/node/src/integrations/http/SentryHttpInstrumentation.ts
+++ b/packages/node/src/integrations/http/SentryHttpInstrumentation.ts
@@ -205,6 +205,14 @@ export class SentryHttpInstrumentation extends InstrumentationBase<SentryHttpIns
     // eslint-disable-next-line @typescript-eslint/no-this-alias
     const instrumentation = this;
 
+    const _breadcrumbs = instrumentation.getConfig().breadcrumbs;
+    const breadcrumbsEnabled = typeof _breadcrumbs === 'undefined' ? true : _breadcrumbs;
+
+    // Skip work here when breadcrumbs are disabled
+    if (!breadcrumbsEnabled) {
+      return original => original;
+    }
+
     return (original: (...args: unknown[]) => http.ClientRequest): ((...args: unknown[]) => http.ClientRequest) => {
       return function outgoingRequest(this: unknown, ...args: unknown[]): http.ClientRequest {
         instrumentation._diag.debug('http instrumentation for outgoing requests');
@@ -227,16 +235,13 @@ export class SentryHttpInstrumentation extends InstrumentationBase<SentryHttpIns
         const request = original.apply(this, args) as ReturnType<typeof http.request>;
 
         request.prependListener('response', (response: http.IncomingMessage) => {
-          const _breadcrumbs = instrumentation.getConfig().breadcrumbs;
-          const breadCrumbsEnabled = typeof _breadcrumbs === 'undefined' ? true : _breadcrumbs;
-
           const _ignoreOutgoingRequests = instrumentation.getConfig().ignoreOutgoingRequests;
           const shouldCreateBreadcrumb =
             typeof _ignoreOutgoingRequests === 'function'
               ? !_ignoreOutgoingRequests(getRequestUrl(request), optionsParsed)
               : true;
 
-          if (breadCrumbsEnabled && shouldCreateBreadcrumb) {
+          if (shouldCreateBreadcrumb) {
             addRequestBreadcrumb(request, response);
           }
         });