From 0ba5d449684db2e32216535569c66578aedafeed Mon Sep 17 00:00:00 2001 From: Charly Gomez Date: Wed, 5 Feb 2025 17:20:06 +0100 Subject: [PATCH 1/3] bump volta to node 20 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 73ae7f18495d..4eaa5eac73ca 100644 --- a/package.json +++ b/package.json @@ -45,7 +45,7 @@ "yalc:publish": "lerna run yalc:publish" }, "volta": { - "node": "18.20.5", + "node": "20.18.2", "yarn": "1.22.22", "pnpm": "9.15.0" }, From 423207f75994e0d37eb2240aa1fb04fd63248d03 Mon Sep 17 00:00:00 2001 From: Charly Gomez Date: Thu, 6 Feb 2025 11:56:08 +0100 Subject: [PATCH 2/3] update extract message for wasm --- packages/browser/src/eventbuilder.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/browser/src/eventbuilder.ts b/packages/browser/src/eventbuilder.ts index acec653c5ee6..058880904746 100644 --- a/packages/browser/src/eventbuilder.ts +++ b/packages/browser/src/eventbuilder.ts @@ -199,6 +199,10 @@ export function extractType(ex: Error & { message: { error?: Error } }): string export function extractMessage(ex: Error & { message: { error?: Error } }): string { const message = ex?.message; + if (isWebAssemblyException(ex)) { + return 'wasm exception'; + } + if (!message) { return 'No error message'; } @@ -207,11 +211,6 @@ export function extractMessage(ex: Error & { message: { error?: Error } }): stri return message.error.message; } - // Emscripten sets array[type, message] to the "message" property on the WebAssembly.Exception object - if (isWebAssemblyException(ex) && Array.isArray(ex.message) && ex.message.length == 2) { - return ex.message[1]; - } - return message; } From 6fc6712f0285580c457c049ec663ae194e2aabfe Mon Sep 17 00:00:00 2001 From: Charly Gomez Date: Thu, 6 Feb 2025 12:25:27 +0100 Subject: [PATCH 3/3] fallback --- packages/browser/src/eventbuilder.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/browser/src/eventbuilder.ts b/packages/browser/src/eventbuilder.ts index 058880904746..fc2654d2b4d7 100644 --- a/packages/browser/src/eventbuilder.ts +++ b/packages/browser/src/eventbuilder.ts @@ -200,6 +200,10 @@ export function extractMessage(ex: Error & { message: { error?: Error } }): stri const message = ex?.message; if (isWebAssemblyException(ex)) { + // For Node 18, Emscripten sets array[type, message] to the "message" property on the WebAssembly.Exception object + if (Array.isArray(ex.message) && ex.message.length == 2) { + return ex.message[1]; + } return 'wasm exception'; }